From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-oln040092070085.outbound.protection.outlook.com [40.92.70.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D2D1A21C91262 for ; Tue, 25 Jul 2017 06:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/CXLIcEiUuJfFANeaIiPu/tTW9VVr7EtTeu7OhXdp4E=; b=WbW6zwee48n++5LT4Ic7q6vM7rBMQXcZUICknVmURbOzoDvpMf+retcp2lKV7X+26PhWVLNSDPjs3cqSuiO8KY2W9icSK7FYYXb88taUE61kkLFzgyX+fn7Zf80pJeFkEpwxrkzddyM2JDhD0OGq1nhUKkX73nbyX/S3rO6h8L0nxzWrTygmCu4BHiklVrxfdJHjSSTPmaXEF66IET4HEybBnaJpKCVAvM0MaptrCvexwgTgRfkyMwQ+17WBd+W5X9OhqpN19rGi3qIOvIlBGsX+Bo3fK8hxvybhnIt3LVQSAG65Tbr1JYdDnWvirMGCqq6aorEdzy96vb0/eIbmPA== Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (10.152.20.59) by DB5EUR03HT212.eop-EUR03.prod.protection.outlook.com (10.152.21.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1240.9; Tue, 25 Jul 2017 13:24:36 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com (10.152.20.54) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1240.9 via Frontend Transport; Tue, 25 Jul 2017 13:24:36 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::dcd0:60e6:90e0:871b]) by AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::dcd0:60e6:90e0:871b%13]) with mapi id 15.01.1282.020; Tue, 25 Jul 2017 13:24:36 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2. Thread-Index: AdMEm0stAu8v+ZaLQCePXmnkVRlHwgAg1CNQAAEYgJAAAImFIAABJhJAAABETjAABz/ecAAATLPw Date: Tue, 25 Jul 2017 13:24:36 +0000 Message-ID: References: <0C09AFA07DD0434D9E2A0C6AEB0483103B8F5988@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8F59EA@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8F5A30@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8F5B03@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B8F5B03@shsmsx102.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:9B98E72E9D80DB7185E74F53D6D053250564DD0B10A8839251AD5F6EF78C28E5; UpperCasedChecksum:AAF4691825907BBA244706EAC0551B20E568C20A61C5F1BBA34FFEF0AA77AF2C; SizeAsReceived:7875; Count:45 x-tmn: [gu1Rjp4+Q4A2NzT1iY1bVg/hD4pg0Hdhc2sdmjPv3OwvGecxLChLyvAOIbJuQLhK] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR03HT212; 7:0GyYu0YIXnxxht7wVIpvP2pcWQMVUPBjJ0eV5RDKkVexkKOhMY5JQwlqEHd5j69c1KYMum8h68gmiYW6ybiL8h4jevD/J8Y6IpXqTRc1RZ8z8VUeVPuy+Y657QAEkY5idK7WzO8hRkxgH0yHPcSxb1smbFXW7stBLJpcDbN5wi7uiz5NQUEJFNZHwv/O+ZbJL8Ut3tB+HUCxsgxViGnOQsQKSI1uQ0KcOzIdgmKEpSBbTpmGchGnCUntig+5BFNpNN9FFyOcSpZCH6tX45PAGKjmHyNxAfBIMYxVQGefc9MIIxtCCG6bKP5HNZ3twNGmTzjaEPLrrVkUdmNYIp5rgdZJ4TnH1m5jVlhaN/Jmui+7VxT9nRHjMGkSFjMC9XiZ5TegKWQSvHHu79y5SSg4SKg6Gn76u4RreW6mzyzFTZFriomj1VA+/1Bl+RQtcmZN+8QqFCE85mGymcYpFpYc4+tOwaftMe9sfhAf03+ySk8sjwJlu0Y4ToxVAd8T2/+7pftf08COEXQCRDRrVoPNAH9Si5Zaduq94VoZjbD8cR0fEdKY5xkcA4N3rUnI+8XgKcky75a3dXSMtRlBM9r9/ffIQleTvijebAZrtjHJz0JQKaqgastPkz0zGuiTweanqmryvuarfWSUQ0aFqTCedTQ68g8tn0dmvnbeQxOOJDsEy0d/1Ln5wvlmaMabnJDXk8J4EC7jbatjgFWGm7/Hy6FJ3oTrmK3U1SSo2iuzQ6jb4HFOvTebAjgchi4b7jJAcu7KsZCTEhFCDrfkenw91g== x-incomingheadercount: 45 x-eopattributedmessage: 0 x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR03HT212; H:AM4PR06MB1491.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: d486d815-a709-4a56-08d1-08d4d3607ea9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322350)(1603101448)(1601125374)(1701031045)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB5EUR03HT212; x-ms-traffictypediagnostic: DB5EUR03HT212: x-exchange-antispam-report-test: UriScan:(189930954265078)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(444000031); SRVR:DB5EUR03HT212; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB5EUR03HT212; x-forefront-prvs: 03793408BA spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2017 13:24:36.0316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR03HT212 Subject: Re: [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jul 2017 13:22:38 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you very much! I will request a new member account soon (due to departure, my E-Mail accou= nt was deactivated and I had to delete my account). Is a 'Member' status enough to submit ECRs? Thanks, Marvin. > -----Original Message----- > From: Zeng, Star [mailto:star.zeng@intel.com] > Sent: Tuesday, July 25, 2017 3:14 PM > To: Marvin H?user ; edk2- > devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > EFI_PEI_GET_VARIABLE2. >=20 > ECR 1828: Add decorator 'OPTIONAL' for Attributes parameter of > EFI_PEI_GET_VARIABLE2 has been submitted. >=20 > Thanks, > Star > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, July 25, 2017 5:46 PM > To: Marvin H?user ; edk2- > devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > EFI_PEI_GET_VARIABLE2. >=20 > Sure, I will help do that. :) >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Marvin H?user > Sent: Tuesday, July 25, 2017 5:43 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for > EFI_PEI_GET_VARIABLE2. >=20 > Sorry, I remembered 'IN OUT' incorrectly then, you are correct. Only > 'OPTIONAL' is lacking. > Would be very kind of you if you could help submitting the ECR, I do not = have > an active account at this point. >=20 > Thanks, > Marvin. >=20 > > -----Original Message----- > > From: Zeng, Star [mailto:star.zeng@intel.com] > > Sent: Tuesday, July 25, 2017 11:09 AM > > To: Marvin H?user ; edk2- > > devel@lists.01.org > > Cc: Zeng, Star > > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > > EFI_PEI_GET_VARIABLE2. > > > > As I know submitting ECR needs log in as a member at > > http://www.uefi.org/memberslogin, I am not sure the whole process. > > If needed, I can help to submit the ECR. > > > > According to EDK2 coding style doc at > > https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards- > > specification/content/5_source_files/57_c_programming.html#table-9- > > parameter-modifiers > > IN OUT Passed by reference, and the passed-in referenced data is > consumed > > and then modified by the routine. > > > > But the code will not consume the pass in referenced data. Personally, > > I don't think just checking NULL pointer should be marked as 'IN' > > > > > > Thanks, > > Star > > -----Original Message----- > > From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] > > Sent: Tuesday, July 25, 2017 4:58 PM > > To: edk2-devel@lists.01.org > > Cc: Zeng, Star > > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > > EFI_PEI_GET_VARIABLE2. > > > > Hey Star, > > > > Thanks for your comment! Sorry, I never submited such a report, could > > you please point me in the right direction? The only way of contact I > > found on the site of the UEFI Forum were Administration and Press, > > both don't sound like the right place to post to. Or Is > > 'Administration' specification administration rather than forum > administration? > > > > Regarding 'IN': Correct me if I'm wrong, but in contrast to just 'OUT' > > parameters, which are 'blindly' written to, 'Attributes' must be > > checked against NULL first before attempting a dereference. Is this > > not the correct usage of IN? Is IN only used, when the pointer's destin= ation > is read? > > > > Thanks again! > > > > Regards, > > Marvin. > > > > > -----Original Message----- > > > From: Zeng, Star [mailto:star.zeng@intel.com] > > > Sent: Tuesday, July 25, 2017 10:25 AM > > > To: Marvin H?user ; edk2- > > > devel@lists.01.org > > > Cc: Zeng, Star > > > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > > > EFI_PEI_GET_VARIABLE2. > > > > > > Marvin, > > > > > > I think you are right about the statement of decorator 'OPTIONAL', > > > you can submit PI ECR, then it can be aligned with UEFI > EFI_GET_VARIABLE. > > > typedef > > > EFI_STATUS > > > (EFIAPI *EFI_GET_VARIABLE)( > > > IN CHAR16 *VariableName, > > > IN EFI_GUID *VendorGuid, > > > OUT UINT32 *Attributes, OPTIONAL > > > IN OUT UINTN *DataSize, > > > OUT VOID *Data OPTIONAL > > > ); > > > > > > And since the passed-in state of the referenced data is not used by > > > the routine, I don't think decorator 'IN' should be added. > > > > > > > > > > > > Thanks, > > > Star > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > > Of Marvin H?user > > > Sent: Tuesday, July 25, 2017 12:42 AM > > > To: edk2-devel@lists.01.org > > > Subject: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for > > > EFI_PEI_GET_VARIABLE2. > > > > > > Dear developers, > > > > > > I noticed that EFI_PEI_GET_VARIABLE2 is lacking decorators in both > > > the UEFI PI 1.6 specification and the EDK2 codebase. The parameter > > > description for 'Attributes' starts with 'If non-NULL', hence it may > > > be NULL, which is not reflected in the function prototype with the > > decorator 'OPTIONAL'. > > > Furthermore, as the possibility of it being NULL is not coupled to > > > the values of the other parameters, 'IN' should be added as well. > > > > > > Can someone please forward this to the right working group? > > > > > > Thanks and best regards, > > > Marvin. > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel