From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064039.outbound.protection.outlook.com [40.92.64.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0FBB620958BDA for ; Wed, 6 Sep 2017 01:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yBJ83uWWEAyrp4qhG8t2IDrsrmxb/Qkb/brlb2f9zPk=; b=QM2NAA2aQiNhJ9yCh9NBp0NDEYRllnf/xeMHWQ6vIQOz6bAVXFT7QoX5wJnhjt/d3dnAgEvcAVumM9tmc6nuXL+8lL+wwEqiIlXxOR/KHIz2PJomfTL/kUBzEwnupF7aQulKk3V0bJDuaFtg4s8BiMIrDv0SQ4tZszJzjtBoI0C6xpOKIjzrD3WwNu0Ot9KlD8QdWjszPBA78F3lnsfWVGfU5XhfLGCHnUztvYfdFPF8rVZxCdyCdSlLb45PYNeGRuuT0CRS0sYcdIp9SJa78d+ltRhel/LbSFj3XEPKoRTBakbux8CyQt4jxUKH0f0EV5tSbPYiyLwKkD/o5+zsvw== Received: from DB5EUR01FT039.eop-EUR01.prod.protection.outlook.com (10.152.4.56) by DB5EUR01HT020.eop-EUR01.prod.protection.outlook.com (10.152.5.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1385.11; Wed, 6 Sep 2017 08:21:32 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com (10.152.4.52) by DB5EUR01FT039.mail.protection.outlook.com (10.152.5.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1385.11 via Frontend Transport; Wed, 6 Sep 2017 08:21:32 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::6cae:b5f6:6e86:86b0]) by AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::6cae:b5f6:6e86:86b0%13]) with mapi id 15.20.0013.018; Wed, 6 Sep 2017 08:21:31 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" Thread-Topic: PI 1.6: Issues within the SPI sections. Thread-Index: AdMmvwtNCvQ32VhVRT+pHJESLZsZqQAAsoVgAAmnMaA= Date: Wed, 6 Sep 2017 08:21:31 +0000 Message-ID: References: In-Reply-To: Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:1BF682903C0C6FED2C46E62B742261E6F157854B3253F4261EF191A20E4FF06A; UpperCasedChecksum:254ED71BB12A9DCBD49448958E6EC2EB49B9B543370FDA41EE8C16E6E6839301; SizeAsReceived:7281; Count:45 x-tmn: [T2Wh1D4EtUnc5N2ISRi3Cd4LXvmZwD/Uyg8zbnSyRZo5+cw2dhEy+vXloYPkrS6q] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR01HT020; 6:Td3MMoVgKjH2CQA4dxzV5h4e1QifOhV2Uya7J4JR3Xg47W+6eMewpATMua0brKd8idXmOpYHIvOpaY4N5vn6IUHkrB6D0ZwOVN1DLqJKZuVGuJmCbY1HW0GjHNCtWHMPY1kdtlnWCq77WD+AXa/cjQZZ4fz3QjEo0sOnm2N4ycB7GkX6+FY6mzsKc7Qhi8tDEwmblpq0/QTp3mX+tmjbQTWs9hka4HwSHcHZB/CCS5SpMKNLnvZ1IpJ/gTcTjl44i6AqBS2HQrjxUZJDnLrqZnoX/s14YdZL/038+v7XQyhzUhbAHl2cZ6QDQgcKvwjs8rGrGwuuC1nUTLvr/OS6ag==; 5:EeCQX6+btIh4bGp7Df1h0mZP472TH6ooBqO8Fu8cYXG8RFmaByOmyxPMOa5pKqw7DcjdQZjTVkBSLvayPGkjrS1LDjASera5N82rNkYlGYEFGJ3OhlD67Bb2Fvw/56FSHhXqqEFAnsZxn2q/QtPqeQ==; 24:tak+MKleDqi/nAgl9BIY7Gb+PHOB5/GVrCqoW523V6pz/Ugrq7yzzw+v0Gezvcjp8w9paiGJtXJ5dFMdigyN3OwFXc87WS2sU9vLTYpBk0Y=; 7:n+U9s7TX0KC4vc3vDEWI746GvLYP0VQlQXJBWWZ69uzPew/gVtACh16Aeuj67EAskaw/uCDJJRSoPuFRMoP1ZL1Hh+F7J9Ns1Tr1RqppRMapQt8pFNQeHf8WyG/VaFHI3lic51FkNY0FzbuFLk3m2pHiSqLbuMRWkPMS2PQ9RDmXkSBdSYWtTAimt6+fgkeirkxhiSv26RvsuqytMhOuVfOaxFlwtaMczkQQTS0qpGg= x-incomingheadercount: 45 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 03873deb-94ee-4ed7-866b-08d4f50047d3 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(300000503095)(300135400095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125374)(1701031045)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB5EUR01HT020; x-ms-traffictypediagnostic: DB5EUR01HT020: x-exchange-antispam-report-test: UriScan:(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(444000031); SRVR:DB5EUR01HT020; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB5EUR01HT020; x-forefront-prvs: 0422860ED4 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR01HT020; H:AM4PR06MB1491.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2017 08:21:31.8682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT020 Subject: Re: PI 1.6: Issues within the SPI sections. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 08:18:45 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry, but there are even more: * "EFI_LEGACY_SPI_CONTROLLER_GUID" contains the non-hex character "l", whic= h I suspect to be "1". * "EFI_SPI_HOST_GUID" does not follow the usual naming scheme. Wouldn't "EF= I_SPI_HC_PROTOCOL_GUID" be more fiting? * The possible values for EFI_SPI_HC_PROTOCOL.Attributes are not defined. * The possible values for EFI_SPI_IO_PROTOCOL.Attributes are not defined. Thanks again for your time! Regards, Marvin. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Marvin H?user > Sent: Wednesday, September 6, 2017 5:42 AM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] PI 1.6: Issues within the SPI sections. >=20 > Sorry, I forgot to mention that the new SPI protocols still mention "SMM" > rather than "MM". Is this intended? >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Marvin H?user > > Sent: Wednesday, September 6, 2017 5:22 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] PI 1.6: Issues within the SPI sections. > > > > Dear UEFI contributors, > > > > I am not an UEFI contributor and hence cannot submit changes. Could > > somebody please take note of the following? > > > > > > 1. I do not see EFI_SPI_TRANSACTION_TYPE defined anywhere. There is > > a list of names for possible values with descriptions (PI 1.6, Vol. 5, > > page 368), though not assigned to numerical values. The size of the > > type is unknown, as far as I can see. > > 2. Some parameter names in the protocol descriptions are flawed > > (e.g. PI 1.6, Vol. 5, page 368: "Read Bytes", "Read Buffer"). > > 3. Some protorype return types are flawed (e.g. PI 1.6, Vol. 5, > > page 367: "EFI STATUS" (space instead of underscore); page 364: "FI > > STATUS" (same as before, also "E" missing)). > > 4. Some prototype parameter types are flawed (e.g. PI 1.6, Vol. 5, p= age > 364: > > "EFI- LEGACY- SPI- FLASH- PROTOCOL"). > > 5. Some status code descriptions are flawed (e.g. PI 1.6, Vol. 5, pa= ge 364: > > "BLocksToProtect" (capital "L")). > > 6. Some formatations are flawed (e.g. PI 1.6, Vol. 5, page 358: > > multiple parameters in one line). > > 7. Some function decorators are flawed (e.g. PI 1.6, Vol. 5, page 35= 7: "In" > > (lower-case "n")). > > 8. Some function parameter names are flawed (e.g. PI 1.6, Vol. 5, pa= ge > 356: > > "LengthinBytes" (lower-case "i")). > > 9. Some descriptions contain spaces in inappropiate places (e.g. PI = 1.5, > Vol. > > 5, page 349: "EFI_SPI_P ART"). > > 10. Occasionally incorrect punctuation (e.g. PI 1.6, Vol. 5, page > > 346: "[...] SPI busses, The SPI bus layer [...]" (comma instead of peri= od)). > > 11. PI 1.6, Vol. 5, page 349: The description of "SpiPeripheralDriver= Guid" > > speaks of a "Driversupported" routine. Is > > EFI_DRIVER_BINDING_PROTOCOL.Supported() meant by this? > > 12. PI 1.6, Vol. 5, page 350: The description of "ChipSelectParameter= " > > contains spaces, though they are barely noticable when having the PDF > > opened with the latest version of Acrobat DC. Can this be fixed? > > 13. UEFI PI 1.6, Vol. 5, 18.2 contains a reference to "EDK2". Is this > intended? > > > > Please note that this list is not complete. Maybe the entire section > > 18 should be reviewed again? > > > > Thank you in advance! > > > > Regards, > > Marvin. > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel