From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.68.39; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068039.outbound.protection.outlook.com [40.92.68.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4300D21E256AB for ; Thu, 25 Jan 2018 10:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7DLkzPecDD6wva1sotJx9yAb17pVow5TWtSVjqhhPHg=; b=J/DoY63A6yUeHPALiAFHCPh0spXrf/LQAu+55vjJ+W94tGvr2mkMBRgVZfFZoGollHNYZP7Aj9hV30rzAtJBzT62cR1+aqYxqk8+3bfVSKpFfuh9OcCjfl6ywSOG17R3IWoKN5YQ0BuQJmU28XWXXhRihH9iDNP9hyCJdl1flRCCVxZaVMShj17l5GOA4hVP5igeFRCO1D1oUWBAW73pwO+q8L2mCmxfHjaVLnotbNny70xQoScj841Ow5RiDs1QBDVysO7dQNGNurkdrYFemIQ8K4Zm/YgVuz8FWonBHxQqjEpntdhq+xVeEM9RIBS3obRpGhbvnP1U3QM1+nh4JA== Received: from HE1EUR02FT013.eop-EUR02.prod.protection.outlook.com (10.152.10.57) by HE1EUR02HT244.eop-EUR02.prod.protection.outlook.com (10.152.11.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.428.12; Thu, 25 Jan 2018 18:31:38 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com (10.152.10.51) by HE1EUR02FT013.mail.protection.outlook.com (10.152.10.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.444.13 via Frontend Transport; Thu, 25 Jan 2018 18:31:39 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::b596:356f:e561:d656]) by AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::b596:356f:e561:d656%13]) with mapi id 15.20.0444.016; Thu, 25 Jan 2018 18:31:38 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" , Tim Lewis , "Supreeth.Venkatesh@arm.com" CC: "michael.d.kinney@intel.com" , "liming.gao@intel.com" Thread-Topic: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. Thread-Index: AQHTlIUz3VAfzVVWQ06CohwnZNiD56OCK8OQgAKzp4CAAAI1gIAACCkw Date: Thu, 25 Jan 2018 18:31:38 +0000 Message-ID: References: <20180123200303.5547-1-supreeth.venkatesh@arm.com> <001601d39605$580f31b0$082d9510$@insyde.com> In-Reply-To: <001601d39605$580f31b0$082d9510$@insyde.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:DE3AAAE2DF535955D9D179CAD813028F0C617F2F4A9D01F8D995BCED455F5B8B; UpperCasedChecksum:CD666315A9FBA7EE6579DDA7562DEF163BC4A77AA96925509E037CB18F0174CF; SizeAsReceived:7520; Count:46 x-tmn: [jcnZgxlw7KINMn8I5G2eF76x/FOEEPyU] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1EUR02HT244; 6:2qXyKALPsQ+28Ywg9uk1GTCvv/bLPayF+KGjNexA6GrXfu2CYxnP8BM4iFOEwNpNCfIqaL0hJtazHvm7P2TXXQj/hY7c1vEkIQnFqqDtfqWzlEUg/PvHySzFCPifJJYDML0pBzhJq/lDK6ml0u7EpBt0jvQWUym4zh2F0xNt2FKdaVkLv15/cTrc2xo6zKfKBNH9bpklgGB5NJNxcYG0sFyCPv1B2MzMbT7n4uh8NbXaPgsA3EM5w3DaZcng7weSL5oaN/74wnSIz3A07wq2sWtXszngyGa6W6PzaSZqB/VW9OhvvzCn0Zs34N2Ozp8dNslJPSEG++06tfUTMPywBdF1bcglTS6Fi7pX/MkNN68=; 5:4gJPBaJnW4lfQ6LMcEPcod83C7k5fTe1karVYci75MPYCffj26+k1a9HJzOAWsZynkAG/aKIMfTuPypz7q83SMS11n7namUEr/69Ebj9Su5qr8BmumrG9aueQnC2tmWZUIU5QqsGHqFnQRfqngBnj+x19sncMnp07FnEoVrU88g=; 24:j0SkV1mqU1XY8e2m8mTfhrJZNR6Btdex51zkhL2R8Rx+xfhhPTcI2kVETHTET4urbprF8CdJ4y2V3N/vphnYS7fvkEOgGuHvL49yfcuPU5o=; 7:tuEQPOs9zO9MN0ErgqJcOnUUviKYh1CrrKmcb0ueCxxkKb57LwwCiLx3ipTo93ReGn3H0cOAbObituBCtBWLLFMs0s7EAjkZfkafYBbyAs1sc4UVPPaSmZFxffBGg60ECKcUVbNG7yeTgtv9oyieC2YXYwE55ig9gv/bZCHog1uUZ2xeYOEJ4e+Hoko1PqMVg0IbjaYBMlm2356ox8UK49OEW/FU8hNgP7jmng3rftTPyy8tA1S3K0UGdcdMvNId x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125374)(1701031045); SRVR:HE1EUR02HT244; x-ms-traffictypediagnostic: HE1EUR02HT244: x-ms-office365-filtering-correlation-id: 0eee2c49-e619-41b6-8130-08d56421df62 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:HE1EUR02HT244; BCL:0; PCL:0; RULEID:; SRVR:HE1EUR02HT244; x-forefront-prvs: 0563F2E8B7 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:HE1EUR02HT244; H:AM4PR06MB1491.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0eee2c49-e619-41b6-8130-08d56421df62 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 18:31:38.6485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR02HT244 Subject: Re: [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 18:26:13 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey Tim and Supreeth, Sorry, 0x0C was a typo, 0x0D is the correct one. The values of the SMM and MM constants are identical, this is just a naming= update plus the introduction of the new value, MM Standalone Core, so back= wards-compatibility is given. Regarding the traditional MM Core, I just assumed it was an oversight as Md= ePkg is generic. If it wasn't, sorry. Thanks, Marvin > -----Original Message----- > From: Tim Lewis [mailto:tim.lewis@insyde.com] > Sent: Thursday, January 25, 2018 6:53 PM > To: 'Supreeth Venkatesh' ; 'Marvin H?user' > ; edk2-devel@lists.01.org > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > FV file type and depex. >=20 > Supreeth -- >=20 > Doesn't Appendix A of the PI 1.6 define this as: >=20 > #define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM #define > EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE >=20 > Thanks, >=20 > Tim > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Thursday, January 25, 2018 9:45 AM > To: Marvin H?user ; edk2- > devel@lists.01.org > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management > mode FV file type and depex. >=20 > Marvin, >=20 > Thanks for your comments. > As per PI v1.6 specification, > EFI_FV_FILETYPE_MM_CORE value is 0x0D (MM Foundation that support > MM Traditional Mode.) >=20 > This is traditional MM mode, which ARM is not supporting at this point. W= e > are more interested in MM_CORE_STANDALONE mode. > However, I have no issues in adding this in the patch, but would prefer i= f this > is added when MM traditional mode is supported in ARM. >=20 > Further, > w.r.t defining *_SMM_* definitions via the *_MM_* definitions. I don't > want to break backwards compatibility with existing SMM traditional mode > implementations. > I will be happy to let folks who have migrated to _MM_ definitions from > _SMM_ definitions to send the patch across. >=20 > Thanks, > Supreeth >=20 > -----Original Message----- > From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] > Sent: Tuesday, January 23, 2018 6:34 PM > To: edk2-devel@lists.01.org > Cc: Supreeth Venkatesh ; > michael.d.kinney@intel.com; liming.gao@intel.com > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > FV file type and depex. >=20 > Good day, >=20 > I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE" > (0x0C). > Furthermore, may I suggest changing the *_SMM_* definitions to be > defined via the *_MM_* definitions? >=20 > Best regards, > Marvin. >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Supreeth Venkatesh > > Sent: Tuesday, January 23, 2018 9:03 PM > > To: edk2-devel@lists.01.org > > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > > Subject: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > FV > > file type and depex. > > > > As per PI specification v1.6, > > The following new file types are added: > > EFI_FV_FILETYPE_MM_STANDALONE > > EFI_FV_FILETYPE_MM_CORE_STANDALONE > > > > The following new section type is added: > > EFI_SECTION_MM_DEPEX > > > > This patch adds the management mode FV file type and depex. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Achin Gupta > > Signed-off-by: Supreeth Venkatesh > > Reviewed-by: Jiewen Yao > > --- > > MdePkg/Include/Pi/PiFirmwareFile.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h > > b/MdePkg/Include/Pi/PiFirmwareFile.h > > index b982c9eda3..6086d1bb2f 100644 > > --- a/MdePkg/Include/Pi/PiFirmwareFile.h > > +++ b/MdePkg/Include/Pi/PiFirmwareFile.h > > @@ -72,9 +72,12 @@ typedef UINT8 EFI_FFS_FILE_STATE; #define > > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > > #define EFI_FV_FILETYPE_APPLICATION 0x09 > > #define EFI_FV_FILETYPE_SMM 0x0A > > +#define EFI_FV_FILETYPE_MM 0x0A > > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > > +#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C > > #define EFI_FV_FILETYPE_SMM_CORE 0x0D > > +#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 > > @@ -218,6 +221,7 @@ typedef UINT8 EFI_SECTION_TYPE; > > #define EFI_SECTION_RAW 0x19 > > #define EFI_SECTION_PEI_DEPEX 0x1B > > #define EFI_SECTION_SMM_DEPEX 0x1C > > +#define EFI_SECTION_MM_DEPEX 0x1C > > > > /// > > /// Common section header. > > -- > > 2.14.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended reci= pient, > please notify the sender immediately and do not disclose the contents to = any > other person, use it for any purpose, or store or copy the information in= any > medium. Thank you. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel