From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.64.19; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064019.outbound.protection.outlook.com [40.92.64.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B6C0521E48F38 for ; Tue, 23 Jan 2018 16:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+OoZSQy7zm4M9TQj3aF7+ncfEl2UCxArtIe1QunsGgg=; b=tmBsn1WfguP0ichnrz85Sq3Jv8wRPJvteL95kL8TrSqePOrQfDWyXJxDSpm30/5ewqUK84RxSlE01wOUc7KGCeyKnwZ/ltJlpfWWVNgIiEHBEuPClzyX4H/ob9sxW4p1pC3G8snKI9/3tEg0nXQ2/TVDXbfA1Cwej8oSIfXZWQpU/XNWk92H5+uFkctqeWLQ73B+wDbLXBsIektJgjQhpt/SZ89ZkSz74yn9RMbVVTBC+DJOK+aufce/6FX53qYQZp5FV2xLw7hSW8YtVFNpEL6FAnn+bibOrG4qs/aTCOrkCqn/tsHoP8zIAF37sDJMiNxNa7poogbqBw0T9NnD6g== Received: from DB5EUR01FT007.eop-EUR01.prod.protection.outlook.com (10.152.4.51) by DB5EUR01HT216.eop-EUR01.prod.protection.outlook.com (10.152.5.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.428.12; Wed, 24 Jan 2018 00:34:18 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com (10.152.4.60) by DB5EUR01FT007.mail.protection.outlook.com (10.152.4.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.428.12 via Frontend Transport; Wed, 24 Jan 2018 00:34:19 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::b596:356f:e561:d656]) by AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::b596:356f:e561:d656%13]) with mapi id 15.20.0428.023; Wed, 24 Jan 2018 00:34:19 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" CC: Supreeth Venkatesh , "michael.d.kinney@intel.com" , "liming.gao@intel.com" Thread-Topic: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. Thread-Index: AQHTlIUz3VAfzVVWQ06CohwnZNiD56OCK8OQ Date: Wed, 24 Jan 2018 00:34:18 +0000 Message-ID: References: <20180123200303.5547-1-supreeth.venkatesh@arm.com> In-Reply-To: <20180123200303.5547-1-supreeth.venkatesh@arm.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:F7FA53206FEAAFB5D752E6D92C4EF2792CA238578492AEFF5AB50D73532B6693; UpperCasedChecksum:74A31D9EB7C3B50C9D3C5B3D1AED8C56961573DE2C68CBDE2BDF6E6536B50058; SizeAsReceived:7244; Count:46 x-tmn: [OuBP/4hUZRlVucnKr+oUHNKZVZv89Vks] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR01HT216; 6:HOSRNtLwalFnKOcmO7MaUAJ4AS52S8aSgD6ARgigZ2u4as43eAe+pANODcnOV2JHyOBiC1VmZrUeIzLSS40ek/ToUgg0TLKFS2uug7HCXUzbTQzpgdoO47c040xJsV1OPHAhkDDBbFHDlCaRIalVpbRQbjM6513emc9E6SGFpkJr9Jhm6Z1kbanLzDhmry+AKKVU6lTEgydu5OzBpfq+iNMK4nNDwfNBubdbAl+k3x39gTVQ+UBDHlXumUynqcW8VE7KwuGE4DjaXPTH37RAbhnXndl+k0UgoTCBH3bdqLMfNoL5469fyJzF0ePbZDB4Ze/XXHvwuY6q6e27IIvVuUBpe9+2v9wlz3MmJ7jpROE=; 5:9UxANJcy8uK392ynhHFtXqnXPyAfMwuDwYX3SwqYB66osVojUOo27n942UDwCvbRzwz2OA++xR87dIBc4AJ6Twye2q49seJjy/ERp7HulRI9GELW77+KLQWLPgBcpbYKKL2VZKm0/p/0waD0EAVH9GRcn9q9F4K8v8Tb7U9I6Ms=; 24:wQOjEwQEIpewaVCIjGFBa1wD3mC1JBz642iiFJSCd4/qKA1JHC+90+2Fpnhb1Oyd5dUrI94Ny+aB3GYEYpk437oq89qfPh48Tfrb2VbQw5g=; 7:LJVH+c/meFUVIJlmV8YZfxa5zBsscWNYShtFYTdOxymELeoTeZ7X+K31Lp145CVcnj0h4xB7hkJSM+2HD/LOyl4wbqTvk1KV3JtK/YS3/xwUg1IPswroqz9cci2kCuLC0oc8/GXpzT/os9sAXnjvYgrSmcW1Og+R3j3fkbXQtk2hWF/3ZU4dXgx51zJsSy4UWNK/Jutaf22smgPWmFsLvKMWvngqJhh6Gvu8lCZRiX6I/sONVzKTJr1kB4AcS2yp x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125374)(1701031045); SRVR:DB5EUR01HT216; x-ms-traffictypediagnostic: DB5EUR01HT216: x-ms-office365-filtering-correlation-id: ff2f9abe-c92f-4a9c-fabd-08d562c234b8 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:DB5EUR01HT216; BCL:0; PCL:0; RULEID:; SRVR:DB5EUR01HT216; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR01HT216; H:AM4PR06MB1491.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff2f9abe-c92f-4a9c-fabd-08d562c234b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 00:34:19.0039 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT216 Subject: Re: [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 00:28:56 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good day, I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE" (0x0= C). Furthermore, may I suggest changing the *_SMM_* definitions to be defined v= ia the *_MM_* definitions? Best regards, Marvin. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Tuesday, January 23, 2018 9:03 PM > To: edk2-devel@lists.01.org > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > Subject: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV > file type and depex. >=20 > As per PI specification v1.6, > The following new file types are added: > EFI_FV_FILETYPE_MM_STANDALONE > EFI_FV_FILETYPE_MM_CORE_STANDALONE >=20 > The following new section type is added: > EFI_SECTION_MM_DEPEX >=20 > This patch adds the management mode FV file type and depex. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > Reviewed-by: Jiewen Yao > --- > MdePkg/Include/Pi/PiFirmwareFile.h | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h > b/MdePkg/Include/Pi/PiFirmwareFile.h > index b982c9eda3..6086d1bb2f 100644 > --- a/MdePkg/Include/Pi/PiFirmwareFile.h > +++ b/MdePkg/Include/Pi/PiFirmwareFile.h > @@ -72,9 +72,12 @@ typedef UINT8 EFI_FFS_FILE_STATE; #define > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > #define EFI_FV_FILETYPE_APPLICATION 0x09 > #define EFI_FV_FILETYPE_SMM 0x0A > +#define EFI_FV_FILETYPE_MM 0x0A > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > +#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C > #define EFI_FV_FILETYPE_SMM_CORE 0x0D > +#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 > @@ -218,6 +221,7 @@ typedef UINT8 EFI_SECTION_TYPE; > #define EFI_SECTION_RAW 0x19 > #define EFI_SECTION_PEI_DEPEX 0x1B > #define EFI_SECTION_SMM_DEPEX 0x1C > +#define EFI_SECTION_MM_DEPEX 0x1C >=20 > /// > /// Common section header. > -- > 2.14.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel