Re: [PATCH] MdePkg: Add PcdPciExpressRegionLength PCD Token

[Marvin H?user <Marvin.Haeuser@outlook.com>]

A bunch of platforms, such as QuarkSocPkg, already declare such a PCD named PcdPciExpressSize of type UINT64.
Maybe PcdPciExpressSize|UINT64 should be 'promoted' to a MdePkg PCD and the platform-defined PCDs replaced?

Regards,
Marvin.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Felix Poludov
> Sent: Wednesday, August 2, 2017 3:48 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] MdePkg: Add PcdPciExpressRegionLength PCD
> Token
> 
> Add PcdPciExpressRegionLength PCD Token to MdePkg.
> The new token can be used in conjunction with PcdPciExpressBaseAddress
> PCD token to describe PCI Express MMIO region.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Felix Polyudov <felixp@ami.com>
> ---
> 
> Resending with inline patch.
> 
> --
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> d6928b3..7e55019 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -2089,6 +2089,10 @@
>    # @Prompt PCI Express Base Address.
> 
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000|UINT6
> 4|0x0000000a
> +  ## Length of the PCI express region.
> +  # @Prompt PCI Express Region Length.
> +
> +
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000|UINT
> 32|0
> + x00000031
> +
>    ## Default current ISO 639-2 language: English & French.
>    # @Prompt Default Value of LangCodes Variable.
> 
> gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultLangCodes|"engfraengf
> ra"|VOID*|0x0000001c
> diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni index
> a110e45..62df5dc 100644
> --- a/MdePkg/MdePkg.uni
> +++ b/MdePkg/MdePkg.uni
> @@ -276,6 +276,10 @@
>  #string STR_gEfiMdePkgTokenSpaceGuid_PcdPciExpressBaseAddress_HELP
> #language en-US "This value is used to set the base address of PCI express
> hierarchy."
> +#string
> STR_gEfiMdePkgTokenSpaceGuid_PcdPciExpressRegionLength_PROMPT
> #language en-US "PCI Express Region Length"
> +
> +#string
> STR_gEfiMdePkgTokenSpaceGuid_PcdPciExpressRegionLength_HELP
> #language en-US "Length of the PCI express region."
> +
> #string
> STR_gEfiMdePkgTokenSpaceGuid_PcdUefiVariableDefaultLangCodes_PROM
> PT  #language en-US "Default Value of LangCodes Variable"
>  #string
> STR_gEfiMdePkgTokenSpaceGuid_PcdUefiVariableDefaultLangCodes_HELP
> #language en-US "Default current ISO 639-2 language: English & French."
> --
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends, Inc.  This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel