From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.92.66.44; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=marvin.haeuser@outlook.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-oln040092066044.outbound.protection.outlook.com [40.92.66.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17D7C21E0BA0A for ; Fri, 2 Feb 2018 10:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TFZcZD9rn0wVJiS4qYEmSEesFqgB4TXNKCu7+Lh+hzw=; b=txaqMsv1ZAiau21rcKSfgy/6VdWFWCY+LtE5qDZL8bKOPxFQQ2TexjaScDnr85iHhxJuAkmvvv/FCN9Be7fBA581HxcKVlRN2DG6bxg1E9CA3CumG827QCYOw/CzC0xYObxTUDDkbm9DbMsI1P1DAZIalNFbJ8UfDxm/N4x42fw//rnP146wJYy+sN7B+Y1p80xmpcl4DSYXSYiebG6RaGNVWAEmLHWS9hmyhLH18ofpQTTj289Z0F3SAR9wnJwq/BpPpw6YWvkgp5TRaHHGmDfgpj4bm8msql43epxtK3rN2H7dvFPryWTDPLWARfoQxHAS9XUtX3kA1GkiUxiz3w== Received: from DB5EUR01FT055.eop-EUR01.prod.protection.outlook.com (10.152.4.59) by DB5EUR01HT023.eop-EUR01.prod.protection.outlook.com (10.152.5.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.464.8; Fri, 2 Feb 2018 18:30:10 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com (10.152.4.52) by DB5EUR01FT055.mail.protection.outlook.com (10.152.5.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.464.8 via Frontend Transport; Fri, 2 Feb 2018 18:30:10 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::b596:356f:e561:d656]) by AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::b596:356f:e561:d656%13]) with mapi id 15.20.0444.022; Fri, 2 Feb 2018 18:30:09 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" , "Yao, Jiewen" Thread-Topic: MinPlatformPkg/PlatformInit: FV code Thread-Index: AdOZ7dDRJ47e1o0uT++5ldvAkWh9yACMtQZQAAxKRNA= Date: Fri, 2 Feb 2018 18:30:09 +0000 Message-ID: References: <74D8A39837DF1E4DA445A8C0B3885C503AAAA932@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AAAA932@shsmsx102.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:5A0000D0D10D1ED87E5A49F4132BE25371862601226CC57A55634B2CAF8E4A94; UpperCasedChecksum:90EBB1CAFFCC78770DF6CE6C0B0B4AEBBBE5E6C1B34765D996ABD8655E645459; SizeAsReceived:7161; Count:45 x-tmn: [oavlclikkwMtQJUATXkUm+dQ5TTio5TS] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB5EUR01HT023; 6:MOnXeeCLblZFi79uDJxpnZ3/n+KNUYEhaDZVBZOroeFSDYUap0e/gJoCJO9ADtUUQI8FfbN9vkNJmoXdtU3rEMSS6QcxkrqFGn/v5YFa497+pBeqxLOwyAapwTfXa+XLLVxe3anRV52M8RaYMe2RwF7LhNSAmzXntJfDSZrCHxvQNfkdqsmXkS1zqb+Qn3XsE7lheCl8K0Fdc4khZTMdvAufeHwatcOTB/jJLdhMPL9UIQMZy9HbGyawcz8TAOt7dMQEvFEv1Xzt+ksC5Io96VtGITBBxawz58OHwtXQcBMuU43VsYY531mCB6YaXAAsP8Pb8Sh7oXp0frC281AvyacEY67ivrPDTbj+4V7oBNM=; 5:5TUYHrSIAVoMBQbejhc6CW17JpZ0zFLFoQen2aLGQp/BFWwe665kHkPIe/Dx5StlwzRAUo+xvGcP/8yx2STnBGiMjVe1B991E7HrehY1Tm18MR0ujN8ypFtJMAyaynIRxzrwAL+NtK3JvRVAKjAYtXHKk8lmkoGAPaG8HPyNdhI=; 24:WoHQO+0rAUJX328D16rRqHnltDcQ527F/AXyLyszAxrxnG32o9H6KJTi0qNpB62i73gW/CF/mcJrp+3jkDo6RaTc7/91KRS7bBNnB/2o+YA=; 7:CNQcJUyylNn6i9rDjGhy77AKuAR1OG2awE1ebbKLYPO8yn/0wtDm5Kdh9b9vSvmDpIVCR0Kf14EPVNhgLY9oaVjjWiSh7UiBBZTB85Ix7+3sAsbd22D2qmzHTPvYpBMzRSCVMcqmd7NMpgjK+VVMnlH5QmkLQfA6gsEZHbukwT5OLK2oy44PVjFW9pmyW9mgr38S0W+6Ne1S/fCsnytnv+sBXJRxXSs7ggwKuUjzBqC7vuDU8U97xHVP3yaES4rV x-incomingheadercount: 45 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125374)(1701031045); SRVR:DB5EUR01HT023; x-ms-traffictypediagnostic: DB5EUR01HT023: x-ms-office365-filtering-correlation-id: 234ac9b8-8f5f-4ecd-a5a4-08d56a6afdca x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:DB5EUR01HT023; BCL:0; PCL:0; RULEID:; SRVR:DB5EUR01HT023; x-forefront-prvs: 05715BE7FD x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:DB5EUR01HT023; H:AM4PR06MB1491.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 234ac9b8-8f5f-4ecd-a5a4-08d56a6afdca X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2018 18:30:09.7912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT023 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: MinPlatformPkg/PlatformInit: FV code X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 18:24:35 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good point with the DxeCore, I didn't consider that. Though OsBoot would be= irrelevant to the PEI phase, wouldn't it be? Thanks, Marvin From: Yao, Jiewen [mailto:jiewen.yao@intel.com] Sent: Friday, February 2, 2018 1:40 PM To: Marvin H?user ; edk2-devel@lists.01.org Subject: RE: MinPlatformPkg/PlatformInit: FV code Excellent question. Comment inline. From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] Sent: Wednesday, January 31, 2018 1:54 AM To: edk2-devel@lists.01.org; Yao, Jiewen > Subject: MinPlatformPkg/PlatformInit: FV code Dear developers, dear Jiewen, I have been investigating the devel-MinPlatform branch of edk2-platforms fo= r educational purposes and got two questions regarding the Firmware Volume = code in PlatformInitPreMem, if you do not mind. I assume the tree was teste= d, so most likely I misunderstood some things. 1. Why is a Firmware Volume HOB built to cover the entire flash range (h= ttps://github.com/tianocore/edk2-platforms/blob/devel-MinPlatform/Platform/= Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c#L379= )? Am I correct that this implies a FV spanning through the entire flash MM= IO range, which would then imply all other FVs are contained within it? Thi= s would make sense, however that's not what I saw in the KabylakeOpenBoardP= kg Flash Map, which has the NV Storage first (https://github.com/tianocore/= edk2-platforms/blob/devel-MinPlatform/Platform/Intel/KabylakeOpenBoardPkg/I= nclude/Fdf/FlashMapInclude.fdf#L25). [Jiewen] You are right. We should not use FD region for FV. Will fix it. 1. Why are FV Info PPIs installed for the UefiBoot and the OsBoot FVs (h= ttps://github.com/tianocore/edk2-platforms/blob/devel-MinPlatform/Platform/= Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c#L344= )? If I checked correctly, installing this PPI type will trigger PeiCore to= dispatch PEIMs in the FVs, however there are only DXE drivers in these. Wh= y are no FV HOBs installed, which are gotten by DxeCore? [Jiewen] In DxeIpl, PeiServicesFfsFindNextVolume() is used to search DxeCor= e. In PeiCore, PeiFfsFindNextVolume() calls FindNextCoreFvHandle() for DxeCore= one by one. If PcdFrameworkCompatibilitySupport is FALSE, it returns &Priv= ate->Fv[Instance] directly. And Fv[Instance] is added in FirmwareVolmeInfoPpiNotifyCallback(), when gEf= iPeiFirmwareVolumeInfo2PpiGuid is installed. So if PcdFrameworkCompatibilitySupport is FALSE, install PPI is the only wa= y to let PEI core discover DxeCore. Only if PcdFrameworkCompatibilitySupport is TRUE, install PPI is not requir= ed, but the FindNextCoreFvHandle() will install the PPI for the HobFv. The = result is same. Thank you Yao Jiewen Thanks in advance for your time! Best regards, Marvin.