From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-oln040092071092.outbound.protection.outlook.com [40.92.71.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7BA8D21D28FDB for ; Tue, 25 Jul 2017 02:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yyvwEVulHVZrXfbqmzgfn7fIL0RpyNCtiEAT12x8mP4=; b=PHlmu7CAjnqqu/UsSMkGqvLwUrrXKIiopdy4N7FNgyycIFSFRX27CWjMa+sWOogYTz41de/2TDhVXXj16WA6iIkjYv5N4u1mVgpXUjoQiKNUg3PKAD71QnFp087etg/xJpiDeKLvV5ygM8ZHA84H0C8CKghOxauFCVgwOQBM1KptB0Oif37TzZ61BSnLCOUPIEhU2H3sJpNTLdZGQJJ58bJSnMEmcTt3KW4V9EVqPBFP5QWnCrxjcC62rEXWqKkqFGQNbW9OOyVmIHz93G+2qUifvH4L1/6ikkcPUM8V+Lo0Xmrz2lOyimnzaBah658GLkkHzQLW9UAP/hm08TJYVg== Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com (10.152.18.53) by VE1EUR03HT037.eop-EUR03.prod.protection.outlook.com (10.152.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1240.9; Tue, 25 Jul 2017 09:42:45 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com (10.152.18.60) by VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1240.9 via Frontend Transport; Tue, 25 Jul 2017 09:42:45 +0000 Received: from AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::dcd0:60e6:90e0:871b]) by AM4PR06MB1491.eurprd06.prod.outlook.com ([fe80::dcd0:60e6:90e0:871b%13]) with mapi id 15.01.1282.020; Tue, 25 Jul 2017 09:42:44 +0000 From: Marvin H?user To: "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2. Thread-Index: AdMEm0stAu8v+ZaLQCePXmnkVRlHwgAg1CNQAAEYgJAAAImFIAABJhJA Date: Tue, 25 Jul 2017 09:42:44 +0000 Message-ID: References: <0C09AFA07DD0434D9E2A0C6AEB0483103B8F5988@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8F59EA@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B8F59EA@shsmsx102.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:B46EF49815F9096A832097B979FD243E82F1F93D911CE45BC77B1FF0CB3FC6F3; UpperCasedChecksum:95AF6ADEC97ED3AD087EE6C21F93642676E379F047FC398F9C51DEDFAC1C667F; SizeAsReceived:7690; Count:45 x-tmn: [fj1HVvMpLkWFEDRJIIccg50zo1ZObuusprg7i5ZZrXz80Kolixt/GQG06U7qPCGg] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VE1EUR03HT037; 7:P5S4xq28+L2iCL7zWirpy1hgpQ1CN6eusA25crpO7bGtUnRbHz31qr4B5WZOjQyDtG5/pFoEnAnjL0jJOlRPlwlEJaQsYDO6y8jvP8MxbNGte4pAVuho6HrPMUbyFcezhs/jeNeNvMFTWrp1XfhRCatW0B0hm+8n5NZgZfCcLcOTIA5HgV1IFrErkRYqT3oF1OUk2SBZJqc0oG07vGUTRZCkaKIXeRJbrUgP32QRrKIudQKDuOLwG+n8fN+VkhQO+JCzkmg+muZwmql3fRYstofnxzw/LAFIHWmWtEFm/kZuHYlYwXTPPBru/wo4UTNZ/Lp8Z7yqhJ59UFKTijp37w4Q63eMIq0Hgy6aJwVBuwDOYVUpY+SNc8eBwYth8S4SlmCBo0KwrRCCwwaQNAM2QosXj+w4alR8dZOST6C3kCRbctUxTP22p+Z/igT1EAb/bDj/8HYkI43Sw153k3afWgTZ1v45QsNudvdewvExYoYUMJPwLhjbvuDdnZ86HG2XfvGraH/dxydD/BieG2L+VfM4g6j5JTemrz4Xd946wiS/aZyvHGscIvWVl9MVlhq66ZnZq9sHxUIE/H4oYysDXQffjmhadHaoO/nRfe8UG0ZZcGBC5TqiRL9HYJhJMtmNZPF/LuTI96FyJbtqYcaPxM7c9IyDCrENNRkAf/vXvH97Al3HsiadxYsagzikFbpBt7fcKUilyRutRmOdWKyq9x3/WctZ3w2yktkNiW00V0lJeUOIKF2eJ6g7spfzKIzbotJT+eFnKfnLqOK9/KlxAw== x-incomingheadercount: 45 x-eopattributedmessage: 0 x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(7070007)(98901004); DIR:OUT; SFP:1901; SCL:1; SRVR:VE1EUR03HT037; H:AM4PR06MB1491.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: 8d1d4b1e-b107-4689-f9ee-08d4d341807c x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201702061074)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322350)(1603101448)(1601125374)(1701031045)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VE1EUR03HT037; x-ms-traffictypediagnostic: VE1EUR03HT037: x-exchange-antispam-report-test: UriScan:(189930954265078)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(444000031); SRVR:VE1EUR03HT037; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VE1EUR03HT037; x-forefront-prvs: 03793408BA spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2017 09:42:44.7154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR03HT037 Subject: Re: [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jul 2017 09:40:47 -0000 Content-Language: de-DE Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry, I remembered 'IN OUT' incorrectly then, you are correct. Only 'OPTIO= NAL' is lacking. Would be very kind of you if you could help submitting the ECR, I do not ha= ve an active account at this point. Thanks, Marvin. > -----Original Message----- > From: Zeng, Star [mailto:star.zeng@intel.com] > Sent: Tuesday, July 25, 2017 11:09 AM > To: Marvin H?user ; edk2- > devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > EFI_PEI_GET_VARIABLE2. >=20 > As I know submitting ECR needs log in as a member at > http://www.uefi.org/memberslogin, I am not sure the whole process. > If needed, I can help to submit the ECR. >=20 > According to EDK2 coding style doc at > https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards- > specification/content/5_source_files/57_c_programming.html#table-9- > parameter-modifiers > IN OUT Passed by reference, and the passed-in referenced data is consumed > and then modified by the routine. >=20 > But the code will not consume the pass in referenced data. Personally, I = don't > think just checking NULL pointer should be marked as 'IN' >=20 >=20 > Thanks, > Star > -----Original Message----- > From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] > Sent: Tuesday, July 25, 2017 4:58 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > EFI_PEI_GET_VARIABLE2. >=20 > Hey Star, >=20 > Thanks for your comment! Sorry, I never submited such a report, could you > please point me in the right direction? The only way of contact I found o= n the > site of the UEFI Forum were Administration and Press, both don't sound li= ke > the right place to post to. Or Is 'Administration' specification administ= ration > rather than forum administration? >=20 > Regarding 'IN': Correct me if I'm wrong, but in contrast to just 'OUT' > parameters, which are 'blindly' written to, 'Attributes' must be checked > against NULL first before attempting a dereference. Is this not the corre= ct > usage of IN? Is IN only used, when the pointer's destination is read? >=20 > Thanks again! >=20 > Regards, > Marvin. >=20 > > -----Original Message----- > > From: Zeng, Star [mailto:star.zeng@intel.com] > > Sent: Tuesday, July 25, 2017 10:25 AM > > To: Marvin H?user ; edk2- > > devel@lists.01.org > > Cc: Zeng, Star > > Subject: RE: [UEFI PI 1.6/EDK2] Missing decorators for > > EFI_PEI_GET_VARIABLE2. > > > > Marvin, > > > > I think you are right about the statement of decorator 'OPTIONAL', you > > can submit PI ECR, then it can be aligned with UEFI EFI_GET_VARIABLE. > > typedef > > EFI_STATUS > > (EFIAPI *EFI_GET_VARIABLE)( > > IN CHAR16 *VariableName, > > IN EFI_GUID *VendorGuid, > > OUT UINT32 *Attributes, OPTIONAL > > IN OUT UINTN *DataSize, > > OUT VOID *Data OPTIONAL > > ); > > > > And since the passed-in state of the referenced data is not used by > > the routine, I don't think decorator 'IN' should be added. > > > > > > > > Thanks, > > Star > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Marvin H?user > > Sent: Tuesday, July 25, 2017 12:42 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] [UEFI PI 1.6/EDK2] Missing decorators for > > EFI_PEI_GET_VARIABLE2. > > > > Dear developers, > > > > I noticed that EFI_PEI_GET_VARIABLE2 is lacking decorators in both the > > UEFI PI 1.6 specification and the EDK2 codebase. The parameter > > description for 'Attributes' starts with 'If non-NULL', hence it may > > be NULL, which is not reflected in the function prototype with the > decorator 'OPTIONAL'. > > Furthermore, as the possibility of it being NULL is not coupled to the > > values of the other parameters, 'IN' should be added as well. > > > > Can someone please forward this to the right working group? > > > > Thanks and best regards, > > Marvin. > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel