public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Marvin H?user <Marvin.Haeuser@outlook.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2.
Date: Mon, 24 Jul 2017 16:41:41 +0000	[thread overview]
Message-ID: <AM4PR06MB1491EE1E0FEAD1B7B170573B80BB0@AM4PR06MB1491.eurprd06.prod.outlook.com> (raw)

Dear developers,

I noticed that EFI_PEI_GET_VARIABLE2 is lacking decorators in both the UEFI PI 1.6 specification and the EDK2
codebase. The parameter description for 'Attributes' starts with 'If non-NULL', hence it may be NULL, which is
not reflected in the function prototype with the decorator 'OPTIONAL'. Furthermore, as the possibility of it
being NULL is not coupled to the values of the other parameters, 'IN' should be added as well.

Can someone please forward this to the right working group?

Thanks and best regards,
Marvin.


             reply	other threads:[~2017-07-24 16:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 16:41 Marvin H?user [this message]
2017-07-25  8:24 ` [UEFI PI 1.6/EDK2] Missing decorators for EFI_PEI_GET_VARIABLE2 Zeng, Star
2017-07-25  8:57   ` Marvin H?user
2017-07-25  9:09     ` Zeng, Star
2017-07-25  9:42       ` Marvin H?user
2017-07-25  9:46         ` Zeng, Star
2017-07-25 13:14           ` Zeng, Star
2017-07-25 13:24             ` Marvin H?user
2017-07-25 13:30               ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR06MB1491EE1E0FEAD1B7B170573B80BB0@AM4PR06MB1491.eurprd06.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox