From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.81; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0081.outbound.protection.outlook.com [104.47.1.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C5DF2218E928 for ; Tue, 5 Dec 2017 10:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4BGF6iaDYykhkI48Ye+6akQZcR2qxSZe+MtPgdn+/8U=; b=DPGNfrPjrSISFrbFPfi8dk8mwK/VXKhsJaClo1/P+jdpBdcJ/gFPq4h0DzOCYW/5snUCgPTMqyCwZ20MmLdebmbpGs4cSl4bWzmqQ+Qkw5QARaXtC3cz7aQtSk9GITFrV2vZHjHQK2aTS4jGRumydsyvaxxgJziOnT79eNTac3M= Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com (10.168.5.24) by AM4PR0801MB1442.eurprd08.prod.outlook.com (10.168.5.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Tue, 5 Dec 2017 18:55:25 +0000 Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::2953:37dd:2fcb:a418]) by AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::2953:37dd:2fcb:a418%14]) with mapi id 15.20.0302.007; Tue, 5 Dec 2017 18:55:25 +0000 From: Evan Lloyd To: Leif Lindholm CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 02/19] ArmPlatformPkg: Tidy LcdGraphicsOutputDxe code: Added comments Thread-Index: AQHTNwRIiRSyeJngAke6xVIBe38dHKLgqysAgFTTe9A= Date: Tue, 5 Dec 2017 18:55:25 +0000 Message-ID: References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-3-evan.lloyd@arm.com> <20171012190208.q27xin4lleppjqo4@bivouac.eciton.net> In-Reply-To: <20171012190208.q27xin4lleppjqo4@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0801MB1442; 6:2jrQBMaxM1mHgLl76QlUm3/bXsV2g+UIfHCwqUQZ87a/dTtkfRpzDd2yBjsjqAq+JwuoibUkllQBFxNSYW4tuc8p1WRvR9pgCbfM55O1R0vRzprXt9d6a3zcJopYGcSQCv1F476Q2m0nxHntcSjctlFXir4CF0KL6Jfiigi08OwEz1YgKTdU7N1COooCfLlJQc3fz6LwvN+AZW+nMX7viOP45n93dmhiHGI9CKuTEED31jGuyB5ZlCkt3n/9qnCB9HNCW8mIwO7jK6TOCMRAz776Pkc9VGLY99R6N65P7i4z0+JYO26CGanWmRQbjeXuX9J1rIED4Vqcm8xEHAYyDcq5hvD5cHvnZBPISCgUTuo=; 5:JCCxZqoBE/32PJ/BvEooQdStZqQu1oW+EmUX+KqFS14fORBDUXufdBKHat5lD/13YmsYvTiBc6IQvtaosxEeTekp4NpXAOPKXqNTEUeNue38TeJCjooVPD6qGVVVb9t+5Li5TxegfXD6Pje6A5CRm/VMbVQMNVtxhXg+WBWTqmk=; 24:tfdMOT12JZ1aLqz5Mc6pcx7BO8L+M/Za+sGcD0LDM/KKFMauK82k7OceAXbikqL7M2d14aLFg3oTTXg35ouyTDblkHFqOZ6BHQqc9MCNBaM=; 7:9O115HQz79yQX6QL+c/1/73rbgh/Q2G37zeMnNp7d67LzOFuwt6RK7kNQz2rEoL9nhHKbRzVckYiHUmK4b7uWusVPquWBbxnXsGpNnMC8ODGxmVmO6J9kw9b2WfNhdC/+LvpIKXj/bNmRRNfjzlpihf5ks7piL0RVrd8pEU/vYKGi9/hq3KGfXp3KXo+QkUKCxytm5XQHSfNoBsrUFB7QQf23ZBim93XEntEbDmlmggXVVc959vCUUvSQwrkFGwi x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 7b847ded-ea30-45f2-a57f-08d53c11be95 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286); SRVR:AM4PR0801MB1442; x-ms-traffictypediagnostic: AM4PR0801MB1442: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231022)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR0801MB1442; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM4PR0801MB1442; x-forefront-prvs: 0512CC5201 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(366004)(24454002)(13464003)(40434004)(199004)(189003)(6436002)(3280700002)(2906002)(66066001)(53946003)(14454004)(53936002)(55016002)(5890100001)(102836003)(5250100002)(6506006)(316002)(101416001)(6116002)(3660700001)(229853002)(5660300001)(8936002)(106356001)(2950100002)(3846002)(72206003)(6916009)(966005)(8676002)(9686003)(6306002)(99286004)(2900100001)(81156014)(81166006)(105586002)(97736004)(86362001)(478600001)(76176011)(53546010)(7696005)(68736007)(575784001)(45080400002)(305945005)(7736002)(33656002)(25786009)(6246003)(74316002)(4326008)(579004)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0801MB1442; H:AM4PR0801MB1444.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b847ded-ea30-45f2-a57f-08d53c11be95 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2017 18:55:25.0350 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0801MB1442 Subject: Re: [PATCH 02/19] ArmPlatformPkg: Tidy LcdGraphicsOutputDxe code: Added comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 18:50:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: 12 October 2017 20:02 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 02/19] ArmPlatformPkg: Tidy > LcdGraphicsOutputDxe code: Added comments > > Given that all changes to the first file _remove_ comments, it may be bet= ter > with a subject line saying "updating comments". > > On Tue, Sep 26, 2017 at 09:15:12PM +0100, evan.lloyd@arm.com wrote: > > From: Girish Pathak > > > > There is no functional modification in this change As preparation for > > a Change (Rejig of LcdGraphicsOutPutDxe), some comments are modified > > and a few new comments are added. > > This is to prevent mixing formatting changes with functional changes. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Girish Pathak > > Signed-off-by: Evan Lloyd > > --- ... > > > > - > > +/** Platform related initialization function. > > + * > > + * @param IN Handle Handle to the LCD device instance. > > + * > > + * @retval EFI_SUCCESS Platform initialization success. > > + * @retval !(EFI_SUCCESS) Other errors. > > +**/ > > So ... 6.8 lists > /** > text > **/ > as the > > The format > /** > * text > **/ > is mentioned as "also legal because doxygen ignores the leading *". > > The format > /** > * > **/ > is never mentioned, although I guess "also legal" because * ignored. > > However, a quick skim in MdePkg suggests the former is the generally used > variant. Can you please update to that format throughout (drop the leadin= g > '*' on lines not starting or ending the comment block)? [[Evan Lloyd]] I'm not sure if Outlook has mangled something, or I'm being= obtuse, but I'm not sure I follow the distinction you are making there. However, if your objection is to the leading '*' then we can remove it. By the way - shouldn't it be: /** Brief description Details **/ (see Horor vacuii) I actually think the CCS is woefully inconsistent in its example comment st= yle, and that although leading '*'s are acceptable to Doxygen, it would be = better to stick to one style (that of the file header comment, without lead= ing '*'s) throughout. > > No other comments (other than having these prototype documentations > are a great improvement). > > / > Leif > > > EFI_STATUS > > LcdPlatformInitializeDisplay ( > > IN EFI_HANDLE Handle > > ); > > > > +/** Reserve VRAM memory in DRAM for the frame buffer > > + * (unless it is reserved already). > > + * > > + * The allocated address can be used to set the frame buffer. > > + * @param OUT VramBaseAddress A pointer to the frame buffer > address. > > + * @param OUT VramSize A pointer to the size of the frame > > + * buffer in bytes > > + * > > + * @retval EFI_SUCCESS Frame buffer memory allocation suc= cess. > > + * @retval !(EFI_SUCCESS) Other errors. > > +**/ > > EFI_STATUS > > LcdPlatformGetVram ( > > OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, > > OUT UINTN* VramSize > > ); > > > > +/** Return total number of modes. > > + * > > + * @retval UINT32 Mode Number. > > +**/ > > UINT32 > > LcdPlatformGetMaxMode ( > > VOID > > ); > > > > +/** Set the requested display mode. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @retval EFI_SUCCESS Set mode success. > > + * @retval EFI_INVALID_PARAMTER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformSetMode ( > > IN UINT32 ModeNumber > > ); > > > > +/** Return information for the requested mode number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT Info Pointer for returned mode informat= ion > > + * (on success). > > + * > > + * @retval EFI_SUCCESS Success if the requested mode is f= ound. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformQueryMode ( > > IN UINT32 ModeNumber, > > OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *Info > > ); > > > > +/** Returns the display timing information for the requested mode > number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT HRes Pointer to horizontal resolution. > > + * @param OUT HSync Pointer to horizontal sync width. > > + * @param OUT HBackPorch Pointer to horizontal back porch. > > + * @param OUT HFrontPorch Pointer to horizontal front porch. > > + * @param OUT VRes Pointer to vertical resolution. > > + * @param OUT VSync Pointer to vertical sync width. > > + * @param OUT VBackPorch Pointer to vertical back porch. > > + * @param OUT VFrontPorch Pointer to vertical front porch. > > + > > + * @retval EFI_SUCCESS Success if the requested mode is f= ound. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformGetTimings ( > > IN UINT32 ModeNumber, > > @@ -212,6 +244,14 @@ LcdPlatformGetTimings ( > > OUT UINT32* VFrontPorch > > ); > > > > +/** Return bits per pixel information for a mode number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT Bpp Pointer to value Bytes Per Pixel. > > + * > > + * @retval EFI_SUCCESS The requested mode is found. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformGetBpp ( > > IN UINT32 ModeNumber, > > diff --git > > > a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcd > ArmVE > > xpress.c > > > b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcd > ArmVE > > xpress.c index > > > 2041de5f63c72de6f0ce4047420c282507a1d04a..cfe3259d3c737de240350 > e8c3eab > > 867b80c40948 100644 > > --- > > > a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcd > ArmVE > > xpress.c > > +++ > b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcd > A > > +++ rmVExpress.c > > @@ -44,7 +44,8 @@ typedef struct { > > UINT32 VFrontPorch; > > } LCD_RESOLUTION; > > > > - > > +/** The display modes supported by the platform. > > +**/ > > LCD_RESOLUTION mResolutions[] =3D { > > { // Mode 0 : VGA : 640 x 480 x 24 bpp > > VGA, VGA_H_RES_PIXELS, VGA_V_RES_PIXELS, > LCD_BITS_PER_PIXEL_24, > > @@ -94,6 +95,11 @@ EFI_EDID_ACTIVE_PROTOCOL mEdidActive =3D { > > NULL > > }; > > > > +/** HDLCD Platform specific initialization function. > > + * > > + * @retval EFI_SUCCESS Plaform library initialization succ= ess. > > + * @retval !(EFI_SUCCESS) Other errors. > > +**/ > > EFI_STATUS > > LcdPlatformInitializeDisplay ( > > IN EFI_HANDLE Handle > > @@ -124,6 +130,18 @@ LcdPlatformInitializeDisplay ( > > return Status; > > } > > > > +/** Reserve VRAM memory in DRAM for the frame buffer > > + * (unless it is reserved already). > > + * > > + * The allocated address can be used to set the frame buffer. > > + * > > + * @param OUT VramBaseAddress A pointer to the frame buffer > address. > > + * @param OUT VramSize A pointer to the size of the frame > > + * buffer in bytes > > + * > > + * @retval EFI_SUCCESS Frame buffer memory allocation suc= cess. > > + * @retval !(EFI_SUCCESS) Other errors. > > +**/ > > EFI_STATUS > > LcdPlatformGetVram ( > > OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, @@ -170,6 +188,13 > @@ > > LcdPlatformGetVram ( > > return EFI_SUCCESS; > > } > > > > +/** Return total number of modes supported. > > + * > > + * Note: Valid mode numbers are 0 to MaxMode - 1 > > + * See Section 11.9 of the UEFI Specification 2.6 Errata A (Jan > > +2017) > > + * > > + * @retval UINT32 Mode Number. > > +**/ > > UINT32 > > LcdPlatformGetMaxMode(VOID) > > { > > @@ -178,6 +203,10 @@ LcdPlatformGetMaxMode(VOID) > > return (sizeof (mResolutions) / sizeof (LCD_RESOLUTION)); } > > > > +/** Set the requested display mode. > > + * > > + * @param IN ModeNumber Mode Number. > > +**/ > > EFI_STATUS > > LcdPlatformSetMode ( > > IN UINT32 ModeNumber > > @@ -227,6 +256,15 @@ LcdPlatformSetMode ( > > return Status; > > } > > > > +/** Return information for the requested mode number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT Info Pointer for returned mode informat= ion > > + * (on success). > > + * > > + * @retval EFI_SUCCESS Success if the requested mode is f= ound. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformQueryMode ( > > IN UINT32 ModeNumber, > > @@ -267,6 +305,21 @@ LcdPlatformQueryMode ( > > return EFI_SUCCESS; > > } > > > > +/** Returns the display timing information for the requested mode > number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT HRes Pointer to horizontal resolution. > > + * @param OUT HSync Pointer to horizontal sync width. > > + * @param OUT HBackPorch Pointer to horizontal back porch. > > + * @param OUT HFrontPorch Pointer to horizontal front porch. > > + * @param OUT VRes Pointer to vertical resolution. > > + * @param OUT VSync Pointer to vertical sync width. > > + * @param OUT VBackPorch Pointer to vertical back porch. > > + * @param OUT VFrontPorch Pointer to vertical front porch. > > + * > > + * @retval EFI_SUCCESS Success if the requested mode is f= ound. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformGetTimings ( > > IN UINT32 ModeNumber, > > @@ -296,6 +349,14 @@ LcdPlatformGetTimings ( > > return EFI_SUCCESS; > > } > > > > +/** Return bits per pixel for a mode number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT Bpp Pointer to value Bits Per Pixel. > > + * > > + * @retval EFI_SUCCESS The requested mode is found. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformGetBpp ( > > IN UINT32 ModeNumber, > > diff --git > > > a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL1 > 11Lc > > dArmVExpress.c > > > b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL1 > 11Lc > > dArmVExpress.c index > > > 8d046816454f642bced00e29c4e02093b74afd24..84880e5fd1dfe6f824b27 > e53926f > > 9bb32ff6cdf7 100644 > > --- > > > a/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL1 > 11Lc > > dArmVExpress.c > > +++ > b/ArmPlatformPkg/ArmVExpressPkg/Library/PL111LcdArmVExpressLib/PL1 > > +++ 11LcdArmVExpress.c > > @@ -41,7 +41,8 @@ typedef struct { > > UINT32 VFrontPorch; > > } LCD_RESOLUTION; > > > > - > > +/** The display modes supported by the platform. > > +**/ > > LCD_RESOLUTION mResolutions[] =3D { > > { // Mode 0 : VGA : 640 x 480 x 24 bpp > > VGA, VGA_H_RES_PIXELS, VGA_V_RES_PIXELS, > LCD_BITS_PER_PIXEL_24, > > @@ -151,7 +152,11 @@ EFI_EDID_ACTIVE_PROTOCOL mEdidActive =3D { > > NULL > > }; > > > > - > > +/** PL111 Platform specific initialization function. > > + * > > + * @retval EFI_SUCCESS Plaform library initialization succ= ess. > > + * @retval !(EFI_SUCCESS) Other errors. > > +**/ > > EFI_STATUS > > LcdPlatformInitializeDisplay ( > > IN EFI_HANDLE Handle > > @@ -176,6 +181,18 @@ LcdPlatformInitializeDisplay ( > > return Status; > > } > > > > +/** Reserve VRAM memory in DRAM for the frame buffer > > + * (unless it is reserved already). > > + * > > + * The allocated address can be used to set the frame buffer. > > + * > > + * @param OUT VramBaseAddress A pointer to the frame buffer > address. > > + * @param OUT VramSize A pointer to the size of the frame > > + * buffer in bytes > > + * > > + * @retval EFI_SUCCESS Frame buffer memory allocation suc= cess. > > + * @retval !(EFI_SUCCESS) Other errors. > > +**/ > > EFI_STATUS > > LcdPlatformGetVram ( > > OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, @@ -232,6 +249,13 > @@ > > LcdPlatformGetVram ( > > return Status; > > } > > > > +/** Return total number of modes supported. > > + * > > + * Note: Valid mode numbers are 0 to MaxMode - 1 > > + * See Section 11.9 of the UEFI Specification 2.6 Errata A (Jan > > +2017) > > + * > > + * @retval UINT32 Mode Number. > > +**/ > > UINT32 > > LcdPlatformGetMaxMode(VOID) > > { > > @@ -249,6 +273,14 @@ LcdPlatformGetMaxMode(VOID) > > return (PcdGet32 (PcdPL111LcdMaxMode)); } > > > > +/** Set the requested display mode. > > + * > > + * @param IN ModeNumber Mode Number. > > + * > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > + * @retval EFI_UNSUPPORTED PLL111 configuration not supported= . > > + * @retval !(EFI_SUCCESS) Other errors. > > +**/ > > EFI_STATUS > > LcdPlatformSetMode ( > > IN UINT32 ModeNumber > > @@ -320,6 +352,15 @@ LcdPlatformSetMode ( > > return Status; > > } > > > > +/** Return information for the requested mode number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT Info Pointer for returned mode informat= ion > > + * (on success). > > + * > > + * @retval EFI_SUCCESS Success if the requested mode is f= ound. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformQueryMode ( > > IN UINT32 ModeNumber, > > @@ -360,6 +401,21 @@ LcdPlatformQueryMode ( > > return EFI_SUCCESS; > > } > > > > +/** Returns the display timing information for the requested mode > number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT HRes Pointer to horizontal resolution. > > + * @param OUT HSync Pointer to horizontal sync width. > > + * @param OUT HBackPorch Pointer to horizontal back porch. > > + * @param OUT HFrontPorch Pointer to horizontal front porch. > > + * @param OUT VRes Pointer to vertical resolution. > > + * @param OUT VSync Pointer to vertical sync width. > > + * @param OUT VBackPorch Pointer to vertical back porch. > > + * @param OUT VFrontPorch Pointer to vertical front porch. > > + * > > + * @retval EFI_SUCCESS Success if the requested mode is f= ound. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformGetTimings ( > > IN UINT32 ModeNumber, > > @@ -389,6 +445,14 @@ LcdPlatformGetTimings ( > > return EFI_SUCCESS; > > } > > > > +/** Return bits per pixel for a mode number. > > + * > > + * @param IN ModeNumber Mode Number. > > + * @param OUT Bpp Pointer to value Bits Per Pixel. > > + * > > + * @retval EFI_SUCCESS The requested mode is found. > > + * @retval EFI_INVALID_PARAMETER Requested mode not found. > > +**/ > > EFI_STATUS > > LcdPlatformGetBpp ( > > IN UINT32 ModeNumber, > > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c > > b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c > > index > > > eb0b6fb3fbbc1cb605469433f6c6dcb85bac668c..744dd3d556b5071defc6b > cad5a9a > > 30881bcb4b6f 100644 > > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c > > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/HdLcd.c > > @@ -29,6 +29,12 @@ > > * > > > > > ********************************************************** > ************ > > / > > > > +/** Initialize display. > > + * > > + * @param VramBaseAddress Address of the frame buffer. > > + * > > + * @retval EFI_SUCCESS Display initialization success. > > +**/ > > EFI_STATUS > > LcdInitialize ( > > IN EFI_PHYSICAL_ADDRESS VramBaseAddress > > @@ -67,6 +73,12 @@ LcdInitialize ( > > return EFI_SUCCESS; > > } > > > > +/** Set requested mode of the display. > > + * > > + * @param ModeNumber Display mode number. > > + * @retval EFI_SUCCESS Display set mode success. > > + * @retval EFI_DEVICE_ERROR If mode not found/supported. > > +**/ > > EFI_STATUS > > LcdSetMode ( > > IN UINT32 ModeNumber > > @@ -136,6 +148,8 @@ LcdSetMode ( > > return EFI_SUCCESS; > > } > > > > +/** De-initializes the display. > > +**/ > > VOID > > LcdShutdown ( > > VOID > > @@ -145,6 +159,12 @@ LcdShutdown ( > > MmioWrite32 (HDLCD_REG_COMMAND, HDLCD_DISABLE); } > > > > +/** Check for presence of HDLCD. > > + * > > + * @retval EFI_SUCCESS Platform implements HDLCD. > > + * @retval EFI_NOT_FOUND HDLCD display controller not > > + * found. > > +**/ > > EFI_STATUS > > LcdIdentify ( > > VOID > > diff --git > > > a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe. > c > > > b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe. > c > > index > > > 2dd8f39873f77b1c211bff407cabe90c1795b121..c40c8e0fa6f4b5f7798aeb > 3c8bf3 > > f261f14cb67b 100644 > > --- > > > a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe. > c > > +++ > b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe > > +++ .c > > @@ -357,8 +357,8 @@ LcdGraphicsSetMode ( > > goto EXIT; > > } > > > > - // The UEFI spec requires that we now clear the visible portions of > > the > > - // output display to black. > > + /* The UEFI spec requires that we now clear the visible portions of = the > > + * output display to black. */ > > > > // Set the fill colour to black > > SetMem (&FillColour, sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL), 0x0); > > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > > b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > > index > > > 0b0c4204fbc44bc9e90dce3d7b410ce167d9f40c..f8a3c1f8266c0a11f111c3 > 747688 > > defc0d49877c 100644 > > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/PL111Lcd.c > > @@ -26,6 +26,12 @@ > > * > > > > > ********************************************************** > ************ > > / > > > > +/** Check for presence of PL111. > > + * > > + * @retval EFI_SUCCESS Platform implements PL111. > > + * @retval EFI_NOT_FOUND PL111 display controller not > > + * found. > > +**/ > > EFI_STATUS > > LcdIdentify ( > > VOID > > @@ -48,6 +54,12 @@ LcdIdentify ( > > return EFI_NOT_FOUND; > > } > > > > +/** Initialize display. > > + * > > + * @param VramBaseAddress Address of the frame buffer. > > + * > > + * @retval EFI_SUCCESS Display initialization success. > > +**/ > > EFI_STATUS > > LcdInitialize ( > > IN EFI_PHYSICAL_ADDRESS VramBaseAddress > > @@ -63,6 +75,12 @@ LcdInitialize ( > > return EFI_SUCCESS; > > } > > > > +/** Set requested mode of the display. > > + * > > + * @param ModeNumber Display mode number. > > + * @retval EFI_SUCCESS Display set mode success. > > + * @retval EFI_DEVICE_ERROR If mode not found/supported. > > +**/ > > EFI_STATUS > > LcdSetMode ( > > IN UINT32 ModeNumber > > @@ -123,7 +141,7 @@ LcdSetMode ( > > > > // PL111_REG_LCD_CONTROL > > LcdControl =3D PL111_CTRL_LCD_EN | PL111_CTRL_LCD_BPP (LcdBpp) > > - | PL111_CTRL_LCD_TFT | PL111_CTRL_BGR; > > + | PL111_CTRL_LCD_TFT | PL111_CTRL_BGR; > > > > MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl); > > > > @@ -134,6 +152,8 @@ LcdSetMode ( > > return EFI_SUCCESS; > > } > > > > +/** De-initializes the display. > > +*/ > > VOID > > LcdShutdown ( > > VOID > > -- > > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.