From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40086.outbound.protection.outlook.com [40.107.4.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C48C721E1B766 for ; Thu, 21 Sep 2017 11:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=V7hCVGq6+Fqy96xhvWnxesKhgB502aDXptfxMVrkjpk=; b=H3wPdPchjDjJH7dN0Q5JeNTkV7eD6+S+VgS67bO3dEUQFkVN71qqqCpVBV9qas68EBzpDYP6iOFNWieAg71TAwY2cgEbNgcj/tfg8phHnAJYsiNf0YhvjGGeX04947c+MJNVstK3F1WQvB9kDMCEOwQusv3U2Tg+UDA/hdq6N/o= Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com (10.168.5.24) by AM4PR0801MB1476.eurprd08.prod.outlook.com (10.168.5.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 21 Sep 2017 18:39:33 +0000 Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::4103:93c:2261:c26c]) by AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::4103:93c:2261:c26c%13]) with mapi id 15.20.0056.018; Thu, 21 Sep 2017 18:39:32 +0000 From: Evan Lloyd To: Leif Lindholm CC: "edk2-devel@lists.01.org" , Ard Biesheuvel , Matteo Carlini , nd , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham Thread-Topic: [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM Thread-Index: AQHTMwLnU3BKhBZVfkiFYh6yHFOMXaK/qflw Date: Thu, 21 Sep 2017 18:39:32 +0000 Message-ID: References: <20170921162345.11724-1-evan.lloyd@arm.com> <20170921175602.2rjg3osgzll5dlhr@bivouac.eciton.net> In-Reply-To: <20170921175602.2rjg3osgzll5dlhr@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0801MB1476; 6:hrya70pGfOkF64KXnAo7u1ltaX0n62U75GRorqS2kseKsnEUR3VAxgqsbqlj4mBsKeKPhQ2BfTcedse4ZdRpKU2WSkQadStQtD23EzJJzn0xRlgbObKMJTacXJr6rUOFzrqx4eKh/fnrlklxdgaMtC0WNWttISbTqL9X560Mim95JVvajoyba1hklYn7trdDrXphs1kTnbXLPttXQjNnsbsmER7418RwKDeXgBlb3O7JHIEnzZQyn1teskmkuCrAOmpTd/vx+eF4Xqp6uMoU9CnZYtAeMqEE2cQj7+8OLCQWxLNyHvQkEn0rHG9/oIBIahmE/jOJZEJxTQx9VBoDvQ==; 5:+L91qt0mXQEAtHOXzbYBpj43tbjWKRlVbAUpzv8J8FIzjNDMctg7YVZui0IATBIeedIeaTnw54iop2ToaFaz1ibR3ImuGaotxg6fM+LzryW3tXpgfoo98buaGsgHa9QmLwlQdbUxhaxn2qcV6H4aJA==; 24:i8t8rWT5ZjpTFsedVazIntY1PzJFpX9lc+RyezzZp2LCRAPYjYcoOoP0wWLBvEusotP+ytR/ySbKcLlA1Vz1IFAlPIQuR6IJcJ9OTqES+iE=; 7:jA7WIyGGks/A/B2IrbtDIjJETsMCHNxbztQte42UonTCJg+PB7fTbVmsNVAZuIso2Mj9by+6iImugdpZO657nbNZ0M8M+uQlK5gE+3MZCddwspqhFg4tJzvu1lXMzDSYwUyBTaltwjTMBLrMdgZ/QpKVZ+RXEDAaRpNbtaCmSxhapdWIxMFjX+UtW7FfbW5+mGSiHCX81gWuZepOv36DyHWLBSigB/u1T18hC9NUw+k= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 724a0683-b296-4dd5-2ec4-08d501201a00 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM4PR0801MB1476; x-ms-traffictypediagnostic: AM4PR0801MB1476: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR0801MB1476; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR0801MB1476; x-forefront-prvs: 04371797A5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(199003)(24454002)(13464003)(189002)(81156014)(102836003)(81166006)(6116002)(3846002)(53546010)(8676002)(6306002)(105586002)(106356001)(68736007)(6246003)(6436002)(2950100002)(74316002)(8936002)(9686003)(6916009)(55016002)(66066001)(86362001)(189998001)(53936002)(54906003)(229853002)(7736002)(2900100001)(2906002)(6506006)(3280700002)(966005)(7696004)(72206003)(305945005)(99286003)(97736004)(14454004)(478600001)(5250100002)(316002)(5660300001)(3660700001)(25786009)(33656002)(50986999)(54356999)(101416001)(76176999)(4326008)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0801MB1476; H:AM4PR0801MB1444.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2017 18:39:32.7406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0801MB1476 Subject: Re: [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 18:36:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: 21 September 2017 18:56 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Matteo Carlini ; nd ; Arvind > Chauhan ; Daniil Egranov > ; Thomas Panakamattam Abraham > > Subject: Re: [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM >=20 > On Thu, Sep 21, 2017 at 05:23:40PM +0100, evan.lloyd@arm.com wrote: > > From: EvanLloyd > > > > This v4 series of patches corrects a problem detected on the ARM Juno > > platform that is actually generic (at least to ARM GIC platforms). > > The HardwareInterrupt protocol had no means of handling > > characteristics like Edge/Level triggered and polarity. > > > > A new HardwareInterrupt2 protocol (provided by Ard) is added, and code > > changed to utilise the new capabilities. > > > > The code is available for examination on Github at: > > https://github.com/EvanLloyd/tianocore/tree/376_irqtype_v4 > > > > v4 responds to further comments from maintainers, being mainly > > cosmetic changes. > > > > Note: Significant defects exist in the (original) Watchdog handling, > > and a new patch will follow. >=20 > If you let me move that | before pushing, I'm happy with this set. [[Evan Lloyd]] Very well, if you really feel that strongly.=20 How come you have a code style rooted in the 1960s before you were born, wh= ile I've move forward to at least the 1990s. Shouldn't I be the surly, hid= e-bound, old, luddite dinosaur? >=20 > Arvind, Daniil, Thomas - any comments? >=20 > / > Leif >=20 > > Ard Biesheuvel (3): > > EmbeddedPkg: Introduce HardwareInterrupt2 protocol > > ArmPkg/ArmGicDxe: Expose HardwareInterrupt2 protocol > > ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type > > > > Evan Lloyd (1): > > ArmPkg: Tidy GIC code before changes. > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 3 +- > > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 6 +- > > ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 31 ++- > > ArmPkg/Include/Library/ArmGicLib.h | 34 +-- > > EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h | 182 > ++++++++++++++++ > > ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 76 +++++-- > > ArmPkg/Drivers/ArmGic/ArmGicLib.c | 73 +++++-- > > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 195 > ++++++++++++++--- > > ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 218 > +++++++++++++++++--- > > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 146 > +++++++------ > > 11 files changed, 779 insertions(+), 186 deletions(-) create mode > > 100644 EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h > > > > -- > > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > >