From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.5.68; helo=eur03-ve1-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50068.outbound.protection.outlook.com [40.107.5.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 905B421F38829 for ; Tue, 17 Oct 2017 07:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QkPWrh7cv7R76uKY7Rmdv9UPn8t/1/5FGqE8ghWA2Hc=; b=Q+rZSFAq4h8uTS8ymOndFBA+pbnk+UNPRzs2/xVTsEOuwE/MRWgvGr+YnmaMWwr8HDukSfpD2iQhlquhmnOJQmVCsazlvEad4JrQ31CI/btVHDsG8Ejx2lw0EBDd30IC+hHWq47qL+riVYf6DEzYiOEm75wHBKkbc1MWICaFcLs= Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com (10.168.5.24) by AM4PR0801MB1442.eurprd08.prod.outlook.com (10.168.5.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 17 Oct 2017 14:32:05 +0000 Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::952e:5c32:61ec:aa1b]) by AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::952e:5c32:61ec:aa1b%14]) with mapi id 15.20.0077.022; Tue, 17 Oct 2017 14:32:05 +0000 From: Evan Lloyd To: Leif Lindholm CC: "edk2-devel@lists.01.org" Thread-Topic: [PATCH 13/19] ArmPlatformPkg: HdLcd Remove redundant Bpp Thread-Index: AQHTQ/hOiKrozclCEUmdGoz01Q5bBaLoH4Ow Date: Tue, 17 Oct 2017 14:32:05 +0000 Message-ID: References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-14-evan.lloyd@arm.com> <20171013075303.crtv45upaupgscxx@bivouac.eciton.net> In-Reply-To: <20171013075303.crtv45upaupgscxx@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0801MB1442; 6:OTU3TQfCuADRV4c52Zhl2DBbUyS26qbm/s6Iqedf5lM3WqVE+3DR1ukVg2+tg9pGN330vHAENyH4Wc1JqZIbh7Bf69PVa9oEhNu/2ahd+mTDZbA4S3snrDmk7PonqGlkFu9Bsk1915by3zmlF4WvlM1Q9QrwR66sy7TyrcgTErfLFPVXKlcRBdtdrlO/X3EipvW+NyC8nLrJ7EK6kvu2gL3uqEi5a2Wz366fb3Flw4vzaBDjmzkltJK0znYpVfop9/YIUUENn66X3enFFlxQEhcq3MjvqHEHfdujyZ8VDko+VOnK9TS8aL2XYznpvEH/gwQWOiD9emF9bYOUZ4UTNA==; 5:P0gjWMwlOgBqQKpt2nGRUGyPBt2WROwinLCBgC4tDDv6LrdIQWx92EeEtCwIrND28nBMuU/q70MaGoeqYuHE8Z2z+jXAH5M6z8MQpXsoOlGiaAS8o72siCy6PDI8+iE2w0QX+uu1khgoK7FnKNbr0g==; 24:ipOee9cYN4VR3+kZ5BDCFxooAUuhOfpeCLL9gdLFou1uzzR5o9BXxEa+T2t5UHHZtiJIdwRfRwIFqc/o1SwiBjf+SwmCgBui6l54bfCqNUs=; 7:vH95Pc7aap74sLBAfw4cSP/BwlsIaNWZQ7LVNrshbupNr19mTgWmHHxoIq8gSTP9LAuMMn6hyggWt7+xkyRwnvHOD2KNg2kmrEJ2IGo7pSJ23qPfAf6mMOtQpq3d+qV1e9bvP7HuAnYP/cY0ACgU+H5mAhvBL/67GyP0eqKFzvbLdGQF1DQAkaj/b6PhYpQAhvbNjC2ByuUXsgIJoF0KoSALzJuwITPgz36GsXe36JY= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: cd01ffe4-88fa-4eb8-a5b5-08d5156bd6fa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:AM4PR0801MB1442; x-ms-traffictypediagnostic: AM4PR0801MB1442: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR0801MB1442; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR0801MB1442; x-forefront-prvs: 04631F8F77 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(6029001)(346002)(376002)(39860400002)(40434004)(189002)(199003)(24454002)(13464003)(7696004)(6506006)(3660700001)(2906002)(68736007)(105586002)(5660300001)(6116002)(3846002)(316002)(9686003)(99286003)(4326008)(55016002)(81166006)(53546010)(102836003)(53936002)(81156014)(6246003)(3280700002)(74316002)(14454004)(8936002)(97736004)(7736002)(6436002)(86362001)(25786009)(2950100002)(8676002)(66066001)(33656002)(6916009)(2900100001)(106356001)(5250100002)(72206003)(478600001)(101416001)(5890100001)(189998001)(50986999)(229853002)(305945005)(76176999)(54356999); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0801MB1442; H:AM4PR0801MB1444.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2017 14:32:05.2727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0801MB1442 Subject: Re: [PATCH 13/19] ArmPlatformPkg: HdLcd Remove redundant Bpp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 14:28:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: 13 October 2017 08:53 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org > Subject: Re: [PATCH 13/19] ArmPlatformPkg: HdLcd Remove redundant Bpp > > On Tue, Sep 26, 2017 at 09:15:23PM +0100, evan.lloyd@arm.com wrote: > > From: EvanLloyd > > > > Because of copy/paste effects, HdLcdArmVExpress.c contained a table > > entry "LCD_BPP Bpp;" specifying the Bits per Pixel for each mode. > > However, all modes are LCD_BITS_PER_PIXEL_24. > > > > This change removes the table entry and related use of the field. > > Since it looks to be modifying some of the same lines, I would prefer to = see > this patch before the previous one. Or am I misreading that? [[Evan Lloyd]] It does modify some shared lines. In practice this change b= ecame obvious once the previous one had been made. I'm not sure I understa= nd what benefit you see in changing the order. I am, however, sure of the = cost of rework and re-test. Do you really need this order change? How wou= ld you feel about our rolling them both together? Evan > > / > Leif > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Girish Pathak > > Signed-off-by: Evan Lloyd > > --- > > > > > ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArm > VExp > > ress.c | 42 ++++++-------------- > > 1 file changed, 13 insertions(+), 29 deletions(-) > > > > diff --git > > > a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdAr > mVE > > xpress.c > > > b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdAr > mVE > > xpress.c index > > > dc2c5fb89923304c46d137ec8eaefc9418548d06..2401cdb30cb7252964ce1f36 > 3aa2 > > 6d99933c09be 100644 > > --- > > > a/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdAr > mVE > > xpress.c > > +++ > b/ArmPlatformPkg/ArmVExpressPkg/Library/HdLcdArmVExpressLib/HdLcdA > > +++ rmVExpress.c > > @@ -30,7 +30,6 @@ > > > > typedef struct { > > UINT32 Mode; > > - LCD_BPP Bpp; > > UINT32 OscFreq; > > > > // These are used by HDLCD > > @@ -42,37 +41,37 @@ typedef struct { > > **/ > > STATIC CONST DISPLAY_MODE mDisplayModes[] =3D { > > { // Mode 0 : VGA : 640 x 480 x 24 bpp > > - VGA, LCD_BITS_PER_PIXEL_24, > > + VGA, > > VGA_OSC_FREQUENCY, > > {VGA_H_RES_PIXELS, VGA_H_SYNC, VGA_H_BACK_PORCH, > VGA_H_FRONT_PORCH}, > > {VGA_V_RES_PIXELS, VGA_V_SYNC, VGA_V_BACK_PORCH, > VGA_V_FRONT_PORCH} > > }, > > { // Mode 1 : SVGA : 800 x 600 x 24 bpp > > - SVGA, LCD_BITS_PER_PIXEL_24, > > + SVGA, > > SVGA_OSC_FREQUENCY, > > {SVGA_H_RES_PIXELS, SVGA_H_SYNC, SVGA_H_BACK_PORCH, > SVGA_H_FRONT_PORCH}, > > {SVGA_V_RES_PIXELS, SVGA_V_SYNC, SVGA_V_BACK_PORCH, > SVGA_V_FRONT_PORCH} > > }, > > { // Mode 2 : XGA : 1024 x 768 x 24 bpp > > - XGA, LCD_BITS_PER_PIXEL_24, > > + XGA, > > XGA_OSC_FREQUENCY, > > {XGA_H_RES_PIXELS, XGA_H_SYNC, XGA_H_BACK_PORCH, > XGA_H_FRONT_PORCH}, > > {XGA_V_RES_PIXELS, XGA_V_SYNC, XGA_V_BACK_PORCH, > XGA_V_FRONT_PORCH} > > }, > > { // Mode 3 : SXGA : 1280 x 1024 x 24 bpp > > - SXGA, LCD_BITS_PER_PIXEL_24, > > + SXGA, > > (SXGA_OSC_FREQUENCY/2), > > {SXGA_H_RES_PIXELS, SXGA_H_SYNC, SXGA_H_BACK_PORCH, > SXGA_H_FRONT_PORCH}, > > {SXGA_V_RES_PIXELS, SXGA_V_SYNC, SXGA_V_BACK_PORCH, > SXGA_V_FRONT_PORCH} > > }, > > { // Mode 4 : UXGA : 1600 x 1200 x 24 bpp > > - UXGA, LCD_BITS_PER_PIXEL_24, > > + UXGA, > > (UXGA_OSC_FREQUENCY/2), > > {UXGA_H_RES_PIXELS, UXGA_H_SYNC, UXGA_H_BACK_PORCH, > UXGA_H_FRONT_PORCH}, > > {UXGA_V_RES_PIXELS, UXGA_V_SYNC, UXGA_V_BACK_PORCH, > UXGA_V_FRONT_PORCH} > > }, > > { // Mode 5 : HD : 1920 x 1080 x 24 bpp > > - HD, LCD_BITS_PER_PIXEL_24, > > + HD, > > (HD_OSC_FREQUENCY/2), > > {HD_H_RES_PIXELS, HD_H_SYNC, HD_H_BACK_PORCH, > HD_H_FRONT_PORCH}, > > {HD_V_RES_PIXELS, HD_V_SYNC, HD_V_BACK_PORCH, > HD_V_FRONT_PORCH} > > @@ -283,27 +282,12 @@ LcdPlatformQueryMode ( > > Info->VerticalResolution =3D > mDisplayModes[ModeNumber].Vertical.Resolution; > > Info->PixelsPerScanLine =3D > > mDisplayModes[ModeNumber].Horizontal.Resolution; > > > > - switch (mDisplayModes[ModeNumber].Bpp) { > > - case LCD_BITS_PER_PIXEL_24: > > - Info->PixelFormat =3D > PixelRedGreenBlueReserved8BitPerColor; > > - Info->PixelInformation.RedMask =3D LCD_24BPP_RED_MASK; > > - Info->PixelInformation.GreenMask =3D LCD_24BPP_GREEN_MASK; > > - Info->PixelInformation.BlueMask =3D LCD_24BPP_BLUE_MASK; > > - Info->PixelInformation.ReservedMask =3D LCD_24BPP_RESERVED_MASK; > > - break; > > - > > - case LCD_BITS_PER_PIXEL_16_555: > > - case LCD_BITS_PER_PIXEL_16_565: > > - case LCD_BITS_PER_PIXEL_12_444: > > - case LCD_BITS_PER_PIXEL_8: > > - case LCD_BITS_PER_PIXEL_4: > > - case LCD_BITS_PER_PIXEL_2: > > - case LCD_BITS_PER_PIXEL_1: > > - default: > > - // These are not supported > > - ASSERT (FALSE); > > - break; > > - } > > + /* Bits per Pixel is always LCD_BITS_PER_PIXEL_24 */ > > + Info->PixelFormat =3D PixelRedGreenBlueReserved8Bi= tPerColor; > > + Info->PixelInformation.RedMask =3D LCD_24BPP_RED_MASK; > > + Info->PixelInformation.GreenMask =3D LCD_24BPP_GREEN_MASK; > > + Info->PixelInformation.BlueMask =3D LCD_24BPP_BLUE_MASK; > > + Info->PixelInformation.ReservedMask =3D LCD_24BPP_RESERVED_MASK; > > > > return EFI_SUCCESS; > > } > > @@ -365,7 +349,7 @@ LcdPlatformGetBpp ( > > return EFI_INVALID_PARAMETER; > > } > > > > - *Bpp =3D mDisplayModes[ModeNumber].Bpp; > > + *Bpp =3D LCD_BITS_PER_PIXEL_24; > > > > return EFI_SUCCESS; > > } > > -- > > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.