From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0060.outbound.protection.outlook.com [104.47.0.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4246621E1B74A for ; Thu, 21 Sep 2017 13:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aTNCaXgej7eh6XelhQaGx44SI8vUSNJdCzkx8I8xv/E=; b=hWo2KYvVbKH8nH+frDDeLWvBVcZa+NriQtN3GtZZS3K8o2p+4Hj6YgXlTNChYCwb3CWGb5Psr1WcNDeLqM0PT6xUNCtY7ksAp8nRjYsVUOmrotxW5bgh69NLsk0sSnn/8v3djDg5Zg0ccFoOjF0R5sU6yDPR0BD5pmgzoIfC6x0= Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com (10.168.5.24) by VI1PR08MB0752.eurprd08.prod.outlook.com (10.164.93.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Thu, 21 Sep 2017 20:53:31 +0000 Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::4103:93c:2261:c26c]) by AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::4103:93c:2261:c26c%13]) with mapi id 15.20.0056.018; Thu, 21 Sep 2017 20:53:31 +0000 From: Evan Lloyd To: "afish@apple.com" CC: Leif Lindholm , nd , Ard Biesheuvel , "edk2-devel@lists.01.org" , Thomas Panakamattam Abraham , Arvind Chauhan Thread-Topic: [edk2] [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM Thread-Index: AQHTMwLnU3BKhBZVfkiFYh6yHFOMXaK/qflwgAAL84CAABKU4A== Date: Thu, 21 Sep 2017 20:53:31 +0000 Message-ID: References: <20170921162345.11724-1-evan.lloyd@arm.com> <20170921175602.2rjg3osgzll5dlhr@bivouac.eciton.net> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB0752; 6:GuXku+5V1n7A5zt2D3w+kUrA9LJxjohsrrblKDq5a0p1jMl0ETd/riz3VbCYJwgdpCQgZ3s8KJu/pnwQ2lg2JewU4H3ngnctumVhrDEm4TsNsd/vDq970uuHC3XpN6+W3Fsns57GiwwwUf8ukD0bUTVW1ndTeLzo3LeC+8X8SPf54bqrYRSo9n17EGLfsQZkU23ISnZob10uPu6dAD2nJoCOZ/Iz210nzk6ncEM1rceVkR68YQJBYb1QbY44rJyNSqYkpWICvyNJO6ZQrxC5nurXjX/tVlZ+V/LgMyTl2cdAvcjXp4aKayQuhxfF6gMO9fYCRAVJU0tEpPYliqYPcw==; 5:J2G8LbrkrLNSuzxWKIFBRL+zWhaCzGkNvfQEWEa1IJ7pLKJGt/q36EsjqgdTPaaofEI+V8Mrnk+dfMOd7HfmNHkO0xKCCwgrajGi+2qfH6RRLwufzvOEHw6i054uaqPXMFSutyK+uJbl101u9JULfw==; 24:TF2kK47ijdKu8ld4hwJhOoz5aq+IDAs3eQpmnGw/Omk2jeOPrPxiIumklb/LcfaMa/B3azgmoTucpSvUhrEGLmNY1b24V9qCsbteboKmXYw=; 7:bGBTXa926tFBq+BdX5Lm9f1iVVT+JvdLACymuNyCEtk0650ihMTqHt42nw1si0pAuJtbbDYbOSvSgWUnn9hQYToKX2wGTgjU8CeQVPcmAif+fQTbfZ56gprAybV0SrAmzIsPUZ+iJTxinkGOcedmmGM1jN0WGoIDX1lVZXJr2bKJBNQQ5fH37hs2IfmWUEoYECF6BCgjrE3sJsRmoqPxkNlViiRypvjDYYATg9wTSM8= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 6dc537d8-843d-44f7-4016-08d50132d146 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR08MB0752; x-ms-traffictypediagnostic: VI1PR08MB0752: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266)(31960201722614); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR08MB0752; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR08MB0752; x-forefront-prvs: 04371797A5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(6009001)(376002)(346002)(39860400002)(189002)(199003)(2900100001)(5640700003)(2950100002)(229853002)(4326008)(93886005)(6506006)(3660700001)(53546010)(2501003)(33656002)(14454004)(86362001)(189998001)(6436002)(5250100002)(3280700002)(6116002)(101416001)(3846002)(102836003)(72206003)(106356001)(97736004)(6246003)(5660300001)(7696004)(54906003)(1730700003)(105586002)(316002)(8676002)(81156014)(2351001)(8936002)(53936002)(81166006)(9686003)(25786009)(74316002)(6916009)(305945005)(45080400002)(2906002)(54356999)(50986999)(76176999)(99286003)(7736002)(68736007)(478600001)(8666007)(55016002)(66066001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB0752; H:AM4PR0801MB1444.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2017 20:53:31.2421 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0752 Subject: Re: [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 20:50:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Andrew. > From: afish@apple.com [mailto:afish@apple.com]=20 > Sent: 21 September 2017 20:15 > To: Evan Lloyd > Cc: Leif Lindholm ; nd ; Ard Bieshe= uvel ; edk2-devel@lists.01.org; Thomas Panakamat= tam Abraham ; Arvind Chauhan > Subject: Re: [edk2] [PATCH 0/4] [PATCH 0/5] Add HardwareInterrupt2 for AR= M > ? >=20 > If you let me move that | before pushing, I'm happy with this set. >=20 > [[Evan Lloyd]] Very well, if you really feel that strongly.=20 > How come you have a code style rooted in the 1960s before you were born, = while I've move forward to at least the 1990s. Shouldn't I be the surly, h= ide-bound, old, luddite dinosaur? >=20 >=20 > Yikes. There is actually no scientific data that one coding standard is b= etter than another. The data does show having a consistent coding style is = what has value.=20 >=20 > I wrote the original coding standard a long time ago.... I remember I was= a 4 space indent person, and as a compromise we moved to 2 space indent. I= t drove me crazy for about 2 weeks and then my brain flipped over and now I= prefer 2 spaces, and 4 spaces look strange. Same kind of thing happened wh= en Apple flipped the scroll direction. Folks went crazy, but after a while = your brain gets accustomed to the new normal.=20 >=20 > Thanks, >=20 > Andrew Fish [[Evan Lloyd]] Reading my comment, one could infer that I overdid calling L= eif names. Now I do do that, frequently, but generally to his face, and, if possible, = over beer. He also knows me well enough to know that I WAS there in the 1960s. The topic under discussion is the placement of operators when splitting lin= es, and the standard has no rules but lots of examples that support my case, which is that: if ( ( (some long condition) && (Another long condition)) || ( (something shortish || something shorter) && (another test) && (yet another check))) is clearer than: if (((some long condition) && (Another long condition)) || ((something shortish || something shorter) && (another test) && (yet another check))) A major reason for that is that aligning the operators at the start gives an extra clue as to how they relate to each other. In the second example the matching of operators can be obscured. I hold that a similar case applies to ordinary operators: variable =3D (a * (calculation + with)) / sums; rather than: variable =3D (a * (calculation + with)) / sums; Regards, Evan PS Outlook insists on messing with the "plain text" format, so this may not= look right, sorry.