From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0084.outbound.protection.outlook.com [104.47.2.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8034921D1E2D8 for ; Mon, 4 Sep 2017 08:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4YKzbRfCgr/iG6yQC16/z6dXYx9Qq0ocAUG5SQmOtow=; b=Qx5/Q9phLCPUtRm2KwyevS0AT1UScxZNwN/ZC9gFOCJrpNt4SA1XJAi04njafWDSau55HSD3PYqBFi7KSUdsn/zpYwm5onao9tOnc2mdUdpqPxI3PIW1s+/r+8m/kZAZjBaHfyN0WyXNhjCIm+K7CZROFwYjflP9NhBw/ZMC6JY= Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com (10.168.5.24) by AM4PR0801MB1457.eurprd08.prod.outlook.com (10.168.5.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Mon, 4 Sep 2017 15:03:42 +0000 Received: from AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::15a4:d4dc:356a:fc61]) by AM4PR0801MB1444.eurprd08.prod.outlook.com ([fe80::15a4:d4dc:356a:fc61%14]) with mapi id 15.20.0013.018; Mon, 4 Sep 2017 15:03:42 +0000 From: Evan Lloyd To: Leif Lindholm CC: "edk2-devel@lists.01.org" , Ard Biesheuvel , Matteo Carlini Thread-Topic: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 Thread-Index: AQHTI2v1lwPb8okCQ0yi3vEZ4AlSiKKk1aoA Date: Mon, 4 Sep 2017 15:03:42 +0000 Message-ID: References: <20170901172728.10480-1-evan.lloyd@arm.com> <20170901214744.hg5da6se3h7kwe7g@bivouac.eciton.net> In-Reply-To: <20170901214744.hg5da6se3h7kwe7g@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0801MB1457; 6:iai1qmj28+T3sq+80OTtDQFxtbpmH7VZ61maYhoiTy37lqsZ91KhOpm2UGHvC+tdaOO5BOMu3hn9OyGk3eBlrbaYGvwHYH4jDFEbZjZCmdwKT2sal9aJQJPblMSCJS5O8V+qgcj94Yp+gL8wXWbetO6J6DUbsnZ9vKmnM+0aCqhvLorH8PXJvz8VcQc3yxyublqEqLruCVdOD0gRwu9S9xx6hTkRCv4tM2PgkBLa12ZOtf7PxS4cMLX6v8REUA5aWEQJgDbZ7xnnNMgn2mewBpl9RRdVtQZ1Uc/dNLFZnof5xuC81+zlCqnvnJon141PynfcBHNZSqavrBU8r7tIHQ==; 5:Y3ed0xvtzMfic35X1exjNu9m5+wlrUlRbPOgX9BPrblj17zc/uWHB5SxhppKyKd/wC0XXIAoXMc/DnKyACIbZGTfVTHL7VQdP8UVSUCka60zupfQs5XBg7O0MogWmooAZ4DUvyAIYWgShzCa4Zw8JQ==; 24:WCOIGHkokCgUlHWhcUkcTds5FEgMnAtQ9BgSpkNJQUa93pRNZPtDVJRtcn51XDfkI2O396kNmQJOqw1VHCni54SQyQpwWqUu9+bt6kElSOg=; 7:lA9IK7T6kbTKfzmBE70auGled+O715BcTznouj0oKcis8Iia0KBl8AtZsK/G/p6b9fIM321lOcEVGKODwNOPpS2OJ9VJAIo5WPsjAyGlN/aokUrJaCbwUPlcEvbEQcctV4mP+y4oHD1+EFjmeP5dxAxzxxfU2GC0IZionH44bTNNqYx9QtDIxrNxt39cBnUmV2vNxVLyWT4B1SzaE/k7jn8ZIctmIIm3P9I49fFC9H4= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: d91ac9ae-c4de-459a-9b8a-08d4f3a6220a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM4PR0801MB1457; x-ms-traffictypediagnostic: AM4PR0801MB1457: x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR0801MB1457; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR0801MB1457; x-forefront-prvs: 0420213CCD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(189002)(199003)(24454002)(40434004)(13464003)(101416001)(6436002)(2900100001)(3280700002)(3660700001)(68736007)(189998001)(6916009)(2950100002)(76176999)(54356999)(76534003)(50986999)(110136004)(2906002)(106356001)(8936002)(99286003)(54906002)(5660300001)(81156014)(105586002)(6246003)(74316002)(81166006)(6306002)(55016002)(8676002)(53936002)(9686003)(86362001)(7736002)(7696004)(305945005)(14454004)(478600001)(97736004)(966005)(6506006)(5250100002)(5890100001)(66066001)(72206003)(4326008)(53546010)(33656002)(229853002)(3846002)(25786009)(102836003)(6116002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0801MB1457; H:AM4PR0801MB1444.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2017 15:03:42.6386 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0801MB1457 Subject: Re: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 15:01:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, Leif. > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: 01 September 2017 22:48 > To: Evan Lloyd > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Matteo Carlini ; ryan.harkin@linaro.org > Subject: Re: [PATCH] Platform/ARM/VExpressPkg:Fix Pcd broken in edk2 > > On Fri, Sep 01, 2017 at 06:27:28PM +0100, evan.lloyd@arm.com wrote: > > From: EvanLloyd > > > > A recent change in edk2: > > EmbeddedPkg/EmbeddedPkg.dsc: fix build for non-ARM architectures > > actually broke the build for AARCH64 architectures (well Juno, really). > > The PCD moved, PcdIsp1761BaseAddress, is used by > > edk2\EmbeddedPkg\Drivers\Isp1761UsbDxe\Isp1761UsbDxe.inf, which > was > > included by Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > > This patch moves the Isp1761UsbDxe.inf to [Components.ARM] so that it > > doesn't invoke the PCD for Juno. > > Err, oops. > > The only explanation I can think of is that in a moment of genius I decid= ed > that since TC2 was the only platform using the driver, that was the only = one I > had to build test after the change... [[Evan Lloyd]] Big of you to own up. We've all been there. > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Evan Lloyd > > Reviewed-by: Leif Lindholm > > However, would you be able to submit this under Contribution Agreement > 1.1? (a reply stating so would be sufficient, I can fold it in before > pushing) [[Evan Lloyd]] [[Evan Lloyd]] "Err, oops." Please be so good as to accept this assurance = that I intended to use Contribution Agreement 1.1. I'll change our templat= e today, to prevent this happening again. > > / > Leif > > > --- > > > > Code may be examined at: > > https://github.com/EvanLloyd/edk2- > platforms/blob/148_fix_juno_build_v1 > > /Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > > > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > index > > > 770007d1c89300f11c130515244686db6f97c96b..f82df48a00b22967f9c974152 > 6fc > > 0c1b75073fa0 100644 > > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > > @@ -471,9 +471,6 @@ [Components.common] > > EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > > !endif > > > > - # ISP1761 USB OTG Controller > > - EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > > - > > # > > # Android Fastboot > > # > > @@ -505,3 +502,9 @@ [Components.common] > > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > > > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC > ommandLib.inf > > } > > + > > +[Components.ARM] > > + > > + # ISP1761 USB OTG Controller > > + EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > > + > > -- > > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.