From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.2.58; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0058.outbound.protection.outlook.com [104.47.2.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D1F6203BEA36 for ; Fri, 4 May 2018 16:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8wJV3oUyJYAan58DQmVd8vLOu9C6gEAQaoxLT8YwluA=; b=ZIOC1E/cxAk55eIMSJu1Df0KHPF0lEK+gwhsrRk4B/i3W+sTuIlU4g7fBnSrfvqrfbwIO5v16Gr7EI6Z30TXW5je56RTFUq+SikQDD53IgEEUUOyEWVAVjXujUiTiVFpBPaKXPqNP9A/q1JoLBPjX1Un/OjonAcVlISjOWRIKyc= Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com (10.172.218.15) by AM4PR0802MB2196.eurprd08.prod.outlook.com (10.172.217.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.735.16; Fri, 4 May 2018 23:19:07 +0000 Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::e117:6f62:6a9b:6be4]) by AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::e117:6f62:6a9b:6be4%8]) with mapi id 15.20.0735.016; Fri, 4 May 2018 23:19:07 +0000 From: Supreeth Venkatesh To: Achin Gupta CC: "edk2-devel@lists.01.org" Thread-Topic: [PATCH v1 03/18] ArmPkg/Include: Add MM interface SVC return codes. Thread-Index: AQHTzbWR/Ox6f1FoLEKkVDE1KJk2AaP7qf0AgB/EW4A= Date: Fri, 4 May 2018 23:19:06 +0000 Message-ID: References: <20180406144223.10931-1-supreeth.venkatesh@arm.com> <20180406144223.10931-4-supreeth.venkatesh@arm.com> <20180411143805.GF663@e104320-lin> In-Reply-To: <20180411143805.GF663@e104320-lin> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0802MB2196; 7:TsyG8CrayoDjJlTrAU8YWvr/rrVH0zTDRyH99ATJ5oAv+wMfMV59m7AV/NJzgufcY9m0Txdkx3TMuvqydXv+I7qsVVL/ABOQdlkgmQn5iftKcEjXnEG04uC0v1YFrLg/TXgBI2CaD83eOEP+71UeRNsG1w1fYJj4QUCkXJsMGAPiVuuoX1WjOqQMDKZpDmJJX/tGJucui70CEKSnzqdtsfdkROvRJehSlWxMdxH94bBPcJQVll07NepCvSqWSd6b x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(2017052603328)(7153060)(7193020); SRVR:AM4PR0802MB2196; x-ms-traffictypediagnostic: AM4PR0802MB2196: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:AM4PR0802MB2196; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0802MB2196; x-forefront-prvs: 06628F7CA4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(39380400002)(396003)(376002)(366004)(13464003)(199004)(189003)(40434004)(105586002)(446003)(8936002)(106356001)(4326008)(11346002)(476003)(486006)(966005)(72206003)(5660300001)(6116002)(478600001)(305945005)(7736002)(3846002)(25786009)(81156014)(81166006)(8676002)(66066001)(14454004)(97736004)(316002)(5250100002)(3280700002)(99286004)(6246003)(86362001)(3660700001)(74316002)(6306002)(9686003)(55016002)(6436002)(229853002)(102836004)(6862004)(2906002)(6636002)(6506007)(68736007)(59450400001)(53546011)(33656002)(26005)(2900100001)(76176011)(7696005)(53936002)(5890100001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0802MB2196; H:AM4PR0802MB2306.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: eDtI662IntjgLa4DDUpqTXP1Zna1wq3bsYsf3x+8YFindlcQ6xXwBw1oRPiSB5tzH3ymeg55gaDdiTd2k4cRhtn+hjFPePmiXzyKJJOK8gNXZu+lpaaSnarqKh5gDXmdFctbA5uMmWII5gjkUG0KcmBU3QGsf74k8vR7KT5UhzhkAjOTitnHG/hC0MjQuiGw spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ea2de6fc-ec28-44d4-ac81-08d5b2156f18 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea2de6fc-ec28-44d4-ac81-08d5b2156f18 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2018 23:19:07.0113 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2196 Subject: Re: [PATCH v1 03/18] ArmPkg/Include: Add MM interface SVC return codes. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 23:19:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable My response inline. -----Original Message----- From: Achin Gupta Sent: Wednesday, April 11, 2018 9:38 AM To: Supreeth Venkatesh Cc: edk2-devel@lists.01.org; michael.d.kinney@intel.com; liming.gao@intel.c= om; jiewen.yao@intel.com; leif.lindholm@linaro.org; ard.biesheuvel@linaro.o= rg; nd Subject: Re: [PATCH v1 03/18] ArmPkg/Include: Add MM interface SVC return c= odes. Hi Supreeth, On Fri, Apr 06, 2018 at 03:42:08PM +0100, Supreeth Venkatesh wrote: > This patch adds the Management Mode(MM) SVC return codes as specified > in http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM= _MM_Interface_Specification.pdf. > Also, corrects SVC ID for retrieving SPM version information. The MM interface specification says nothing about these SVCs. At the moment= , this interface is exported by Arm TF. So lets say that instead. Also, it = would make sense to rename this file to ArmTfSpmSvc.h or similar 'cause thi= s SVC interface is usable by non-MM partitions too. [Supreeth] The file exists already. How would having "ArmTfSpmSvc.h" in ed= k2 code base help? This is only for edk2 based MM partition. I have removed the references to http://infocenter.arm.com/help/topic/com.a= rm.doc.den0060a/DEN0060A_ARM_MM_Interface_Specification.pdf in the commit m= essage. cheers, Achin > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > --- > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > index 4c7b6c3386..a64b9ec23c 100644 > --- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > +++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > @@ -20,7 +20,7 @@ > * delegated events and request the Secure partition manager to perform > * privileged operations on its behalf. > */ > -#define ARM_SVC_ID_SPM_VERSION_AARCH64 0xC4000060 > +#define ARM_SVC_ID_SPM_VERSION_AARCH32 0x84000060 > #define ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64 0xC4000061 > #define ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64 0xC4000064 > #define ARM_SVC_ID_SP_SET_MEM_ATTRIBUTES_AARCH64 0xC4000065 > @@ -40,4 +40,11 @@ > ((((c_perm) & SET_MEM_ATTR_CODE_PERM_MASK) << SET_MEM_ATTR_CODE_PERM= _SHIFT) | \ > (( (d_perm) & SET_MEM_ATTR_DATA_PERM_MASK) << > SET_MEM_ATTR_DATA_PERM_SHIFT)) > > +/* MM SVC Return error codes */ > +#define ARM_SVC_SPM_RET_SUCCESS 0 > +#define ARM_SVC_SPM_RET_NOT_SUPPORTED -1 > +#define ARM_SVC_SPM_RET_INVALID_PARAMS -2 > +#define ARM_SVC_SPM_RET_DENIED -3 > +#define ARM_SVC_SPM_RET_NO_MEMORY -5 > + > #endif > -- > 2.16.2 > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.