From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.1.87; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10087.outbound.protection.outlook.com [40.107.1.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D0C6021E0B9E0 for ; Wed, 7 Feb 2018 09:49:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CyO7rDvqJT9GTPf1WLTYkIJODev0neK4WYdlQCHSjUA=; b=BPi0pxKJKtDWbOjpROhr3OiLGHXwtc0p2xGGL0Fw83r10If7EhCnai7CIfUyrruVh47KXAtht1bmaqMvJ8XXX90Fc0+PfrA07vClyG7dQZGK28e6Ac84eGGvJ/Msph6wPv5+CrX0tXqsrs8vboliZBuEjjM2R6clOKK+P6LNI78= Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com (10.172.218.15) by AM4PR0802MB2196.eurprd08.prod.outlook.com (10.172.217.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Wed, 7 Feb 2018 17:55:38 +0000 Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::8d74:15bd:f59a:60a7]) by AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::8d74:15bd:f59a:60a7%18]) with mapi id 15.20.0485.009; Wed, 7 Feb 2018 17:55:38 +0000 From: Supreeth Venkatesh To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Marvin.Haeuser@outlook.com" , "tim.lewis@insyde.com" , "Yao, Jiewen" , Achin Gupta Thread-Topic: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file type and depex. Thread-Index: AQHTms77Tkcp7CKjvEidSHNAqzhl9KOYVeEAgADuAAA= Date: Wed, 7 Feb 2018 17:55:38 +0000 Message-ID: References: <20180131200613.30710-1-supreeth.venkatesh@arm.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1C8B14@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E1C8B14@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0802MB2196; 7:XmGQbVL5QuyReu+6/56Zk79eHIK04SDGVf+QOlUAz70UygJl0oQ0UONjoyAJ5aKMIij2oXftAnOUJnzZM+m4MQXOnmpeDSX70yZCPIdmjvdq2dR+59IR3oajYHcwqBslxCLowTmRNyKXp6+jtJ8oEt+sjson702etuXxOIqa9ic7GMmLlYOUg3GZNmAUor5aHYhLOiSBtV50AsEPTJk4EBYI8YqIY7eo2U+WFoBD8chOQ3kmL52KEwednTasJNm7 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: dbc60b85-fe0d-4304-7663-08d56e53ff36 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM4PR0802MB2196; x-ms-traffictypediagnostic: AM4PR0802MB2196: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(189930954265078)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(2400082)(944501161)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:AM4PR0802MB2196; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0802MB2196; x-forefront-prvs: 0576145E86 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(396003)(366004)(376002)(39860400002)(13464003)(189003)(199004)(40434004)(102836004)(6506007)(105586002)(68736007)(76176011)(26005)(2906002)(53546011)(575784001)(74316002)(186003)(7696005)(7736002)(3846002)(59450400001)(14454004)(305945005)(3280700002)(229853002)(99286004)(478600001)(25786009)(5250100002)(33656002)(97736004)(5890100001)(86362001)(4326008)(72206003)(39060400002)(45080400002)(8676002)(8936002)(55016002)(106356001)(9686003)(316002)(6116002)(3660700001)(2501003)(81166006)(5660300001)(6246003)(54906003)(2950100002)(110136005)(66066001)(81156014)(6436002)(2900100001)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0802MB2196; H:AM4PR0802MB2306.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: gsvRHMF6tV88D5H/58kY4mrGlS1TKZQ40llxjOD7okPF5lUdnOfXwCKHsEMQMQgE+IZahWYyosQG6FYxo6DpyA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbc60b85-fe0d-4304-7663-08d56e53ff36 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2018 17:55:38.4955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2196 Subject: Re: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file type and depex. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 17:49:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Thanks for your feedback. I have sent v3 of this patch with your feedback, incorporated. Supreeth -----Original Message----- From: Gao, Liming [mailto:liming.gao@intel.com] Sent: Tuesday, February 6, 2018 9:43 PM To: Supreeth Venkatesh ; edk2-devel@lists.01.or= g Cc: Kinney, Michael D ; Marvin.Haeuser@outlook.= com; tim.lewis@insyde.com; Yao, Jiewen ; Achin Gupta = Subject: RE: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file typ= e and depex. Supreeth: Thanks for your update. PI spec doesn't define EFI_FV_FILETYPE_SMM_STANDA= LONE and EFI_FV_FILETYPE_SMM_CORE_STANDALONE. So, please remove them in thi= s patch. Thanks Liming >-----Original Message----- >From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com] >Sent: Thursday, February 01, 2018 4:06 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming >; Marvin.Haeuser@outlook.com; >tim.lewis@insyde.com; Yao, Jiewen ; Supreeth >Venkatesh ; Achin Gupta > >Subject: [PATCH v2 1/1] MdePkg/Include: Add management mode FV file >type and depex. > >As per PI specification v1.6, >As per section 2.1.4.1, >The following file types exist: >Table 3. Defined File Types >Name Value >EFI_FV_FILETYPE_RAW 0x01 >EFI_FV_FILETYPE_FREEFORM 0x02 >EFI_FV_FILETYPE_SECURITY_CORE 0x03 >EFI_FV_FILETYPE_PEI_CORE 0x04 >EFI_FV_FILETYPE_DXE_CORE 0x05 >EFI_FV_FILETYPE_PEIM 0x06 >EFI_FV_FILETYPE_DRIVER 0x07 >EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 >EFI_FV_FILETYPE_APPLICATION 0x09 >EFI_FV_FILETYPE_MM 0x0A >EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B >EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C >EFI_FV_FILETYPE_MM_CORE 0x0D >EFI_FV_FILETYPE_MM_STANDALONE 0x0E >EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F > >The following new section type is added: >EFI_SECTION_MM_DEPEX > >This patch adds the management mode FV file type and depex. > >Contributed-under: TianoCore Contribution Agreement 1.1 >Signed-off-by: Achin Gupta >Signed-off-by: Supreeth Venkatesh >Reviewed-by: Jiewen Yao >--- > MdePkg/Include/Pi/PiFirmwareFile.h | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > >diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h >b/MdePkg/Include/Pi/PiFirmwareFile.h >index b982c9eda3..808202cd22 100644 >--- a/MdePkg/Include/Pi/PiFirmwareFile.h >+++ b/MdePkg/Include/Pi/PiFirmwareFile.h >@@ -71,10 +71,17 @@ typedef UINT8 EFI_FFS_FILE_STATE; > #define EFI_FV_FILETYPE_DRIVER 0x07 > #define EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > #define EFI_FV_FILETYPE_APPLICATION 0x09 >-#define EFI_FV_FILETYPE_SMM 0x0A >+#define EFI_FV_FILETYPE_MM 0x0A >+#define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B >-#define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C >-#define EFI_FV_FILETYPE_SMM_CORE 0x0D >+#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C >+#define EFI_FV_FILETYPE_COMBINED_SMM_DXE >EFI_FV_FILETYPE_COMBINED_MM_DXE >+#define EFI_FV_FILETYPE_MM_CORE 0x0D >+#define EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE >+#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E >+#define EFI_FV_FILETYPE_SMM_STANDALONE >EFI_FV_FILETYPE_MM_STANDALONE >+#define EFI_FV_FILETYPE_MM_CORE_STANDALONE 0x0F >+#define EFI_FV_FILETYPE_SMM_CORE_STANDALONE >EFI_FV_FILETYPE_MM_CORE_STANDALONE > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 >@@ -217,7 +224,8 @@ typedef UINT8 EFI_SECTION_TYPE; #define >EFI_SECTION_FREEFORM_SUBTYPE_GUID 0x18 > #define EFI_SECTION_RAW 0x19 > #define EFI_SECTION_PEI_DEPEX 0x1B >-#define EFI_SECTION_SMM_DEPEX 0x1C >+#define EFI_SECTION_MM_DEPEX 0x1C >+#define EFI_SECTION_SMM_DEPEX EFI_SECTION_MM_DEPEX > > /// > /// Common section header. >-- >2.14.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.