From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0072.outbound.protection.outlook.com [104.47.2.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 65F0821A16ED1 for ; Fri, 23 Jun 2017 09:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=osrjph8q/q5QNWGg4JvD1eTgBmWSR4Owm6FSegU7zuk=; b=d86Yu8YQXSFavNoHN8K5F+/55I76r1CmHs/Nhz7v1R928k1n7ymicf5mVn/WK4Tms0JIZQb6bLDLexKIONcCVzanAYQDD+7YF6Kqrh/2ayKSTT7K8fFOZ5R9cLPzPnPYuMlfo6pr8IxuoyZyZ2yMbZOn7QzRrA6JqDoNQvBYiyg= Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com (10.172.218.15) by AM4PR08MB2690.eurprd08.prod.outlook.com (10.171.190.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.15; Fri, 23 Jun 2017 16:08:08 +0000 Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::21de:3827:e45b:f0c]) by AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::21de:3827:e45b:f0c%17]) with mapi id 15.01.1199.016; Fri, 23 Jun 2017 16:08:08 +0000 From: Supreeth Venkatesh To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "leif.lindholm@linaro.org" , "Kinney, Michael D" , Achin Gupta , "Felixp@ami.com" , "jbrasen@qti.qualcomm.com" , "jonathan.zhang@cavium.com" , "Yao, Jiewen" Thread-Topic: [PATCH v3 01/10] BaseTools: Tools change to support PI v1.5 Specification. Thread-Index: AQHS65F4nqVpcXUXYkGZG9362J8BRKIxyPKAgADVbTA= Date: Fri, 23 Jun 2017 16:08:08 +0000 Message-ID: References: <1498161266-18877-1-git-send-email-supreeth.venkatesh@arm.com> <1498161266-18877-2-git-send-email-supreeth.venkatesh@arm.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D74DAEA@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D74DAEA@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR08MB2690; 7:9CrZKhVulU9KPXVlX5MUokHbX8hNKF4XWOoCCXzpYIjbkkcN+Q+frEOh4vk9SBMJLBezpEMC+pE9i5I2OZqv/F5dKjHBdovHq9Xuh8oaIrVGgZjVEAe8NE+D9dWSoalGwfGj2ApnIEgKl9VaTOVIwH27bX1Z4USl6CzcAs1Uqbj1iD81wOgrf/yoWm4rSViyT4U7l1Dmxt4urjS0UohTyum7K4Fc/7Oep9CK80wn3HyP5302hgMnFm/BpMIi7cGnDPs6NMr5EawU2jtSzjSenFdn4T4Hg4upbUzs7z/tQJcrJLkNFoVLeVMs9TOoXFluc5ek5LNAwzoJmbhrvsTOTkROv94fXU5eOX9BYaP8VVnXyITtLdKEyIkH1k3TFg4mx0MsIdLYtZy6KogzrIC3dHzMB12EtyXbHUALfuuDP/YmXL0wGLyBM+jP9x3JUGra3Ur1RgPFgGXKBB3pM+57I+VaEpsKmYixJz4JsA9J76LMIuxzedZp2G7A9sydV243efjDfhwmQu/ygE3oi1ilF+H+mhmwAC1pp9vIzmmapnShGnkP7YDwkxMwcq8CGPss60pvZsXKzpaeFRycGaQLphV++8Aq5Et0xmE+ooNQsaREyhvh/5zMvIhpt1Id5r/rz81AQPshbbZ9K4OwsMvgpLMmC7upPOmtic9flDesT8Fzvmu53a0DmZOdKHaO6/xdp8CeYDqkCwqzYYDUhwHsyy5wdjhoBemJvOUX6gPKn0dB4Y2V6uo/eli3/RkRlZJNhhVyd3WHwyFRbq/aplwicYW7Xz339ouccu+wTp8hU/E= x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-office365-filtering-correlation-id: e9c26fd0-e8cd-4be1-296b-08d4ba520a07 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075); SRVR:AM4PR08MB2690; x-ms-traffictypediagnostic: AM4PR08MB2690: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR08MB2690; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR08MB2690; x-forefront-prvs: 0347410860 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(39410400002)(39850400002)(39400400002)(39840400002)(13464003)(377454003)(40434004)(6246003)(6116002)(102836003)(53546010)(53936002)(229853002)(7696004)(38730400002)(2900100001)(72206003)(575784001)(25786009)(54906002)(8936002)(86362001)(6436002)(33656002)(478600001)(6506006)(4326008)(9686003)(99286003)(55016002)(3846002)(81166006)(14454004)(8676002)(189998001)(3280700002)(50986999)(76176999)(54356999)(74316002)(66066001)(5890100001)(5250100002)(2950100002)(3660700001)(2906002)(5660300001)(305945005)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB2690; H:AM4PR0802MB2306.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2017 16:08:08.2497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2690 Subject: Re: [PATCH v3 01/10] BaseTools: Tools change to support PI v1.5 Specification. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 16:06:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, No issue. I will update v4 to indicate Name change. Supreeth -----Original Message----- From: Gao, Liming [mailto:liming.gao@intel.com] Sent: Thursday, June 22, 2017 10:23 PM To: Supreeth Venkatesh ; edk2-devel@lists.01.or= g Cc: leif.lindholm@linaro.org; Kinney, Michael D ; Achin Gupta ; Felixp@ami.com; jbrasen@qti.qualcomm.= com; jonathan.zhang@cavium.com; Yao, Jiewen Subject: RE: [PATCH v3 01/10] BaseTools: Tools change to support PI v1.5 Sp= ecification. Supreeth: I just realize MM_STANDALONE and MM_CORE_STANDALONE are new feature. They= have no compatibility issue. We can directly define them with MM prefix in= stead of SMM prefix. So, for new added FV file type MM_STANDALONE and MM_CO= RE_STANDALONE, I prefer to use the same definition with PI spec. For new mo= dule type MM_STANDALONE and MM_CORE_STANDALONE, I suggest to update BaseToo= ls to support them only. For the existing SMM_CORE, DXE_SMM_DRIVER, they will still be kept for co= mpatibility. Thanks Liming >-----Original Message----- >From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com] >Sent: Friday, June 23, 2017 3:54 AM >To: edk2-devel@lists.01.org >Cc: leif.lindholm@linaro.org; Kinney, Michael D >; Gao, Liming ; >achin.gupta@arm.com; supreeth.venkatesh@arm.com; felixp@ami.com; >jbrasen@qti.qualcomm.com; jonathan.zhang@cavium.com; Yao, Jiewen > >Subject: [PATCH v3 01/10] BaseTools: Tools change to support PI v1.5 >Specification. > >PI specification v1.5 defines new firmware volume file types. > >This patch adds the new file type EFI_FV_FILETYPE_SMM_STANDALONE and >EFI_FV_FILETYPE_SMM_CORE_STANDALONE in GenFfs tool. >*_SMM_* regex instead of *_MM_* is used to preserve backwards >compatibility. > >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Jiewen Yao >Signed-off-by: Supreeth Venkatesh >--- > BaseTools/Source/C/GenFfs/GenFfs.c | 8 ++++++-- > BaseTools/Source/C/Include/Common/PiFirmwareFile.h | 2 ++ > 2 files changed, 8 insertions(+), 2 deletions(-) > >diff --git a/BaseTools/Source/C/GenFfs/GenFfs.c >b/BaseTools/Source/C/GenFfs/GenFfs.c >index c5d657b..c394b8b 100644 >--- a/BaseTools/Source/C/GenFfs/GenFfs.c >+++ b/BaseTools/Source/C/GenFfs/GenFfs.c >@@ -43,8 +43,10 @@ STATIC CHAR8 *mFfsFileType[] =3D { > "EFI_FV_FILETYPE_SMM", // 0x0A > "EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE",// 0x0B > "EFI_FV_FILETYPE_COMBINED_SMM_DXE", // 0x0C >- "EFI_FV_FILETYPE_SMM_CORE" // 0x0D >- }; >+ "EFI_FV_FILETYPE_SMM_CORE", // 0x0D >+ "EFI_FV_FILETYPE_SMM_STANDALONE", // 0x0E >+ "EFI_FV_FILETYPE_SMM_CORE_STANDALONE" // 0x0F >+}; > > STATIC CHAR8 *mAlignName[] =3D { > "1", "2", "4", "8", "16", "32", "64", "128", "256", "512", @@ -130,6 >+132,8 @@ Returns: > EFI_FV_FILETYPE_DRIVER, EFI_FV_FILETYPE_APPLICATI= ON,\n\ > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER,\n\ > EFI_FV_FILETYPE_SMM, >EFI_FV_FILETYPE_SMM_CORE,\n\ >+ EFI_FV_FILETYPE_SMM_STANDALONE,\n\ >+ EFI_FV_FILETYPE_SMM_CORE_STANDALONE,\n\ > EFI_FV_FILETYPE_COMBINED_SMM_DXE, \n\ > EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE.\n"); > fprintf (stdout, " -g FileGuid, --fileguid FileGuid\n\ diff --git >a/BaseTools/Source/C/Include/Common/PiFirmwareFile.h >b/BaseTools/Source/C/Include/Common/PiFirmwareFile.h >index 2984860..8b40ec2 100644 >--- a/BaseTools/Source/C/Include/Common/PiFirmwareFile.h >+++ b/BaseTools/Source/C/Include/Common/PiFirmwareFile.h >@@ -52,6 +52,8 @@ typedef UINT8 EFI_FFS_FILE_STATE; #define >EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > #define EFI_FV_FILETYPE_SMM_CORE 0x0D >+#define EFI_FV_FILETYPE_SMM_STANDALONE 0x0E >+#define EFI_FV_FILETYPE_SMM_CORE_STANDALONE 0x0F > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 >-- >2.7.4 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.