From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.89; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0089.outbound.protection.outlook.com [104.47.1.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 868E6210D6926 for ; Mon, 4 Jun 2018 15:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYTPtU7G1zlEOZ/VZaCO18pgN8LETgLHWmOzts7WZzw=; b=NOIcbGnJtfmwfQmXuFu18mPGkrQQ9328qImgcUtzH76MvvJexFJVnIUoOevSgUGABhmVz7sR+QlK+/19W7HKq638JcpN4RAZP54wW3NlJHCC9wE5loqB2tXxBBfIOj20ee0EnFppauT9MoLt7sqlJbXJCZvyaAyU0RkPj7EMIYs= Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com (10.172.218.15) by AM4PR0802MB2212.eurprd08.prod.outlook.com (10.172.217.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.797.11; Mon, 4 Jun 2018 22:16:47 +0000 Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::c069:5358:a14d:c096]) by AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::c069:5358:a14d:c096%10]) with mapi id 15.20.0820.015; Mon, 4 Jun 2018 22:16:47 +0000 From: Supreeth Venkatesh To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules. Thread-Index: AQHT4+huA3fU+CELwEGA6httP6LmGaQkY30AgCx3uJA= Date: Mon, 4 Jun 2018 22:16:47 +0000 Message-ID: References: <20180504204109.3354-1-supreeth.venkatesh@arm.com> <20180504204109.3354-18-supreeth.venkatesh@arm.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E225F04@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E225F04@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0802MB2212; 7:tJLlVoub6IJ3ejEaniL9g9JdDu0XgkTSixa/DDpYlz1WQZFXZ55PyKgNY4suKA3jf2qoaKBssSNgmxJLW/7S59n7iS8AwqU7GfFZCsrQ0zmnb9sU1d+eIK30OCsEqMCmXO88nbx6ud8F7xiY2+ONU94OsQniVjiYQ5Wx7HVlo4d6dH0o9gtvdzHlL+GDdnLQ5GNcimVX0fgo3mpmebCm/v8NZtMAFybFwKAFCyAGODPkDin1wCVVu0xewvvuUz6W x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM4PR0802MB2212; x-ms-traffictypediagnostic: AM4PR0802MB2212: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM4PR0802MB2212; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0802MB2212; x-forefront-prvs: 069373DFB6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39380400002)(39860400002)(376002)(346002)(13464003)(40434004)(199004)(189003)(51914003)(8936002)(59450400001)(486006)(9686003)(476003)(110136005)(6506007)(25786009)(74316002)(81156014)(11346002)(97736004)(99286004)(86362001)(5250100002)(81166006)(105586002)(68736007)(305945005)(55016002)(72206003)(2501003)(14454004)(3846002)(6116002)(5890100001)(446003)(3280700002)(102836004)(106356001)(26005)(478600001)(7696005)(6436002)(8676002)(316002)(2900100001)(6246003)(186003)(229853002)(33656002)(15650500001)(7736002)(76176011)(5660300001)(53546011)(2906002)(53936002)(66066001)(3660700001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0802MB2212; H:AM4PR0802MB2306.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:3; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: dWfX7OKe88WYx8ecrbaMhGVvCiQvMk0J9BC+7LC9TZa3v0I95XZBxGrZJqZ8LulJNZTJGXBEzsU0eZGJeYfYqDpuDLNCa6mxY75kyIHNn6TLo1XnevetkwMJB3FfG3kJNc8v8FmfvfLuRI2qHnT9qVunwiwi7dylJ0AuH+oo3IW+7p8tAOx8TdORyktK9c+K spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 042e3e31-5cc5-4d83-3b33-08d5ca68dd04 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 042e3e31-5cc5-4d83-3b33-08d5ca68dd04 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2018 22:16:47.5304 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2212 Subject: Re: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 22:16:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Thanks for the feedback. I have sent v3 of this patch. Sorry for the delay, I was waiting for feedback on other patches in the pat= ch set. Thanks, Supreeth -----Original Message----- From: Gao, Liming Sent: Monday, May 7, 2018 10:11 AM To: Supreeth Venkatesh ; edk2-devel@lists.01.or= g Cc: Kinney, Michael D ; Yao, Jiewen ; Achin Gupta ; leif.lindholm@linaro.org; a= rd.biesheuvel@linaro.org Subject: RE: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM = modules. Hi, This change should map to PiMm.h. I see the version 1 patch uses PiMm.h. + SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Lib= rary/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"], + SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", + "Library/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"], > -----Original Message----- > From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com] > Sent: Saturday, May 5, 2018 4:41 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; Yao, Jiewen ; > achin.gupta@arm.com; leif.lindholm@linaro.org; > ard.biesheuvel@linaro.org; Supreeth Venkatesh > > Subject: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM mo= dules. > > This patch corrects the Module Type Header file for Management > Mode(MM) as specified in PI v1.6 Specification. Also, it updates > parameter for auto generated template functions from > EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Supreeth Venkatesh > Reviewed-by: Jiewen Yao > --- > BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/BaseTools/Source/Python/AutoGen/GenC.py > b/BaseTools/Source/Python/AutoGen/GenC.py > index d062588882..42753af62e 100644 > --- a/BaseTools/Source/Python/AutoGen/GenC.py > +++ b/BaseTools/Source/Python/AutoGen/GenC.py > @@ -265,7 +265,7 @@ EFI_STATUS > EFIAPI > ${Function} ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ); > ${END} > """) > @@ -278,7 +278,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -292,7 +292,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -307,7 +307,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -675,7 +675,7 @@ EFI_STATUS > EFIAPI > ${Function} ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > );${END} > """), > } > @@ -755,7 +755,7 @@ VOID > EFIAPI > ProcessLibrary${Type}List ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > { > ${BEGIN} EFI_STATUS Status; > @@ -779,8 +779,8 @@ gModuleTypeHeaderFile =3D { > SUP_MODULE_UEFI_DRIVER : ["Uefi.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"], > SUP_MODULE_UEFI_APPLICATION : ["Uefi.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.= h"], > SUP_MODULE_SMM_CORE : ["PiDxe.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiDriverEntryPoint.h"], > - SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/SmmDriverStandaloneEntryPoint.h"], > - SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/SmmCoreStandaloneEntryPoint.h"], > + SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/StandaloneMmDriverEntryPoint.h"], > + SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", > + "Library/DebugLib.h", > "Library/StandaloneMmCoreEntryPoint.h"], > SUP_MODULE_USER_DEFINED : [gBasicHeaderFile] > } > > -- > 2.16.2 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.