From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.74; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0074.outbound.protection.outlook.com [104.47.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59DEC2096109D for ; Mon, 7 May 2018 12:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NQn6AD5Ned8VOFBfwDq9qhDwsq5sEOF6zq3Cl3dNHnM=; b=nunQCqQU16TeBABfHG1KmvcPJmlIzDgEyL9UCrV97c2JJLE22MpMWqy0Ax7MiNZ10Y1vmG1EwwYrNcVsre+iDYrVKJfxf7yFRDKXOWzkkQVN8IOGBkmERRtGiN7/86hAbUIAJa0HPJsPjwfZHtUgDArj2o99O7ewU21TCcfaMwg= Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com (10.172.218.15) by AM4PR0802MB2130.eurprd08.prod.outlook.com (10.172.216.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.735.16; Mon, 7 May 2018 19:16:08 +0000 Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::e117:6f62:6a9b:6be4]) by AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::e117:6f62:6a9b:6be4%8]) with mapi id 15.20.0735.018; Mon, 7 May 2018 19:16:07 +0000 From: Supreeth Venkatesh To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Yao, Jiewen" , Achin Gupta , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules. Thread-Index: AQHT4+huA3fU+CELwEGA6httP6LmGaQkY30AgABC5JA= Date: Mon, 7 May 2018 19:16:07 +0000 Message-ID: References: <20180504204109.3354-1-supreeth.venkatesh@arm.com> <20180504204109.3354-18-supreeth.venkatesh@arm.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E225F04@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E225F04@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0802MB2130; 7:0LdRoJhSrvqSEs/bevY9jaON/wlIymjyQlaXIAyYOAK52YHVWKNEOXw0kDCF5Qbe6WWVlxSAuwZwVUF7inJqv0bVxKgMldiAeXSKI2QvPG40MirUYGymZfwrMQvWWWD9EpgdLgVsSnxICIVfmbZta6krX4moyHIBLhkUBT9aak1YsxTwg8NLM9pQAtpCX/gn5EGfTCrBUtWSW1sGhxB9A8ngsPKFcpYEsQEXIhMuMaTI2e4Gj/yW7oc+TsARloxQ x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:AM4PR0802MB2130; x-ms-traffictypediagnostic: AM4PR0802MB2130: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR0802MB2130; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0802MB2130; x-forefront-prvs: 066517B35B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(376002)(39860400002)(39380400002)(40434004)(199004)(189003)(13464003)(7736002)(14454004)(81166006)(68736007)(25786009)(81156014)(8676002)(478600001)(486006)(2900100001)(9686003)(3280700002)(8936002)(3660700001)(105586002)(106356001)(2906002)(54906003)(11346002)(53546011)(110136005)(305945005)(74316002)(446003)(5660300001)(72206003)(59450400001)(6506007)(3846002)(4326008)(26005)(6436002)(6116002)(99286004)(102836004)(66066001)(316002)(7696005)(5250100002)(6246003)(97736004)(15650500001)(229853002)(33656002)(86362001)(2501003)(5890100001)(76176011)(53936002)(186003)(55016002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0802MB2130; H:AM4PR0802MB2306.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 40VYKrnJuOfVe9xLl5Kkwgt15yrf5TsRK/nFqwqsIzkYYMhf7GUVyggOjFpfypF1O0hHmU+i8j2AQ0swXFe0HsHeXmr1gDKVAod/TrYM1xtTAMTA3CLCGOrX0PioygjC3jxv6YTLU1BPx4EuuRl6X5NWVTmAT6gSPKgURyMwT7J5xIZiR5RTsB5/iQ+Mz0iQ spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 50a5f623-94a1-44b7-0011-08d5b44efc5b X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50a5f623-94a1-44b7-0011-08d5b44efc5b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2018 19:16:07.6439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2130 Subject: Re: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 19:16:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Liming. With new changes in this file and three-way merge, I have messed this up. I will resend v3 of this again. Supreeth -----Original Message----- From: Gao, Liming Sent: Monday, May 7, 2018 10:11 AM To: Supreeth Venkatesh ; edk2-devel@lists.01.or= g Cc: Kinney, Michael D ; Yao, Jiewen ; Achin Gupta ; leif.lindholm@linaro.org; a= rd.biesheuvel@linaro.org Subject: RE: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM = modules. Hi, This change should map to PiMm.h. I see the version 1 patch uses PiMm.h. + SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "Lib= rary/DebugLib.h", "Library/StandaloneMmDriverEntryPoint.h"], + SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", + "Library/DebugLib.h", "Library/StandaloneMmCoreEntryPoint.h"], > -----Original Message----- > From: Supreeth Venkatesh [mailto:supreeth.venkatesh@arm.com] > Sent: Saturday, May 5, 2018 4:41 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ; Yao, Jiewen ; > achin.gupta@arm.com; leif.lindholm@linaro.org; > ard.biesheuvel@linaro.org; Supreeth Venkatesh > > Subject: [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM mo= dules. > > This patch corrects the Module Type Header file for Management > Mode(MM) as specified in PI v1.6 Specification. Also, it updates > parameter for auto generated template functions from > EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Supreeth Venkatesh > Reviewed-by: Jiewen Yao > --- > BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/BaseTools/Source/Python/AutoGen/GenC.py > b/BaseTools/Source/Python/AutoGen/GenC.py > index d062588882..42753af62e 100644 > --- a/BaseTools/Source/Python/AutoGen/GenC.py > +++ b/BaseTools/Source/Python/AutoGen/GenC.py > @@ -265,7 +265,7 @@ EFI_STATUS > EFIAPI > ${Function} ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ); > ${END} > """) > @@ -278,7 +278,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -292,7 +292,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -307,7 +307,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -675,7 +675,7 @@ EFI_STATUS > EFIAPI > ${Function} ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > );${END} > """), > } > @@ -755,7 +755,7 @@ VOID > EFIAPI > ProcessLibrary${Type}List ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > { > ${BEGIN} EFI_STATUS Status; > @@ -779,8 +779,8 @@ gModuleTypeHeaderFile =3D { > SUP_MODULE_UEFI_DRIVER : ["Uefi.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPoint.h"], > SUP_MODULE_UEFI_APPLICATION : ["Uefi.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEntryPoint.= h"], > SUP_MODULE_SMM_CORE : ["PiDxe.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/UefiDriverEntryPoint.h"], > - SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/SmmDriverStandaloneEntryPoint.h"], > - SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/SmmCoreStandaloneEntryPoint.h"], > + SUP_MODULE_MM_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", "L= ibrary/DebugLib.h", > "Library/StandaloneMmDriverEntryPoint.h"], > + SUP_MODULE_MM_CORE_STANDALONE : ["PiSmm.h", "Library/BaseLib.h", > + "Library/DebugLib.h", > "Library/StandaloneMmCoreEntryPoint.h"], > SUP_MODULE_USER_DEFINED : [gBasicHeaderFile] > } > > -- > 2.16.2 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.