From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.69; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0069.outbound.protection.outlook.com [104.47.1.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 88281203BEA3A for ; Fri, 4 May 2018 16:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/bAQip6mvIJTZtEquKrLJ7ip+WuSDb6mP2AYQztkbkI=; b=c0QS5RAtl4hGDSlWboPLx9GJv9L2sFG/ipq7lq/GGp8vWyPt2PmP5SsN+ysoOmId9kJlRYdNXGLbLeYk1sgZ6XKi/Zkw0CCVLOxbWRM0zM3ldnuloQv7c/BWrSp90rzBGIohcnLu0hXJFkWwpl1kEkB9UnEiGHcLS9ZW8/uwtMM= Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com (10.172.218.15) by AM4PR0802MB2276.eurprd08.prod.outlook.com (10.172.218.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.735.16; Fri, 4 May 2018 23:30:22 +0000 Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::e117:6f62:6a9b:6be4]) by AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::e117:6f62:6a9b:6be4%8]) with mapi id 15.20.0735.016; Fri, 4 May 2018 23:30:22 +0000 From: Supreeth Venkatesh To: Achin Gupta CC: "edk2-devel@lists.01.org" , "michael.d.kinney@intel.com" , "liming.gao@intel.com" , "jiewen.yao@intel.com" , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" , nd Thread-Topic: [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM modules. Thread-Index: AQHTzbWvVUiWF3iDw0C4jyWFWBIIHqQZ3iaAgASdcRA= Date: Fri, 4 May 2018 23:30:21 +0000 Message-ID: References: <20180406144223.10931-1-supreeth.venkatesh@arm.com> <20180406144223.10931-17-supreeth.venkatesh@arm.com> <20180430195235.GA663@e104320-lin> In-Reply-To: <20180430195235.GA663@e104320-lin> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0802MB2276; 7:eM9yJdCvpnJ9GgJNG89pTVJMAaZoMd2iME3LNjJQVw2S9Mqv6uL7JAXKr3/HKWceUPInp8WTk8XttzV1mLzvWfOiBCWODMpXOftUMktntC702Zna8H3TnMDTnquP4k3vM6SCTJLi8ksULKDg6I+oESZCewK3kwtgETp2zNrCLa+Xxkw1+pmta0UDmArj4tgudacPDVFmFmQJ4jVfdqY9SAe1xjKMDQDT4lWRECxEMkJb5MRjFOt5Hzk9CnSl91nC x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(2017052603328)(7153060)(7193020); SRVR:AM4PR0802MB2276; x-ms-traffictypediagnostic: AM4PR0802MB2276: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(6055026)(6041310)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:AM4PR0802MB2276; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0802MB2276; x-forefront-prvs: 06628F7CA4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(366004)(346002)(376002)(39380400002)(199004)(189003)(13464003)(40434004)(53936002)(81166006)(6636002)(4326008)(7736002)(55016002)(6862004)(9686003)(8936002)(6116002)(15650500001)(2900100001)(3846002)(5250100002)(97736004)(6246003)(68736007)(5890100001)(8676002)(25786009)(229853002)(72206003)(86362001)(3660700001)(478600001)(59450400001)(7696005)(6436002)(3280700002)(106356001)(102836004)(26005)(105586002)(11346002)(6506007)(305945005)(33656002)(76176011)(66066001)(5660300001)(14454004)(81156014)(316002)(99286004)(74316002)(53546011)(476003)(446003)(2906002)(54906003)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0802MB2276; H:AM4PR0802MB2306.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: EHMvBb/n/6k45ZXnMTZbGDjgyyjAo5S2/vc10CuGaHj/+EDNgZZzWGje7icA2fByXW03rhoujs+2v+V3f+kAiBVTMfcQaDbfeRGVqLA1rvHl8Xt4ocvl4tox7614Hw7cXi0YUQ+AEQxRXcKZeD1rRB1jFLN//Qcfz4LYIpuy1K4t5Y1QY4qOEeWGNFJBbGsY spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 652aec4b-afd4-4111-7ed5-08d5b2170172 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 652aec4b-afd4-4111-7ed5-08d5b2170172 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2018 23:30:21.9815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2276 Subject: Re: [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM modules. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 23:30:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable My response inline. -----Original Message----- From: Achin Gupta Sent: Monday, April 30, 2018 2:53 PM To: Supreeth Venkatesh Cc: edk2-devel@lists.01.org; michael.d.kinney@intel.com; liming.gao@intel.c= om; jiewen.yao@intel.com; leif.lindholm@linaro.org; ard.biesheuvel@linaro.o= rg; nd Subject: Re: [PATCH v1 16/18] BaseTools/AutoGen: Update header file for MM = modules. Hi Supreeth, CIL. On Fri, Apr 06, 2018 at 03:42:21PM +0100, Supreeth Venkatesh wrote: > This patch corrects the Module Type Header file for Management > Mode(MM) as specified in PI v1.6 Specification. Also, it updates > parameter for auto generated template functions from > EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta -Achin & +Jiewen if possible! [Supreeth] Ok. Acked-by: Achin Gupta cheers, Achin > Signed-off-by: Supreeth Venkatesh > --- > BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/BaseTools/Source/Python/AutoGen/GenC.py > b/BaseTools/Source/Python/AutoGen/GenC.py > index 4d9ea1b2a8..8601e4ee70 100644 > --- a/BaseTools/Source/Python/AutoGen/GenC.py > +++ b/BaseTools/Source/Python/AutoGen/GenC.py > @@ -270,7 +270,7 @@ EFI_STATUS > EFIAPI > ${Function} ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ); > ${END} > """) > @@ -283,7 +283,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -297,7 +297,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -312,7 +312,7 @@ EFI_STATUS > EFIAPI > ProcessModuleEntryPointList ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > > { > @@ -680,7 +680,7 @@ EFI_STATUS > EFIAPI > ${Function} ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > );${END} > """), > } > @@ -760,7 +760,7 @@ VOID > EFIAPI > ProcessLibrary${Type}List ( > IN EFI_HANDLE ImageHandle, > - IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > ) > { > ${BEGIN} EFI_STATUS Status; > @@ -784,8 +784,8 @@ gModuleTypeHeaderFile =3D { > "UEFI_DRIVER" : ["Uefi.h", "Library/BaseLib.h", "Library/De= bugLib.h", "Library/UefiBootServicesTableLib.h", "Library/UefiDriverEntryPo= int.h"], > "UEFI_APPLICATION" : ["Uefi.h", "Library/BaseLib.h", "Library/De= bugLib.h", "Library/UefiBootServicesTableLib.h", "Library/UefiApplicationEn= tryPoint.h"], > "SMM_CORE" : ["PiDxe.h", "Library/BaseLib.h", "Library/De= bugLib.h", "Library/UefiDriverEntryPoint.h"], > - "MM_STANDALONE" : ["PiSmm.h", "Library/BaseLib.h", "Library/De= bugLib.h", "Library/SmmDriverStandaloneEntryPoint.h"], > - "MM_CORE_STANDALONE" : ["PiSmm.h", "Library/BaseLib.h", "Library/De= bugLib.h", "Library/SmmCoreStandaloneEntryPoint.h"], > + "MM_STANDALONE" : ["PiMm.h", "Library/BaseLib.h", "Library/De= bugLib.h", "Library/MmDriverStandaloneEntryPoint.h"], > + "MM_CORE_STANDALONE": ["PiMm.h", "Library/BaseLib.h", "Library/De= bugLib.h", "Library/MmCoreStandaloneEntryPoint.h"], > "USER_DEFINED" : [gBasicHeaderFile] > } > > -- > 2.16.2 > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.