Re: [PATCH v1 1/1] BaseTools/AutoGen: Update header file for MM modules.

[Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>]

Liming,

Library/SmmCoreStandaloneEntryPoint.h does not exist in MdePkg.
It is supposed to exist in new package StandaloneSmmPkg.

However, with PI specification change, Library/MmCoreStandaloneEntryPoint.h will exist in new StandaloneMmPkg
and discussion about the new package creation is going on other thread.

Thanks,
Supreeth
-----Original Message-----
From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Monday, January 29, 2018 8:40 AM
To: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v1 1/1] BaseTools/AutoGen: Update header file for MM modules.

Supreeth:
  Where is Library/MmCoreStandaloneEntryPoint.h? I don't find it in MdePkg.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Supreeth Venkatesh
> Sent: Wednesday, January 24, 2018 4:02 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH v1 1/1] BaseTools/AutoGen: Update header file for MM modules.
>
> This patch corrects the Module Type Header file for Management
> Mode(MM) as specified in PI v1.6 Specification. Also, it updates
> parameter for auto generated template functions from
> EFI_SMM_SYSTEM_TABLE2 to EFI_MM_SYSTEM_TABLE.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> ---
>  BaseTools/Source/Python/AutoGen/GenC.py | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/GenC.py
> b/BaseTools/Source/Python/AutoGen/GenC.py
> index 3e98506cc8..b74524be0d 100644
> --- a/BaseTools/Source/Python/AutoGen/GenC.py
> +++ b/BaseTools/Source/Python/AutoGen/GenC.py
> @@ -270,7 +270,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    );
>  ${END}
>  """)
> @@ -283,7 +283,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    )
>
>  {
> @@ -297,7 +297,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    )
>
>  {
> @@ -312,7 +312,7 @@ EFI_STATUS
>  EFIAPI
>  ProcessModuleEntryPointList (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2 *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    )
>
>  {
> @@ -680,7 +680,7 @@ EFI_STATUS
>  EFIAPI
>  ${Function} (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    );${END}
>  """),
>  }
> @@ -760,7 +760,7 @@ VOID
>  EFIAPI
>  ProcessLibrary${Type}List (
>    IN EFI_HANDLE            ImageHandle,
> -  IN EFI_SMM_SYSTEM_TABLE2  *MmSystemTable
> +  IN EFI_MM_SYSTEM_TABLE   *MmSystemTable
>    )
>  {
>  ${BEGIN}  EFI_STATUS  Status;
> @@ -784,8 +784,8 @@ gModuleTypeHeaderFile = {
>      "UEFI_DRIVER"       :   ["Uefi.h",  "Library/BaseLib.h", "Library/DebugLib.h", "Library/UefiBootServicesTableLib.h",
> "Library/UefiDriverEntryPoint.h"],
>      "UEFI_APPLICATION"  :   ["Uefi.h",  "Library/BaseLib.h", "Library/DebugLib.h", "Library/UefiBootServicesTableLib.h",
> "Library/UefiApplicationEntryPoint.h"],
>      "SMM_CORE"          :   ["PiDxe.h", "Library/BaseLib.h", "Library/DebugLib.h", "Library/UefiDriverEntryPoint.h"],
> -    "MM_STANDALONE"     :   ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/SmmDriverStandaloneEntryPoint.h"],
> -    "MM_CORE_STANDALONE" :  ["PiSmm.h", "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/SmmCoreStandaloneEntryPoint.h"],
> +    "MM_STANDALONE"     :   ["PiMm.h",  "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/MmDriverStandaloneEntryPoint.h"],
> +    "MM_CORE_STANDALONE":   ["PiMm.h",  "Library/BaseLib.h", "Library/DebugLib.h",
> "Library/MmCoreStandaloneEntryPoint.h"],
>      "USER_DEFINED"      :   [gBasicHeaderFile]
>  }
>
> --
> 2.14.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.