From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.2.54; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0054.outbound.protection.outlook.com [104.47.2.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 467D721E256BE for ; Thu, 25 Jan 2018 13:15:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6B1M75NIG2oWkIjKpc57wTUM34LSxVfmYv6TCuNHEms=; b=oPY+VBDOLpknfPllmytnjH0URF9wGMknmrjqtKSNUHBbepAm8uVec1MPCbYGc6lOep0JLwrpxbOC7bEelYGqbYD3s3ux5ufTIqg99ii71ehFdcsoAtsjeOD1WoRsEG+iJBlB+AWm7vTtOLYdfqB9PDRYdUkPaFwhuFcBR/IxMRU= Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com (10.172.218.15) by AM4PR0802MB2211.eurprd08.prod.outlook.com (10.172.217.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 25 Jan 2018 21:20:56 +0000 Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::61a6:cb94:4307:8d77]) by AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::61a6:cb94:4307:8d77%18]) with mapi id 15.20.0444.016; Thu, 25 Jan 2018 21:20:56 +0000 From: Supreeth Venkatesh To: Marvin H?user , "edk2-devel@lists.01.org" , "tim.lewis@insyde.com" CC: "michael.d.kinney@intel.com" , "liming.gao@intel.com" Thread-Topic: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. Thread-Index: AQHTlIUypswMo5AIJEG7XiWLeo/UbaOCLRgAgAKvZRCAAAUigIAACs8AgAAtYdA= Date: Thu, 25 Jan 2018 21:20:55 +0000 Message-ID: References: <20180123200303.5547-1-supreeth.venkatesh@arm.com> <001601d39605$580f31b0$082d9510$@insyde.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0802MB2211; 6:qhVqKKAP1v+E4FnSJhPZ0EawVALulIWXPjCCxJlKZsyFu9ccr8XQclkLS2W9/K39McaTsDAImWRwYIvFSD7a4di4JZvr2Sw+5LxqGsBOU4w+KouML2QBwX4xbsZAVe3pAO72/NdQGJGVQ8PMncRQS0QTpfuJE/3PRp0YHBM34TtBbY/UxjER77Iqgp1wbXrssgeQV/FV0h68sHGqukmiCT1DTBeiFvFBz4/WKsyRKr2H7m52c3VBH6CuXB2bn4MJLmBwQruEkTqaHdqnStvAxTamu4e+QL6nSfQm8W/8mAPPs5/JR2w1xNOazNC2LlbjV2OZmaRT3PVfnQykNn1zyrNdPOrdLF1CEgEd23CAYuCbiKXJUB0fwjNtrVk8mN1T; 5:IW6nck9Qda8SldFLXJt9DZMadMGjgfC/yGUE641TIPWtlwv0ajMVXJrvwDzp0+B/q9T23C3ZPUrbOP04iVcV5FqUBesPqT9NC22G0EuEfnt4NBefl83tVZo2VybrfIx60WIP6/Rno5PlizJZXCNYSWGJzTTOuehyh+dSLM3xMRc=; 24:f1SCbLtDFiTWzrbugMi+gpfhLjfKT7afV+wf7djR3uiWeQ6uIrAWCNsm6HVa93LLzGRIcwDlI9D6krXi/Xcx00+Pa358foH+tMGW4oRxxH0=; 7:G409EFe6p5pWRQwOeeO/JI8nkeA2wVskhvcdomT8HbE1jqPhMo1355FwK8m8d0oSVTPcSDlfIbnJoJhSNvndlkA+Q11wHnFiBavdeakhDJl51MP6BgAWyFHJq03mjRBot5NbXnQABh6BahjslG7bJnFkYz9Wb49hjPYKPQ/pYOd01kF3KnScqfnZJkIvz/unPBbhuSVrD4lVvBUtHz9LaQs3+YaBAxjjv1Hvw7YzWgGzwzn9CU7TwTvndY4itdAP x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 832de8da-be0b-4cf6-2f3e-08d56439859d x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM4PR0802MB2211; x-ms-traffictypediagnostic: AM4PR0802MB2211: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(189930954265078)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3231061)(2400081)(944501161)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:AM4PR0802MB2211; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0802MB2211; x-forefront-prvs: 0563F2E8B7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(366004)(346002)(396003)(376002)(199004)(40434004)(189003)(13464003)(5660300001)(6506007)(3280700002)(2900100001)(6436002)(102836004)(99286004)(93886005)(53546011)(54906003)(316002)(68736007)(110136005)(3660700001)(7736002)(2906002)(26005)(186003)(7696005)(97736004)(74316002)(59450400001)(3846002)(229853002)(6116002)(305945005)(76176011)(2950100002)(5250100002)(14454004)(39060400002)(55016002)(4326008)(106356001)(72206003)(966005)(2501003)(575784001)(53936002)(5890100001)(86362001)(66066001)(6306002)(9686003)(81156014)(478600001)(25786009)(105586002)(33656002)(45080400002)(8676002)(81166006)(2201001)(6246003)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0802MB2211; H:AM4PR0802MB2306.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: uwZlrkraAuDfvRdXKcYac4IkhBHC04M5n8A1HoxVKwp8fMwsRpVVB3CG5dy/ujhl6PNOXE6Eyy/9sTE4OAMo2Q== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 832de8da-be0b-4cf6-2f3e-08d56439859d X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 21:20:55.9440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2211 Subject: Re: [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 21:15:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Marvin/Tim, Thanks. Apologies, if I didn't mention that this patch was just addition of new val= ues EFI_FV_FILETYPE_MM_STANDALONE EFI_FV_FILETYPE_MM_CORE_STANDALONE and EFI_SECTION_MM_DEPEX No other changes. In existing code, EFI_FV_FILETYPE_SMM and EFI_FV_FILETYPE_MM are same alre= ady. Supreeth -----Original Message----- From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] Sent: Thursday, January 25, 2018 12:32 PM To: edk2-devel@lists.01.org; tim.lewis@insyde.com; Supreeth Venkatesh Cc: michael.d.kinney@intel.com; liming.gao@intel.com Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV f= ile type and depex. Hey Tim and Supreeth, Sorry, 0x0C was a typo, 0x0D is the correct one. The values of the SMM and MM constants are identical, this is just a naming= update plus the introduction of the new value, MM Standalone Core, so back= wards-compatibility is given. Regarding the traditional MM Core, I just assumed it was an oversight as Md= ePkg is generic. If it wasn't, sorry. Thanks, Marvin > -----Original Message----- > From: Tim Lewis [mailto:tim.lewis@insyde.com] > Sent: Thursday, January 25, 2018 6:53 PM > To: 'Supreeth Venkatesh' ; 'Marvin H?user' > ; edk2-devel@lists.01.org > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > FV file type and depex. > > Supreeth -- > > Doesn't Appendix A of the PI 1.6 define this as: > > #define EFI_FV_FILETYPE_SMM EFI_FV_FILETYPE_MM #define > EFI_FV_FILETYPE_SMM_CORE EFI_FV_FILETYPE_MM_CORE > > Thanks, > > Tim > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Thursday, January 25, 2018 9:45 AM > To: Marvin H?user ; edk2- > devel@lists.01.org > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > Subject: Re: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > FV file type and depex. > > Marvin, > > Thanks for your comments. > As per PI v1.6 specification, > EFI_FV_FILETYPE_MM_CORE value is 0x0D (MM Foundation that support MM > Traditional Mode.) > > This is traditional MM mode, which ARM is not supporting at this > point. We are more interested in MM_CORE_STANDALONE mode. > However, I have no issues in adding this in the patch, but would > prefer if this is added when MM traditional mode is supported in ARM. > > Further, > w.r.t defining *_SMM_* definitions via the *_MM_* definitions. I don't > want to break backwards compatibility with existing SMM traditional > mode implementations. > I will be happy to let folks who have migrated to _MM_ definitions > from _SMM_ definitions to send the patch across. > > Thanks, > Supreeth > > -----Original Message----- > From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] > Sent: Tuesday, January 23, 2018 6:34 PM > To: edk2-devel@lists.01.org > Cc: Supreeth Venkatesh ; > michael.d.kinney@intel.com; liming.gao@intel.com > Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > FV file type and depex. > > Good day, > > I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE" > (0x0C). > Furthermore, may I suggest changing the *_SMM_* definitions to be > defined via the *_MM_* definitions? > > Best regards, > Marvin. > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > Of Supreeth Venkatesh > > Sent: Tuesday, January 23, 2018 9:03 PM > > To: edk2-devel@lists.01.org > > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > > Subject: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode > FV > > file type and depex. > > > > As per PI specification v1.6, > > The following new file types are added: > > EFI_FV_FILETYPE_MM_STANDALONE > > EFI_FV_FILETYPE_MM_CORE_STANDALONE > > > > The following new section type is added: > > EFI_SECTION_MM_DEPEX > > > > This patch adds the management mode FV file type and depex. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Achin Gupta > > Signed-off-by: Supreeth Venkatesh > > Reviewed-by: Jiewen Yao > > --- > > MdePkg/Include/Pi/PiFirmwareFile.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h > > b/MdePkg/Include/Pi/PiFirmwareFile.h > > index b982c9eda3..6086d1bb2f 100644 > > --- a/MdePkg/Include/Pi/PiFirmwareFile.h > > +++ b/MdePkg/Include/Pi/PiFirmwareFile.h > > @@ -72,9 +72,12 @@ typedef UINT8 EFI_FFS_FILE_STATE; #define > > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > > #define EFI_FV_FILETYPE_APPLICATION 0x09 > > #define EFI_FV_FILETYPE_SMM 0x0A > > +#define EFI_FV_FILETYPE_MM 0x0A > > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > > +#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C > > #define EFI_FV_FILETYPE_SMM_CORE 0x0D > > +#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 > > @@ -218,6 +221,7 @@ typedef UINT8 EFI_SECTION_TYPE; > > #define EFI_SECTION_RAW 0x19 > > #define EFI_SECTION_PEI_DEPEX 0x1B > > #define EFI_SECTION_SMM_DEPEX 0x1C > > +#define EFI_SECTION_MM_DEPEX 0x1C > > > > /// > > /// Common section header. > > -- > > 2.14.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose > the contents to any other person, use it for any purpose, or store or > copy the information in any medium. Thank you. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.