From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.68; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0068.outbound.protection.outlook.com [104.47.0.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B5C3D21FC7469 for ; Mon, 9 Oct 2017 08:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1Q3kSL+DRHJa7WuPcg83NE/uTkzPXNNvVwA2ogCBUlY=; b=Jcp1kf+HI6hXgmup3RqzlzJQu4jQW3pWLt7Be4nO+fJIrUlqHEQQBZ45CoU4kjQnYlHHTXk1RMheUsEKuRLAD2rSgGuCY4inHSgLa/4zimq3CBqU8bCNFrKPLwFM9lLDHaX+jXgmRfpbnb515BCxmjE46B6KtDixhOpVMHcZClk= Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com (10.172.218.15) by AM4PR08MB2690.eurprd08.prod.outlook.com (10.171.190.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 9 Oct 2017 15:15:27 +0000 Received: from AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::41a1:a70f:607f:3d50]) by AM4PR0802MB2306.eurprd08.prod.outlook.com ([fe80::41a1:a70f:607f:3d50%17]) with mapi id 15.20.0077.020; Mon, 9 Oct 2017 15:15:27 +0000 From: Supreeth Venkatesh To: Achin Gupta , Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Leif Lindholm , nd Thread-Topic: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface. Thread-Index: AQHTN8K52FXQXvC48EyiEWoTjrpkjKLXXjwAgAPp/4CAAGq4kA== Date: Mon, 9 Oct 2017 15:15:27 +0000 Message-ID: References: <20170927185859.27833-1-supreeth.venkatesh@arm.com> <20171009085202.GW26498@e104320-lin> In-Reply-To: <20171009085202.GW26498@e104320-lin> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR08MB2690; 6:jvgwtjUny2g7SGb2IIyKVXvQHzYF7KPZi9QqWxVLjR8LUP/IMkcTFvNsHhpY9iRIVCWkiKm3YRhx+tp3DaPPO/2pnaIX+/EodLPeevXkYQi3P+ODG3y453YwHnftXZ+tul82n3YyY5fopxrWF6nj6R0WtsquBN+7vg+/1o+33unH8xTRz/v8HHH3Wp29tkctsHQetgJjFS7K/1sF30jZFZ24pT4S0r/WnX2Lx3uAeMoTrcLMPUmofQVGeHP5N31S8dKLK07vPUsA3HEaAXHUfAaPhA8br0gjrgLBnyDvvTsdxyb0GfVuq2BmKx9wYGcVEd5ZFsqcXGPoC2c1eq3EoA==; 5:EspwOvjP/L3SKAA/AU+NMnWqlyx9MUbAQuTKLLiGLBLiwUjUATB7RY86pV0CeiHC574NpTJI5MHOvn7cixIBqdpWMd4G3wGHaTaMJk3LlHcSzOzaHZf5b3LIRgVdQ0rhVvx1clMMqobGr6uCPzsqY6fmKMg3uXDdswM6BLQwLbk=; 24:F5V6lBSX5ag/y3IVIQWxdbP/Ct2/4vz/VsC5aiG6EdY42MVC/kHHUGGmR89CvWPT5707taHBhWVYiaEnAsE/sfmONzETOG5WlCYEDAFKCFc=; 7:0bcrfU++w1IlWD0lmqrNQwZFIM2gU7w2pflIo9outYJgbtNgorp69XXWvqbE1UZsMwt4Y7hw1eRMqMRqGCkeGNqF6kLrEsT0/tvCqc4G4gZXcWXYggP0VXrmZQOuQglk7CpRwwGhBjI+pIwm6XvvfXIS1a1WisGKjGVX7kHGPywXgRuIDJdeGXEW0IsisAvkPXLCQCkrRV7j9RzAEsWhcmPbIHbZHXHy+j+j0KeszI0= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: 82a9cf63-626f-43ea-f4bb-08d50f28926a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:AM4PR08MB2690; x-ms-traffictypediagnostic: AM4PR08MB2690: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR08MB2690; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR08MB2690; x-forefront-prvs: 045584D28C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(189002)(24454002)(377454003)(199003)(13464003)(40434004)(50986999)(189998001)(76176999)(316002)(106356001)(105586002)(101416001)(33656002)(966005)(7696004)(53546010)(3660700001)(5890100001)(3280700002)(72206003)(2950100002)(25786009)(5660300001)(2906002)(54356999)(478600001)(6306002)(9686003)(6246003)(53936002)(6506006)(229853002)(6436002)(5250100002)(305945005)(7736002)(74316002)(4326008)(99286003)(55016002)(14454004)(97736004)(86362001)(68736007)(2900100001)(8676002)(8936002)(81166006)(110136005)(6116002)(54906003)(3846002)(102836003)(66066001)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB2690; H:AM4PR0802MB2306.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2017 15:15:27.0978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2690 Subject: Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs for MM interface. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 15:12:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I can do that. However, "-4" is missing in the specification. Is there a chance to rectify= specification to add "-4", so that I can do both the defines. Thanks, Supreeth -----Original Message----- From: Achin Gupta Sent: Monday, October 9, 2017 3:52 AM To: Ard Biesheuvel ; Supreeth Venkatesh Cc: Supreeth Venkatesh ; edk2-devel@lists.01.or= g; Leif Lindholm ; nd Subject: Re: [PATCH v2 1/2] ArmPkg/Include: Add standard SMC function IDs f= or MM interface. Hi Ard/Supreeth, On Fri, Oct 06, 2017 at 10:05:46PM +0100, Ard Biesheuvel wrote: > On 27 September 2017 at 19:58, Supreeth Venkatesh > wrote: > > This patch adds a list of function IDs that fall under the standard > > SMC range as defined in > > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ARM_= MM_Interface_Specification.pdf. > > > > SMCs associated with Management Mode are in the range 0xC4000040 - > > 0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit). > > > > The function(s) available to the normal world: > > 1. Request services from the secure MM environment using MM_COMMUNICATE= . > > > > It also defines MM return codes. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Achin Gupta > > Signed-off-by: Supreeth Venkatesh > > Both patches applied. Thanks. I should have spotted this earlier but the following define is not spec. co= mpliant. It says: > +#define ARM_SMC_MM_RET_NO_MEMORY -4 but should be > +#define ARM_SMC_MM_RET_NO_MEMORY -5 Supreeth. Could you please submit a patch to rectify this? cheers, Achin > > > --- > > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 20 > > +++++++++++++++++++- > > 1 file changed, 19 insertions(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > index 593a3ce729..37d0796649 100644 > > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > > @@ -1,6 +1,6 @@ > > /** @file > > * > > -* Copyright (c) 2012-2014, ARM Limited. All rights reserved. > > +* Copyright (c) 2012-2017, ARM Limited. All rights reserved. > > * > > * This program and the accompanying materials > > * are licensed and made available under the terms and conditions > > of the BSD License @@ -40,6 +40,24 @@ > > #define ARM_SMC_STD_REVISION_MAJOR 0x0 > > #define ARM_SMC_STD_REVISION_MINOR 0x1 > > > > +/* > > + * Management Mode (MM) calls cover a subset of the Standard Service C= all range. > > + * The list below is not exhaustive. > > + */ > > +#define ARM_SMC_ID_MM_VERSION_AARCH32 0x84000040 > > +#define ARM_SMC_ID_MM_VERSION_AARCH64 0xC4000040 > > + > > +// Request service from secure standalone MM environment > > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH32 0x84000041 > > +#define ARM_SMC_ID_MM_COMMUNICATE_AARCH64 0xC4000041 > > + > > +/* MM return error codes */ > > +#define ARM_SMC_MM_RET_SUCCESS 0 > > +#define ARM_SMC_MM_RET_NOT_SUPPORTED -1 > > +#define ARM_SMC_MM_RET_INVALID_PARAMS -2 > > +#define ARM_SMC_MM_RET_DENIED -3 > > +#define ARM_SMC_MM_RET_NO_MEMORY -4 > > + > > /* > > * Power State Coordination Interface (PSCI) calls cover a subset of t= he > > * Standard Service Call range. > > -- > > 2.14.1 > > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.