From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.85; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=girish.pathak@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0085.outbound.protection.outlook.com [104.47.1.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D23A422497F5A for ; Mon, 23 Apr 2018 09:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lKTuN+4jf17107oOnl80MmTO/SWQkohMI6/uDs0NQMA=; b=ZvngOZI4XGbey0DSiaqsfR4YF0ZB82nJF+zjRz6hbzjvUlRzbJpOILDRuuOI5vjbphOAjGEsf9L9cEDvEzUqx5PodVna0uHCvznPbLFWTqLXuoArSLtRUwpk7VOuGZ2/7+PHg1jscrCmWfOdGN5BAT/keQqUmSu8N/Lf2QkPtLE= Received: from AM4PR08MB0995.eurprd08.prod.outlook.com (10.166.134.10) by AM4PR08MB2820.eurprd08.prod.outlook.com (10.171.191.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.13; Mon, 23 Apr 2018 16:49:24 +0000 Received: from AM4PR08MB0995.eurprd08.prod.outlook.com ([fe80::d94d:5186:b1c6:e46b]) by AM4PR08MB0995.eurprd08.prod.outlook.com ([fe80::d94d:5186:b1c6:e46b%3]) with mapi id 15.20.0696.017; Mon, 23 Apr 2018 16:49:24 +0000 From: Girish Pathak To: Leif Lindholm CC: "edk2-devel@lists.01.org" , "ard.biesheuvel@linaro.org" , Matteo Carlini , Stephanie Hughes-Fitt , nd Thread-Topic: [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol Thread-Index: AQHT2vbiuaqgDC0omUaczEnSWEYez6QOZA5QgAAkdwCAAAbaYA== Date: Mon, 23 Apr 2018 16:49:24 +0000 Message-ID: References: <20180320161212.79120-1-girish.pathak@arm.com> <20180320161212.79120-17-girish.pathak@arm.com> <20180423113150.6dgqzp23ersamcrh@bivouac.eciton.net> <20180423162208.qgjfm6znzcsbhjna@bivouac.eciton.net> In-Reply-To: <20180423162208.qgjfm6znzcsbhjna@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR08MB2820; 7:YdMCMBpiEzLpZl0qeL3m0TFOMGDyAVIULG89ADtKKfp+CtF3E8jjZ6KI3rcaTcf3vO7DNUCIt9DtEy3WKOB5mJLvJk2RKjYcmLqKYiWuQ9LR/LuU/+0pFTJpEpMZyi6AZiyMmYX7fP2jggG4QqTGmkqmgWNoCmJxHRrSuIpRTTDgqUDQS6Rg4fW1ix0buJAFQHgFWF20QdUKZ6ziBY1SsTBDAPOni1xEv9lLPGTNys1C4+AAtnyeUwI2FNRMwtcO x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM4PR08MB2820; x-ms-traffictypediagnostic: AM4PR08MB2820: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231232)(944501410)(52105095)(93006095)(93001095)(6055026)(6041310)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:AM4PR08MB2820; BCL:0; PCL:0; RULEID:; SRVR:AM4PR08MB2820; x-forefront-prvs: 06515DA04B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(39860400002)(396003)(376002)(39380400002)(13464003)(74316002)(7696005)(81166006)(575784001)(86362001)(305945005)(6916009)(72206003)(6246003)(2900100001)(8676002)(186003)(55016002)(4326008)(446003)(11346002)(6436002)(9686003)(3280700002)(3660700001)(76176011)(476003)(316002)(5660300001)(54906003)(93886005)(6506007)(6116002)(3846002)(53546011)(102836004)(25786009)(7736002)(53936002)(229853002)(5250100002)(2906002)(33656002)(478600001)(66066001)(26005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB2820; H:AM4PR08MB0995.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: 0SGBnbeFA5ND1xW+HLx3wxPzCKaobwUfII7oNX+U34/d1f11nMp/zuq1MGRSJB3IcSMvot98EQFnA+qkCUZveSnEL0VW5nhIbM1O6XrcOrkwwx4P2WCfm9RGp1A+QfX0P3nX4odxbytUBpPquqsCIE9U/QP4Jy7F7RA+umyQR2T+U0vdMLy8Yn7K5ZPO3K71 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 68a40af3-ba66-4d10-a4b1-08d5a93a2b6e X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68a40af3-ba66-4d10-a4b1-08d5a93a2b6e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2018 16:49:24.3255 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2820 Subject: Re: [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 16:49:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, > -----Original Message----- > From: Leif Lindholm > Sent: 23 April 2018 17:22 > To: Girish Pathak > Cc: edk2-devel@lists.01.org; ard.biesheuvel@linaro.org; Matteo Carlini > ; Stephanie Hughes-Fitt Fitt@arm.com>; nd > Subject: Re: [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol >=20 > On Mon, Apr 23, 2018 at 04:06:43PM +0000, Girish Pathak wrote: > > > From: Leif Lindholm > > > Sent: 23 April 2018 12:32 > > > To: Girish Pathak > > > Cc: edk2-devel@lists.01.org; ard.biesheuvel@linaro.org; Matteo > > > Carlini ; Stephanie Hughes-Fitt > > > ; nd > > > Subject: Re: [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol > > > > > > Hmm, I did find a few minor things below that I need to hear back on > > > before pushing. > > > > Thanks for your comments, We can incorporate all the changes > > suggested, shall I tidy this up and resubmit the patch series ? >=20 > Oh God, please don't. >=20 > If you're happy with all of my comments on previous patches, can you just > say if you're OK with me folding in the below patch into 16/16 before > pushing?: Thanks for this, it's ok to fold it. Regards, Girish >=20 > From 50294f90db0c3e7b5b19bc2022b5c1d866d0b8e1 Mon Sep 17 00:00:00 > 2001 > From: Leif Lindholm > Date: Mon, 23 Apr 2018 12:36:06 +0100 > Subject: [PATCH] fixup scmi >=20 > --- > ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h | 2 +- > ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 4 ++-- > ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c | 8 ++++---- > 3 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h > b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h > index 71245c1647..0d1ec6f5ad 100644 > --- a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h > +++ b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiClockProtocolPrivate.h > @@ -30,7 +30,7 @@ typedef struct { > #define RATE_FORMAT_SHIFT 12 > #define RATE_FORMAT_MASK 0x0001 > #define RATE_FORMAT(RatesFlags) ((RatesFlags >> RATE_FORMAT_SHIFT) > \ > - & RATE_FORMAT_MASK) > + & RATE_FORMAT_MASK) >=20 > // Number of remaining rates after a call to the SCP, RatesFlag Bits[31:= 16] > #define NUM_REMAIN_RATES_SHIFT 16 > diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c > b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c > index fe7edd2a8c..64d2afab72 100644 > --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c > +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c > @@ -83,7 +83,7 @@ ClockGetTotalClocks ( >=20 > Status =3D ScmiGetProtocolAttributes (SCMI_PROTOCOL_ID_CLOCK, > &ReturnValues); > if (EFI_ERROR (Status)) { > - return Status; > + return Status; > } >=20 > *TotalClocks =3D SCMI_CLOCK_PROTOCOL_TOTAL_CLKS (ReturnValues[0]); > @@ -334,7 +334,7 @@ ClockRateGet ( > return Status; > } >=20 > - *Rate =3D ((UINT64)ClockRate->High << 32) | ClockRate->Low; > + *Rate =3D ConvertTo64Bit (ClockRate->Low, ClockRate->High); >=20 > return EFI_SUCCESS; > } > diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c > b/ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c > index ac32442ad8..e012424a9b 100644 > --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c > +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPerformanceProtocol.c > @@ -15,9 +15,9 @@ > DEN0056A_System_Control_and_Management_Interface.pdf > **/ >=20 > +#include > #include > #include > -#include >=20 > #include "ArmScmiPerformanceProtocolPrivate.h" > #include "ScmiPrivate.h" > @@ -72,7 +72,7 @@ PerformanceGetAttributes ( > return Status; > } >=20 > - memcpy ( > + CopyMem ( > Attributes, > ReturnValues, > sizeof (SCMI_PERFORMANCE_PROTOCOL_ATTRIBUTES) > @@ -127,7 +127,7 @@ PerformanceDomainAttributes ( > return Status; > } >=20 > - memcpy ( > + CopyMem ( > DomainAttributes, > ReturnValues, > sizeof (SCMI_PERFORMANCE_DOMAIN_ATTRIBUTES) > @@ -219,7 +219,7 @@ PerformanceDescribeLevels ( > } >=20 > for (LevelNo =3D 0; LevelNo < ReturnNumLevels; LevelNo++) { > - memcpy ( > + CopyMem ( > &LevelArray[LevelIndex++], > &Levels->PerfLevel[LevelNo], > sizeof (SCMI_PERFORMANCE_LEVEL) > -- > 2.11.0