Re: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf

[Girish Pathak <Girish.Pathak@arm.com>]

Hi Leif,

> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: 23 April 2018 18:03
> To: Girish Pathak <Girish.Pathak@arm.com>
> Cc: edk2-devel@lists.01.org; ard.biesheuvel@linaro.org; Matteo Carlini
> <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-
> Fitt@arm.com>; nd <nd@arm.com>; Arvind Chauhan
> <Arvind.Chauhan@arm.com>; Daniil Egranov <Daniil.Egranov@arm.com>;
> Thomas Abraham <thomas.abraham@arm.com>
> Subject: Re: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove
> unused PcdPL111LcdMaxMode from HDLCD inf
> 
> On Thu, Apr 05, 2018 at 07:07:50PM +0100, Girish Pathak wrote:
> > PCD PcdPL111LcdMaxMode is not used in HDLCD platform library.
> > Presence of this PCD in HDLCD is probably due to copy/paste code from
> > PL111 Lcd platform library. This change removes it from the
> > HdLcdArmVExpressLib.inf file.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> 
> Urgh - push failed on the above.
> Can you confirm it should be version 1.1?
Oops.. Sorry my fault. It should be 1.1

Thanks,
Girish
> /
>     Leif
> 
> > Signed-off-by: Girish Pathak <girish.pathak@arm.com>
> > Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
> > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> >
> >
> Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpr
> essL
> > ib.inf | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git
> >
> a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx
> pres
> > sLib.inf
> >
> b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx
> pres
> > sLib.inf index
> >
> bedbaea3a296bea5184564c582659381733d08a9..34db24d4ee6162b0e963d50
> 0a8ed
> > 1097bd8a5ceb 100644
> > ---
> >
> a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx
> pres
> > sLib.inf
> > +++
> b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx
> > +++ pressLib.inf
> > @@ -40,5 +40,4 @@ [Protocols]
> >    gEfiEdidActiveProtocolGuid                    # Produced
> >
> >  [Pcd]
> > -  gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode
> >    gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> >
> >