From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.2.88; helo=eur01-db5-obe.outbound.protection.outlook.com; envelope-from=girish.pathak@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0088.outbound.protection.outlook.com [104.47.2.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 556452283930F for ; Mon, 23 Apr 2018 10:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=B5u+wEa8DXNh1FbbzjgE5S5UhEkn9p2IMbKced5GYMU=; b=CxFvkSCgIGG20Xcot2/50Hp3RbPKpIxc2ud4SeHH1aP7ByI5AeNKaU8s5mNzpLbFfHTFv8YvIX0LN+HjIHkI3u+Tv55RqNm5qNdjmWKS1qRVwVw3v1u1+fdY2YMmZgp0lbX8eYf2hvjP+efPtNwHzMmo4KkJlnGyU5VMairkHSU= Received: from AM4PR08MB0995.eurprd08.prod.outlook.com (10.166.134.10) by AM4PR08MB1233.eurprd08.prod.outlook.com (10.167.92.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.12; Mon, 23 Apr 2018 17:07:02 +0000 Received: from AM4PR08MB0995.eurprd08.prod.outlook.com ([fe80::d94d:5186:b1c6:e46b]) by AM4PR08MB0995.eurprd08.prod.outlook.com ([fe80::d94d:5186:b1c6:e46b%3]) with mapi id 15.20.0696.017; Mon, 23 Apr 2018 17:07:02 +0000 From: Girish Pathak To: Leif Lindholm CC: "edk2-devel@lists.01.org" , "ard.biesheuvel@linaro.org" , Matteo Carlini , Stephanie Hughes-Fitt , nd , Arvind Chauhan , Daniil Egranov , "Thomas Abraham" Thread-Topic: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf Thread-Index: AQHT2yT4S89sBgtqmEqejJjl0QTCuqQOlHeg Date: Mon, 23 Apr 2018 17:07:02 +0000 Message-ID: References: <20180405180803.33684-1-girish.pathak@arm.com> <20180405180803.33684-5-girish.pathak@arm.com> <20180423170310.gox5mgxwu4bsflpk@bivouac.eciton.net> In-Reply-To: <20180423170310.gox5mgxwu4bsflpk@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR08MB1233; 7:cTw4W1SCxAAOqh0lfb0JyJk6R9g/rO4qp7ErsLsOta1KxZLcA3z2ZZU11su1mAoHj9qHGtQFGHh/XPORlOYZzXfuetA77SvL7EqrFCYIeZI7kNmtoojrRJ2wZpuVMc6wp5RwdI23qv7fknD+e8bXL22H9SK1SZlMU/Qej5J/K0OSLE1kQ5mNXKJdvQMAJk1/lgUMgIuEqH4ne6nn6ItVjdosuBLg3nbm6iamkLFqvqjCY3TTXutbh1tq/hZQpxfs x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM4PR08MB1233; x-ms-traffictypediagnostic: AM4PR08MB1233: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231232)(944501410)(52105095)(6055026)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:AM4PR08MB1233; BCL:0; PCL:0; RULEID:; SRVR:AM4PR08MB1233; x-forefront-prvs: 06515DA04B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(39380400002)(366004)(346002)(396003)(13464003)(478600001)(575784001)(6116002)(66066001)(229853002)(3846002)(53936002)(53546011)(2900100001)(6246003)(4326008)(55016002)(9686003)(59450400001)(305945005)(186003)(7736002)(54906003)(6436002)(5660300001)(74316002)(72206003)(316002)(446003)(33656002)(476003)(76176011)(81166006)(102836004)(25786009)(6916009)(26005)(11346002)(5250100002)(6506007)(3660700001)(3280700002)(8676002)(7696005)(8936002)(86362001)(2906002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB1233; H:AM4PR08MB0995.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: FPpmmyRbmbHay1G4WIK57GmJ+kvGMEKboBp31JFNsFNm9YWfxzVRbFe++v7Big+sUkUPWJYMWWySWQQSePgYcp8SwkTusnDdYGw4H9W5tDj8he4DN1cKnnvrd/dPuaJpELVwvkt6V1jop2MQtC/Lap+lFJJ1Ty5vyyAKdjeC1imipQ/DNbhnfkfaQ1UMNlSh spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: beaf53d7-884c-4f40-d562-08d5a93ca1fe X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: beaf53d7-884c-4f40-d562-08d5a93ca1fe X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2018 17:07:02.2663 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB1233 Subject: Re: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 17:07:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, > -----Original Message----- > From: Leif Lindholm > Sent: 23 April 2018 18:03 > To: Girish Pathak > Cc: edk2-devel@lists.01.org; ard.biesheuvel@linaro.org; Matteo Carlini > ; Stephanie Hughes-Fitt Fitt@arm.com>; nd ; Arvind Chauhan > ; Daniil Egranov ; > Thomas Abraham > Subject: Re: [PATCH edk2-platforms v4 04/17] ARM/VExpressPkg: Remove > unused PcdPL111LcdMaxMode from HDLCD inf >=20 > On Thu, Apr 05, 2018 at 07:07:50PM +0100, Girish Pathak wrote: > > PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. > > Presence of this PCD in HDLCD is probably due to copy/paste code from > > PL111 Lcd platform library. This change removes it from the > > HdLcdArmVExpressLib.inf file. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 >=20 > Urgh - push failed on the above. > Can you confirm it should be version 1.1? Oops.. Sorry my fault. It should be 1.1 Thanks, Girish > / > Leif >=20 > > Signed-off-by: Girish Pathak > > Signed-off-by: Evan Lloyd > > Reviewed-by: Ard Biesheuvel > > --- > > > > > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpr > essL > > ib.inf | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git > > > a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > pres > > sLib.inf > > > b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > pres > > sLib.inf index > > > bedbaea3a296bea5184564c582659381733d08a9..34db24d4ee6162b0e963d50 > 0a8ed > > 1097bd8a5ceb 100644 > > --- > > > a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > pres > > sLib.inf > > +++ > b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVEx > > +++ pressLib.inf > > @@ -40,5 +40,4 @@ [Protocols] > > gEfiEdidActiveProtocolGuid # Produced > > > > [Pcd] > > - gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode > > gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > >