Re: edk2-test: SctPkg: Build failure when compiled with latest edk2

Re: edk2-test: SctPkg: Build failure when compiled with latest edk2

[Supreeth Venkatesh]

Thomas,

+ edk2 mailing list

UEFI-SCT is open source.
We welcome all contributions.
Appreciate all your contributions.

We still need to setup CI to catch these kinds of bugs. Thanks for letting us know.

Thanks,
Supreeth

-----Original Message-----
From: Thomas Abraham <thomas.abraham@arm.com>
Sent: Tuesday, January 22, 2019 2:54 AM
To: Jin, Eric <eric.jin@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Subject: RE: edk2-test: SctPkg: Build failure when compiled with latest edk2

Hi Eric,

Thanks for your reply. Will send a fix patch for this compilation issue.

Regards,
Thomas.

> -----Original Message-----
> From: Jin, Eric <eric.jin@intel.com>
> Sent: Tuesday, January 22, 2019 12:57 PM
> To: Thomas Abraham <thomas.abraham@arm.com>; Supreeth Venkatesh
> <Supreeth.Venkatesh@arm.com>
> Cc: Jin, Eric <eric.jin@intel.com>
> Subject: RE: edk2-test: SctPkg: Build failure when compiled with
> latest edk2
>
> Hello Thomas,
>
> Thank you for raising this issue.
> Any patch is appreciated, I think.
>
> Best Regards
> Eric
>
> -----Original Message-----
> From: Thomas Abraham <thomas.abraham@arm.com>
> Sent: Tuesday, January 22, 2019 3:07 PM
> To: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; Jin, Eric
> <eric.jin@intel.com>
> Subject: edk2-test: SctPkg: Build failure when compiled with latest
> edk2
>
> Hi Supreeth, Eric,
>
> The following patch was merged in edk2 which causes build failure for
> UEFI- SCT.
>
> commit 822925013278733ac7f03c35fece2df3e8bc3614
> Author: Feng, Bob C <bob.c.feng@intel.com>
> Date:   Mon Jan 14 09:24:12 2019 +0800
>
>     BaseTools: Remove unused logic for EDKI
>
>     BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350
>     Remove EDK module type support from BaseTools python code.
>
>     Contributed-under: TianoCore Contribution Agreement 1.1
>     Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>     Cc: Liming Gao <liming.gao@intel.com>
>     Cc: Jaben Carsey <jaben.carsey@intel.com>
>     Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
>     Reviewed-by: Liming Gao <liming.gao@intel.com>
>
>
> Due to this patch, the SctPkg compilation fails due to MODULE_TYPE
> missing in most of the .inf file. Is this already known and is there
> any work going on to resolve this issue? If not, would you be okay to
> receive contributions to fix this build issue?
>
> Thanks,
> Thomas.
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose
> the contents to any other person, use it for any purpose, or store or
> copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.