* [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
@ 2018-11-20 6:49 Lokesh B V
2018-11-20 8:09 ` Jin, Eric
2018-11-20 15:03 ` Supreeth Venkatesh
0 siblings, 2 replies; 7+ messages in thread
From: Lokesh B V @ 2018-11-20 6:49 UTC (permalink / raw)
To: edk2-devel, supreeth.venkatesh, eric.jin
EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be
usable with this version of EFI.
Signed-off-by: Lokesh B V <lokesh.bv@arm.com>
---
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
index d24c201..c861437 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
@@ -46,6 +46,8 @@ Abstract:
#define EFI_SCT_NAME L"UEFI2.5 Self Certification Test(SCT2)"
#elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION)
#define EFI_SCT_NAME L"UEFI2.6 Self Certification Test(SCT2)"
+#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION)
+#define EFI_SCT_NAME L"UEFI2.7 Self Certification Test(SCT2)"
#else
#error Unknown EFI_SPECIFICATION_VERSION
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
2018-11-20 6:49 [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7 Lokesh B V
@ 2018-11-20 8:09 ` Jin, Eric
2018-11-20 15:03 ` Supreeth Venkatesh
1 sibling, 0 replies; 7+ messages in thread
From: Jin, Eric @ 2018-11-20 8:09 UTC (permalink / raw)
To: Lokesh B V, edk2-devel@lists.01.org, supreeth.venkatesh@arm.com; +Cc: Jin, Eric
Please don't forget to change the copyright info when commit patch.
Reviewed-by: Eric Jin <eric.jin@intel.com>
-----Original Message-----
From: Lokesh B V <lokesh.bv@arm.com>
Sent: Tuesday, November 20, 2018 2:50 PM
To: edk2-devel@lists.01.org; supreeth.venkatesh@arm.com; Jin, Eric <eric.jin@intel.com>
Cc: Lokesh B V <lokesh.bv@arm.com>
Subject: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be usable with this version of EFI.
Signed-off-by: Lokesh B V <lokesh.bv@arm.com>
---
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
index d24c201..c861437 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
@@ -46,6 +46,8 @@ Abstract:
#define EFI_SCT_NAME L"UEFI2.5 Self Certification Test(SCT2)"
#elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION)
#define EFI_SCT_NAME L"UEFI2.6 Self Certification Test(SCT2)"
+#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION)
+#define EFI_SCT_NAME L"UEFI2.7 Self Certification Test(SCT2)"
#else
#error Unknown EFI_SPECIFICATION_VERSION #endif
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
2018-11-20 6:49 [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7 Lokesh B V
2018-11-20 8:09 ` Jin, Eric
@ 2018-11-20 15:03 ` Supreeth Venkatesh
2018-11-21 5:30 ` Lokesh Belathur Veerappa
1 sibling, 1 reply; 7+ messages in thread
From: Supreeth Venkatesh @ 2018-11-20 15:03 UTC (permalink / raw)
To: Lokesh Belathur Veerappa, edk2-devel@lists.01.org,
eric.jin@intel.com
Thanks Lokesh for the patch.
Has this been compiled and sanity tested against latest edk2?
Let me know SHA of edk2 tested, so that I can test it against that SHA and push it.
If so, Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
-----Original Message-----
From: Lokesh B V <lokesh.bv@arm.com>
Sent: Tuesday, November 20, 2018 12:50 AM
To: edk2-devel@lists.01.org; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; eric.jin@intel.com
Cc: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>
Subject: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be usable with this version of EFI.
Signed-off-by: Lokesh B V <lokesh.bv@arm.com>
---
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
index d24c201..c861437 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
@@ -46,6 +46,8 @@ Abstract:
#define EFI_SCT_NAME L"UEFI2.5 Self Certification Test(SCT2)"
#elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION)
#define EFI_SCT_NAME L"UEFI2.6 Self Certification Test(SCT2)"
+#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION)
+#define EFI_SCT_NAME L"UEFI2.7 Self Certification Test(SCT2)"
#else
#error Unknown EFI_SPECIFICATION_VERSION #endif
--
2.7.4
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
2018-11-20 15:03 ` Supreeth Venkatesh
@ 2018-11-21 5:30 ` Lokesh Belathur Veerappa
2018-11-27 8:07 ` Lokesh Belathur Veerappa
0 siblings, 1 reply; 7+ messages in thread
From: Lokesh Belathur Veerappa @ 2018-11-21 5:30 UTC (permalink / raw)
To: Supreeth Venkatesh, edk2-devel@lists.01.org, eric.jin@intel.com
Hi Supreeth,
Yes it has been compiled and tested against edk2 with SHA da2c81ee96eba5d5c8ef91fd870ac98d3cf72beb.
-----Original Message-----
From: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Sent: Tuesday, November 20, 2018 8:34 PM
To: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>; edk2-devel@lists.01.org; eric.jin@intel.com
Cc: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>
Subject: RE: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
Thanks Lokesh for the patch.
Has this been compiled and sanity tested against latest edk2?
Let me know SHA of edk2 tested, so that I can test it against that SHA and push it.
If so, Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
-----Original Message-----
From: Lokesh B V <lokesh.bv@arm.com>
Sent: Tuesday, November 20, 2018 12:50 AM
To: edk2-devel@lists.01.org; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; eric.jin@intel.com
Cc: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>
Subject: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be usable with this version of EFI.
Signed-off-by: Lokesh B V <lokesh.bv@arm.com>
---
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
index d24c201..c861437 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
@@ -46,6 +46,8 @@ Abstract:
#define EFI_SCT_NAME L"UEFI2.5 Self Certification Test(SCT2)"
#elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION)
#define EFI_SCT_NAME L"UEFI2.6 Self Certification Test(SCT2)"
+#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION)
+#define EFI_SCT_NAME L"UEFI2.7 Self Certification Test(SCT2)"
#else
#error Unknown EFI_SPECIFICATION_VERSION #endif
--
2.7.4
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
2018-11-21 5:30 ` Lokesh Belathur Veerappa
@ 2018-11-27 8:07 ` Lokesh Belathur Veerappa
0 siblings, 0 replies; 7+ messages in thread
From: Lokesh Belathur Veerappa @ 2018-11-27 8:07 UTC (permalink / raw)
To: Supreeth Venkatesh, edk2-devel@lists.01.org, eric.jin@intel.com
Hello Supreeth,
I verified this patch against latest edk2. Please verify from your side and merge it.
Thanks,
Lokesh
-----Original Message-----
From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Lokesh Belathur Veerappa
Sent: Wednesday, November 21, 2018 11:00 AM
To: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; edk2-devel@lists.01.org; eric.jin@intel.com
Subject: Re: [edk2] [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
Hi Supreeth,
Yes it has been compiled and tested against edk2 with SHA da2c81ee96eba5d5c8ef91fd870ac98d3cf72beb.
-----Original Message-----
From: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Sent: Tuesday, November 20, 2018 8:34 PM
To: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>; edk2-devel@lists.01.org; eric.jin@intel.com
Cc: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>
Subject: RE: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
Thanks Lokesh for the patch.
Has this been compiled and sanity tested against latest edk2?
Let me know SHA of edk2 tested, so that I can test it against that SHA and push it.
If so, Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
-----Original Message-----
From: Lokesh B V <lokesh.bv@arm.com>
Sent: Tuesday, November 20, 2018 12:50 AM
To: edk2-devel@lists.01.org; Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>; eric.jin@intel.com
Cc: Lokesh Belathur Veerappa <Lokesh.BV@arm.com>
Subject: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be usable with this version of EFI.
Signed-off-by: Lokesh B V <lokesh.bv@arm.com>
---
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
index d24c201..c861437 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
@@ -46,6 +46,8 @@ Abstract:
#define EFI_SCT_NAME L"UEFI2.5 Self Certification Test(SCT2)"
#elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION)
#define EFI_SCT_NAME L"UEFI2.6 Self Certification Test(SCT2)"
+#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION)
+#define EFI_SCT_NAME L"UEFI2.7 Self Certification Test(SCT2)"
#else
#error Unknown EFI_SPECIFICATION_VERSION #endif
--
2.7.4
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
@ 2018-11-28 9:29 Lokesh B V
2018-11-28 22:30 ` Supreeth Venkatesh
0 siblings, 1 reply; 7+ messages in thread
From: Lokesh B V @ 2018-11-28 9:29 UTC (permalink / raw)
To: edk2-devel
EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be
usable with this version of EFI.
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Lokesh B V <lokesh.bv@arm.com>
---
uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
index d24c201..8fda374 100644
--- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
+++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
@@ -2,6 +2,7 @@
Copyright 2006 - 2017 Unified EFI, Inc.<BR>
Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2018 ARM Ltd. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -46,6 +47,8 @@ Abstract:
#define EFI_SCT_NAME L"UEFI2.5 Self Certification Test(SCT2)"
#elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION)
#define EFI_SCT_NAME L"UEFI2.6 Self Certification Test(SCT2)"
+#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION)
+#define EFI_SCT_NAME L"UEFI2.7 Self Certification Test(SCT2)"
#else
#error Unknown EFI_SPECIFICATION_VERSION
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7
2018-11-28 9:29 Lokesh B V
@ 2018-11-28 22:30 ` Supreeth Venkatesh
0 siblings, 0 replies; 7+ messages in thread
From: Supreeth Venkatesh @ 2018-11-28 22:30 UTC (permalink / raw)
To: Lokesh B V, edk2-devel
Thanks for the patch.
Pushed with the following changes
copyright text by adding a comma as below:
Copyright (c) 2018, ARM Ltd. All rights reserved.<BR>
On Wed, 2018-11-28 at 14:59 +0530, Lokesh B V wrote:
Thanks,
Supreeth
> EDK2 supports EFI version 2.7 and so allow UEFI-SCT to be
> usable with this version of EFI.
>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Lokesh B V <lokesh.bv@arm.com>
> ---
> uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h |
> 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h b/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
> index d24c201..8fda374 100644
> --- a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
> +++ b/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/Include/SctDef.h
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2017 Unified EFI, Inc.<BR>
> Copyright (c) 2010 - 2017, Intel Corporation. All rights
> reserved.<BR>
> + Copyright (c) 2018 ARM Ltd. All rights reserved.<BR>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of
> the BSD License
> @@ -46,6 +47,8 @@ Abstract:
> #define EFI_SCT_NAME L"UEFI2.5 Self
> Certification Test(SCT2)"
> #elif (EFI_SPECIFICATION_VERSION == EFI_2_60_SYSTEM_TABLE_REVISION)
> #define EFI_SCT_NAME L"UEFI2.6 Self
> Certification Test(SCT2)"
> +#elif (EFI_SPECIFICATION_VERSION == EFI_2_70_SYSTEM_TABLE_REVISION)
> +#define EFI_SCT_NAME L"UEFI2.7 Self
> Certification Test(SCT2)"
> #else
> #error Unknown EFI_SPECIFICATION_VERSION
> #endif
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-11-28 22:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-20 6:49 [edk2-test][PATCH] Framework/Include: allow usage with EFI version 2.7 Lokesh B V
2018-11-20 8:09 ` Jin, Eric
2018-11-20 15:03 ` Supreeth Venkatesh
2018-11-21 5:30 ` Lokesh Belathur Veerappa
2018-11-27 8:07 ` Lokesh Belathur Veerappa
-- strict thread matches above, loose matches on Subject: below --
2018-11-28 9:29 Lokesh B V
2018-11-28 22:30 ` Supreeth Venkatesh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox