From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.1.79; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10079.outbound.protection.outlook.com [40.107.1.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0882C211E9596 for ; Fri, 29 Mar 2019 07:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UwXDeiIwfS718wpnt9ySCIMGdZuWmydbuKZnqU5J8s8=; b=nQpz/KDiWneRsL+UYYQu/0UDXAOdJ+3JeoUQGk3zgqyo4ZnPKlbDDK0zSz0E2kr7qY1oh+qyFbENncK7NJXGhEs9kxgAvgNHLLiQNzRX5ryvkin9ysxPxcUwegsIymyK2bo+vAQgJKlKi019WImC7LGAt7Qa1wStKA3Zg4m541M= Received: from AM4PR08MB2788.eurprd08.prod.outlook.com (10.170.126.27) by AM4PR08MB2866.eurprd08.prod.outlook.com (10.171.187.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Fri, 29 Mar 2019 14:12:52 +0000 Received: from AM4PR08MB2788.eurprd08.prod.outlook.com ([fe80::cc1a:f5ec:27c6:4136]) by AM4PR08MB2788.eurprd08.prod.outlook.com ([fe80::cc1a:f5ec:27c6:4136%3]) with mapi id 15.20.1730.019; Fri, 29 Mar 2019 14:12:51 +0000 From: Supreeth Venkatesh To: "Jin, Eric" , "edk2-devel@lists.01.org" Thread-Topic: [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GUIDs in declaration file. Thread-Index: AQHU5bvXH0JUq69Sz0SH4oxTklA52KYiURiAgABWHWA= Date: Fri, 29 Mar 2019 14:12:51 +0000 Message-ID: References: <20190328231222.4717-1-supreeth.venkatesh@arm.com> <20190328231222.4717-30-supreeth.venkatesh@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-originating-ip: [2600:1700:8c61:400:9dee:35fc:d60a:3373] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f136583c-6068-40a7-5aa4-08d6b450a188 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM4PR08MB2866; x-ms-traffictypediagnostic: AM4PR08MB2866: x-microsoft-antispam-prvs: x-forefront-prvs: 0991CAB7B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(346002)(39860400002)(376002)(366004)(40434004)(13464003)(189003)(199004)(229853002)(71200400001)(6246003)(110136005)(486006)(76176011)(2906002)(71190400001)(6506007)(2501003)(53546011)(86362001)(256004)(106356001)(316002)(6436002)(14444005)(19627235002)(5024004)(5660300002)(8936002)(476003)(14454004)(7736002)(186003)(25786009)(446003)(33656002)(74316002)(99286004)(105586002)(6116002)(305945005)(11346002)(52536014)(8676002)(81166006)(46003)(81156014)(9686003)(53936002)(72206003)(68736007)(97736004)(102836004)(7696005)(478600001)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB2866; H:AM4PR08MB2788.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: MxSkNM94enmVeozC+0b4IJY6+uNaxyJYHWMl2bBA230/SMFZBCwiEJKuGrRxsnYnC3eo+WEzuD+akix/jcTulKw8JXOcUK19zu4F9LvqilZKaYyOyz05VpCLFCXyRNmEGLkK7KfW6aQrVCh/zOutbmOtoqrRL4ADfOUpIt6KonbMdfCS9WhvfMsNDpObiL2K92bvr1dYXwcrtcMRFLEF5hvVmDRFiFzITeSWCTXwaXnDs+Ug8w8ROSp6oXKNraIkbtlv3Wo+4yabqMq1G9pBOVbGQjtWO8mxrjdpYf4Oh101uO1dj+FcDXU7RQDhvzKso82g8jRS2XYb0ZZ9PRAk1yX+OHptyUZw0e5gIjztei2uV52Mf5hCsA/OR/apt5CSrXz/YZTN56x23Syywov+61GUmqT6HnWMjSLA7q8VBnI= MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f136583c-6068-40a7-5aa4-08d6b450a188 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2019 14:12:51.9494 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2866 Subject: Re: [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GUIDs in declaration file. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Mar 2019 14:12:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you very much for the comments/feedback. I will check this in after taking care of your feedback. Supreeth -----Original Message----- From: Jin, Eric Sent: Friday, March 29, 2019 4:04 AM To: Supreeth Venkatesh ; edk2-devel@lists.01.or= g Cc: Jin, Eric Subject: RE: [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protoco= l GUIDs in declaration file. Hi Supreeth, Thanks a lot to fix this build issue at first. Comments for this series of patches are replied below. Patch 1/2 : 1. Could the two patches can be re-organized? For example, merge the change= of *.dsc in patch 2 to patch 1 to make it clear. 2. The change of CommonGenFramework.sh in patch 2 will remove the ebc from = binary package. Patch 24 : 1. Please don't forget change the copyright part 2. Do you meet the similar= issue that "UEFI_CONFIG_LANG" : macro redefinition while build? Other Patches : 1. Please remove "COMPONENT_TYPE =3D BS_DRIVER" With that Reviewed-by: Eric Jin Best Regards Eric -----Original Message----- From: Supreeth Venkatesh Sent: Friday, March 29, 2019 7:12 AM To: edk2-devel@lists.01.org Cc: Supreeth Venkatesh ; Jin, Eric Subject: [edk2-test][PATCH v1 30/30] UEFI/UEFI.dec: Add missing protocol GU= IDs in declaration file. Fix compilation issues in inf files when compiled against edk2 stable tag e= dk2-stable201903. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Supreeth Venkatesh --- uefi-sct/SctPkg/UEFI/UEFI.dec | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/UEFI/UEFI.dec b/uefi-sct/SctPkg/UEFI/UEFI.dec = index 8495a4e1..bdf3323f 100644 --- a/uefi-sct/SctPkg/UEFI/UEFI.dec +++ b/uefi-sct/SctPkg/UEFI/UEFI.dec @@ -1,7 +1,7 @@ ## @file # # Copyright 2004 - 2017 Unified EFI, Inc.
-# Copyright (c) 2014 - 20= 18, ARM Limited. All rights reserved. +# Copyright (c) 2014 - 2019, ARM Limited. All rights reserved. # Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
= # (C) Copyright 2017 Hewlett Packard Enterprise Development LP
# @@ = -119,14 +119,22 @@ gBlackBoxEfiHIIStringProtocolGuid =3D {0xfd96974, 0x23aa, 0x4cdc, { 0xb9= , 0xcb, 0x98, 0xd1, 0x77, 0x50, 0x32, 0x2a }} gBlackBoxEfiHIIImageProtocolGuid =3D { 0x31a6406a, 0x6bdf, 0x4e46, {0xb2= , 0xa2, 0xeb, 0xaa, 0x89, 0xc4, 0x9, 0x20 }} gBlackBoxEfiHIIImageExProtocolGuid =3D { 0x1a1241e6, 0x8f19, 0x41a9, { 0= xbc, 0xe, 0xe8, 0xef,0x39, 0xe0, 0x65, 0x46 }} + gBlackBoxEfiHIIDatabaseProtocolGuid =3D { 0xef9fc172, 0xa1b2, 0x4693, { + 0xb3, 0x27, 0x6d, 0x32, 0xfc, 0x41, 0x60, 0x42 }} + gBlackBoxEfiHIIPackageListProtocolGuid =3D { 0x6a1ee763, 0xd47a, 0x43b4, + { 0xaa, 0xbe, 0xef, 0x1d, 0xe2, 0xab, 0x56, 0xfc }} + gBlackBoxEfiHIIStringProtocolGuid =3D {0xfd96974, 0x23aa, 0x4cdc, { + 0xb9, 0xcb, 0x98, 0xd1, 0x77, 0x50, 0x32, 0x2a }} + gBlackBoxEfiHIIConfigAccessProtocolGuid =3D { 0x330d4706, 0xf2a0, + 0x4e4f, { 0xa3, 0x69, 0xb6, 0x6f, 0xa8, 0xd5, 0x43, 0x85 }} + gBlackBoxEfiHIIConfigRoutingProtocolGuid =3D { 0x587e72d7, 0xcc50, + 0x4f79, { 0x82, 0x09, 0xca, 0x29, 0x1f, 0xc1, 0xa1, 0x0f }} gBlackBoxEfiHIIFontProtocolGuid =3D { 0xe9ca4775, 0x8657, 0x47fc, { 0x97= , 0xe7, 0x7e, 0xd6, 0x5a, 0x8, 0x43, 0x24 }} gBlackBoxEfiHIIFontExProtocolGuid =3D { 0x849e6875, 0xdb35, 0x4df8, { 0x= b4, 0x1e, 0xc8, 0xf3, 0x37, 0x18, 0x7, 0x3f }} gBlackBoxEfiHttpProtocolGuid =3D { 0x7A59B29B, 0x910B, 0x4171, { 0x82, 0= x42, 0xA8, 0x5A, 0x0D, 0xF2, 0x5B, 0x5B }} gBlackBoxEfiHttpServiceBindingProtocolGuid =3D { 0xbdc8e6af, 0xd9bc, 0x4= 379, { 0xa7, 0x2a, 0xe0, 0xc4, 0xe7, 0x5d, 0xae, 0x1c }} gBlackBoxEfiIp4ServiceBindingProtocolGuid =3D { 0xc51711e7, 0xb4bf, 0x40= 4a, {0xbf, 0xb8, 0x0a, 0x04, 0x8e, 0xf1, 0xff, 0xe4 } } gBlackBoxEfiIp4ProtocolGuid =3D { 0x41d94cd2, 0x35b6, 0x455a, {0x82, 0x5= 8, 0xd4, 0xe5, 0x13, 0x34, 0xaa, 0xdd } } + gBlackBoxEfiIp4ConfigProtocolGuid =3D { 0x3B95AA31, 0x3793, 0x434B, + {0x86, 0x67, 0xC8, 0x07, 0x08, 0x92, 0xE0, 0x5E } } + gBlackBoxEfiIp4Config2ProtocolGuid =3D { 0x5b446ed1, 0xe30b, 0x4faa, + {0x87, 0x1a, 0x36, 0x54, 0xec, 0xa3, 0x60, 0x80 } } gBlackBoxEfiIp6ServiceBindingProtocolGuid =3D { 0xec835dd3, 0xfe0f, 0x61= 7b, {0xa6, 0x21, 0xb3, 0x50, 0xc3, 0xe1, 0x33, 0x88 } } gBlackBoxEfiIp6ProtocolGuid =3D { 0xec835dd3, 0xfe0f, 0x617b, {0xa6, 0x2= 1, 0xb3, 0x50, 0xc3, 0xe1, 0x33, 0x88 } } + gBlackBoxEfiIp6ConfigProtocolGuid =3D { 0x937fe521, 0x95ae, 0x4d1a, + {0x89, 0x29, 0x48, 0xbc, 0xd9, 0x0a, 0xd3, 0x1a } } gBlackBoxEfiIPsec2ProtocolGuid =3D {0xa3979e64, 0xace8, 0x4ddc, { 0xbc, = 0x7, 0x4d, 0x66, 0xb8, 0xfd, 0x9, 0x77 }} gBlackBoxEfiIPsecConfigProtocolGuid =3D { 0xce5e5929, 0xc7a3, 0x4602, { = 0xad, 0x9e, 0xc9, 0xda, 0xf9, 0x4e, 0xbf, 0xcf }} gBlackBoxEfiIScsiInitiatorNameProtocolGuid =3D { 0x59324945, 0xec44, 0x4= c0d, {0xb1, 0xcd, 0x9d, 0xb1, 0x39, 0xdf, 0x7, 0xc }} -- 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.