Assuming Laszlo's comment is addressed.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Wednesday, April 17, 2019 6:12 PM
> To: Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>
> Subject: RE: [patch] ShellBinPkg: Remove ShellBinPkg
> Importance: High
>
> Thank you all.
> I will update the patch according to Laszlo's comments before commit the
> patch.
>
>
> Thanks,
> Dandan
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Wednesday, April 17, 2019 6:53 PM
> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Bi, Dandan
> > <dandan.bi@intel.com>
> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Carsey, Jaben
> > <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm
> > <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>
> > Subject: Re: [patch] ShellBinPkg: Remove ShellBinPkg
> >
> > On 04/17/19 09:16, Ard Biesheuvel wrote:
> > > On Tue, 16 Apr 2019 at 23:40, Dandan Bi <dandan.bi@intel.com> wrote:
> > >>
> > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
> > >>
> > >> Remove ShellBinPkg from edk2.
> > >> If developers work on current edk2 master and still want to use
> > >> Shell binary after this removal, they can get it from source code
> > >> in the Assets part of edk2-stable201903 tag release page.
> > >> And from next release (edk2-stable201905 tag), we will publish all
> > >> Shell binaries to the according Assets part directly.
> > >> edk2 release link: https://github.com/tianocore/edk2/releases
> > >>
> > >> Cc: Jaben Carsey <jaben.carsey@intel.com>
> > >> Cc: Ray Ni <ray.ni@intel.com>
> > >> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >> Cc: Liming Gao <liming.gao@intel.com>
> > >> Cc: Laszlo Ersek <lersek@redhat.com>
> > >> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> > >
> > > Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >
> > > BTW you can use the --no-binary option to git to omit the binary
> > > diffs in the patch. Especially when deleting binaries, that saves a
> > > lot of hassle dealing with a multimegabyte patch email.
> >
> > +1
> >
> > For the patch, I have a request towards Dandan: regarding the line
> >
> > +Maintainers for stable Shell binaries generation when need to publish
> > +Shell
> > binaries with edk2 release:
> >
> > please:
> >
> > (1) wrap it with an 80-char margin,
> > (2) please insert a blank line just above it.
> >
> > With those:
> >
> > Acked-by: Laszlo Ersek <lersek@redhat.com>
> >
> > Thanks
> > Laszlo