From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (EUR03-AM5-obe.outbound.protection.outlook.com [40.107.3.80]) by mx.groups.io with SMTP id smtpd.web10.3926.1590578477510182678 for ; Wed, 27 May 2020 04:21:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nxp.com header.s=selector2 header.b=IftU28dL; spf=pass (domain: nxp.com, ip: 40.107.3.80, mailfrom: gaurav.jain@nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KJkYkQHlzgqprXwoxfp56y2y6LAhCmuRbA9StIVrHJI2zBxPS8CwN9vCdsfYvtstaXkdYxEJ3eUD4ca6/1heq0nfEoeMsBRikfdc6tvUpVcmaxLJMueTV/c/Fn/s+2AdfTYW6zNUJjSPPUc4RPC/LayLny+lM+xpv1dxjSXhOH+BvkuBVTKDLO+AKw+r3HXWaX3b/rx/fIFOdansmeMdew9RgGCACnN/kuQxXpa3abhCbNFoveTs+1pR3O8IljgvcqWDT9yL3Y256hsaopcXOsmZFsE6NZA3Vecvz9k2c7PTYcxCH5DlMYUg9rk9OexiGJRe1MwhxD7SjVfW9US0Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WbQ0h7STVIh7qhnkRZ1DNSSNfxDafmW/sgUcxDjVRwI=; b=TpMEYhlgvejAQGMEPCSrG4Y4NDtzzFJd2JbkxqZKLsnkOjsZ8nmeVOsYgODaNKA6xepjcqbniW1sJi7fC8gu+nB306vtocBq7TQDP8IUjZs7hXZ+emv66fap0UIHJ52/pX1EJZ3F+EgDaSgi6oBkMQUI29x3eVSUre8JA7Rclk+Vqypp5FPuFtFyMuZeMMOxJ29mZftjYtxRHyDja/BynwiZBFjyfHLrkHfeXmYBEudleH2nR1hqWxz8+dENJcWUTOhJOHEGMZugu7sDf/SHnad/pa0CnuvKjohm6n3IVJhPkSE4uX7zm4fIBAxJ8Cjgc70JZg3K9qsSpO64EgIo9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WbQ0h7STVIh7qhnkRZ1DNSSNfxDafmW/sgUcxDjVRwI=; b=IftU28dLVT+EPVq+tzyLTA5Z6fY97ALf/thmuYchFOHzZBXlHM3w/Zo5h31yOHBBZp35r9LyiDYw021WfoEQJe5MSIYFb7weHvktFdMhnnkw0bVCZN8MSZupwO2Nxrfl1DJXLesIa1s4eFhLDk66k3oJzkHs7JkFf6BuCYeRKlA= Received: from AM5PR04MB3074.eurprd04.prod.outlook.com (2603:10a6:206:4::16) by AM5PR04MB2946.eurprd04.prod.outlook.com (2603:10a6:206:b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.27; Wed, 27 May 2020 11:21:13 +0000 Received: from AM5PR04MB3074.eurprd04.prod.outlook.com ([fe80::a5ed:ce0d:fc98:73a4]) by AM5PR04MB3074.eurprd04.prod.outlook.com ([fe80::a5ed:ce0d:fc98:73a4%7]) with mapi id 15.20.3045.018; Wed, 27 May 2020 11:21:13 +0000 From: "Gaurav Jain" To: "Loh, Tien Hock" , Leif Lindholm CC: Pankaj Bansal , Ard Biesheuvel , Meenakshi Aggarwal , "devel@edk2.groups.io" , Haojian Zhuang , Varun Sethi Subject: Re: [EXT] RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W. Thread-Topic: [EXT] RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W. Thread-Index: AQHWHFvMcArz7CKfOUeegfEvifwfyqiPki8AgABkTgCAAOrTAIArFuYQ Date: Wed, 27 May 2020 11:21:13 +0000 Message-ID: References: <1585905847-16380-1-git-send-email-gaurav.jain@nxp.com> <20200406140819.GI14075@vanye> <3d55018b-8751-bbe1-b1ac-98ac36e16e1c@arm.com> <20200429111618.GF21486@vanye> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [45.120.126.226] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 06e10506-5244-4f8b-a3c3-08d8023010d9 x-ms-traffictypediagnostic: AM5PR04MB2946: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 04163EF38A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aAfI53UatIFBV9KsOVBP2kXzu4lOXMoc6U3X5kpRNITa1L+lFfrzDR1MUqBl8VlEvGyC4W9F4bchb1PEHvWdkNMoWsuY1qXRCLNXz10bPAGOIJEii/qAk6Eky30SqUD0OWNgqYBKwtNBMCsAg4B7Hl7Yirmvj/ETTwQLSCi0+/nIngZBJXCrW39YjmPlldAd71LTimtAYCB/tPIgKtfyrgtdnILpj8V+TEAw+PXTphqic1P0MojVXL994f0sQf6boSOuhNlB29o9EygDwJ5jnE2u6hIOEoi0+T5wKJxSGzlL26Hw9KP75aTRhEetYl8njbxKwOl2FiTHSEnXRnyJEQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR04MB3074.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(44832011)(53546011)(66556008)(6506007)(9686003)(66446008)(64756008)(76116006)(66476007)(66946007)(26005)(4326008)(478600001)(7696005)(110136005)(186003)(54906003)(52536014)(316002)(86362001)(8936002)(2906002)(55016002)(71200400001)(33656002)(8676002)(5660300002)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 7fNxgviaFsP4y0HfreTxBpsx2rNFNqKiIORBWOCxAUl8QhOFtwLjH9KvQBnFzoeNCs5miN6xEsIMa2tjkKMrPWBjZVWtXbZqvDkMxdz5eTlYikYddsrt7uwbERT5uzOh7ftiI6Jv0kotXVmpiuYxNZzLVAQnVP51eC7+0xFr9fwyWVBK//pbc8LpoHRwqAQS8W4kMBlGbnbP5m+LG/YefEGM2YQd5f3yhxiVANMk56ISLD/zklPZuTPvj63TO8R352OayWEZ2+PRn+nuGRfX/n+knNT53GVmenHGc5DKWU9F6zrbTsTuRIxdwDVABoWp6t52utzZUk0xAHXq9Nn68u2+Pf7/QWZ7YmsySTWLAXgB+4v07IwkYEMHx6CJT+K2D4zom14z2J+XhJNTEBXQY50s+OU71NM/IAV3rDqJV9h6Qt18sRGY87k6D8PvvqTt+r5wcNs1CIXfKLxRiqmlXyLkQ7g04ZtlKhTotqsTTCzPuY2nswARyGm72F9taRJG MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06e10506-5244-4f8b-a3c3-08d8023010d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2020 11:21:13.6320 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mE5hCnnQnsbTz7kWz7azjVtOZWUWdtthstf3FQ5q+ZaxKSmbkjnknuO5YOX58JJtG4Oy9V9hp0L7lK2D9bQAKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB2946 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif Tein Hock has reviewed this patch. Please help to merge in edk2. Regards Gaurav Jain > -----Original Message----- > From: Loh, Tien Hock > Sent: Thursday, April 30, 2020 6:47 AM > To: Leif Lindholm > Cc: Pankaj Bansal ; Ard Biesheuvel > ; Gaurav Jain ; > Meenakshi Aggarwal ; > devel@edk2.groups.io; Haojian Zhuang ; Varun > Sethi > Subject: [EXT] RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > Transfer Limit 65535 in R/W. >=20 > Caution: EXT Email >=20 > Hi Leif, >=20 > Yes, that's a Reviewed-by. >=20 > Thanks. >=20 > > -----Original Message----- > > From: Leif Lindholm > > Sent: Wednesday, April 29, 2020 7:16 PM > > To: Loh, Tien Hock > > Cc: Pankaj Bansal ; Ard Biesheuvel > > ; Gaurav Jain ; > Meenakshi > > Aggarwal ; devel@edk2.groups.io; > Haojian > > Zhuang ; Varun Sethi > > Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > Transfer > > Limit 65535 in R/W. > > > > Hi Tien Hock, > > > > Can I take that as a Reviewed-by:? > > > > Regards, > > > > Leif > > > > On Wed, Apr 29, 2020 at 05:17:18 +0000, Loh, Tien Hock wrote: > > > Hi Ard, > > > > > > I have checked the patch and it looks good. > > > > > > However, I can no longer test the patch as the new DwMmc driver no > > > longer > > uses the protocol. > > > Sorry for the delay, I initially thought I can test it until I > > > investigated further > > today. > > > > > > Thanks > > > > > > > > > > -----Original Message----- > > > > From: Pankaj Bansal > > > > Sent: Monday, April 27, 2020 2:19 PM > > > > To: Ard Biesheuvel ; Leif Lindholm > > > > ; Gaurav Jain ; Meenakshi > > > > Aggarwal > > > > Cc: devel@edk2.groups.io; Haojian Zhuang > > > > ; Loh, Tien Hock > > > > ; Varun Sethi > > > > Subject: RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > > Transfer > > > > Limit 65535 in R/W. > > > > > > > > + Meenakshi > > > > > > > > > -----Original Message----- > > > > > From: Ard Biesheuvel > > > > > Sent: Monday, April 6, 2020 7:42 PM > > > > > To: Leif Lindholm ; Gaurav Jain > > > > > > > > > > Cc: devel@edk2.groups.io; Pankaj Bansal ; > > > > > Haojian Zhuang ; Loh, Tien Hock > > > > > > > > > > Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock > > > > > Transfer Limit 65535 in R/W. > > > > > > > > > > On 4/6/20 4:08 PM, Leif Lindholm wrote: > > > > > > Hi Gaurav, > > > > > > > > > > > > Haojian, Tien Hock - can you help review/test this change? > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > Leif > > > > > > > > > > > > On Fri, Apr 03, 2020 at 14:54:07 +0530, Gaurav Jain wrote: > > > > > >> Moved BlockCount calculation below BufferSize Validation check= s. > > > > > >> First Ensure Buffersize is Not Zero and multiple of Media Bloc= kSize. > > > > > >> then calculate BlockCount and perform Block checks. > > > > > >> > > > > > >> Corrected BlockCount calculation, as BufferSize is multiple > > > > > >> of BlockSize, So adding (BlockSize-1) bytes to BufferSize and > > > > > >> then divide by BlockSize will have no impact on BlockCount. > > > > > >> > > > > > >> Reading Large Images from MMC causes errors. > > > > > >> As per SD Host Controller Spec version 4.20, Restriction of > > > > > >> 16-bit Block Count transfer is 65535. > > > > > >> Max block transfer limit in single cmd is 65535 blocks. > > > > > >> Added Max Block check that can be processed is 0xFFFF. > > > > > >> then Update BlockCount on the basis of MaxBlock. > > > > > >> > > > > > >> Signed-off-by: Gaurav Jain > > > > > > > > > > > > > > > Hello Gaurav, > > > > > > > > > > Could you please elaborate on the underlying need for this change= ? > > > > > If you are considering using this driver for future NXP > > > > > platforms, I should point out that this legacy driver is only > > > > > kept around for existing users, and new users should use the > > > > > driver stack in MdeModulePkg, which is based on the UEFI spec. > > > > > > > > > > -- > > > > > Ard. > > > > > > > > > > > > > > > > > >