Re: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds

["Marvin Häuser" <Marvin.Haeuser@outlook.com>]

Please do not push this commit, I just bumped into a compilation error which I did not see before.
I'll post a V2 once I figured out what happened.

Thanks,
Marvin.

> -----Original Message-----
> From: Gao, Liming [mailto:liming.gao@intel.com]
> Sent: Monday, March 6, 2017 3:27 AM
> To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org
> Cc: Zhu, Yonghong <yonghong.zhu@intel.com>
> Subject: RE: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable
> on RELEASE builds
> 
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> >-----Original Message-----
> >From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com]
> >Sent: Sunday, March 05, 2017 11:00 AM
> >To: edk2-devel@lists.01.org
> >Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong
> ><yonghong.zhu@intel.com>
> >Subject: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on
> >RELEASE builds
> >
> >Set -Wno-unused-but-set-variable on RELEASE builds so variables only
> >verified in DEBUG code (e.g. ASSERT()) do not trigger build errors.
> >This is done to align with GCC compilation:
> >https://github.com/tianocore/edk2/commit/20d00edf21d2f2144921622891
> d8
> >b59a1553cd83
> >
> >Contributed-under: TianoCore Contribution Agreement 1.0
> >Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> >---
> > BaseTools/Conf/tools_def.template | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> >diff --git a/BaseTools/Conf/tools_def.template
> >b/BaseTools/Conf/tools_def.template
> >index ab4f936e7a8b..b9a063215354 100755
> >--- a/BaseTools/Conf/tools_def.template
> >+++ b/BaseTools/Conf/tools_def.template
> >@@ -5467,7 +5467,7 @@ DEFINE CLANG35_AARCH64_CC_FLAGS  =
> >DEF(GCC_AARCH64_CC_FLAGS) DEF(CLANG35_AARCH64
> > *_CLANG35_ARM_CC_XIPFLAGS        = DEF(GCC_ARM_CC_XIPFLAGS)
> >
> >   DEBUG_CLANG35_ARM_CC_FLAGS     = DEF(CLANG35_ARM_CC_FLAGS)
> >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0
> >-RELEASE_CLANG35_ARM_CC_FLAGS     = DEF(CLANG35_ARM_CC_FLAGS)
> >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz
> >+RELEASE_CLANG35_ARM_CC_FLAGS     = DEF(CLANG35_ARM_CC_FLAGS)
> >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz -Wno-unused-but-set-
> variable
> >
> > ##################
> > # CLANG35 AARCH64 definitions
> >@@ -5489,7 +5489,7 @@ RELEASE_CLANG35_ARM_CC_FLAGS     =
> >DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(P
> > *_CLANG35_AARCH64_CC_XIPFLAGS    =
> DEF(GCC_AARCH64_CC_XIPFLAGS)
> >
> >   DEBUG_CLANG35_AARCH64_CC_FLAGS =
> >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS)
> $(PLATFORM_FLAGS)
> >-O0
> >-RELEASE_CLANG35_AARCH64_CC_FLAGS =
> >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS)
> $(PLATFORM_FLAGS) -Oz
> >-fomit-frame-pointer
> >+RELEASE_CLANG35_AARCH64_CC_FLAGS =
> >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS)
> $(PLATFORM_FLAGS) -Oz
> >-fomit-frame-pointer -Wno-unused-but-set-variable
> >
> >
> >#########################################################
> ##
> >#########################
> > #
> >@@ -5543,7 +5543,7 @@ DEBUG_CLANG38_IA32_CC_FLAGS         =
> >DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -
> > DEBUG_CLANG38_IA32_DLINK_FLAGS      =
> >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 -Wl,--
> >oformat=elf32-i386
> > DEBUG_CLANG38_IA32_DLINK2_FLAGS     =
> DEF(GCC5_IA32_DLINK2_FLAGS)
> >-O3
> >
> >-RELEASE_CLANG38_IA32_CC_FLAGS       = DEF(CLANG38_ALL_CC_FLAGS) -
> >m32 -Oz -flto -march=i586 DEF(CLANG38_IA32_TARGET)
> >+RELEASE_CLANG38_IA32_CC_FLAGS       = DEF(CLANG38_ALL_CC_FLAGS) -
> >m32 -Oz -flto -march=i586 DEF(CLANG38_IA32_TARGET) -Wno-unused-but-
> >set-variable
> > RELEASE_CLANG38_IA32_DLINK_FLAGS    =
> >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 -Wl,--
> >oformat=elf32-i386
> > RELEASE_CLANG38_IA32_DLINK2_FLAGS   =
> DEF(GCC5_IA32_DLINK2_FLAGS)
> >-O3
> >
> >@@ -5580,7 +5580,7 @@ DEBUG_CLANG38_X64_CC_FLAGS         =
> >DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
> > DEBUG_CLANG38_X64_DLINK_FLAGS      =
> >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_x86_64 -Wl,--
> >oformat=elf64-x86-64 -Wl,-pie -mcmodel=small
> > DEBUG_CLANG38_X64_DLINK2_FLAGS     = DEF(GCC5_X64_DLINK2_FLAGS)
> -
> >O3
> >
> >-RELEASE_CLANG38_X64_CC_FLAGS       = DEF(CLANG38_ALL_CC_FLAGS) -
> >m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -
> >fpie -Oz -flto DEF(CLANG38_X64_TARGET)
> >+RELEASE_CLANG38_X64_CC_FLAGS       = DEF(CLANG38_ALL_CC_FLAGS) -
> >m64 "-DEFIAPI=__attribute__((ms_abi))" -mno-red-zone -mcmodel=small -
> >fpie -Oz -flto DEF(CLANG38_X64_TARGET) -Wno-unused-but-set-variable
> > RELEASE_CLANG38_X64_DLINK_FLAGS    =
> >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_x86_64 -Wl,--
> >oformat=elf64-x86-64 -Wl,-pie -mcmodel=small
> > RELEASE_CLANG38_X64_DLINK2_FLAGS   =
> DEF(GCC5_X64_DLINK2_FLAGS) -
> >O3
> >
> >--
> >2.11.1.windows.1