From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from BAY004-OMC4S17.hotmail.com (bay004-omc4s17.hotmail.com [65.54.190.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1408480345 for ; Mon, 6 Mar 2017 17:55:51 -0800 (PST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com ([65.54.190.199]) by BAY004-OMC4S17.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Mon, 6 Mar 2017 17:55:50 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Pfh0gIgTyqnaltYTJLkDb7hndp7vTBPrbliblh1khc0=; b=OxfdyAzCN4leVhS9u2nUqwzSJ9wcNmFKKtrAX+sGaOeh6HxciBfG1Mjqt9ltaRC06gPB/yJzgkz8Det8Ul/IEUkuUBBV9b4llStjhVXN7F50XLR5YaBYt8vyGW9jXUZfTnSDvVCVy1yFE8Tr7HXad4PE+GhNLcMTfBGt99ruSHq/99tlSCM6k4aqEIGgiFrhfT+67wVEkLLaeUHwgvAj3hUORWNhI4JRCZWk6ocj8arz4dTjBAqJQMI27LxGrCqAsV9OyLmQmxsPz7ay8xvPmIXr3GB030mzirY6UeV7Pt1rtA2U2VKZEE4i1Y9hLGtXyTpGHjTJXPmRTK13NJkkCQ== Received: from VE1EUR01FT040.eop-EUR01.prod.protection.outlook.com (10.152.2.58) by VE1EUR01HT119.eop-EUR01.prod.protection.outlook.com (10.152.3.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.11; Tue, 7 Mar 2017 01:55:49 +0000 Received: from AM5PR0601MB2579.eurprd06.prod.outlook.com (10.152.2.58) by VE1EUR01FT040.mail.protection.outlook.com (10.152.3.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.11 via Frontend Transport; Tue, 7 Mar 2017 01:55:49 +0000 Received: from AM5PR0601MB2579.eurprd06.prod.outlook.com ([10.168.154.13]) by AM5PR0601MB2579.eurprd06.prod.outlook.com ([10.168.154.13]) with mapi id 15.01.0947.020; Tue, 7 Mar 2017 01:55:49 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds Thread-Index: AQHSlVyVt77oHRQkW0u6YHIqXbpoqKGHF5pggAGI2oA= Date: Tue, 7 Mar 2017 01:55:49 +0000 Message-ID: References: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E8472@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E8472@shsmsx102.ccr.corp.intel.com> Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:428280A506B53959282E846B825C586E9E326F512F3A0256F77F873E61BA8A85; UpperCasedChecksum:24C20CDBA2BE2941FC27674CC683EF28ECA818C6423CE8A3FD5EA39B6FAC1F49; SizeAsReceived:8124; Count:39 x-tmn: [iOcioUYAAvYn89Ctwd6QEtpQztrYS2Pts3BPQ9Wl3jsfW63SVj+7d4h1z2peAoRw] x-incomingheadercount: 39 x-eopattributedmessage: 0 x-microsoft-exchange-diagnostics: 1; VE1EUR01HT119; 5:TL7gC6OGPW2j5Vi4++QgxFzkj2TEis1oWmiipuOX9JIAQaTIm+nUdkd8jF6H9e6LLjxq3rDODia+dmcCco+oTlpBnUmROp3V/lk9Rz5x25JTBK5sWmKIdJgDAtOEfCxU3W9PQZyzM+Ptpj2kOVD5Cw==; 24:z0MzuSWjrivbYmlOeXuW0iKhMwchNzgbYL2VgGQSFk5UJ1sLiCM8zhDD67i15s8200JhxvpeQoZSf6oK6gpkXwRmkDMG5WlNFVRjpYksi3g=; 7:WDJXezH7v7fW3sZK+r4W51VksCkSivqI7NohgQrxu0j6HUXWH7DdBH6BfRBNYH6wH5dfln0Oedpff+VkI7knYPsiTcjBdu2z8Q8UwMJ3a9IVIB95GsE6gb/KcsOWsZqMqXJ9VM7eC5qvfL2nCqRwiI9dj8hLe26ehOKFueasiSodh2zUwALf80o4Nc/KbZLTXu5QoFpcpy6dLNAEFj22O0VXBCMnbHoRqQl8y0+5dxDvPSFweCXDQ3Z2iwCEpiVZEPMbZTYr0GvBATpMZX+KcLo7Rku+JTPTq2GMe3simOTlp5mGpLqIpFf5vS86nxaE x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(10019020)(98900016); DIR:OUT; SFP:1102; SCL:1; SRVR:VE1EUR01HT119; H:AM5PR0601MB2579.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: 22a9430a-45d7-44ae-6ce4-08d464fd1413 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201702061074)(5061506573)(5061507331)(1603103135)(1601125254)(1603101448)(1701031045); SRVR:VE1EUR01HT119; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015087)(444000031); SRVR:VE1EUR01HT119; BCL:0; PCL:0; RULEID:; SRVR:VE1EUR01HT119; x-forefront-prvs: 0239D46DB6 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2017 01:55:49.1963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT119 X-OriginalArrivalTime: 07 Mar 2017 01:55:50.0812 (UTC) FILETIME=[F28C3DC0:01D296E5] Subject: Re: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 01:55:51 -0000 Content-Language: de-DE Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Please do not push this commit, I just bumped into a compilation error whic= h I did not see before. I'll post a V2 once I figured out what happened. Thanks, Marvin. > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Monday, March 6, 2017 3:27 AM > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > Cc: Zhu, Yonghong > Subject: RE: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable > on RELEASE builds >=20 > Reviewed-by: Liming Gao >=20 > >-----Original Message----- > >From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > >Sent: Sunday, March 05, 2017 11:00 AM > >To: edk2-devel@lists.01.org > >Cc: Gao, Liming ; Zhu, Yonghong > > > >Subject: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on > >RELEASE builds > > > >Set -Wno-unused-but-set-variable on RELEASE builds so variables only > >verified in DEBUG code (e.g. ASSERT()) do not trigger build errors. > >This is done to align with GCC compilation: > >https://github.com/tianocore/edk2/commit/20d00edf21d2f2144921622891 > d8 > >b59a1553cd83 > > > >Contributed-under: TianoCore Contribution Agreement 1.0 > >Signed-off-by: Marvin Haeuser > >--- > > BaseTools/Conf/tools_def.template | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > >diff --git a/BaseTools/Conf/tools_def.template > >b/BaseTools/Conf/tools_def.template > >index ab4f936e7a8b..b9a063215354 100755 > >--- a/BaseTools/Conf/tools_def.template > >+++ b/BaseTools/Conf/tools_def.template > >@@ -5467,7 +5467,7 @@ DEFINE CLANG35_AARCH64_CC_FLAGS =3D > >DEF(GCC_AARCH64_CC_FLAGS) DEF(CLANG35_AARCH64 > > *_CLANG35_ARM_CC_XIPFLAGS =3D DEF(GCC_ARM_CC_XIPFLAGS) > > > > DEBUG_CLANG35_ARM_CC_FLAGS =3D DEF(CLANG35_ARM_CC_FLAGS) > >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 > >-RELEASE_CLANG35_ARM_CC_FLAGS =3D DEF(CLANG35_ARM_CC_FLAGS) > >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz > >+RELEASE_CLANG35_ARM_CC_FLAGS =3D DEF(CLANG35_ARM_CC_FLAGS) > >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz -Wno-unused-but-set- > variable > > > > ################## > > # CLANG35 AARCH64 definitions > >@@ -5489,7 +5489,7 @@ RELEASE_CLANG35_ARM_CC_FLAGS =3D > >DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(P > > *_CLANG35_AARCH64_CC_XIPFLAGS =3D > DEF(GCC_AARCH64_CC_XIPFLAGS) > > > > DEBUG_CLANG35_AARCH64_CC_FLAGS =3D > >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) > >-O0 > >-RELEASE_CLANG35_AARCH64_CC_FLAGS =3D > >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) -Oz > >-fomit-frame-pointer > >+RELEASE_CLANG35_AARCH64_CC_FLAGS =3D > >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) > $(PLATFORM_FLAGS) -Oz > >-fomit-frame-pointer -Wno-unused-but-set-variable > > > > > >######################################################### > ## > >######################### > > # > >@@ -5543,7 +5543,7 @@ DEBUG_CLANG38_IA32_CC_FLAGS =3D > >DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto - > > DEBUG_CLANG38_IA32_DLINK_FLAGS =3D > >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 -Wl,-- > >oformat=3Delf32-i386 > > DEBUG_CLANG38_IA32_DLINK2_FLAGS =3D > DEF(GCC5_IA32_DLINK2_FLAGS) > >-O3 > > > >-RELEASE_CLANG38_IA32_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) - > >m32 -Oz -flto -march=3Di586 DEF(CLANG38_IA32_TARGET) > >+RELEASE_CLANG38_IA32_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) - > >m32 -Oz -flto -march=3Di586 DEF(CLANG38_IA32_TARGET) -Wno-unused-but- > >set-variable > > RELEASE_CLANG38_IA32_DLINK_FLAGS =3D > >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 -Wl,-- > >oformat=3Delf32-i386 > > RELEASE_CLANG38_IA32_DLINK2_FLAGS =3D > DEF(GCC5_IA32_DLINK2_FLAGS) > >-O3 > > > >@@ -5580,7 +5580,7 @@ DEBUG_CLANG38_X64_CC_FLAGS =3D > >DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=3D__ > > DEBUG_CLANG38_X64_DLINK_FLAGS =3D > >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_x86_64 -Wl,-- > >oformat=3Delf64-x86-64 -Wl,-pie -mcmodel=3Dsmall > > DEBUG_CLANG38_X64_DLINK2_FLAGS =3D DEF(GCC5_X64_DLINK2_FLAGS) > - > >O3 > > > >-RELEASE_CLANG38_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) - > >m64 "-DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone -mcmodel=3Dsmall = - > >fpie -Oz -flto DEF(CLANG38_X64_TARGET) > >+RELEASE_CLANG38_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) - > >m64 "-DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone -mcmodel=3Dsmall = - > >fpie -Oz -flto DEF(CLANG38_X64_TARGET) -Wno-unused-but-set-variable > > RELEASE_CLANG38_X64_DLINK_FLAGS =3D > >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_x86_64 -Wl,-- > >oformat=3Delf64-x86-64 -Wl,-pie -mcmodel=3Dsmall > > RELEASE_CLANG38_X64_DLINK2_FLAGS =3D > DEF(GCC5_X64_DLINK2_FLAGS) - > >O3 > > > >-- > >2.11.1.windows.1