From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from COL004-OMC2S10.hotmail.com (col004-omc2s10.hotmail.com [65.55.34.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 861F280346 for ; Mon, 6 Mar 2017 19:05:05 -0800 (PST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com ([65.55.34.71]) by COL004-OMC2S10.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Mon, 6 Mar 2017 19:05:05 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=e4Su1TZsPXHM9nbJcCO+jrNp8lgepFxB3eLMVDcVQnw=; b=dGiJCeBRn4Nj+6wH4CiM63z4r2F+g8XdMNIg2TkNg3JTJSEKWSrKk8fg8BG54roFJaMVNhCJL1SZWx6bN3mfWxknl9vbAzRucgEIrDakr2SPq+s+5LtTzRnoIgxdgipA/i9JEc7aiPBIXysyjlTymPPcdR6nbC27Ouylx0cOUVGOhqFCjofwrBE1BNlj/fjD0L3gKKt0nO0os8ngaaErFPZ42+pSvhrEB38WlAqQKbyYimAOX07b36xoH4V9ixkMXdtOMWRztQVT0CUDPUBtZ65Oh7hWh44nZVVIv1+HlEj2p3FLYEDTrYm+1kkBNIvg8LAYsCazgAqu2qtfysZJ7Q== Received: from VE1EUR02FT050.eop-EUR02.prod.protection.outlook.com (10.152.12.60) by VE1EUR02HT226.eop-EUR02.prod.protection.outlook.com (10.152.13.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.7; Tue, 7 Mar 2017 03:04:52 +0000 Received: from AM5PR0601MB2579.eurprd06.prod.outlook.com (10.152.12.56) by VE1EUR02FT050.mail.protection.outlook.com (10.152.13.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.7 via Frontend Transport; Tue, 7 Mar 2017 03:04:52 +0000 Received: from AM5PR0601MB2579.eurprd06.prod.outlook.com ([10.168.154.13]) by AM5PR0601MB2579.eurprd06.prod.outlook.com ([10.168.154.13]) with mapi id 15.01.0947.020; Tue, 7 Mar 2017 03:04:52 +0000 From: =?iso-8859-1?Q?Marvin_H=E4user?= To: "edk2-devel@lists.01.org" Thread-Topic: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds Thread-Index: AQHSlVyVt77oHRQkW0u6YHIqXbpoqKGHF5pggAGI2oCAABO00A== Date: Tue, 7 Mar 2017 03:04:52 +0000 Message-ID: References: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6E8472@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: de-DE, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.01.org; dkim=none (message not signed) header.d=none;lists.01.org; dmarc=none action=none header.from=outlook.com; x-incomingtopheadermarker: OriginalChecksum:EE331AFBF06A739DD6DFCE31A5E2D2EE53A2D3C04D9D208BFDCA1CBC91BFC50C; UpperCasedChecksum:98D5C71ECA602010320E92F3D99DB086E25ACC95D234FFA7A533306BF721BA7B; SizeAsReceived:8197; Count:38 x-tmn: [XIk5xFy5sRB/+SsE6JViItDOV+9A8y+vzBHtyPVikyChuEUp4GKaRBRgZEgfiu8T] x-incomingheadercount: 38 x-eopattributedmessage: 0 x-microsoft-exchange-diagnostics: 1; VE1EUR02HT226; 5:VB4Ytiu4V30+0ypx+KlXXpVt7agBle20M5zks/cIowu7fR1AWpy7hsKEA2mWGdJRfmEo7JfT74uPfLmuwchaykwutAiXcf76HGm9XJAlyzF8c5b8Ep57DaXZSDo5oZJdlPcfmVRrGtVatJ83GydZhw==; 24:sMKPV6VR2Ge0fp8bRv0c1vJrqNeOnPEq/7uc+ziKBusQqWFBnVlcuiqgsKUvJ87MOm7AC64GtYzp78UfwUiui96wAzxBHXo9Owrl4GdAK3k=; 7:jK69chVghOJ/Na5PmLoZRSuMZnMD0tBsTmvUWqTwz1z7BoTTLrOY1K9hwRBO8cpXyJ8O9QSXmpMrrikriY7LrmvE4ceoo1h6Kh7FDFYkgQejxEFhdpFE7QReadD67+uw0wL+k/J82kOSEqRYOdmUKVvNuFUXtxoqGDGZtY1dCOCyib+ZCfdtPFuYsbtAbhAkTbFkok1Vz2mnlhNfqQNr83xdlSLYfedOkAP9pVrqpFJ+ikn2PSwa3PdVxnVO4I3RwQBfR9R3sW4BMNRt5wNaldg6k3avES841yXGIX2YQSHRiFCdoht/Ehw2W8Wrzdvb x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(10019020)(98900016); DIR:OUT; SFP:1102; SCL:1; SRVR:VE1EUR02HT226; H:AM5PR0601MB2579.eurprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: 031fd9fd-49aa-4f5a-14f7-08d46506b985 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201702061074)(5061506573)(5061507331)(1603103135)(1601125254)(1603101448)(1701031045); SRVR:VE1EUR02HT226; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015087)(444000031); SRVR:VE1EUR02HT226; BCL:0; PCL:0; RULEID:; SRVR:VE1EUR02HT226; x-forefront-prvs: 0239D46DB6 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2017 03:04:52.1006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR02HT226 X-OriginalArrivalTime: 07 Mar 2017 03:05:05.0340 (UTC) FILETIME=[9ED6E7C0:01D296EF] Subject: Re: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable on RELEASE builds X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 03:05:05 -0000 Content-Language: de-DE Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sorry, the reason for the commit was caused by a misconfiguration of my wor= kspace. The commit can be discarded, no V2 needed. Sorry for any inconvenience. Regards, Marvin. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Marvin H=E4user > Sent: Tuesday, March 7, 2017 2:56 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: Re: [edk2] [PATCH] BaseTools/CLANG: set -Wno-unused-but-set- > variable on RELEASE builds >=20 > Please do not push this commit, I just bumped into a compilation error wh= ich > I did not see before. > I'll post a V2 once I figured out what happened. >=20 > Thanks, > Marvin. >=20 > > -----Original Message----- > > From: Gao, Liming [mailto:liming.gao@intel.com] > > Sent: Monday, March 6, 2017 3:27 AM > > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > > Cc: Zhu, Yonghong > > Subject: RE: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable > > on RELEASE builds > > > > Reviewed-by: Liming Gao > > > > >-----Original Message----- > > >From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > > >Sent: Sunday, March 05, 2017 11:00 AM > > >To: edk2-devel@lists.01.org > > >Cc: Gao, Liming ; Zhu, Yonghong > > > > > >Subject: [PATCH] BaseTools/CLANG: set -Wno-unused-but-set-variable > on > > >RELEASE builds > > > > > >Set -Wno-unused-but-set-variable on RELEASE builds so variables only > > >verified in DEBUG code (e.g. ASSERT()) do not trigger build errors. > > >This is done to align with GCC compilation: > > > >https://github.com/tianocore/edk2/commit/20d00edf21d2f2144921622891 > > d8 > > >b59a1553cd83 > > > > > >Contributed-under: TianoCore Contribution Agreement 1.0 > > >Signed-off-by: Marvin Haeuser > > >--- > > > BaseTools/Conf/tools_def.template | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > >diff --git a/BaseTools/Conf/tools_def.template > > >b/BaseTools/Conf/tools_def.template > > >index ab4f936e7a8b..b9a063215354 100755 > > >--- a/BaseTools/Conf/tools_def.template > > >+++ b/BaseTools/Conf/tools_def.template > > >@@ -5467,7 +5467,7 @@ DEFINE CLANG35_AARCH64_CC_FLAGS =3D > > >DEF(GCC_AARCH64_CC_FLAGS) DEF(CLANG35_AARCH64 > > > *_CLANG35_ARM_CC_XIPFLAGS =3D DEF(GCC_ARM_CC_XIPFLAGS) > > > > > > DEBUG_CLANG35_ARM_CC_FLAGS =3D > DEF(CLANG35_ARM_CC_FLAGS) > > >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 > > >-RELEASE_CLANG35_ARM_CC_FLAGS =3D > DEF(CLANG35_ARM_CC_FLAGS) > > >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz > > >+RELEASE_CLANG35_ARM_CC_FLAGS =3D > DEF(CLANG35_ARM_CC_FLAGS) > > >$(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -Oz -Wno-unused-but-set- > > variable > > > > > > ################## > > > # CLANG35 AARCH64 definitions > > >@@ -5489,7 +5489,7 @@ RELEASE_CLANG35_ARM_CC_FLAGS =3D > > >DEF(CLANG35_ARM_CC_FLAGS) $(ARCHCC_FLAGS) $(P > > > *_CLANG35_AARCH64_CC_XIPFLAGS =3D > > DEF(GCC_AARCH64_CC_XIPFLAGS) > > > > > > DEBUG_CLANG35_AARCH64_CC_FLAGS =3D > > >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) > > $(PLATFORM_FLAGS) > > >-O0 > > >-RELEASE_CLANG35_AARCH64_CC_FLAGS =3D > > >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) > > $(PLATFORM_FLAGS) -Oz > > >-fomit-frame-pointer > > >+RELEASE_CLANG35_AARCH64_CC_FLAGS =3D > > >DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) > > $(PLATFORM_FLAGS) -Oz > > >-fomit-frame-pointer -Wno-unused-but-set-variable > > > > > > > > > >######################################################### > > ## > > >######################### > > > # > > >@@ -5543,7 +5543,7 @@ DEBUG_CLANG38_IA32_CC_FLAGS =3D > > >DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto - > > > DEBUG_CLANG38_IA32_DLINK_FLAGS =3D > > >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 -Wl,-- > > >oformat=3Delf32-i386 > > > DEBUG_CLANG38_IA32_DLINK2_FLAGS =3D > > DEF(GCC5_IA32_DLINK2_FLAGS) > > >-O3 > > > > > >-RELEASE_CLANG38_IA32_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) > - > > >m32 -Oz -flto -march=3Di586 DEF(CLANG38_IA32_TARGET) > > >+RELEASE_CLANG38_IA32_CC_FLAGS =3D > DEF(CLANG38_ALL_CC_FLAGS) - > > >m32 -Oz -flto -march=3Di586 DEF(CLANG38_IA32_TARGET) -Wno-unused- > but- > > >set-variable > > > RELEASE_CLANG38_IA32_DLINK_FLAGS =3D > > >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_i386 -Wl,-- > > >oformat=3Delf32-i386 > > > RELEASE_CLANG38_IA32_DLINK2_FLAGS =3D > > DEF(GCC5_IA32_DLINK2_FLAGS) > > >-O3 > > > > > >@@ -5580,7 +5580,7 @@ DEBUG_CLANG38_X64_CC_FLAGS =3D > > >DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=3D__ > > > DEBUG_CLANG38_X64_DLINK_FLAGS =3D > > >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_x86_64 -Wl,-- > > >oformat=3Delf64-x86-64 -Wl,-pie -mcmodel=3Dsmall > > > DEBUG_CLANG38_X64_DLINK2_FLAGS =3D > DEF(GCC5_X64_DLINK2_FLAGS) > > - > > >O3 > > > > > >-RELEASE_CLANG38_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) > - > > >m64 "-DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone - > mcmodel=3Dsmall - > > >fpie -Oz -flto DEF(CLANG38_X64_TARGET) > > >+RELEASE_CLANG38_X64_CC_FLAGS =3D DEF(CLANG38_ALL_CC_FLAGS) > - > > >m64 "-DEFIAPI=3D__attribute__((ms_abi))" -mno-red-zone - > mcmodel=3Dsmall - > > >fpie -Oz -flto DEF(CLANG38_X64_TARGET) -Wno-unused-but-set-variable > > > RELEASE_CLANG38_X64_DLINK_FLAGS =3D > > >DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Wl,-Oz -Wl,-melf_x86_64 -Wl,-- > > >oformat=3Delf64-x86-64 -Wl,-pie -mcmodel=3Dsmall > > > RELEASE_CLANG38_X64_DLINK2_FLAGS =3D > > DEF(GCC5_X64_DLINK2_FLAGS) - > > >O3 > > > > > >-- > > >2.11.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel