From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.88])
 by mx.groups.io with SMTP id smtpd.web08.6399.1618898250770964722
 for <devel@edk2.groups.io>;
 Mon, 19 Apr 2021 22:57:31 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=BZH0QMAg;
 spf=pass (domain: arm.com, ip: 40.107.21.88, mailfrom: pranav.madhu@arm.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4+Emv+2XbEyhsdYscZje+0S0dVRZEJHeCI2A5d6m5Jg=;
 b=BZH0QMAgc/vIzGzpdscalW1gvcqeo8L9wvpXPFXOksg6AD9X47Cyx1g1w8IqkQXoLIjtcx1yKU4HPj1OB+gVnlfDH62lei4kG4/h0VUQ/rjteNkCu7zw+fmU2X2rF5TS4/+TJDWJNMMbRbm2X77UL8QMik79Lf4SnS1upEWPWcw=
Received: from AM5PR0601CA0039.eurprd06.prod.outlook.com
 (2603:10a6:203:68::25) by VI1PR0802MB2335.eurprd08.prod.outlook.com
 (2603:10a6:800:a0::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.20; Tue, 20 Apr
 2021 05:57:27 +0000
Received: from AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:68:cafe::18) by AM5PR0601CA0039.outlook.office365.com
 (2603:10a6:203:68::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20 via Frontend
 Transport; Tue, 20 Apr 2021 05:57:27 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT062.mail.protection.outlook.com (10.152.17.120) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4042.16 via Frontend Transport; Tue, 20 Apr 2021 05:57:26 +0000
Received: ("Tessian outbound 700fd1fc53d5:v90"); Tue, 20 Apr 2021 05:57:26 +0000
X-CR-MTA-TID: 64aa7808
Received: from e02379670da1.4
	by 64aa7808-outbound-1.mta.getcheckrecipient.com id 54BCC2A7-0068-479C-AEF0-30D41C8AA4AA.1;
	Tue, 20 Apr 2021 05:57:20 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
    by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e02379670da1.4
    (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
    Tue, 20 Apr 2021 05:57:20 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UQjDO3cQUwNdnUVDoQ2HNHZf2OD0tO0DHfUyRxQ55ZDuaUj4yAeoytk3XuqYKiqBqYRiZuWNbqgeVfLd1opf3C0SmLfDZF3A2fgM2ylCMqST+DvCQ4o0aqBcF27n8pW1brWK4Gpm40mPrndymGzjooh+cGFnBzc9KunLOnuAa07jd5PtDFH7FigPp1LjOW7pBQf5MrX597I0WJDt+h8f3d24sgUVnKyu8SJjD9MS1BKtltrPVwKaGauziP0x2U+XI/ru4Y9JD6ZG7URDsTTtH5pwX1xFdgSQgX/iEyr7XbgWsQFsB6lZ7A/l4e9YLNUTxOQ1QqFTQumQNeyVMXEg9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4+Emv+2XbEyhsdYscZje+0S0dVRZEJHeCI2A5d6m5Jg=;
 b=hqtHBoNiuKgtCKWoMCj0DQsh8ncoU0R4E7mgOCA1NVvpLAghv/60hOt29XmNvzxM+1Llp7q9KXW3hSdlN9ry6SGhv9WZ9OUKztyzrojTUTVI6hrMoqNfxWcKDh1+VXvuihKYkI8H4CEOJWYnwpnXylUs0m19ykPPH24ZGMJsoZzKuhYgH2C0h4+Ho1JbJ4s60R0dkBcnARpZbhzW0GrbnSZWKx4qGo3lz1+/pa7Q5j6nuH31lELXa6Bud04rzryps20LdyifYfpCN+JDyYKs5tjBGUI96skrRAn8nLux7Wc8qkt8BMIDt5nY3q57YD+mnicSUyfiWCpArivU7xVd0g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4+Emv+2XbEyhsdYscZje+0S0dVRZEJHeCI2A5d6m5Jg=;
 b=BZH0QMAgc/vIzGzpdscalW1gvcqeo8L9wvpXPFXOksg6AD9X47Cyx1g1w8IqkQXoLIjtcx1yKU4HPj1OB+gVnlfDH62lei4kG4/h0VUQ/rjteNkCu7zw+fmU2X2rF5TS4/+TJDWJNMMbRbm2X77UL8QMik79Lf4SnS1upEWPWcw=
Received: from AM5PR0801MB1715.eurprd08.prod.outlook.com
 (2603:10a6:203:3c::10) by AM6PR08MB3766.eurprd08.prod.outlook.com
 (2603:10a6:20b:83::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Tue, 20 Apr
 2021 05:57:19 +0000
Received: from AM5PR0801MB1715.eurprd08.prod.outlook.com
 ([fe80::1d1b:f3f3:d8bc:a2d4]) by AM5PR0801MB1715.eurprd08.prod.outlook.com
 ([fe80::1d1b:f3f3:d8bc:a2d4%7]) with mapi id 15.20.4042.024; Tue, 20 Apr 2021
 05:57:19 +0000
From: "Pranav Madhu" <pranav.madhu@arm.com>
To: Pierre Gondois <Pierre.Gondois@arm.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: Ard Biesheuvel <ardb+tianocore@kernel.org>, Leif Lindholm
	<leif@nuviainc.com>, Sami Mujawar <Sami.Mujawar@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/8] Platform/Sgi: Helper macros for PPTT Table
Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 1/8] Platform/Sgi: Helper
 macros for PPTT Table
Thread-Index: AQHXMEXsN8mzIxTWAECEtEviFpEDQaq84m0g
Date: Tue, 20 Apr 2021 05:57:19 +0000
Message-ID: 
 <AM5PR0801MB17150D5015D98DCAAFC8D38A8A489@AM5PR0801MB1715.eurprd08.prod.outlook.com>
References: <20210402091208.16752-1-pranav.madhu@arm.com>
 <20210402091208.16752-2-pranav.madhu@arm.com>
 <04572474-09c9-056f-397b-ef38ca06175c@arm.com>
In-Reply-To: <04572474-09c9-056f-397b-ef38ca06175c@arm.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ts-tracking-id: C6688A93606D464499161C93EAAC4B99.0
x-checkrecipientchecked: true
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
x-originating-ip: [157.44.186.192]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 756a1f2a-aa42-492b-98c9-08d903c12d09
x-ms-traffictypediagnostic: AM6PR08MB3766:|VI1PR0802MB2335:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: 
	<VI1PR0802MB23350A84D74DBC20E6139A788A489@VI1PR0802MB2335.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: 
 FfDOWbnrpD+sZvC/xi/NocQoXDiQAoRYuvRlvnBq9lvczkmJhs7j3h7GZQ3okvoPejjZjMVeva16dYkOzyA7ea9BW9fbwEA3wHtaNjPHp2ZNYzgLD15GQxxNRGIaexKs5SLYdZdhXKY9OLBiRY59Pb3W3Mc+VteY46YdLBy9ycc67OhmFpSR3KNge6ehHaSoObdhY6gsOmbyp/qLpNNhV57YWQIhfJuHsFFYUblC2CH6/zQv4r/OfHKbVm7DNagtckoHnYeJcDiDIkRgBUQ54UwFFzwJ07TdFI3EcCrEECV+NhoRcEDby5wrz4mN2gKCwe2XK6gSwOtRCZ67DttqInlwX587f99vKKjdBp2Gdhuev5Ru/8YKPHDiQf6YtQ2mbV3ld9YOwFcx2DopQphSz4ulGeCAuhm2oA4gVKUl7HBSiICwOVtRZx8rdXVBFylVVqy90EnUoidbiM6F6OiFETZXi968K+XM5Lqf3SxPyBziOk5hwdRiKDfTnMhArNQHMHkJ0CGsF6a9nWq5GvkAp2p7TeXx8YZhxJCIYseDP3QUVqVQyDS7XHrUmbc9BTtgMd75AAMpqEbYC46YmPjwRgiovFz43O+6LWd5apbOgcY=
X-Forefront-Antispam-Report-Untrusted: 
 CIP:255.255.255.255;CTRY:;LANG:fr;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB1715.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(53546011)(110136005)(186003)(54906003)(55016002)(71200400001)(26005)(5660300002)(9686003)(52536014)(8936002)(316002)(478600001)(4326008)(66556008)(83380400001)(2906002)(66476007)(66446008)(64756008)(66946007)(122000001)(8676002)(76116006)(33656002)(86362001)(6506007)(38100700002)(7696005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: 
 =?iso-8859-1?Q?FNTHWtnUdus2N+4+Ub4BixfNv2l6EBvyUFZ3Eb2lhmwCyC1GmTlExQY5ka?=
 =?iso-8859-1?Q?cppp1zNeSL9Pn6sRb9izjmA7MPBCz+2BupJvtCfDbmTJoHfKU67BxAjJzD?=
 =?iso-8859-1?Q?55oiRcy99c+0ixk8RzTRGa1VX7is6haOP1toGjLSDEQLRt+Sgdye6iJ9mK?=
 =?iso-8859-1?Q?2nYGXbmKqjTvfmbulvZCBTdeoCEKvaTNrsskY7hMJu72e7oCNV6RVZq9gr?=
 =?iso-8859-1?Q?Y6vcYZl/JzTiwXbfFGTgdz7hGBg13SoPL5ZgCs2KoizFAex+ggm7nkNtKM?=
 =?iso-8859-1?Q?k/GU8HtHIBuFqKtpmuAsbmNkV+9sa2u0y3qzTWeB7VAb9PSk142e4shLbW?=
 =?iso-8859-1?Q?rHdrPJYbDOFPNkZENLVE7/v5g3uyMlNJVMtPrqbunEegmbz4jUlWwWro0D?=
 =?iso-8859-1?Q?LHtamdkplQhRzpB5YI3eZ4UptA0WYcEzyjXMPyo85M0op+0WsxZfigYZDU?=
 =?iso-8859-1?Q?mjuQgm+MnnNR+2Z3SyJnFbb+LeqWG8ciyBDqBi+RQlf45v9vDwCp0oMGww?=
 =?iso-8859-1?Q?mD0nRhePD+2Pzp2vg+NAbfU9SBtbOc4KUW6koZbUWhBjHM2BzjNswWv/OE?=
 =?iso-8859-1?Q?C1dmOO75pO2r1cOjeh9Wfx4c0AFw1LxURDt1Z1j37hBry6WSmUqoOe5yeA?=
 =?iso-8859-1?Q?v9nVGStYDIizLRswHwrkgQMUa1y6Ktm1Sq2u6k/SFopLmswgiWevHQBSUM?=
 =?iso-8859-1?Q?aqL7JQ9QKLLwU6KJ90tKKsEtedyZMCe/VJsIxnvTN9lTz8/dtXwK+MZJiW?=
 =?iso-8859-1?Q?JNzjFyBxOxevvv3D3DT6v9N3SwZjCTJY9OrIutSDiWCj+ul5V5ZMSofuMY?=
 =?iso-8859-1?Q?6IxGucBTo76mdfXHfuXL0os4RSfxIGNbe4G0+3SBnPv60hFSH+77aQcZ+W?=
 =?iso-8859-1?Q?JFqedub7EipIWKu50wZ77Kb/9QPmqgO+TF6Yuy+vqv1/QlnWRL479GmiOu?=
 =?iso-8859-1?Q?g11aLDCsIYipYDG8O4wyNJhlnNieS0Wn4G3nTzdIWCroWjoU1cCGLh511e?=
 =?iso-8859-1?Q?4vDuuMV1PUKN0D1NxVwCc5hIHW1yyoxarX3Mpl7o08ughBuPtbvh5IaPAa?=
 =?iso-8859-1?Q?felVZnAl+tkRKVcpO7EW11E6aZI2RzfyNq4Xirrp9Oq6tp7iruWYG1SjeS?=
 =?iso-8859-1?Q?xBszUwQBPBb7QuEGv/ByVfFhccAYumxEg24ysK4fJgzs/+m84B75f0tEYE?=
 =?iso-8859-1?Q?XLvLxhmQnlaKGbXY49ZemP0o4A6e2/LErzvguMJWCXeW9tiiTaLs1D9aew?=
 =?iso-8859-1?Q?u13pv/tTANbQs3cl/tDujNAZrEUVkceomweP71HOO2udxVWcWc4/i8UYZ7?=
 =?iso-8859-1?Q?+cptpWkUxd3qEGTR4zWJ/L4AyEoI9ufPeXaM9Ik8ZvNJTAw=3D?=
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3766
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
Return-Path: Pranav.Madhu@arm.com
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: 
 AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: 
	ed8025f4-3f92-4c45-f696-08d903c12870
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	Wk1RurJ92wNf3lV4fugRLyzdYbE3bnP3MBaH4lULNmVdRGKg2JzScSwIqQREYlt3l8iobTZfK8P9egU1YdDIW6etKDmK3G6tzC0GuSoM1dojTFNx95LXgy51ydIl780XN8b6tt6VnNE5/IGWGeKy5O2my3kOx2csIvIYgvP4hWsl4OHUWIi7Zk6F6RMTrjjHMszXRV2EW7/a9RFLWAnRNFiJSvjiu1ewZ+TEivwQBZ9OW92hFNrvhXnjVNV53UK30g1cQN1LMDp2NV82+qCz421GOUnCBPtBihLxMjrmgB4aIsL6ix5xB38icrEfyWHDNOP6q5vn21IOPTcZ97iRPSHstfDFE+BMJWfYDHP/we0+2krHuUtkuOwSzvwscFhZuNOD+yajvgbIgtHfwAHPBeQ9+V56RSXs9oTqaVDmLpUdKVqU5hEiWYVK1e9v2TgVEKct80Beu8OLlaUvkW0VvYv2HrQsg1zYFopFF6iCKwfPGveQXlQlkIA+lqf/NhUPRq6bwqdaEpvXWKTPMxD0GP7FBiUB4e/pUY2q3e52YBr6kdOYT0c36xXWy8tbPY+f/AbRAg49fMNLp03/mzWTKvtHOc+uk4Pq5Wgf4W9soOnmZuYoFohoR9rdNL6spZGI3W3J8Gr2vwwt69uHtrKdRw==
X-Forefront-Antispam-Report: 
	CIP:63.35.35.123;CTRY:IE;LANG:fr;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(36840700001)(46966006)(86362001)(336012)(33656002)(82740400003)(53546011)(55016002)(26005)(81166007)(47076005)(36860700001)(316002)(6506007)(356005)(83380400001)(70586007)(82310400003)(478600001)(52536014)(70206006)(5660300002)(2906002)(8936002)(4326008)(186003)(110136005)(9686003)(8676002)(54906003)(7696005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2021 05:57:26.8051
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 756a1f2a-aa42-492b-98c9-08d903c12d09
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: 
	AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2335
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi Pierre,

Thanks for reviewing this patch. Please find my response inline.

> -----Original Message-----
> From: Pierre Gondois <pierre.gondois@arm.com>
> Sent: Tuesday, April 13, 2021 2:48 PM
> To: devel@edk2.groups.io; Pranav Madhu <Pranav.Madhu@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm
> <leif@nuviainc.com>; Sami Mujawar <Sami.Mujawar@arm.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/8] Platform/Sgi:
> Helper macros for PPTT Table
>=20
> Hi Pranav,
>=20
> > diff --git a/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h
> > b/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h
> > index 8d715de173c9..7ceb090a78e9 100644
> > --- a/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h
> > +++ b/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h
> > @@ -1,6 +1,6 @@
> > =EF=BF=BD/** @file
> > =EF=BF=BD*
> > -*=EF=BF=BD Copyright (c) 2018-2020, ARM Limited. All rights reserved.
> > +*=EF=BF=BD Copyright (c) 2018-2021, ARM Limited. All rights reserved.
> > =EF=BF=BD*
> > =EF=BF=BD*=EF=BF=BD SPDX-License-Identifier: BSD-2-Clause-Patent
> > =EF=BF=BD*
> > @@ -20,6 +20,132 @@
> > =EF=BF=BD#define EFI_ACPI_ARM_CREATOR_ID SIGNATURE_32('A','R','M',' ')
> > =EF=BF=BD#define EFI_ACPI_ARM_CREATOR_REVISION 0x00000099
> >
> > +#define CORE_COUNT=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD FixedP=
cdGet32 (PcdCoreCount)
> > +#define CLUSTER_COUNT=EF=BF=BD=EF=BF=BD FixedPcdGet32 (PcdClusterCount=
)
> > +
> > +#pragma pack(1)
> > +// PPTT processor core structure
> > +typedef struct {
> > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR=EF=BF=BD Core; =EF=BF=
=BD
> >
> +UINT32=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> =BD
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD Offset[2];
>=20
> I think there should be 3 entries (DCache, ICache, L2Cache). Updating thi=
s will
> require updating the other PPTT tables written.

As per ACPI spec 6.4, chapter '5.2.29.2 Cache Type Structure - Type 1', " O=
nly
the head of the list needs to be listed as a resource by a processor node (=
and
counted toward Number of Private Resources), as the cache node itself
contains a link to the next level of cache."
Here L2 cache is represented as next level of L1, so no need to count it.

>=20
> Would it be also possible to rename the field 'PrivateResources' as in th=
e
> spec ?

Yes, but in actual, it is not the private resource count.

> Another question: what does 'RD_' stands for ?

RD Stands for Reference Design, it is the convention we follow.

>=20
> > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD DCache; =EF=BF=BD
> > +EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD ICache; =EF=BF=BD
> > +EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD L2Cache; }
> > +RD_PPTT_CORE;
> > +
> > +// PPTT processor cluster structure
> > +typedef struct {
> > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR=EF=BF=BD Cluster; =EF=
=BF=BD
> >
> +UINT32=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> =BD
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD Offset; =EF=BF=BD
> > +EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD L3Cache; =EF=BF=BD
> > +RD_PPTT_CORE Core[CORE_COUNT]; } RD_PPTT_CLUSTER;
> > +
> > +// PPTT processor cluster structure without cache typedef struct {
> > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR=EF=BF=BD Cluster; =EF=
=BF=BD
> >
> +UINT32=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> =BD
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD Offset;
> I think there is no need for an offset here. Updating this will require u=
pdating
> the other PPTT tables written.

Right. Will update.

> > +=EF=BF=BD RD_PPTT_CORE Core[CORE_COUNT];
> > +} RD_PPTT_MINIMAL_CLUSTER;
> > +
> > +// PPTT processor package structure
> > +typedef struct {
> > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR=EF=BF=BD Package; =EF=
=BF=BD
> >
> +UINT32=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> =BD
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD Offset; =EF=BF=BD
> > +EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD Slc; =EF=BF=BD
> > +RD_PPTT_MINIMAL_CLUSTER Cluster[CLUSTER_COUNT]; }
> > +RD_PPTT_SLC_PACKAGE; #pragma pack ()
> > +
> > +//
> > +// PPTT processor structure flags for different SoC components as
> > defined in
> > +// ACPI 6.3 specification
> > +//
> > +
> [...]
> >
> > +// EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR
> > +#define EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR_INIT(Length, Flag,
> > Parent,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD ACPIProcessorID, NumberOfPrivateResource) \
>=20
> I think it should be possible to remove the 'Length' parameter and comput=
e it
> as:
> sizeof (EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR) +
> NumberOfPrivateResource * sizeof
> (EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE) + NumberOfPrivateResource *
> sizeof (UINT32)
>=20

As per 6.4 specification, table 5.138, the Length is "Length of the local p=
rocessor
structure in bytes" It is just the length of local processor, not the entir=
e structure.

> > + { \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +EFI_ACPI_6_3_PPTT_TYPE_PROCESSOR,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> =BD=EF=BF=BD
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Type 0
> > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +Length,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> > +=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /*
> > +Length
> > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > + { \
> > + EFI_ACPI_RESERVED_BYTE, \
> > + EFI_ACPI_RESERVED_BYTE, \
> > + }, \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> > +Flag,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF
> >
> +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD
> > +/* Processor
> > flags */=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +Parent,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> > +=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /*
> > +Ref to
> > parent node */ \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +ACPIProcessorID,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> > +=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* UI=
D, as per
> > MADT */=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +NumberOfPrivateResource=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF
> =BD=EF
> > +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Resource
> > count */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD }
> > +
> > +// EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE
> > +#define EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE_INIT(Flag,
> NextLevelCache,
> > Size,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD NoOfSets, Associativity, Attributes,
> > LineSize)=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF
> > =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD \
> > + { \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +EFI_ACPI_6_3_PPTT_TYPE_CACHE,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF
> =BF=BD=EF
> > +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Type 1
> > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD sizeof
> > +(EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE),=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD /* Length
> > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > + { \
> > + EFI_ACPI_RESERVED_BYTE, \
> > + EFI_ACPI_RESERVED_BYTE, \
> > + }, \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> > +Flag,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF
> >
> +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD
> > +/* Cache flags
> > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +NextLevelCache,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF
> =BD
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
 /* Ref to next
> > level */=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> > +Size,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF
> >
> +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD
> > +/* Size in
> > bytes */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +NoOfSets,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF
> =BD
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Num
> > +of sets
> > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> > +Associativity,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF
> > +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD /* Num of ways
> > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> > +Attributes,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF
> > +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD /* Cache
> > attributes */=EF=BF=BD=EF=BF=BD \
> > +=EF=BF=BD=EF=BF=BD=EF=BF=BD
> >
> +LineSize=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF
> > +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /*
> > +Line size in
> > bytes */ \
> > +=EF=BF=BD }
> > +
> > =EF=BF=BD#endif /* __SGI_ACPI_HEADER__ */
> > --
> > 2.17.1
>=20
> Regards,
>=20
> Pierre
>=20

Regards,
Pranav.