From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.46]) by mx.groups.io with SMTP id smtpd.web10.6465.1618898543501016128 for ; Mon, 19 Apr 2021 23:02:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=l36+ZbGq; spf=pass (domain: arm.com, ip: 40.107.20.46, mailfrom: pranav.madhu@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yz6E/wzAvtpz2WFtNm1H+W/Ik1k8tymmfYWAJc6Y4rw=; b=l36+ZbGqTX45Q6q9t/Ddyge9Ew4cmBeq82FegigEUYaIN5gbc7C15OscsPkMQBNpmvkRjrvqrzG4P2c9mUpt4fGfszPhp17O4N6G6FSp5qyAeZWfUAILi+g+PNyftxB6QR26Pic3Jv4b8ZZsPjodNZ0Fzwpbi5rgggHnTb4qr9Q= Received: from AM6PR08CA0036.eurprd08.prod.outlook.com (2603:10a6:20b:c0::24) by AM0PR08MB4338.eurprd08.prod.outlook.com (2603:10a6:208:13e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Tue, 20 Apr 2021 06:02:20 +0000 Received: from AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:c0:cafe::67) by AM6PR08CA0036.outlook.office365.com (2603:10a6:20b:c0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20 via Frontend Transport; Tue, 20 Apr 2021 06:02:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT054.mail.protection.outlook.com (10.152.16.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Tue, 20 Apr 2021 06:02:20 +0000 Received: ("Tessian outbound 82c2d58b350b:v90"); Tue, 20 Apr 2021 06:02:19 +0000 X-CR-MTA-TID: 64aa7808 Received: from 83f629e25f9e.4 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0C3AACA6-0FB2-4692-B9CB-933B49AA8183.1; Tue, 20 Apr 2021 06:02:13 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 83f629e25f9e.4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 20 Apr 2021 06:02:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nEBhDCKwrkIkTZONYTs8ujByZexH3iRtNzAPrB0+Es6QisFAt/Zm3Bz/f0D3oUVxde/IZOLJbSUEYkaVj5sHvkEnu5nm8/dSrwKzfzvGfbV2Bas9vII1z4ShBNjDxAaoEN458yyutEKkqwGXOY3R0IRf9WD4wFiFkYS9v91g2p6QwPlkjeAAV4qMWY7X1F6w6dg1U9VMrIvJpb1KyW0m3wWamRn9pS0HM4h1fVVZE5XC4mzQRtb9xeerDgmySw3reqHCoXOLaksF+e4OPnJsD0iQtqY85Owqp5ZDNFY4Zwh3oISMfgAybEv837ChpX+mg7zZ8gxWR24j2mWnI05wgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yz6E/wzAvtpz2WFtNm1H+W/Ik1k8tymmfYWAJc6Y4rw=; b=cYlxq9lLzTPxdEPuRRVvl7ByxWjIvkPoDgPZPf/4k2IcPF0Q8vEfljHj5+qSKfpPIffjHidkFb0QpU8xg+lmAcavWsnT9F5csBZQ/Q5lX70Lk/D113aWJQ+PkGU+xCD33ucBjUcUwAmvKx+pW5FhGbTAYMzgprxVyDfaLmAYn7vbXlQlFdYGXktUNpNKHSCE5iHPqLDjio0ZQGUz6wtEW8mUSroPRgCegUjuvhmBncV+bx3m2UzG8dzsjHRO4mq6FwTINyN+rBpAU31MboJM019CzTwthxPO+v4zTepUQPoMeFe8V8XLGwhNlTthXbbxQ7hfPBua7ph1sydhykaRUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yz6E/wzAvtpz2WFtNm1H+W/Ik1k8tymmfYWAJc6Y4rw=; b=l36+ZbGqTX45Q6q9t/Ddyge9Ew4cmBeq82FegigEUYaIN5gbc7C15OscsPkMQBNpmvkRjrvqrzG4P2c9mUpt4fGfszPhp17O4N6G6FSp5qyAeZWfUAILi+g+PNyftxB6QR26Pic3Jv4b8ZZsPjodNZ0Fzwpbi5rgggHnTb4qr9Q= Received: from AM5PR0801MB1715.eurprd08.prod.outlook.com (2603:10a6:203:3c::10) by AS8PR08MB6887.eurprd08.prod.outlook.com (2603:10a6:20b:38e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Tue, 20 Apr 2021 06:02:12 +0000 Received: from AM5PR0801MB1715.eurprd08.prod.outlook.com ([fe80::1d1b:f3f3:d8bc:a2d4]) by AM5PR0801MB1715.eurprd08.prod.outlook.com ([fe80::1d1b:f3f3:d8bc:a2d4%7]) with mapi id 15.20.4042.024; Tue, 20 Apr 2021 06:02:12 +0000 From: "Pranav Madhu" To: Pierre Gondois , "devel@edk2.groups.io" CC: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , nd Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 5/8] Platform/Sgi: ACPI PPTT table for RD-E1-Edge platform Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 5/8] Platform/Sgi: ACPI PPTT table for RD-E1-Edge platform Thread-Index: AQHXMEg9qTYVrCE0TUa3o3+7kX6cAaq89EQw Date: Tue, 20 Apr 2021 06:02:12 +0000 Message-ID: References: <20210402091208.16752-1-pranav.madhu@arm.com> <20210402091208.16752-6-pranav.madhu@arm.com> <91781887-47e9-2a87-4d88-f8e7e36b18f7@arm.com> In-Reply-To: <91781887-47e9-2a87-4d88-f8e7e36b18f7@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 92A3AEBDECDF7B4181932D82EA54102E.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [157.44.186.192] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 9aa9cea8-3c23-495c-5f36-08d903c1dbf1 x-ms-traffictypediagnostic: AS8PR08MB6887:|AM0PR08MB4338: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BuVPf9m0N14uerwNyvxnKFQAosD/2jRNMMFuC+BQAyrt99Vs/n6Zacozp7ukLBqBFtAbWc15paKlP/D+acboo+gLly2xAy6kCdvvDAb2E/onQJfi5MhiTH5LkbziIC9OUnqjil5Nd4GkRzCHlaGSYu7xGDMueAhIq7ztqKlJ8F9KokjbTlmpVo9ZbiDvqN+/t130gBohuXURAxhyB6G8zF+IRzODO4Ce8SLh9hHDL1h8O1qDDvCGTy8VAbGrA3A7TzPqtx7A4KSHFR38nvqWV7U+hXQroTr996/1tOHsbfcOt3EdZPlUeHpM2dvSpW7OddAzIMibGoZGAobq9D0GYXZQkLhAIZxponTVGRA290L3wMSGjSMyKmiHW4A2TsVYud7YTAfnSDmWAEq50knXe2iIywIIDXU4DsDc/qLLKinwMlxvMtEXfppsYlwmnxGnvf0pbw0Iq+510ZTy/k/U0F/bmccDpkyxgbaH+9KlzO2w8vrWSm1+IhSHKNDfvfsV4WpQsYng40PSUQZyLIghepybh+1uG50IIZVtTNZTdXZg/nk3sbYNu8CKDdFVjLWHL2KzTTYMTq5iOLK42Vno2gHXXr+ZqodO0Hifbwifn20= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:fr;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB1715.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(39860400002)(396003)(136003)(346002)(9686003)(6506007)(567974003)(55016002)(2906002)(33656002)(478600001)(122000001)(71200400001)(52536014)(86362001)(26005)(110136005)(5660300002)(8936002)(76116006)(8676002)(66446008)(66946007)(66556008)(7696005)(66476007)(316002)(4326008)(83380400001)(186003)(38100700002)(54906003)(64756008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?lU40IwNgGFtHWyfhN8SgFz8J+UOtO8hx5SHN6DYZlHGb9mcv44i2d0cmz5?= =?iso-8859-1?Q?ZBvMtcQObUzYVZc7mY2QDHXxk4H+6EqTLoor3VDVv2njzQ0W3jrVKPmfwk?= =?iso-8859-1?Q?gAwPSmT0oNMBvHkXNzDAVFHuDrUvt76zz8E5M1yFISr4tzEzdXmcvnXoBj?= =?iso-8859-1?Q?VD3Kcm4WpKwedT0bj7MEX5XVoiysrVec1eJUjwzHiciyf0c+HbYM+bBsMJ?= =?iso-8859-1?Q?woxU89tolge+81H9erQd5xDRWv1warWT3+p6JohEjWuxwV85SDSBs1wW3r?= =?iso-8859-1?Q?WGOdpYo0a5WYW7efqPxx4rbmd2cuvTN29zdGRZP1dZ8ZCQ0jDVA75ni/Go?= =?iso-8859-1?Q?cQKYs3lUGCXeXfU7FPRTgmhRpRNkuCt93sxnczXAkl+HdMsctLDxbg2Cwt?= =?iso-8859-1?Q?dcosPI2WwT31yz/rx/cyiwcLt1rqVgJ7JeHJCAf+US/kIa0KGuy1MJ6yyh?= =?iso-8859-1?Q?tOTsA2Klz0jVx4nYmNxcWc85BgHxzcTSMnqYi25Tm+QCCX6AzNiLJQnoXt?= =?iso-8859-1?Q?n8TfM3LApt/ZyR9cKLEVhZ7iElfV8hJzast/G/IpudIgtFI0jXD3AOxq+K?= =?iso-8859-1?Q?VZ50Wy7HYylyRkmv5aySPJjM4cxM7jUzjsaeBOUwuRCzIoQ5d+tVz8JxMw?= =?iso-8859-1?Q?nMLvRguj3UoAmw3dNSvTr+6R+htxvLV3MX7EPByKFWhVB61iKkpyICFQnd?= =?iso-8859-1?Q?yeMmmZoOLFNz8gtz/L7x3m7bqUVUydagpWM8gnaCewL9eRShw+QH81wLAC?= =?iso-8859-1?Q?1G0wLlDh+m0Oc9BPWsjecT/vSmTOse2RT1+Ijx9yQ+wBYaD4UOTQ2tnGPa?= =?iso-8859-1?Q?J/P3eXAGy7wRGeTealsXGs9HG7sP/zRLlyAC/DqN/HpKPvn6OJcWaMF5pA?= =?iso-8859-1?Q?zaxBpiQUHacTjX/NuIOe4js9CK9j6s0G7KuX1FUFeNeZMogInjL8ikhMP2?= =?iso-8859-1?Q?DpPZeJTdFMKJXOviogvrB6jfGC135HHopn59Tt64WtkCdKZgUfg7ZYRvH3?= =?iso-8859-1?Q?cDqJ62A9dG3IXIXsbSa4rm9eHZqRijHQmgvhc9pcGCpSKpy751PEZmCdrJ?= =?iso-8859-1?Q?GND5wlnvct4rqYWpC2HlJV7nMVa1jpBnPMw7QJbxm+ybF9l4mxmgdpuVhF?= =?iso-8859-1?Q?XSVsBXo7A0Xn86+kHov3eJJEbN3M4SJxsI4DB6/5bOjAzn6JIyAQRUd4hH?= =?iso-8859-1?Q?U+AodI3ni+CVA0yhFfxAABRPPVleEiwNYpnxLPDfonAdQe7AE3bPH3UtXD?= =?iso-8859-1?Q?6RTSuiJeJqDG1gg1Epw6/hXju4UQZ22vS1IXCp0XwYSuBpOkInRmTtnGJg?= =?iso-8859-1?Q?DRsXzX5rqEcpPbBAmoGv7I/Ia3ZWCObNqWvZNtUT/362Fc1J+FBMy3tldB?= =?iso-8859-1?Q?7vAKVVENSW?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6887 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Pranav.Madhu@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 59b50e94-cc57-49ac-3f00-08d903c1d781 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zRP2EnRAXJqSZyN8EYlVBzZDtK0Bs/2Mu67s8tnyxBQC3nWTnseOhmr82t5uIleMWGsYtkDGpAYlV/RHlV52QhZgKDhhTZysEmp/dnDSJU1ulMZR36Ttjr5L9cwokzpz9s3NTdP1pxQoAu+83MG9YV6u+6LPq/ctVRojumXf9h71UkQhvsjSumKxOmZ73V91lHra6qSoygIPAeSoF1+A8IqPsO4SupmXPTu1SylJ+nPDPIJVWkc/ZMB/vBQzgulTxZYCTXjIC4C/DUteQCYCsyZb+Vmn/1LY1gvtRg+PrB+LPWNazq6iuQWN7xinPutUN2oJSUTdiP2u0opKrDQGSG3ta0unJ5xWp/NQpW1laIuqrbI+w3H8WemFmsbYOPwPh6nATsRaZ7+cXdAFaOdkHUtaNnJ8wtZSSNQL0OCIV3UeUiPgYA3HRfr7QwO4GnZtu86+L6MUEuUd6Ho+5/f4hm3lQg7MXEBU2UEVg4pXXjJmCOhh9cX7vSQsN7J/Go267ScufjcRC+wFiQDRUFswVXjwFOwsNZRXsv+U3ZCJS3wDnx2dNGogTued1B7FJEuv7G5bPbobH+TU9B/qLR65GSMdBOdUzRvWNPKUhrVoSnKMtrsqhDG1fj+GoMsI2HMkGgVfNfU+X2eUkmoD/WU1BqM5UcgEa4KwdJGTAKf9go4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:fr;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(46966006)(36840700001)(4326008)(54906003)(36860700001)(33656002)(7696005)(47076005)(2906002)(8676002)(478600001)(83380400001)(70206006)(52536014)(8936002)(55016002)(567974003)(356005)(82310400003)(6506007)(26005)(82740400003)(81166007)(9686003)(5660300002)(316002)(110136005)(86362001)(70586007)(336012)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2021 06:02:20.2566 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9aa9cea8-3c23-495c-5f36-08d903c1dbf1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4338 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Pierre, Thanks for reviewing this patch. >=20 > Hi Pranav, > > +=EF=BF=BD } > > + > > +#define PPTT_CORE_INIT(pid, cid, > > > coreId)=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD \ > > + { \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Parameters for CPU Core > > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > > =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR_INIT > > > (=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD __builtin_offsetof (RDE1= EDGE_PPTT_CORE, DCache), /* > > +Length > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > +PPTT_PROCESSOR_CORE_THREADED_FLAGS,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > /* Flag > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD __builtin_offsetof > > (EFI_ACPI_6_3_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE,=EF=BF=BD=EF=BF=BD=EF= =BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > +Package.Cluster[cid]),=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF > > +=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Parent > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > > +0,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF > > +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD /* ACPI Id > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > > +2=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > > +=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Num > of > > +private > > resource */\ > > + ), \ > > + \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Offsets of the private resources > > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > > =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \ > > + { \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD __builtin_offsetof > > (EFI_ACPI_6_3_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE,=EF=BF=BD=EF=BF=BD=EF= =BF=BD \ > > + Package.Cluster[cid].Core[coreId].DCache), \ =EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD > > +__builtin_offsetof > > (EFI_ACPI_6_3_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE,=EF=BF=BD=EF=BF=BD=EF= =BF=BD \ > > + Package.Cluster[cid].Core[coreId].ICache) \ }, \ >=20 > Would it be possible to use the edk2/MdePkg/Include/Base.h:OFFSET_OF() > macro to handle the different compilers ? Yes, will update >=20 > This modification could be applied to all the other PPTT tables in the se= t. >=20 > > + \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD /* L1 Data cache parameters > > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > > =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE_INIT > > > (=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > +PPTT_CACHE_STRUCTURE_FLAGS,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* > Flag > > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > > =BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD __builtin_offsetof > > (EFI_ACPI_6_3_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE,=EF=BF=BD=EF=BF=BD=EF= =BF=BD \ > > + Package.Cluster[cid].Core[coreId].L2Cache), \ > > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Next > > +level of cache > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > > +SIZE_32KB,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > > +=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* = Size > > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > > =BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > > +128,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > > +=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Num of sets > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > > +4,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF > > +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Associativity > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > > +PPTT_DATA_CACHE_ATTR,=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF > =BD=EF=BF=BD > > +/* Attributes > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD \ > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD > > > +64=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF > > +=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD /* Line size > > */=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD \ > > + ), \ > > + \ > [...] > > + > > +#pragma pack(1) > > +typedef struct { > > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR Thread; } > > +RDE1EDGE_PPTT_THREAD; > > + > > +typedef struct { > > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR=EF=BF=BD Core; =EF=BF= =BD > > > +UINT32=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > =BD > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD Offset[2]; > Similarly to the the first patch, I think there should be 3 elements (and= if > possible renamed to 'PrivateResources'). > > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD DCache; =EF=BF=BD > > +EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD ICache; =EF=BF=BD > > +EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD L2Cache; =EF=BF=BD > > +RDE1EDGE_PPTT_THREAD Thread[THREAD_PER_CORE]; } > RDE1EDGE_PPTT_CORE; > > + > > +typedef struct { > > +=EF=BF=BD EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR=EF=BF=BD Cluster; =EF= =BF=BD > > > +UINT32=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF > =BD > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF= =BD=EF=BF=BD=EF=BF=BD=EF=BF=BD Offset; =EF=BF=BD > > +EFI_ACPI_6_3_PPTT_STRUCTURE_CACHE=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD L3Cache; =EF=BF=BD > > > +RDE1EDGE_PPTT_CORE=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF= =BF=BD=EF=BF > =BD=EF=BF=BD > > +=EF=BF=BD=EF=BF=BD=EF=BF=BD Core[CORE_COUNT / > > THREAD_PER_CORE]; > > +} RDE1EDGE_PPTT_CLUSTER; > > + >=20 > Regards, >=20 > Pierre Regards, Pranav