From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=WMZVKvF2; spf=pass (domain: arm.com, ip: 40.107.2.56, mailfrom: alexei.fedorov@arm.com) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.56]) by groups.io with SMTP; Fri, 23 Aug 2019 04:47:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogyucIiyLUPauVRflC8xgOiNqCKtx6ZTWyWCkRFvZIM=; b=WMZVKvF21nqWNXp7bEnVfLkUiB2XwFxVxIpk73tqmDtXqlWdC3qjAWZtPLooYwQ9mreoNabP2v4b0dszZBU2dydLc6pFTzS4eiQDeQckkCmzJWK1+xqiEq5hYVmPksK3xsNAZPdbj8rSmWwhv1JZumF0tuw0D65c4jPZNQByj7g= Received: from DB7PR08CA0026.eurprd08.prod.outlook.com (2603:10a6:5:16::39) by DB6PR0801MB1847.eurprd08.prod.outlook.com (2603:10a6:4:3c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Fri, 23 Aug 2019 11:47:31 +0000 Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::208) by DB7PR08CA0026.outlook.office365.com (2603:10a6:5:16::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.18 via Frontend Transport; Fri, 23 Aug 2019 11:47:31 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.13 via Frontend Transport; Fri, 23 Aug 2019 11:47:29 +0000 Received: ("Tessian outbound 4f2e8f9f1994:v27"); Fri, 23 Aug 2019 11:47:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 71e5e9cbcde2d9c0 X-CR-MTA-TID: 64aa7808 Received: from d9c1eb7fa901.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.4.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id D64ADCFE-567D-4913-A38C-543257305E5B.1; Fri, 23 Aug 2019 11:47:23 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d9c1eb7fa901.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Fri, 23 Aug 2019 11:47:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ETQzMBzIAPdG2TaiJbkyj9jNYH6TkznQjjQlwrdFDOabOZDCJrMEX0DGa1r/5NeQta5BDGMxJ9+urrAeB+tT1gjCRApqj44SS72efDctf4jJZFU1/pGGEhilAFs78SHTbNVObhtMSKroJL2MaPvLScymjhpItcz+cKYyzio+ELN6uStR4S7KfmoefVSnAgdPxR+/xWlApW9vlArKpKW2LRXiN/KjGBPhcUy8mIaPXhMjqsttqUuKFS6D7/dB/g6lss4C+9186X5yMb4d7RE1kf5DMT80C1NR0sZCq7mfERf1tmOvIcKMU8n5p04eWlTkoCnOVvx3gTMkINb6uwIpig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogyucIiyLUPauVRflC8xgOiNqCKtx6ZTWyWCkRFvZIM=; b=LAN65KtfsvaQTLLQDoUeqKvj5k+Z661JqYluFYZ0actrwOqY3wnKfhfy169M0JFuzz0HukhXRvyHl6EZ2/4SmAMRYXKfq3iKQiQyn/YxvMQpbeTXwVXa5OU8aND/3Zy1c2EU6pyCi6MVOKtA1YNjFuipxVZasHRD258BIuGkTS3zaPs7q/FLLMQyzHydxmnqUACYH17UETC8hWoYm+P8l8jA5mcZ8h5mkB6XcCKf/0YztIZve6+k1LNAWG/ht3jjGc+nOuxEnIg/4MuhylrWlMqRz99ABxPWdPeVKxcgWOYEHWTMyJaNRPtUIzMKj8p2cyb4VQFxWYf6DZUMjDFkVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogyucIiyLUPauVRflC8xgOiNqCKtx6ZTWyWCkRFvZIM=; b=WMZVKvF21nqWNXp7bEnVfLkUiB2XwFxVxIpk73tqmDtXqlWdC3qjAWZtPLooYwQ9mreoNabP2v4b0dszZBU2dydLc6pFTzS4eiQDeQckkCmzJWK1+xqiEq5hYVmPksK3xsNAZPdbj8rSmWwhv1JZumF0tuw0D65c4jPZNQByj7g= Received: from AM5PR0801MB1732.eurprd08.prod.outlook.com (10.169.244.21) by AM5PR0801MB1906.eurprd08.prod.outlook.com (10.168.156.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.18; Fri, 23 Aug 2019 11:47:21 +0000 Received: from AM5PR0801MB1732.eurprd08.prod.outlook.com ([fe80::50d7:cef5:ee39:2e83]) by AM5PR0801MB1732.eurprd08.prod.outlook.com ([fe80::50d7:cef5:ee39:2e83%9]) with mapi id 15.20.2178.020; Fri, 23 Aug 2019 11:47:21 +0000 From: "Alexei Fedorov" To: Sami Mujawar , "devel@edk2.groups.io" CC: "leif.lindholm@linaro.org" , Matteo Carlini , nd Subject: Re: [PATCH v1 01/19] DynamicTablesPkg: Fix entry point param definition Thread-Topic: [PATCH v1 01/19] DynamicTablesPkg: Fix entry point param definition Thread-Index: AQHVWaF4WFwKGLQ/BEavDBC/qY/HYKcInb/v Date: Fri, 23 Aug 2019 11:47:21 +0000 Message-ID: References: <20190823105539.13260-1-sami.mujawar@arm.com>,<20190823105539.13260-2-sami.mujawar@arm.com> In-Reply-To: <20190823105539.13260-2-sami.mujawar@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; x-originating-ip: [217.140.106.49] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 2009a545-d193-4a17-d6e2-08d727bfad81 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:AM5PR0801MB1906; X-MS-TrafficTypeDiagnostic: AM5PR0801MB1906:|DB6PR0801MB1847: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:4941;OLM:4941; x-forefront-prvs: 0138CD935C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(136003)(376002)(39860400002)(366004)(189003)(199004)(76176011)(4326008)(19627405001)(26005)(2501003)(9686003)(66066001)(186003)(3846002)(102836004)(25786009)(105004)(6116002)(2906002)(55016002)(99286004)(66946007)(476003)(14444005)(53546011)(7696005)(446003)(76116006)(66446008)(478600001)(256004)(11346002)(66476007)(66556008)(64756008)(8936002)(8676002)(53936002)(52536014)(229853002)(486006)(33656002)(6506007)(19627235002)(81166006)(74316002)(6246003)(316002)(7736002)(71190400001)(71200400001)(54896002)(5660300002)(81156014)(86362001)(54906003)(110136005)(30864003)(14454004)(6436002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0801MB1906;H:AM5PR0801MB1732.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: lNSwFUokpdS9rVDlXvFpVD0DX9laGhk+Dqszm2aPKPAvRpHgwB4ti89OzeNDER1V8y2rV0AVJE13TytVctnpf454zKir8TvLHXR/MCCmewGy/scVtl1v/517/KxUJbTPGzfEa5Mu1NRPjJ+x6tr83cu7mE6i7z+KIbHWQbSNsWZi2CGgtSI23M7vZ9fEAwADuolBehTmorzv2Vi34DCq2Uz3flyF6Drqv7sN82DWdtda6uX8exQk5O5JmErPQpL7YC7yyJdQ2M1VupyS/kxolAMVQ6HWGXPbuP4T/5ZQhmhuXIOTEnh9551EIqU/4htSlLuZfwBTl0pOf/YZd321UTQ0dUjvCqtEJkwO2/H4YBdX/4NCs9kBGFX3eoNX3r0xFxQi5leoV+PlgqxYPO/EIjqU2SzQhYy6dwvdYHfO+fU= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1906 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; Return-Path: Alexei.Fedorov@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(396003)(346002)(376002)(39860400002)(136003)(2980300002)(199004)(189003)(76130400001)(6246003)(33656002)(4326008)(86362001)(54896002)(9686003)(53946003)(55016002)(229853002)(2906002)(7736002)(6116002)(3846002)(74316002)(14454004)(22756006)(81156014)(81166006)(71190400001)(25786009)(8676002)(8936002)(356004)(102836004)(5660300002)(19627405001)(52536014)(36906005)(19627235002)(14444005)(53546011)(6506007)(66066001)(99286004)(26826003)(7696005)(105004)(446003)(76176011)(63350400001)(11346002)(486006)(126002)(476003)(336012)(70586007)(54906003)(26005)(316002)(16586007)(30864003)(110136005)(2501003)(478600001)(186003)(63370400001)(70206006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB1847;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 1c6505c0-9376-49c6-ceba-08d727bfa897 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DB6PR0801MB1847; NoDisclaimer: True X-Forefront-PRVS: 0138CD935C X-Microsoft-Antispam-Message-Info: GhF7sq6CUk+HKlmDrrOQHym10sIs1IrlTPIdVsYpG+jMHVF6l2Nf8SuQwi87hq8emjJM+KKe6LebznX/4QNhfUhjXtmC5r5MlOEYyv04o+H6KaCiS0RffVlrLnN5Mt/u3dYdk3VYSBjMHwLRuSOfvd0Tr9AeRUmNqrdOeKzQxcx1s5DBKzqAuU7HEL4oCzNx5ZszR1TJxkp72AcJ/AykY2u4dFL8amSjgGmHhH39nQvPAdU2XrKqnFX41aDo8jLZ/PaveG7weDEaJJF7Yol+8SK9INldGWEKvlpqXChZBk3UvpRLzhOz1zX/TPjLioox1OfQXgKiHlBXnUHIuHdKj/iItSzyCuHXGnp/XMi9zGjENj5RG5ecHBw1FyQeATZpm/i5RGl+sVByidpXDmzQivB7hfryMNpJBuLJp3m/3B4= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2019 11:47:29.8528 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2009a545-d193-4a17-d6e2-08d727bfad81 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1847 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AM5PR0801MB173200DC3C465EEBC5C80AFD9AA40AM5PR0801MB1732_" --_000_AM5PR0801MB173200DC3C465EEBC5C80AFD9AA40AM5PR0801MB1732_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Alexei Fedorov Alexei ________________________________ From: Sami Mujawar Sent: 23 August 2019 11:55 To: devel@edk2.groups.io Cc: Sami Mujawar ; Alexei Fedorov ; leif.lindholm@linaro.org ; Matteo Carlini = ; nd Subject: [PATCH v1 01/19] DynamicTablesPkg: Fix entry point param definitio= n VS2017 reports 'warning C4028: formal parameter 2 different from declaration' for the library constructor and destructor interfaces for the Generator modules. VS2017 compiler also reports similar warnings for the DXE entry points. Remove the CONST qualifier for the SystemTable pointer (the second parameter to the constructor/destructor/DXE Entry point) to make it compatible with the formal declaration. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c |= 6 +++--- DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c |= 4 ++-- DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c |= 8 ++++---- 11 files changed, 41 insertions(+), 41 deletions(-) diff --git a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFa= ctoryDxe.c b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFa= ctoryDxe.c index d87ea7809eae09cdb5ff06290cff8c2d7e7fa904..d1432348f05143bed8588cea54d= 7b9b6722b9b6d 100644 --- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.c +++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.c @@ -1,7 +1,7 @@ /** @file Dynamic Table Factory Dxe - Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. + Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -60,8 +60,8 @@ EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL DynamicTableFactoryP= rotocol =3D { EFI_STATUS EFIAPI DynamicTableFactoryDxeInitialize ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableMa= nagerDxe.c b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableMa= nagerDxe.c index 39b75996d9922d2daf953bb28809aa285f7d214c..e27dcaf37470d811c4d6218d4f4= 0d2260f550c02 100644 --- a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDx= e.c +++ b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDx= e.c @@ -655,8 +655,8 @@ ProcessAcpiTables ( EFI_STATUS EFIAPI DynamicTableManagerDxeInitialize ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c index 0b45e15d2d1c2c1e35e801ca719d68d9ff88a65e..346ab5b22f5402bf87c385558f6= 8f080d1b454ed 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c @@ -418,8 +418,8 @@ ACPI_TABLE_GENERATOR Dbg2Generator =3D { EFI_STATUS EFIAPI AcpiDbg2LibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -442,8 +442,8 @@ AcpiDbg2LibConstructor ( EFI_STATUS EFIAPI AcpiDbg2LibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c index e9e4991dc127abb97f859436df0c4ceafdb3f5ec..6cb60e898f697ce4347ad3adeb5= bca1cc1f30a0c 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c @@ -648,8 +648,8 @@ ACPI_TABLE_GENERATOR FadtGenerator =3D { EFI_STATUS EFIAPI AcpiFadtLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -671,8 +671,8 @@ AcpiFadtLibConstructor ( EFI_STATUS EFIAPI AcpiFadtLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c index a30870806d7f223fde7311e3609cca92f47731cc..7e86c30649bd36ecebac75c7e3a= 86a0c25cd590b 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c @@ -738,8 +738,8 @@ ACPI_TABLE_GENERATOR GtdtGenerator =3D { EFI_STATUS EFIAPI AcpiGtdtLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -761,8 +761,8 @@ AcpiGtdtLibConstructor ( EFI_STATUS EFIAPI AcpiGtdtLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c index 05e360c899c7563aed04c071921865929524fdc4..f303e9f29cc700634d236c08505= cab91b9d62cb8 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c @@ -2040,8 +2040,8 @@ ACPI_IORT_GENERATOR IortGenerator =3D { EFI_STATUS EFIAPI AcpiIortLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -2063,8 +2063,8 @@ AcpiIortLibConstructor ( EFI_STATUS EFIAPI AcpiIortLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c index dc5238078376746847e7ae14258bbe35ca07ca2c..2651ca15414694c494678bcec65= 5fc882ee2cc0c 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c @@ -795,8 +795,8 @@ ACPI_TABLE_GENERATOR MadtGenerator =3D { EFI_STATUS EFIAPI AcpiMadtLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -818,8 +818,8 @@ AcpiMadtLibConstructor ( EFI_STATUS EFIAPI AcpiMadtLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c index d219e2f04ad6602b8157b048ae840a3094492680..1293ac8e43c8e0ed641b20ba425= 19172bc541b54 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c @@ -329,8 +329,8 @@ ACPI_TABLE_GENERATOR McfgGenerator =3D { EFI_STATUS EFIAPI AcpiMcfgLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -352,8 +352,8 @@ AcpiMcfgLibConstructor ( EFI_STATUS EFIAPI AcpiMcfgLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c index c8713dec625cc18b0806659ffcdc3d9e70411e11..9e42eee9b75bb330833b0f56c98= 947563d9eb821 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c @@ -1492,8 +1492,8 @@ ACPI_PPTT_GENERATOR PpttGenerator =3D { EFI_STATUS EFIAPI AcpiPpttLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -1516,8 +1516,8 @@ AcpiPpttLibConstructor ( EFI_STATUS EFIAPI AcpiPpttLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c= b/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c index 544ea06f0bcb3442b78cf6409846f70ae5360664..2facfaa048115575829c9787084= 876efbe60834a 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c @@ -109,8 +109,8 @@ ACPI_TABLE_GENERATOR RawGenerator =3D { EFI_STATUS EFIAPI AcpiRawLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -132,8 +132,8 @@ AcpiRawLibConstructor ( EFI_STATUS EFIAPI AcpiRawLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c index 7b70ba2c2c55a9a15a569680d1a57b359db4e73d..1404279f828d5c06bb7605cb2fe= 6d864ef7a080e 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c @@ -308,8 +308,8 @@ ACPI_TABLE_GENERATOR SpcrGenerator =3D { EFI_STATUS EFIAPI AcpiSpcrLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -331,8 +331,8 @@ AcpiSpcrLibConstructor ( EFI_STATUS EFIAPI AcpiSpcrLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' --_000_AM5PR0801MB173200DC3C465EEBC5C80AFD9AA40AM5PR0801MB1732_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

Alexei

From: Sami Mujawar <sami= .mujawar@arm.com>
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Al= exei.Fedorov@arm.com>; leif.lindholm@linaro.org <leif.lindholm@linaro= .org>; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com&= gt;
Subject: [PATCH v1 01/19] DynamicTablesPkg: Fix entry point param de= finition
 
VS2017 reports 'warning C4028: formal parameter 2 = different
from declaration' for the library constructor and destructor
interfaces for the Generator modules. VS2017 compiler also
reports similar warnings for the DXE entry points.

Remove the CONST qualifier for the SystemTable pointer (the
second parameter to the constructor/destructor/DXE Entry
point) to make it compatible with the formal declaration.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.c | 6 +++---
 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDx= e.c | 4 ++--
 DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c = ;        | 8 ++++----  DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c = ;        | 8 ++++----  DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c = ;        | 8 ++++----  DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c = ;        | 8 ++++----  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c = ;        | 8 ++++----  DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c = ;        | 8 ++++----  DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c = ;        | 8 ++++----  DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c &= nbsp;         | 8 +++&#= 43;----
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c = ;        | 8 ++++----  11 files changed, 41 insertions(+), 41 deletions(-)

diff --git a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFa= ctoryDxe.c b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFa= ctoryDxe.c
index d87ea7809eae09cdb5ff06290cff8c2d7e7fa904..d1432348f05143bed8588cea54d= 7b9b6722b9b6d 100644
--- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.c
+++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTa= bleFactoryDxe.c
@@ -1,7 +1,7 @@
 /** @file
   Dynamic Table Factory Dxe
 
-  Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
+  Copyright (c) 2017 - 2019, ARM Limited. All rights reserved.  
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -60,8 +60,8 @@ EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL DynamicTableFact= oryProtocol =3D {
 EFI_STATUS
 EFIAPI
 DynamicTableFactoryDxeInitialize (
-  IN  EFI_HANDLE        =          ImageHandle,
-  IN  EFI_SYSTEM_TABLE   * CONST SystemTable
+  IN  EFI_HANDLE       &n= bsp;    ImageHandle,
+  IN  EFI_SYSTEM_TABLE   *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableMa= nagerDxe.c b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableMa= nagerDxe.c
index 39b75996d9922d2daf953bb28809aa285f7d214c..e27dcaf37470d811c4d6218d4f4= 0d2260f550c02 100644
--- a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDx= e.c
+++ b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTa= bleManagerDxe.c
@@ -655,8 +655,8 @@ ProcessAcpiTables (
 EFI_STATUS
 EFIAPI
 DynamicTableManagerDxeInitialize (
-  IN CONST EFI_HANDLE        =          ImageHandle,
-  IN       EFI_SYSTEM_TABLE  = * CONST SystemTable
+  IN  EFI_HANDLE       &n= bsp;    ImageHandle,
+  IN  EFI_SYSTEM_TABLE   *  SystemTable
   )
 {
   EFI_STATUS        &nbs= p;            &= nbsp;           Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
index 0b45e15d2d1c2c1e35e801ca719d68d9ff88a65e..346ab5b22f5402bf87c385558f6= 8f080d1b454ed 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Gene= rator.c
@@ -418,8 +418,8 @@ ACPI_TABLE_GENERATOR Dbg2Generator =3D {
 EFI_STATUS
 EFIAPI
 AcpiDbg2LibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -442,8 +442,8 @@ AcpiDbg2LibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiDbg2LibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c
index e9e4991dc127abb97f859436df0c4ceafdb3f5ec..6cb60e898f697ce4347ad3adeb5= bca1cc1f30a0c 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGene= rator.c
@@ -648,8 +648,8 @@ ACPI_TABLE_GENERATOR FadtGenerator =3D {
 EFI_STATUS
 EFIAPI
 AcpiFadtLibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -671,8 +671,8 @@ AcpiFadtLibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiFadtLibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c
index a30870806d7f223fde7311e3609cca92f47731cc..7e86c30649bd36ecebac75c7e3a= 86a0c25cd590b 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGene= rator.c
@@ -738,8 +738,8 @@ ACPI_TABLE_GENERATOR GtdtGenerator =3D {
 EFI_STATUS
 EFIAPI
 AcpiGtdtLibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -761,8 +761,8 @@ AcpiGtdtLibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiGtdtLibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c
index 05e360c899c7563aed04c071921865929524fdc4..f303e9f29cc700634d236c08505= cab91b9d62cb8 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGene= rator.c
@@ -2040,8 +2040,8 @@ ACPI_IORT_GENERATOR IortGenerator =3D {
 EFI_STATUS
 EFIAPI
 AcpiIortLibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -2063,8 +2063,8 @@ AcpiIortLibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiIortLibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c
index dc5238078376746847e7ae14258bbe35ca07ca2c..2651ca15414694c494678bcec65= 5fc882ee2cc0c 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGene= rator.c
@@ -795,8 +795,8 @@ ACPI_TABLE_GENERATOR MadtGenerator =3D {
 EFI_STATUS
 EFIAPI
 AcpiMadtLibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -818,8 +818,8 @@ AcpiMadtLibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiMadtLibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c
index d219e2f04ad6602b8157b048ae840a3094492680..1293ac8e43c8e0ed641b20ba425= 19172bc541b54 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGene= rator.c
@@ -329,8 +329,8 @@ ACPI_TABLE_GENERATOR McfgGenerator =3D {
 EFI_STATUS
 EFIAPI
 AcpiMcfgLibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -352,8 +352,8 @@ AcpiMcfgLibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiMcfgLibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
index c8713dec625cc18b0806659ffcdc3d9e70411e11..9e42eee9b75bb330833b0f56c98= 947563d9eb821 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGene= rator.c
@@ -1492,8 +1492,8 @@ ACPI_PPTT_GENERATOR PpttGenerator =3D {
 EFI_STATUS
 EFIAPI
 AcpiPpttLibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -1516,8 +1516,8 @@ AcpiPpttLibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiPpttLibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c= b/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c
index 544ea06f0bcb3442b78cf6409846f70ae5360664..2facfaa048115575829c9787084= 876efbe60834a 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenera= tor.c
@@ -109,8 +109,8 @@ ACPI_TABLE_GENERATOR RawGenerator =3D {
 EFI_STATUS
 EFIAPI
 AcpiRawLibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -132,8 +132,8 @@ AcpiRawLibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiRawLibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
index 7b70ba2c2c55a9a15a569680d1a57b359db4e73d..1404279f828d5c06bb7605cb2fe= 6d864ef7a080e 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGene= rator.c
@@ -308,8 +308,8 @@ ACPI_TABLE_GENERATOR SpcrGenerator =3D {
 EFI_STATUS
 EFIAPI
 AcpiSpcrLibConstructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
@@ -331,8 +331,8 @@ AcpiSpcrLibConstructor (
 EFI_STATUS
 EFIAPI
 AcpiSpcrLibDestructor (
-  IN CONST EFI_HANDLE        =         ImageHandle,
-  IN       EFI_SYSTEM_TABLE  * CON= ST SystemTable
+  IN  EFI_HANDLE       &n= bsp;   ImageHandle,
+  IN  EFI_SYSTEM_TABLE  *  SystemTable
   )
 {
   EFI_STATUS  Status;
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


--_000_AM5PR0801MB173200DC3C465EEBC5C80AFD9AA40AM5PR0801MB1732_--