From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ClXx3SDJ; spf=pass (domain: arm.com, ip: 40.107.15.74, mailfrom: alexei.fedorov@arm.com) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.74]) by groups.io with SMTP; Fri, 23 Aug 2019 04:52:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VUpM/88ah/ZTefeRPNV9jAibzxpCC7XdlyJGt3gvgt8=; b=ClXx3SDJwQtgKIv6X6+jBs1iKYlL79rxZAkdCCaVnw682+boMzVygsuAfQOibuYZMSV4tl7UngAjgs6qaEGIjxvXA4Zn19I+bY2vBXuO7XqdkkM0Rp0TA3V73zgRGbdJaIWnFkq5fCK4qCRcSDiymEGmUDvUHJ07RbdiSB8/HS0= Received: from VI1PR08CA0213.eurprd08.prod.outlook.com (2603:10a6:802:15::22) by DB6PR0801MB1846.eurprd08.prod.outlook.com (2603:10a6:4:35::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Fri, 23 Aug 2019 11:52:46 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::208) by VI1PR08CA0213.outlook.office365.com (2603:10a6:802:15::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.18 via Frontend Transport; Fri, 23 Aug 2019 11:52:46 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.13 via Frontend Transport; Fri, 23 Aug 2019 11:52:44 +0000 Received: ("Tessian outbound 0c23f37acac0:v27"); Fri, 23 Aug 2019 11:52:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4cc0e4fa378831ce X-CR-MTA-TID: 64aa7808 Received: from f50181db3d58.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.4.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 008ED75C-5997-4E9B-8F84-32A5D0645E43.1; Fri, 23 Aug 2019 11:52:38 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2054.outbound.protection.outlook.com [104.47.4.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f50181db3d58.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 23 Aug 2019 11:52:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HjhMDEGCiTZbPXgrHQo7qiyFQQcjfSpEQt6FMbT+lyDMFhoapnSn7/U8DJk8pN0D4Iq92uRXp7XUFc7US+x2SHLNDRguS1o/7vOwe+aafaXw0f3XsGm036hPvsfmFp1OouYU5+2wIgYYkbU/dMvhCA+lzMjDmdhYxOVum39TzJY9cukWDSXLUNUqQbjvtoH30P3DWkKanF4rbGXmys8jHCbaUUZwwWw/LkzGCfpJm6KbF4MiYJTyTKu044rTDrEHCHBcQUxWVNuIyi8tEkSGqtzW6zEAEOBT5J1wh3MY/dSN3wk5bPJ0wMLwWD74Tr/6+s4TXPl2ojx1pH6h2Ks6Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ifSZQ0colOHCp43zYU9UUHsQ2AK6faXrCrDh+Y1fZ0=; b=Qw9m7d2nLSPkvwlVums5O1zMLDczJXQMvVjEYpn+SW0FNHZQf6X2wgFOgZXF16vJ6vvSprYObwCVIVWM1OVRgpWUWGZTn0FWiU153RVMa7XUOoYvohnz8x9T4h5Uoe7Ehqo0jEQgeP4uOxqSi01Ea2lYQCc4zLM7goyDtiNRnAaX8yKD1QTkif5DHsp6MIYkG/B2JAm+AJ+UP2dwUWPbklMZx7WsQPa3jmHleS4uLRxWRq5bKJO81gDwV6Cuizl+Y29l2EOOm/U648ThX0OaaQ8cXvzfDcJ8fFJmxu4HeY6RXZRPGTlpBrQahjATBmEgUoqOYDv2cffD7nI9tYZRQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ifSZQ0colOHCp43zYU9UUHsQ2AK6faXrCrDh+Y1fZ0=; b=vCgvBageLMQJ9ILkZrW5gX9oyeFHWoWYyuYFS9KfTFG84VTHxa4/jZCqAM0eOBeu43sc5coeid+dvlMHW+zYa0/IWTapY4zwHIIkrV7IjNWk8Bx4K+phmjPHrNLKC/e16OYncPv60HPglflOntakGOZ3o4seZe3Vc1ClTCTFLV8= Received: from AM5PR0801MB1732.eurprd08.prod.outlook.com (10.169.244.21) by AM5PR0801MB1906.eurprd08.prod.outlook.com (10.168.156.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.18; Fri, 23 Aug 2019 11:52:37 +0000 Received: from AM5PR0801MB1732.eurprd08.prod.outlook.com ([fe80::50d7:cef5:ee39:2e83]) by AM5PR0801MB1732.eurprd08.prod.outlook.com ([fe80::50d7:cef5:ee39:2e83%9]) with mapi id 15.20.2178.020; Fri, 23 Aug 2019 11:52:37 +0000 From: "Alexei Fedorov" To: Sami Mujawar , "devel@edk2.groups.io" Subject: Re: [PATCH v1 11/19] DynamicTablesPkg: Remove redundant frame count check Thread-Topic: [PATCH v1 11/19] DynamicTablesPkg: Remove redundant frame count check Thread-Index: AQHVWaGOFJ64b4rlZUe5nKjUE+vsvacInzg0 Date: Fri, 23 Aug 2019 11:52:37 +0000 Message-ID: References: <20190823105539.13260-1-sami.mujawar@arm.com>,<20190823105539.13260-12-sami.mujawar@arm.com> In-Reply-To: <20190823105539.13260-12-sami.mujawar@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; x-originating-ip: [217.140.106.49] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 68ea1581-92e3-49b8-f3fb-08d727c068ee X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:AM5PR0801MB1906; X-MS-TrafficTypeDiagnostic: AM5PR0801MB1906:|DB6PR0801MB1846: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:2043;OLM:2043; x-forefront-prvs: 0138CD935C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(136003)(376002)(39860400002)(366004)(189003)(199004)(76176011)(19627405001)(26005)(2501003)(9686003)(66066001)(186003)(3846002)(102836004)(25786009)(105004)(6116002)(2906002)(55016002)(99286004)(66946007)(476003)(14444005)(53546011)(7696005)(446003)(76116006)(66446008)(478600001)(256004)(11346002)(66476007)(66556008)(64756008)(8936002)(8676002)(53936002)(52536014)(229853002)(486006)(33656002)(6506007)(81166006)(74316002)(6246003)(316002)(7736002)(71190400001)(71200400001)(54896002)(5660300002)(81156014)(86362001)(110136005)(14454004)(6436002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0801MB1906;H:AM5PR0801MB1732.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: qOpkNKSJ3xuFpXhF2JhYxiCPp1xRPBDSZlxRSSsX+kvhFjdgArmsdJywID3mZYuo83eZAIPB6ERCKzFvqURROhxbNGz9l1GTWDlFatwgw6EM1Ul9zKP98/ho5IMqnlI6bVh4Dn6T2D0ThHgdfR6Njwwnp2naOr4fXk7GkPKw16nhRHee+qbRpVwHCIEA2g614OMi+hZpKbPOPww79lumNUP+xsOCndVl3eg1zJFnOOBUOCMZF3n7ezRooNrhFe7s7AzKJiy+jXf8OBb5nPTH8GucxBjQ2D+0FQTnGd7IXyElPGyN33oTqjN0XNHXTgB0zBwyH7ytE5WDQsq6YcvIhMeIGLXIvxSMaLuMxe+2OQ9G/7wYfDvWGuFt0p+VzVu1eYu5wQ/hFm9AgtoA2ycBOAKyOwa8fo/fTCZx/Obx+8Q= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1906 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; Return-Path: Alexei.Fedorov@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(376002)(39860400002)(136003)(2980300002)(199004)(189003)(40434004)(9686003)(5660300002)(19627405001)(70206006)(81156014)(81166006)(33656002)(76130400001)(5024004)(26826003)(14444005)(7696005)(14454004)(70586007)(478600001)(476003)(22756006)(8676002)(76176011)(36906005)(8936002)(126002)(11346002)(2501003)(316002)(53546011)(110136005)(446003)(63350400001)(6506007)(16586007)(63370400001)(55016002)(74316002)(356004)(6246003)(229853002)(7736002)(25786009)(2906002)(105004)(336012)(71190400001)(6116002)(86362001)(66066001)(26005)(102836004)(486006)(99286004)(54896002)(52536014)(186003)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB1846;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 28624715-cd12-4080-9c68-08d727c0651c X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DB6PR0801MB1846; X-Forefront-PRVS: 0138CD935C X-Microsoft-Antispam-Message-Info: FzaDMzG16r0TMwGgdHlh6l288tS261AhUv8/owT3ORYPhv2zzkMs6YrVJqusYIdZZLaDt8J3E5+zQZAisC96ajd2ncN2SuRvKqFVbsuwzDToVLx227aWjBzMCdqPU5IgnXQZQ8d5Q8TldTEsvz9CRD1opZ29Pw896Jn36NRTJR7UGcGBNA/l2Wcxl+T/suhtqQm2oaYoUHLkBxbfI5dCPS5V5xDvtHrvL3pJjkhp7Gv8yAVAojIg8kVlEzvtXj1lUEW8m4Q7cFQ2k+R3YLT67fE9SaWEXw1RIvyRDiQbDDJ1coEgaHb55tnOS638G42mv0lUH6SenxdRXs+oufsPYUGiQgKX6S3NXWTpCEKSygMtsTWsOtKDet3bP8vOGAREYTDp4XwxL6rTYJcn7JM8BA6Y8jG4cO/25Zos/8SgGYQ= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2019 11:52:44.3148 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68ea1581-92e3-49b8-f3fb-08d727c068ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1846 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AM5PR0801MB1732887EA6B7CF444DF015DD9AA40AM5PR0801MB1732_" --_000_AM5PR0801MB1732887EA6B7CF444DF015DD9AA40AM5PR0801MB1732_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Alexei Fedorov Alexei ________________________________ From: Sami Mujawar Sent: 23 August 2019 11:55 To: devel@edk2.groups.io Cc: Sami Mujawar ; Alexei Fedorov ; leif.lindholm@linaro.org ; Matteo Carlini = ; nd Subject: [PATCH v1 11/19] DynamicTablesPkg: Remove redundant frame count ch= eck Removing GT Block frame count check from AddGTBlockTimerFrames() as this is already validated in BuildGtdtTable(). Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 10 ----= ------ 1 file changed, 10 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c index 0e996698887aefca8a7240fc27fe3cb9324fd3e2..c109f2ac207311646e5a4ad3aa4= 65b1c2883e465 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c @@ -259,16 +259,6 @@ AddGTBlockTimerFrames ( ASSERT (GtBlockFrame !=3D NULL); ASSERT (GTBlockTimerFrameList !=3D NULL); - if (GTBlockFrameCount > 8) { - DEBUG (( - DEBUG_ERROR, - "ERROR: GTDT: GT Block Frame Count %d is greater than 8\n", - GTBlockFrameCount - )); - ASSERT (GTBlockFrameCount <=3D 8); - return EFI_INVALID_PARAMETER; - } - IsFrameNumberDuplicated =3D FindDuplicateValue ( GTBlockTimerFrameList, GTBlockFrameCount, -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. --_000_AM5PR0801MB1732887EA6B7CF444DF015DD9AA40AM5PR0801MB1732_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

Alexei

From: Sami Mujawar <sami= .mujawar@arm.com>
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Al= exei.Fedorov@arm.com>; leif.lindholm@linaro.org <leif.lindholm@linaro= .org>; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com&= gt;
Subject: [PATCH v1 11/19] DynamicTablesPkg: Remove redundant frame c= ount check
 
Removing GT Block frame count check from AddGTBloc= kTimerFrames()
as this is already validated in BuildGtdtTable().

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 10= ----------
 1 file changed, 10 deletions(-)

diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c
index 0e996698887aefca8a7240fc27fe3cb9324fd3e2..c109f2ac207311646e5a4ad3aa4= 65b1c2883e465 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGene= rator.c
@@ -259,16 +259,6 @@ AddGTBlockTimerFrames (
   ASSERT (GtBlockFrame !=3D NULL);
   ASSERT (GTBlockTimerFrameList !=3D NULL);
 
-  if (GTBlockFrameCount > 8) {
-    DEBUG ((
-      DEBUG_ERROR,
-      "ERROR: GTDT: GT Block Frame Count %d = is greater than 8\n",
-      GTBlockFrameCount
-      ));
-    ASSERT (GTBlockFrameCount <=3D 8);
-    return EFI_INVALID_PARAMETER;
-  }
-
   IsFrameNumberDuplicated =3D FindDuplicateValue (
            &nb= sp;            =       GTBlockTimerFrameList,
            &nb= sp;            =       GTBlockFrameCount,
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in any medium. Thank you. --_000_AM5PR0801MB1732887EA6B7CF444DF015DD9AA40AM5PR0801MB1732_--