From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=u+vgxupY; spf=pass (domain: arm.com, ip: 40.107.15.70, mailfrom: alexei.fedorov@arm.com) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.70]) by groups.io with SMTP; Fri, 23 Aug 2019 04:53:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n8fds2btx1dHB8MnehSmaz2rKX30Q98wj6kdrHzN31Q=; b=u+vgxupY0lIA3LtCH9BEDkA5ASRaRW+DmEYD1nKwPvlISXObtmJtztc8eI/cQKkXtyxUzLuwV2BXL/87jnOIpG1l0oXcboPsMXKn5god2gH3vxYTCwb+kxDIBVRNT2tdU1/VPKBoEEqhS0GbNavYvIZuCyZvEj8ATv7qdGGK59M= Received: from VI1PR08CA0112.eurprd08.prod.outlook.com (2603:10a6:800:d4::14) by VI1PR0801MB1853.eurprd08.prod.outlook.com (2603:10a6:800:5a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.19; Fri, 23 Aug 2019 11:53:28 +0000 Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::204) by VI1PR08CA0112.outlook.office365.com (2603:10a6:800:d4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2199.14 via Frontend Transport; Fri, 23 Aug 2019 11:53:28 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2199.13 via Frontend Transport; Fri, 23 Aug 2019 11:53:28 +0000 Received: ("Tessian outbound df6366865adf:v27"); Fri, 23 Aug 2019 11:53:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 80b8b3aedf8661c2 X-CR-MTA-TID: 64aa7808 Received: from f0a462620ac4.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.4.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id E89D3DA8-609C-485F-AF0A-930A2A424D4F.1; Fri, 23 Aug 2019 11:53:22 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2056.outbound.protection.outlook.com [104.47.4.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f0a462620ac4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 23 Aug 2019 11:53:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXuY26luoRVgHG9+syoyuiStwueWSU8RaImavpgp9slIRJw3XgIGogYVK+VgXSNTrBSCCGUGqhZXhthjGakfWoIXUfPIje/FE5FqEajW+nhvQ1kpxYPlj+LX6DgjarGl8GvpufcienE3976APnoWuUWr1cEY1MwLNS2kQ2vRAUop/6YRs1URnHsjRUeXQcnrNZgAoF5G4j5l78xn/yVXnkEEb28cYrCFJGhFne2pcVP6xWnLh6zvFaoEaMYLAb1xgYbtvwyOWNJapDNXb4UF4BEdy9hgvwod6K09a1z5YgmVLGdWkDGdjTMreXlVoU/KHDvUK4SgnOP9XnpRGV4AvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cF5PhMGeBA2EcKb6f7C3UXPL1Qn+gG4PghHQBHLt9R8=; b=g8HX4GCEeuhLYV98OhTpie6L+wmQk6fdHRX9Qby5hyygxy4LIf4cyu6j2GDxzYuJzVEp034QGB2ZCjFQKOUcl0Q2WBx8PElF+gRkzJ9+z0tLBq3/XLj8frh54sSUNru/DdKTdv/BHd0TzrxihgNRHL0+0j2OotQScY2cM8H/skXIql492je7oy57Jix1AFc5BmEkelhNwO4nEZxLEPU2t6ujvXAytTiEPmioQW3IzFTS72SqitHaoCyqta99sS4smn7UkwbOX5baXIZqOW6OdhdYCYE6geFupZEuUjxBPP+pFWzSS1KUI9OG60ztYNDShQSGWC423LgYDaQrKGgcXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cF5PhMGeBA2EcKb6f7C3UXPL1Qn+gG4PghHQBHLt9R8=; b=1hqPFd3Ob1v1ldZawpzKdh4gs3ndrvYwEqBp4h/TG+yttK4YjH0MATjyISeDugawrLJt4bILdfJN2futcdh6wQ1MijGWouLyeePjaaCKUD/XkNOX8hIop8GWNeBYeXh8ozQBuRcgqW7DueasyxVB7R8RqDJHqg4uqh7qKBlqAoA= Received: from AM5PR0801MB1732.eurprd08.prod.outlook.com (10.169.244.21) by AM5PR0801MB1906.eurprd08.prod.outlook.com (10.168.156.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.18; Fri, 23 Aug 2019 11:53:21 +0000 Received: from AM5PR0801MB1732.eurprd08.prod.outlook.com ([fe80::50d7:cef5:ee39:2e83]) by AM5PR0801MB1732.eurprd08.prod.outlook.com ([fe80::50d7:cef5:ee39:2e83%9]) with mapi id 15.20.2178.020; Fri, 23 Aug 2019 11:53:21 +0000 From: "Alexei Fedorov" To: Sami Mujawar , "devel@edk2.groups.io" Subject: Re: [PATCH v1 08/19] DynamicTablesPkg: Fix ACPI table rev field width Thread-Topic: [PATCH v1 08/19] DynamicTablesPkg: Fix ACPI table rev field width Thread-Index: AQHVWaGGiHgczdUF/USeTs1iW5i06qcIn232 Date: Fri, 23 Aug 2019 11:53:21 +0000 Message-ID: References: <20190823105539.13260-1-sami.mujawar@arm.com>,<20190823105539.13260-9-sami.mujawar@arm.com> In-Reply-To: <20190823105539.13260-9-sami.mujawar@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; x-originating-ip: [217.140.106.49] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c49ac7d9-5a5e-4168-3450-08d727c08313 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:AM5PR0801MB1906; X-MS-TrafficTypeDiagnostic: AM5PR0801MB1906:|VI1PR0801MB1853: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; x-forefront-prvs: 0138CD935C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(136003)(376002)(39860400002)(366004)(189003)(199004)(76176011)(19627405001)(26005)(2501003)(9686003)(66066001)(186003)(3846002)(102836004)(25786009)(105004)(6116002)(2906002)(55016002)(99286004)(66946007)(476003)(14444005)(53546011)(7696005)(446003)(76116006)(66446008)(478600001)(256004)(11346002)(66476007)(66556008)(64756008)(8936002)(8676002)(53936002)(52536014)(229853002)(486006)(33656002)(6506007)(81166006)(74316002)(6246003)(316002)(7736002)(71190400001)(71200400001)(54896002)(5660300002)(81156014)(86362001)(110136005)(14454004)(6436002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0801MB1906;H:AM5PR0801MB1732.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: ZC3iKcP2c0X0vJVwWk3thA/nKRILdobrazr5bi2BKpWDQpI3ALau8jR30sQv57agRum7EBL6sVMtZeSUHxfjTXpg9nTfJ5voaX68tdKcSH/0Q4KOSwiXbcjBX9dXZY9ckPwCCmIR0l7yvGo0bgKjDRiS8PaGzX5JVZEuQLmpNosFIDIeONCuhNlkBPSLSOzXrFffUldjU6yFeIEbeSWneAB9UT0rJlCbuULTDP5XeNC9ETl9FtFNb7Zr+mK6XcM6V8TAONXvLTfg9sfWZ6dOU5L9V0SYHMt4fWGMAcgv6abHS0tWzzBfoxGqlV5X7j6zKsGh6H11c1QpAuWMMAKr0LEusTv9/bXouSBbH3EnWeCSaHexx7PfSsdaxtFPEFe24aZfE8zFr2kkr/hf+SQ1jGbS2DFNcQoqLxOBCiBr9mw= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1906 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexei.Fedorov@arm.com; Return-Path: Alexei.Fedorov@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(136003)(346002)(396003)(376002)(2980300002)(40434004)(199004)(189003)(446003)(81166006)(81156014)(53546011)(102836004)(16586007)(36906005)(8676002)(26005)(76130400001)(229853002)(86362001)(5660300002)(316002)(70206006)(70586007)(6246003)(6506007)(110136005)(14454004)(486006)(26826003)(22756006)(14444005)(5024004)(126002)(476003)(76176011)(105004)(6116002)(3846002)(99286004)(19627405001)(54896002)(55016002)(9686003)(71190400001)(478600001)(33656002)(186003)(356004)(52536014)(66066001)(74316002)(8936002)(2906002)(25786009)(336012)(11346002)(63350400001)(63370400001)(7736002)(7696005)(2501003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0801MB1853;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 5424673b-a7ce-480b-604c-08d727c07f3a X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:VI1PR0801MB1853; X-Forefront-PRVS: 0138CD935C X-Microsoft-Antispam-Message-Info: 0xoL7HGyl5k6nQvAYfZHd9A62wVHMrGwtG6hEskKI+pjVAPO9wXyB/N2UBkIrqt27io44mTT/iGQVLdXnKWhu/F/a9zdD0Pq/vDSyRQ1rQrRlaQ0JRcpn+maIS3fzmStkE1qAWrGn8PUVzmkgfUcTZIWoPfuUftW9LHpaJXCqoQuIw0hfGygAcQEbTykHHNzbEQsSqnvBQTwD1aPSnfSHT8D+1zyEomvGpPmoQU4dUrRUl2ZsU85eJgPUtT42DD1Q5BAH30n0L8hrgE+yr504VCcBIHQvOYKbFF/VbixqhkG4o7oQKd9jH6f44ZtxpeOD0ytevPTiAoWiqciWoVUyt5znBuc2yJWv+ZBhhd1R41zR8yeavEBDLInPMqU0Lbs5wd2kniJrx5jY9N0eeoTe7MttNl5oKbXR1S/A8uehUU= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2019 11:53:28.0821 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c49ac7d9-5a5e-4168-3450-08d727c08313 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1853 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_AM5PR0801MB1732CDD41F6E9B6F8CCC6FB59AA40AM5PR0801MB1732_" --_000_AM5PR0801MB1732CDD41F6E9B6F8CCC6FB59AA40AM5PR0801MB1732_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Alexei Fedorov Alexei ________________________________ From: Sami Mujawar Sent: 23 August 2019 11:55 To: devel@edk2.groups.io Cc: Sami Mujawar ; Alexei Fedorov ; leif.lindholm@linaro.org ; Matteo Carlini = ; nd Subject: [PATCH v1 08/19] DynamicTablesPkg: Fix ACPI table rev field width The VS2017 compiler reports 'warning C4244: '=3D': conversion from 'const UINT32' to 'UINT8', possible loss of data' when the ACPI table revision field is being updated. The width of the revision field in the EFI_ACPI_DESCRIPTION_HEADER struct is 8-bit wide. Therefore, to fix the above warning make the ACPI Table revision field usage 8-bit wide across Dynamic Tables Framework. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 ++-- DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DynamicTablesPkg/Include/AcpiTableGenerator.h b/DynamicTablesP= kg/Include/AcpiTableGenerator.h index 7d6d3442276db7b4abaeb3b053ba489258adea0b..d7a1209c4d40c2e6ffb3dac786c= 276a30d70b6df 100644 --- a/DynamicTablesPkg/Include/AcpiTableGenerator.h +++ b/DynamicTablesPkg/Include/AcpiTableGenerator.h @@ -284,10 +284,10 @@ typedef struct AcpiTableGenerator { UINT32 AcpiTableSignature; /// The ACPI table revision. - UINT32 AcpiTableRevision; + UINT8 AcpiTableRevision; /// The minimum supported ACPI table revision. - UINT32 MinAcpiTableRevision; + UINT8 MinAcpiTableRevision; /// The ACPI table creator ID. UINT32 CreatorId; diff --git a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h b/DynamicT= ablesPkg/Include/StandardNameSpaceObjects.h index 21bb7de4044ffd6f97156f761e30fc1790f11c0c..0ba6b163691ea127ae7a7d57fb5= f9fdf84789338 100644 --- a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h @@ -79,7 +79,7 @@ typedef struct CmAStdObjAcpiTableInfo { UINT32 AcpiTableSignature; /// The ACPI table revision - UINT32 AcpiTableRevision; + UINT8 AcpiTableRevision; /// The ACPI Table Generator ID ACPI_TABLE_GENERATOR_ID TableGeneratorId; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. --_000_AM5PR0801MB1732CDD41F6E9B6F8CCC6FB59AA40AM5PR0801MB1732_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

Alexei

From: Sami Mujawar <sami= .mujawar@arm.com>
Sent: 23 August 2019 11:55
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Alexei Fedorov <Al= exei.Fedorov@arm.com>; leif.lindholm@linaro.org <leif.lindholm@linaro= .org>; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com&= gt;
Subject: [PATCH v1 08/19] DynamicTablesPkg: Fix ACPI table rev field= width
 
The VS2017 compiler reports 'warning C4244: '=3D':= conversion from
'const UINT32' to 'UINT8', possible loss of data' when the ACPI
table revision field is being updated.

The width of the revision field in the EFI_ACPI_DESCRIPTION_HEADER
struct is 8-bit wide. Therefore, to fix the above warning make the
ACPI Table revision field usage 8-bit wide across Dynamic Tables
Framework.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 DynamicTablesPkg/Include/AcpiTableGenerator.h    =    | 4 ++--
 DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/DynamicTablesPkg/Include/AcpiTableGenerator.h b/DynamicTablesP= kg/Include/AcpiTableGenerator.h
index 7d6d3442276db7b4abaeb3b053ba489258adea0b..d7a1209c4d40c2e6ffb3dac786c= 276a30d70b6df 100644
--- a/DynamicTablesPkg/Include/AcpiTableGenerator.h
+++ b/DynamicTablesPkg/Include/AcpiTableGenerator.h
@@ -284,10 +284,10 @@ typedef struct AcpiTableGenerator {
   UINT32         &n= bsp;            = ;           AcpiTableSign= ature;
 
   /// The ACPI table revision.
-  UINT32          &= nbsp;           &nbs= p;          AcpiTableRevision;=
+  UINT8         &nbs= p;            &= nbsp;           AcpiTable= Revision;
 
   /// The minimum supported ACPI table revision.
-  UINT32          &= nbsp;           &nbs= p;          MinAcpiTableRevisi= on;
+  UINT8         &nbs= p;            &= nbsp;           MinAcpiTa= bleRevision;
 
   /// The ACPI table creator ID.
   UINT32         &n= bsp;            = ;           CreatorId; diff --git a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h b/DynamicT= ablesPkg/Include/StandardNameSpaceObjects.h
index 21bb7de4044ffd6f97156f761e30fc1790f11c0c..0ba6b163691ea127ae7a7d57fb5= f9fdf84789338 100644
--- a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h
+++ b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h
@@ -79,7 +79,7 @@ typedef struct CmAStdObjAcpiTableInfo {
   UINT32         &n= bsp;            = ;   AcpiTableSignature;
 
   /// The ACPI table revision
-  UINT32          &= nbsp;           &nbs= p;  AcpiTableRevision;
+  UINT8         &nbs= p;            &= nbsp;   AcpiTableRevision;
 
   /// The ACPI Table Generator ID
   ACPI_TABLE_GENERATOR_ID      &nb= sp; TableGeneratorId;
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in any medium. Thank you. --_000_AM5PR0801MB1732CDD41F6E9B6F8CCC6FB59AA40AM5PR0801MB1732_--