public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Evan Lloyd <Evan.Lloyd@arm.com>
To: "edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Cc: "ryan.harkin@linaro.org" <ryan.harkin@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 0/4] HardwareInterrupt2 protocol
Date: Mon, 13 Feb 2017 15:51:58 +0000	[thread overview]
Message-ID: <AM5PR0801MB176218F7EB3B05C38C234A648B590@AM5PR0801MB1762.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20170209192623.262044-1-evan.lloyd@arm.com>

I'd like to make something clear here.  We found a problem and solicited opinion.
Ard very helpfully proposed a solution, complete with a rapid response example patch.
However, it was code he wrote quickly to propose a solution - and I imagine he didn't expect it to go directly into the code line.
We submitted his patches as sent, because we felt we should not take credit for his excellent work.
So any problems here are our fault, not Ard's - and he didn't get to review things before submission.
I'll tidy things up, and try again.

Evan

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>evan.lloyd@arm.com
>Sent: 09 February 2017 19:26
>To: edk2-devel@ml01.01.org
>Cc: ryan.harkin@linaro.org; Leif Lindholm; ard.biesheuvel@linaro.org
>Subject: [edk2] [PATCH 0/4] HardwareInterrupt2 protocol
>
>From: Evan Lloyd <evan.lloyd@arm.com>
>
>This series of patches corrects a problem detected on the ARM Juno
>platform that is actually generic (at least to ARM GIC platforms).
>The HardwareInterrupt protocol had no means of handling characteristics
>like Edge/Level triggered and polarity.
>
>A new HardwareInterrupt2 protocol (provided by Ard) is added,
>and code changed to utilise the new capabilities.
>
>The code is available for examination on Github at:
>    https://github.com/EvanLloyd/tianocore/tree/376_irqtype_v1
>
>Ard Biesheuvel (3):
>  EmbeddedPkg: introduce HardwareInterrupt2 protocol
>  ArmPkg/ArmGicDxe: expose HardwareInterrupt2 protocol
>  ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type
>
>Girish Pathak (1):
>  ArmPkg:Provide GetTriggerType/SetTriggerType functions
>
> EmbeddedPkg/EmbeddedPkg.dec                              |   1 +
> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf                      |   1 +
> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf |   4 +-
> ArmPkg/Drivers/ArmGic/ArmGicDxe.h                        |   2 +
> ArmPkg/Include/Library/ArmGicLib.h                       |   4 +
> EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h        | 181
>++++++++++++++++++++
> ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c                  |   2 +
> ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c                | 181
>+++++++++++++++++++-
> ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c                | 178
>++++++++++++++++++-
> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c   |  27 +--
> 10 files changed, 567 insertions(+), 14 deletions(-)
> create mode 100644
>EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h
>
>--
>Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


  parent reply	other threads:[~2017-02-13 15:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 19:26 [PATCH 0/4] HardwareInterrupt2 protocol evan.lloyd
2017-02-09 19:26 ` [PATCH 1/4] EmbeddedPkg: introduce " evan.lloyd
2017-02-13 12:26   ` Leif Lindholm
2017-02-09 19:26 ` [PATCH 2/4] ArmPkg/ArmGicDxe: expose " evan.lloyd
2017-02-13 12:21   ` Leif Lindholm
2017-02-13 12:26     ` Ard Biesheuvel
2017-02-09 19:26 ` [PATCH 3/4] ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type evan.lloyd
2017-02-13 12:30   ` Leif Lindholm
2017-02-09 19:26 ` [PATCH 4/4] ArmPkg:Provide GetTriggerType/SetTriggerType functions evan.lloyd
2017-02-13 12:15   ` Leif Lindholm
2017-02-16 20:27     ` Evan Lloyd
2017-02-16 20:42       ` Ryan Harkin
2017-02-17 12:06         ` Evan Lloyd
2017-02-17 12:30           ` Ryan Harkin
2017-02-17 15:08             ` Alexei Fedorov
2017-02-17 18:18               ` Ard Biesheuvel
2017-02-24 14:06           ` Leif Lindholm
2017-02-13 13:05   ` Ard Biesheuvel
2017-02-16 20:16     ` Evan Lloyd
2017-02-16 20:46       ` Ard Biesheuvel
2017-02-17 11:53         ` Evan Lloyd
2017-02-24 11:26           ` Leif Lindholm
2017-02-13 15:51 ` Evan Lloyd [this message]
2017-02-13 17:15   ` [PATCH 0/4] HardwareInterrupt2 protocol Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM5PR0801MB176218F7EB3B05C38C234A648B590@AM5PR0801MB1762.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox