Re: [PATCH 0/4] HardwareInterrupt2 protocol

[Evan Lloyd <Evan.Lloyd@arm.com>]

I'd like to make something clear here.  We found a problem and solicited opinion.
Ard very helpfully proposed a solution, complete with a rapid response example patch.
However, it was code he wrote quickly to propose a solution - and I imagine he didn't expect it to go directly into the code line.
We submitted his patches as sent, because we felt we should not take credit for his excellent work.
So any problems here are our fault, not Ard's - and he didn't get to review things before submission.
I'll tidy things up, and try again.

Evan

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>evan.lloyd@arm.com
>Sent: 09 February 2017 19:26
>To: edk2-devel@ml01.01.org
>Cc: ryan.harkin@linaro.org; Leif Lindholm; ard.biesheuvel@linaro.org
>Subject: [edk2] [PATCH 0/4] HardwareInterrupt2 protocol
>
>From: Evan Lloyd <evan.lloyd@arm.com>
>
>This series of patches corrects a problem detected on the ARM Juno
>platform that is actually generic (at least to ARM GIC platforms).
>The HardwareInterrupt protocol had no means of handling characteristics
>like Edge/Level triggered and polarity.
>
>A new HardwareInterrupt2 protocol (provided by Ard) is added,
>and code changed to utilise the new capabilities.
>
>The code is available for examination on Github at:
>    https://github.com/EvanLloyd/tianocore/tree/376_irqtype_v1
>
>Ard Biesheuvel (3):
>  EmbeddedPkg: introduce HardwareInterrupt2 protocol
>  ArmPkg/ArmGicDxe: expose HardwareInterrupt2 protocol
>  ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type
>
>Girish Pathak (1):
>  ArmPkg:Provide GetTriggerType/SetTriggerType functions
>
> EmbeddedPkg/EmbeddedPkg.dec                              |   1 +
> ArmPkg/Drivers/ArmGic/ArmGicDxe.inf                      |   1 +
> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf |   4 +-
> ArmPkg/Drivers/ArmGic/ArmGicDxe.h                        |   2 +
> ArmPkg/Include/Library/ArmGicLib.h                       |   4 +
> EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h        | 181
>++++++++++++++++++++
> ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c                  |   2 +
> ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c                | 181
>+++++++++++++++++++-
> ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c                | 178
>++++++++++++++++++-
> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c   |  27 +--
> 10 files changed, 567 insertions(+), 14 deletions(-)
> create mode 100644
>EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h
>
>--
>Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.