From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0623.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::623]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8931582003 for ; Mon, 13 Feb 2017 07:52:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fU9QPorAvlbNGS7o7/nldmQR/f/mJM8Q2KDnr2szhYg=; b=pTRCFkdAg+2UUPjK61e9CdexD16TmuKSSHdb8BaQ4ALSEi6Zh7h4MgT8ll8COt05rSzdlrzUrZkzRbpPApPcc76cRx5DJ94jQcS7UpsCVkT3yWzoTyTYo3Db51mqvlHqq0Rwg15YuvfqOIB96sNmKbkFTONGfyKycnZoqjZHsUw= Received: from AM5PR0801MB1762.eurprd08.prod.outlook.com (10.169.247.16) by AM5PR0801MB1763.eurprd08.prod.outlook.com (10.169.247.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Mon, 13 Feb 2017 15:51:58 +0000 Received: from AM5PR0801MB1762.eurprd08.prod.outlook.com ([10.169.247.16]) by AM5PR0801MB1762.eurprd08.prod.outlook.com ([10.169.247.16]) with mapi id 15.01.0888.030; Mon, 13 Feb 2017 15:51:58 +0000 From: Evan Lloyd To: "edk2-devel@ml01.01.org" CC: "ryan.harkin@linaro.org" , Leif Lindholm , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH 0/4] HardwareInterrupt2 protocol Thread-Index: AQHSgwpv3JBdbRL0/0OvCGYFy39ruKFnF1SQ Date: Mon, 13 Feb 2017 15:51:58 +0000 Message-ID: References: <20170209192623.262044-1-evan.lloyd@arm.com> In-Reply-To: <20170209192623.262044-1-evan.lloyd@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-office365-filtering-correlation-id: c24e6c14-ca2a-4d99-3c8d-08d454283e1b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:AM5PR0801MB1763; x-microsoft-exchange-diagnostics: 1; AM5PR0801MB1763; 7:ORBk0eQRsZeM0JzyhDUY3GJ/e/ehr7cyTshcgFGY+znJWCMdNt9DIGxWGwD19wr4BrjOgZ914HKte34UrMpN3U6O3ENkwcyXCmr0L0oxDH1w52a56evf2kpql+6UIbA0+AJ3kgzXKP2MF+J7mWjL4EK+SqzM1ZW48TOC91wsDEDPVNyIizSTLYBW1xTdN/R1u1JgOzyaDbNxOUBGuaOTCPQU3NgME+qmqtH9EIQM/2IrRDF31NubN5jBzFKDL6p9Rnv0iW3v90AaTXt1Mi922mBJX0twdwhtpeN+7to6MZ8EiVzWFLcUHxfksF5tZk2A90r39n9i8FS46lAHPovm+NAsguEDSNE1TCUumTBjgrYuf9lCoEsYd7we+qm/yBQ+qgMBZJ6Rs2QuZZ+xTdO+k2g5n+hk9bCS5WE8NrvAeYuarF1Stw8+vQaHzgQjIxjRS9NKeXw7yWEnmNbxoF3kJpG9UXrDnD1QC8diIxk7ZlxwkwNeDv2Yyh1C7ThqkGusxlCTgpAMEUDw5y677G7R4w== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123555025)(20161123558025)(20161123560025)(20161123562025)(6072148); SRVR:AM5PR0801MB1763; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0801MB1763; x-forefront-prvs: 02176E2458 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39860400002)(39840400002)(39450400003)(39410400002)(39850400002)(13464003)(189002)(199003)(40434004)(101416001)(2501003)(5890100001)(7696004)(50986999)(6246003)(5640700003)(3280700002)(229853002)(54356999)(76176999)(3846002)(2950100002)(6916009)(86362001)(74316002)(68736007)(2900100001)(4326007)(66066001)(305945005)(7736002)(102836003)(6116002)(92566002)(2906002)(122556002)(6506006)(9686003)(105586002)(8676002)(97736004)(81156014)(81166006)(77096006)(5660300001)(55016002)(33656002)(2351001)(106356001)(106116001)(53936002)(6306002)(25786008)(99286003)(6436002)(110136004)(54906002)(38730400002)(8936002)(189998001)(3660700001)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0801MB1763; H:AM5PR0801MB1762.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2017 15:51:58.1468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1763 Subject: Re: [PATCH 0/4] HardwareInterrupt2 protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 15:52:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I'd like to make something clear here. We found a problem and solicited op= inion. Ard very helpfully proposed a solution, complete with a rapid response exam= ple patch. However, it was code he wrote quickly to propose a solution - and I imagine= he didn't expect it to go directly into the code line. We submitted his patches as sent, because we felt we should not take credit= for his excellent work. So any problems here are our fault, not Ard's - and he didn't get to review= things before submission. I'll tidy things up, and try again. Evan >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >evan.lloyd@arm.com >Sent: 09 February 2017 19:26 >To: edk2-devel@ml01.01.org >Cc: ryan.harkin@linaro.org; Leif Lindholm; ard.biesheuvel@linaro.org >Subject: [edk2] [PATCH 0/4] HardwareInterrupt2 protocol > >From: Evan Lloyd > >This series of patches corrects a problem detected on the ARM Juno >platform that is actually generic (at least to ARM GIC platforms). >The HardwareInterrupt protocol had no means of handling characteristics >like Edge/Level triggered and polarity. > >A new HardwareInterrupt2 protocol (provided by Ard) is added, >and code changed to utilise the new capabilities. > >The code is available for examination on Github at: > https://github.com/EvanLloyd/tianocore/tree/376_irqtype_v1 > >Ard Biesheuvel (3): > EmbeddedPkg: introduce HardwareInterrupt2 protocol > ArmPkg/ArmGicDxe: expose HardwareInterrupt2 protocol > ArmPkg/GenericWatchdogDxe: Set Watchdog interrupt type > >Girish Pathak (1): > ArmPkg:Provide GetTriggerType/SetTriggerType functions > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > ArmPkg/Drivers/ArmGic/ArmGicDxe.inf | 1 + > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf | 4 +- > ArmPkg/Drivers/ArmGic/ArmGicDxe.h | 2 + > ArmPkg/Include/Library/ArmGicLib.h | 4 + > EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h | 181 >++++++++++++++++++++ > ArmPkg/Drivers/ArmGic/ArmGicCommonDxe.c | 2 + > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 181 >+++++++++++++++++++- > ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 178 >++++++++++++++++++- > ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 27 +-- > 10 files changed, 567 insertions(+), 14 deletions(-) > create mode 100644 >EmbeddedPkg/Include/Protocol/HardwareInterrupt2.h > >-- >Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > >_______________________________________________ >edk2-devel mailing list >edk2-devel@lists.01.org >https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.