From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eu-smtp-delivery-143.mimecast.com (eu-smtp-delivery-143.mimecast.com [146.101.78.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3CB011A1E3D for ; Wed, 31 Aug 2016 02:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OihKsDF/9gToJCuJYphZF8ssw9ydLcyMW35pTUk0P1E=; b=Jak2I2xwZF6Rebzlc+sNyKMbuDWZvlNmpeYkg5w2euDxC0FwockZ6SXFA496OjvCnq2FJJsv3pF6b2YlLak8g1DBBBcFL0Kglblkq656WJVtC/yyxrNRhxte+MgM90YossiSV89dmtEVaTJDNi4/T/qvp/Iz6mlhaqaSAFIor2o= Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp0183.outbound.protection.outlook.com [213.199.180.183]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-73-ZwPN-neHNUSg3-x_2Tyj6g-1; Wed, 31 Aug 2016 10:47:09 +0100 Received: from AM5PR0801MB1762.eurprd08.prod.outlook.com (10.169.247.16) by AM5PR0801MB1762.eurprd08.prod.outlook.com (10.169.247.16) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Wed, 31 Aug 2016 09:47:06 +0000 Received: from AM5PR0801MB1762.eurprd08.prod.outlook.com ([10.169.247.16]) by AM5PR0801MB1762.eurprd08.prod.outlook.com ([10.169.247.16]) with mapi id 15.01.0599.010; Wed, 31 Aug 2016 09:47:06 +0000 From: Evan Lloyd To: Michael Zimmermann , Leif Lindholm CC: "edk2-devel@lists.01.org" , "Cohen, Eugene" , Laszlo Ersek , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro Thread-Index: AQHR8xqVypVd/1G8zU+Lvd27qkp/faBDcTSAgB8qIACAAFcYMA== Date: Wed, 31 Aug 2016 09:47:06 +0000 Message-ID: References: <1470842282-8415-1-git-send-email-ard.biesheuvel@linaro.org> <1470842282-8415-23-git-send-email-ard.biesheuvel@linaro.org> <20160811083817.GQ31760@bivouac.eciton.net> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.96.140] x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr,ExtAddr x-ms-office365-filtering-correlation-id: 10664733-1279-4eb4-f73a-08d3d183c513 x-microsoft-exchange-diagnostics: 1; AM5PR0801MB1762; 20:ITTSiZuE0YNf9o3Vj3ooqBf1lNYM8z5UKLDbtlpTDf1r7OSxPyS/GCcCz2FIEX66yTeNG24EjjAIF6p3vv4qDwTe39JNy5mGTU1HnjBJpfg+JN7GjjIXAajnKzK5V9olKmbWvruGguNVT0MUrDbVE3RxV8GqkCJY4uY9ee66EQA= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0801MB1762; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:AM5PR0801MB1762; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0801MB1762; x-forefront-prvs: 00514A2FE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(13464003)(40434004)(189002)(199003)(189998001)(5660300001)(93886004)(5890100001)(2906002)(3280700002)(3660700001)(4326007)(97736004)(5002640100001)(122556002)(10400500002)(5001770100001)(66066001)(87936001)(2950100001)(9686002)(76576001)(2900100001)(92566002)(19580395003)(77096005)(19580405001)(8676002)(81166006)(586003)(102836003)(3846002)(8936002)(6116002)(33656002)(74316002)(305945005)(7696003)(86362001)(7736002)(106356001)(11100500001)(7846002)(54356999)(101416001)(50986999)(8666005)(76176999)(105586002)(68736007)(106116001)(81156014)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0801MB1762; H:AM5PR0801MB1762.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2016 09:47:06.4611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1762 X-MC-Unique: ZwPN-neHNUSg3-x_2Tyj6g-1 Subject: Re: [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2016 09:47:14 -0000 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable >-----Original Message----- >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >Michael Zimmermann >Sent: 31 August 2016 05:33 >To: Leif Lindholm >Cc: edk2-devel@lists.01.org; Cohen, Eugene; Laszlo Ersek; >ard.biesheuvel@linaro.org >Subject: Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to >ASM_FUNC() asm macro > >reviewed should mean tested ;) > Sorry to be pedantic, but shouldn't "Reviewed-by" mean code reviewed, and "= Tested-by" mean tested? Evan ... IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.