From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0631.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::631]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C0F0B81EC9 for ; Fri, 11 Nov 2016 05:12:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ShfxVDTGXyzJPVzFCSXYtCAqG+OzndPBtdd5/4DcEbM=; b=a2Ll9MChJptJOQ085YGc3B8cSNHJuqlDL9+zI/NAI6rKJQfEhTu8D4A2KrGgSy1h7Zse9UqEkDKxHXBcVOBTNDCHoURtQDP1D8+Tmsy/GlPOoUu6AQM8G2vLC5EduAX8I9UVWkMTuykUJLchqizA11lb+zTgdZtWfsAnPe96pac= Received: from AM5PR0801MB1762.eurprd08.prod.outlook.com (10.169.247.16) by AM5PR0801MB1762.eurprd08.prod.outlook.com (10.169.247.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.707.6; Fri, 11 Nov 2016 13:12:33 +0000 Received: from AM5PR0801MB1762.eurprd08.prod.outlook.com ([10.169.247.16]) by AM5PR0801MB1762.eurprd08.prod.outlook.com ([10.169.247.16]) with mapi id 15.01.0707.013; Fri, 11 Nov 2016 13:12:33 +0000 From: Evan Lloyd To: Laszlo Ersek , "edk2-devel (edk2-devel@lists.01.org)" CC: Leif Lindholm , "liming.gao@intel.com" Thread-Topic: [edk2] File mode problem on Github edk2-BaseTools-win32 Thread-Index: AdI8By2yC6dzeTaMQUKJB1RXVwuCawABvXOAAACwYPA= Date: Fri, 11 Nov 2016 13:12:33 +0000 Message-ID: References: <8f47b193-8855-8a0c-5e97-9eb9373d6d66@redhat.com> In-Reply-To: <8f47b193-8855-8a0c-5e97-9eb9373d6d66@redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-microsoft-exchange-diagnostics: 1; AM5PR0801MB1762; 7:wlcAZ0S8LifOHtjMvdRfjo2EOn9S77t9wq1alFj9Uii+mKhvIzvz0tIwjB4C/wYVQvmBSqRr58BidYbQ4cLEhEgTKLFjNwr7uutntHvL8E3ByFR9Yd13Lbyt4I0IwQJ+I9sDfjBTb2Uiii9fwT0/9gYU4ZXt6JY9flhqHa/2moEJaPkyZOnpd3wiJ6WJ0GQ4Bzw2TWC4A0+sQ1sO6NCdj7qO2uEwDpVmcYbLYpvffkZBoVGuroYDwWhsrtwB48DAc2COMH5N4/AD5KHL69eOoenyzFnu9qcFOBr580QvT94HOBxrKQfnOjog0AF/frSVhcsrtkoh270H5ad39bRPxoxBGsLh3UoXZINz2rXyehM= x-ms-office365-filtering-correlation-id: 8c167c09-a80f-447d-33dd-08d40a346664 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:AM5PR0801MB1762; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:AM5PR0801MB1762; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0801MB1762; x-forefront-prvs: 012349AD1C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(40434004)(13464003)(189002)(199003)(81166006)(77096005)(189998001)(7696004)(3846002)(76576001)(2900100001)(586003)(86362001)(8676002)(74316002)(97736004)(5001770100001)(92566002)(3660700001)(66066001)(106356001)(7846002)(81156014)(87936001)(101416001)(105586002)(305945005)(6116002)(2950100002)(230783001)(5890100001)(68736007)(54356999)(102836003)(50986999)(76176999)(9686002)(7736002)(4326007)(5660300001)(3280700002)(8936002)(122556002)(2906002)(33656002)(229853002)(460985005)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0801MB1762; H:AM5PR0801MB1762.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2016 13:12:33.6971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1762 Subject: Re: File mode problem on Github edk2-BaseTools-win32 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 13:12:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo. >-----Original Message----- >From: Laszlo Ersek [mailto:lersek@redhat.com] >Sent: 11 November 2016 11:24 >To: Evan Lloyd; edk2-devel (edk2-devel@lists.01.org) >Cc: Leif Lindholm; liming.gao@intel.com >Subject: Re: [edk2] File mode problem on Github edk2-BaseTools-win32 ... >> Liming, >> Because this is purely a permission problem in the Git repository, and .= exe >files are not amenable to patching, > >They are -- I think if you change the file mode bits, git will see that, a= nd will >create a patch that has no content hunks, just the file mode changes. A semantic quibble; ".exe files are not amenable to patching" is true, the = file ATTRIBUTES may be. Patches against a .exe (or .dll) should surely start alarm bells ringing fo= r most people. > >For example, in the BaseTools/Conf/ directory, we happen have two >template files that have gratuitous execute permissions. If I remove those >permissions, "git diff" shows > ... >(The above patch is one I could submit genuinely, but I'm too lazy. :)) And somebody on the list would only object, so why bother? ;-) > >> I have raised a pull request on https://github.com/tianocore/edk2- >BaseTools-win32/pulls >> This is only a minor thing, but I would deem it a great favour were you = to >accept the pull request. >> It has me tearing my hair out, and I have little enough to begin with. = :-{ > >It is fine to send pull requests, but: >- they should be mailed to the list (not opened on github), >- the patches have to be reviewed first, anyway. > >(Speaking about the edk2 repo at least -- I realize this is a different re= po.) As you point out, this is for a different repo; provided (I think) as a con= venience, and is ancillary to edk2. My viewpoint is that this is a specialised aspect, of interest to very few = people. (Does anyone else use Cygwin Git and the Win32 binaries?) The only reason for publishing this request here was one of awareness. Mos= t people will, I expect, be blissfully unconcerned. I am happy to submit a patch though, should those responsible (Liming?) wan= t that. Until that is confirmed though, I'm assuming that the GitHub repo is a mirr= or of a Subversion original (which will not record modes), so applying a pa= tch might involve a lot more work than accepting the pull request on GitHub= . Regards, Evan > >Thanks >Laszlo IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.