* Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed [not found] <15FF82990C57A035.32445@groups.io> @ 2020-04-14 8:50 ` Krzysztof Koch 2020-04-17 7:20 ` Gao, Zhichao 0 siblings, 1 reply; 4+ messages in thread From: Krzysztof Koch @ 2020-04-14 8:50 UTC (permalink / raw) To: devel@edk2.groups.io, ray.ni@intel.com, zhichao.gao@intel.com Cc: Sami Mujawar, Matteo Carlini, Laura Moretta, nd Hi, Can I get a review for this patch series? Thanks, Krzysztof -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Krzysztof Koch via Groups.Io Sent: Wednesday, March 25, 2020 9:39 To: devel@edk2.groups.io Cc: ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com> Subject: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed This patch series adds a new capability to the Acpiview UEFI shell tool. Using the -r command line parameter, it is now possible to choose a specification which lists mandatory ACPI tables. The parameter value is then consumed by a library which validates ACPI tables identified on the platform against these requirements. The -r parameter is architecture agnostic. However, as of now, the possible values for the parameter are only defined in the context of the Arm architecture. For Arm-based platforms, it is now possible to validate that Server Base Boot Requirements (SBBR) mandatory ACPI tables are present on the platform. Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/617_sbbr_validate_acpi_table_counts_v1 Krzysztof Koch (3): ShellPkg: acpiview: Add -r parameter for table requirements validation ShellPkg: acpiview: Add library for SBBR ACPI requirements validation ShellPkg: acpiview: Check if SBBR mandatory ACPI tables are installed ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c | 16 ++ ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 104 ++++++++- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h | 44 +++- ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c | 222 ++++++++++++++++++++ ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h | 91 ++++++++ ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 6 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 14 +- 7 files changed, 492 insertions(+), 5 deletions(-) create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed 2020-04-14 8:50 ` [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed Krzysztof Koch @ 2020-04-17 7:20 ` Gao, Zhichao 2020-05-01 11:26 ` Krzysztof Koch 0 siblings, 1 reply; 4+ messages in thread From: Gao, Zhichao @ 2020-04-17 7:20 UTC (permalink / raw) To: Krzysztof Koch, devel@edk2.groups.io, Ni, Ray Cc: Sami Mujawar, Matteo Carlini, Laura Moretta, nd For the patch set: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: Krzysztof Koch <Krzysztof.Koch@arm.com> > Sent: Tuesday, April 14, 2020 4:50 PM > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > <zhichao.gao@intel.com> > Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini > <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd > <nd@arm.com> > Subject: RE: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are > installed > > Hi, > > Can I get a review for this patch series? > > Thanks, > > Krzysztof > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Krzysztof Koch via Groups.Io > Sent: Wednesday, March 25, 2020 9:39 > To: devel@edk2.groups.io > Cc: ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar > <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; > Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com> > Subject: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are > installed > > This patch series adds a new capability to the Acpiview UEFI shell tool. > Using the -r command line parameter, it is now possible to choose a > specification which lists mandatory ACPI tables. The parameter value is then > consumed by a library which validates ACPI tables identified on the platform > against these requirements. > > The -r parameter is architecture agnostic. However, as of now, the possible > values for the parameter are only defined in the context of the Arm > architecture. > > For Arm-based platforms, it is now possible to validate that Server Base Boot > Requirements (SBBR) mandatory ACPI tables are present on the platform. > > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/617_sbbr_validate_acpi_tabl > e_counts_v1 > > Krzysztof Koch (3): > ShellPkg: acpiview: Add -r parameter for table requirements validation > ShellPkg: acpiview: Add library for SBBR ACPI requirements validation > ShellPkg: acpiview: Check if SBBR mandatory ACPI tables are installed > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c | > 16 ++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 104 > ++++++++- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h | 44 > +++- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c > | 222 ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h > | 91 ++++++++ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > dLib.inf | 6 +- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > dLib.uni | 14 +- > 7 files changed, 492 insertions(+), 5 deletions(-) create mode 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c > create mode 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed 2020-04-17 7:20 ` Gao, Zhichao @ 2020-05-01 11:26 ` Krzysztof Koch 2020-05-07 2:22 ` Gao, Zhichao 0 siblings, 1 reply; 4+ messages in thread From: Krzysztof Koch @ 2020-05-01 11:26 UTC (permalink / raw) To: devel@edk2.groups.io, zhichao.gao@intel.com, Ni, Ray Cc: Sami Mujawar, Matteo Carlini, Laura Moretta, nd Hi Zhichao, Any idea when this patch set will get merged? Kind regards, Krzysztof -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, Zhichao via groups.io Sent: Friday, April 17, 2020 8:20 To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com> Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com> Subject: Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed For the patch set: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: Krzysztof Koch <Krzysztof.Koch@arm.com> > Sent: Tuesday, April 14, 2020 4:50 PM > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > <zhichao.gao@intel.com> > Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini > <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd > <nd@arm.com> > Subject: RE: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables > are installed > > Hi, > > Can I get a review for this patch series? > > Thanks, > > Krzysztof > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Krzysztof Koch via Groups.Io > Sent: Wednesday, March 25, 2020 9:39 > To: devel@edk2.groups.io > Cc: ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar > <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Laura > Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com> > Subject: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are > installed > > This patch series adds a new capability to the Acpiview UEFI shell tool. > Using the -r command line parameter, it is now possible to choose a > specification which lists mandatory ACPI tables. The parameter value > is then consumed by a library which validates ACPI tables identified > on the platform against these requirements. > > The -r parameter is architecture agnostic. However, as of now, the > possible values for the parameter are only defined in the context of > the Arm architecture. > > For Arm-based platforms, it is now possible to validate that Server > Base Boot Requirements (SBBR) mandatory ACPI tables are present on the platform. > > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/617_sbbr_validate_acpi_tab > l > e_counts_v1 > > Krzysztof Koch (3): > ShellPkg: acpiview: Add -r parameter for table requirements validation > ShellPkg: acpiview: Add library for SBBR ACPI requirements validation > ShellPkg: acpiview: Check if SBBR mandatory ACPI tables are > installed > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c | > 16 ++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 104 > ++++++++- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h | 44 > +++- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c > | 222 ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h > | 91 ++++++++ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > dLib.inf | 6 +- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > dLib.uni | 14 +- > 7 files changed, 492 insertions(+), 5 deletions(-) create mode > 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c > create mode 100644 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed 2020-05-01 11:26 ` Krzysztof Koch @ 2020-05-07 2:22 ` Gao, Zhichao 0 siblings, 0 replies; 4+ messages in thread From: Gao, Zhichao @ 2020-05-07 2:22 UTC (permalink / raw) To: Krzysztof Koch, devel@edk2.groups.io, Ni, Ray Cc: Sami Mujawar, Matteo Carlini, Laura Moretta, nd Pushed at 8af507c1f16d9cc311e83397881016e3887acfbb.. faef5a367c8345df906be3755e15e0dabc3105b3 > -----Original Message----- > From: Krzysztof Koch <Krzysztof.Koch@arm.com> > Sent: Friday, May 1, 2020 7:27 PM > To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray > <ray.ni@intel.com> > Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini > <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd > <nd@arm.com> > Subject: RE: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are > installed > > Hi Zhichao, > > Any idea when this patch set will get merged? > > Kind regards, > > Krzysztof > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, Zhichao > via groups.io > Sent: Friday, April 17, 2020 8:20 > To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io; Ni, Ray > <ray.ni@intel.com> > Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini > <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd > <nd@arm.com> > Subject: Re: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are > installed > > For the patch set: > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > Thanks, > Zhichao > > > -----Original Message----- > > From: Krzysztof Koch <Krzysztof.Koch@arm.com> > > Sent: Tuesday, April 14, 2020 4:50 PM > > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > > <zhichao.gao@intel.com> > > Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini > > <Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd > > <nd@arm.com> > > Subject: RE: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables > > are installed > > > > Hi, > > > > Can I get a review for this patch series? > > > > Thanks, > > > > Krzysztof > > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > Krzysztof Koch via Groups.Io > > Sent: Wednesday, March 25, 2020 9:39 > > To: devel@edk2.groups.io > > Cc: ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar > > <Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; > Laura > > Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com> > > Subject: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are > > installed > > > > This patch series adds a new capability to the Acpiview UEFI shell tool. > > Using the -r command line parameter, it is now possible to choose a > > specification which lists mandatory ACPI tables. The parameter value > > is then consumed by a library which validates ACPI tables identified > > on the platform against these requirements. > > > > The -r parameter is architecture agnostic. However, as of now, the > > possible values for the parameter are only defined in the context of > > the Arm architecture. > > > > For Arm-based platforms, it is now possible to validate that Server > > Base Boot Requirements (SBBR) mandatory ACPI tables are present on the > platform. > > > > Changes can be seen at: > > https://github.com/KrzysztofKoch1/edk2/tree/617_sbbr_validate_acpi_tab > > l > > e_counts_v1 > > > > Krzysztof Koch (3): > > ShellPkg: acpiview: Add -r parameter for table requirements validation > > ShellPkg: acpiview: Add library for SBBR ACPI requirements validation > > ShellPkg: acpiview: Check if SBBR mandatory ACPI tables are > > installed > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c | > > 16 ++ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 104 > > ++++++++- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h | 44 > > +++- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c > > | 222 ++++++++++++++++++++ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h > > | 91 ++++++++ > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > > dLib.inf | 6 +- > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > > dLib.uni | 14 +- > > 7 files changed, 492 insertions(+), 5 deletions(-) create mode > > 100644 > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c > > create mode 100644 > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h > > > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-07 2:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <15FF82990C57A035.32445@groups.io>
2020-04-14 8:50 ` [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are installed Krzysztof Koch
2020-04-17 7:20 ` Gao, Zhichao
2020-05-01 11:26 ` Krzysztof Koch
2020-05-07 2:22 ` Gao, Zhichao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox