From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.55]) by mx.groups.io with SMTP id smtpd.web11.47630.1590487698026659333 for ; Tue, 26 May 2020 03:08:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=4wfI1sKn; spf=pass (domain: arm.com, ip: 40.107.7.55, mailfrom: tomas.pilar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJsgQG5zbbgAOxeelPqvi/TT9D2RC3rNtbrWeG56+ew=; b=4wfI1sKnX7OG1XCuLdEmaHkbRJ49Kc5lLYcFD59G6TKmyIddIZ+2C9R/n5sLXLdn9XT/ZrH20FgGX9fNzFUmdpftC90BQD+5NGG0AkafCw4IxZs8sigXjwAVL8csq3b2JlsNDbS3O1q5rUnA6ad+QD2ZkJWa9b1HGFjLoaDMvTY= Received: from AM6PR0202CA0055.eurprd02.prod.outlook.com (2603:10a6:20b:3a::32) by AM4PR08MB2898.eurprd08.prod.outlook.com (2603:10a6:205:b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24; Tue, 26 May 2020 10:08:15 +0000 Received: from AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::4a) by AM6PR0202CA0055.outlook.office365.com (2603:10a6:20b:3a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.24 via Frontend Transport; Tue, 26 May 2020 10:08:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT062.mail.protection.outlook.com (10.152.17.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Tue, 26 May 2020 10:08:14 +0000 Received: ("Tessian outbound 9eabd37e4fee:v57"); Tue, 26 May 2020 10:08:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6d09f0fb75fe934a X-CR-MTA-TID: 64aa7808 Received: from 35dadef338b8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7474D3AB-C512-4093-92D7-3324F9A1B57B.1; Tue, 26 May 2020 10:08:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 35dadef338b8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 May 2020 10:08:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DAaAU9hcpIGGH0iZ4hOzGofBjlWALks+i9K1AHhHNhGaA+oqWiFRditw62RDMGr1cRkQfRoe69mQmIEV/8ybQLaSNENCEftNQ30dXqzH9469GqWYg1X4yiPlPPy6jgWTYtJ2Ci2LXiO0Cs7mQ2x4xoyDEblCZXxMjb71gdU5+fTkYeuFI1wK5/w9fCpk7tzzUz9VGiV9XlCxA0WmM/p+LRReGzPpPA9gbDRkZINBv2s7AVfIzafvioUaq5rB0428IJkG17OyOEoraqy1Al3z88R9pM2qAlwFRZCGli+VRZTuvhg9wFr7w/YbRgAUEd/iYLdc5W0fdHocXOerXeIrnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJsgQG5zbbgAOxeelPqvi/TT9D2RC3rNtbrWeG56+ew=; b=MVzqkV5qX3pb/TM8uhxr1NTyxExBCmmDKLsLY9jRb43o9JLaJShKP2pWb+mhB/2YMyXsoVqMFWPSuayZmulyNCbbvFMhniuw7lByUN/7PWeRTUFpUY/5xk2FptnNCtEJOrXZfmhjH7J21pcsoDUF8lqOrUX+uNxvqNmhBtKKfbCdrb8QrPUZa4rrhKB8dJ6jk7jJHljQ0Two/7oAhDKU9WODpuHBVVnncUIg99//DWK4JUBPUDcnrVZckllD3y+HvwsjYdNTa6bGqPBLEZ8LZtX5qFv7zi7mx1gVl7KSov6VIxSP/rhBban+yhVSEiyAvmQKbVjeOuCGwetIAzRjHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJsgQG5zbbgAOxeelPqvi/TT9D2RC3rNtbrWeG56+ew=; b=4wfI1sKnX7OG1XCuLdEmaHkbRJ49Kc5lLYcFD59G6TKmyIddIZ+2C9R/n5sLXLdn9XT/ZrH20FgGX9fNzFUmdpftC90BQD+5NGG0AkafCw4IxZs8sigXjwAVL8csq3b2JlsNDbS3O1q5rUnA6ad+QD2ZkJWa9b1HGFjLoaDMvTY= Received: from AM5PR0801MB1844.eurprd08.prod.outlook.com (2603:10a6:203:39::22) by AM5PR0801MB1972.eurprd08.prod.outlook.com (2603:10a6:203:4b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Tue, 26 May 2020 10:08:06 +0000 Received: from AM5PR0801MB1844.eurprd08.prod.outlook.com ([fe80::ed78:8b3c:523d:d153]) by AM5PR0801MB1844.eurprd08.prod.outlook.com ([fe80::ed78:8b3c:523d:d153%6]) with mapi id 15.20.3021.029; Tue, 26 May 2020 10:08:06 +0000 From: "Tomas Pilar (tpilar)" To: "rfc@edk2.groups.io" , "rebecca@bsdio.com" , "bret.barkelew@microsoft.com" , "Kinney, Michael D" , "devel@edk2.groups.io" , "lersek@redhat.com" Subject: Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process Thread-Topic: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process Thread-Index: AdYlrbT8bFM60bvPQMeeqo8QbNJ7HwCHhx4AAAELN4UAAPT4UACYjp5FAADFsYACQw2eQA== Date: Tue, 26 May 2020 10:08:05 +0000 Message-ID: References: <8389d6a6-aaf5-3c0e-904f-84f814c9d385@redhat.com> <812843fa-36ad-6ef3-42e1-8ec2a3c3e42d@bsdio.com> In-Reply-To: <812843fa-36ad-6ef3-42e1-8ec2a3c3e42d@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [81.111.29.163] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8b41ec2b-c82d-452a-af0a-08d8015cb470 x-ms-traffictypediagnostic: AM5PR0801MB1972:|AM4PR08MB2898: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:2582;OLM:4502; x-forefront-prvs: 041517DFAB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XotQwaQNG7VqjgqDQOvs/UKe8eyjLrVp24tlasEblh2Pn0t8DFGMN8qwDppN9rTEBfpLOqEb30jybA4pRuoY5eBYjMLuYXLFOgt1gmHSG3XMHTx/3B3kPWrDi4Xuts3M/O/G0UaxfzHL8G2JqdXefExAI0GRWvlJ5a8DNpQpBMZJfp+lkT7FP/NOcJlUv1YlTqgUxroMXb0vqKTg6C5zfOWlle7syzibxXyxCsuWjtsVXR7H2WzGgmrOM5DxpIZcRq0LuS9B98Oedv1dx21gxOh3vJtlSlBAGlgixHxBn5l/PQz8eFvqkA2j3gUVSJ7kgKNECRmvnreis1xUh6UXx354Lmo980LB3QlAYPqLh/4PBWSqy3DAKPCfCHRQLDcEa1tX3pMZ5L0UZdHZblaUpg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB1844.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(8936002)(478600001)(966005)(45080400002)(71200400001)(5660300002)(26005)(52536014)(186003)(8676002)(9686003)(66476007)(66446008)(64756008)(33656002)(66556008)(76116006)(66946007)(2906002)(53546011)(6506007)(110136005)(86362001)(55016002)(7696005)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: qe4CCghB6R7r5pSY02zE/ODHpwy8JDG9/VhMTS1zfpSObndwtm0ABTKWzkwTrfL3nFQCVzgx6/XOYfXODZ4eMxUYQDS747xRUh2J/maXhs0jDfZB2peEno90+1TFxfMuOy2iJCSJkPWijECY+3hDcURTKBMCYmh427T1Glv9MSlbTu1XdkCsQk9ScdbScpSkPXu+2O8covugxzqPA7ocnBLcWzQBTO6RUwwFokE16ZUgr2UeBI+Qdi795PUtK1h2lg5gxh9ltdR5Lpy7kc7OaiXryu3u+ghsWxNZOwZeDhs6BmAjfx2tAx5SZ1FZsXrpkqCliyXQ6Q2O0wtnlLnMrgygyzymTY2FZdSQwy1A1dPX4n9d+5hCo8twjiTJG1UlKRJIwBKuEi629n+A7UpQ/Kixj+xbqnG1TIda/a+lpmd9s401zL52I/xHdEMSx70/xv+XBGv5F3ee6TwiJGnGbfZ6EaJKsJH1JEQ77BZ6SAI= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1972 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Tomas.Pilar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(136003)(39860400002)(376002)(46966005)(450100002)(9686003)(356005)(5660300002)(45080400002)(82310400002)(336012)(55016002)(6506007)(70586007)(52536014)(86362001)(53546011)(70206006)(81166007)(82740400003)(26005)(33656002)(186003)(110136005)(966005)(47076004)(2906002)(8936002)(36906005)(7696005)(478600001)(8676002)(316002);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 700599b4-4968-424f-c1eb-08d8015caf3b X-Forefront-PRVS: 041517DFAB X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wWVyS6yyoXcjEiju+3/E+Q0xtAodm/sPavTW1cU7Ml8hVORMuaAwT0F30UWVNKnAEyLB1KeS6Oyf/uiMO0GsCoZw+h4iBR9GKSnr1o4t2HzE0xWgBLiyynnAnSg/daAfyY06zEg1qjUfc32tBDspLqKl3ioHlD30A5338UjFLET2cdH+DXLXJNy54yA8ItWQmlmSf1HYxBDA73o3/mZLVM0cEGz88G6Pc9vMXpkk+IHEl0G9C96TZoU4pb1anOK9z0oCM/4qpKTXRYOGSvMVS7sH/43TiHVsSKPCjRwAuL/7OdvpcUgr/LHXuH+ZWtZKrbxulzvU6FtD2RcVdhz4BvRzLzAxDEfRcKAWFzhMk7+RE2rWQHi/ESs/PV349GCYQbiMPK7y7Wk9M1C2Hxd2UdByJHHBXlz4ZzHH2hedNOGOCkYDikQgW+iPdARsJ9MV0IltiAGqjs8ofLJNNOiQuB9HYJEdNgrt4g8F1WT1gm0= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2020 10:08:14.7858 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b41ec2b-c82d-452a-af0a-08d8015cb470 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2898 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I actually agree with you, when we migrated from reviewboard to github pull= requests, I was sorely disappointed with the PR functionality and ergonomi= cs. Tomas Pilar -----Original Message----- From: rfc@edk2.groups.io On Behalf Of Rebecca Cran vi= a groups.io Sent: 14 May 2020 22:47 To: rfc@edk2.groups.io; bret.barkelew@microsoft.com; Kinney, Michael D ; devel@edk2.groups.io; lersek@redhat.com Subject: Re: [EXTERNAL] Re: [edk2-devel] [edk2-rfc] GitHub Pull Request ba= sed Code Review Process On 5/14/20 3:26 PM, Bret Barkelew via groups.io wrote: > I feel like this process is a good compromise. It=EF=BF=BDs not perfect = (frankly, I=EF=BF=BDm a fan of enforced squash merges, which can maintain b= isectability if managed well), but it allows for rapid iteration, ease of c= ontribution, and approaches the workflow that many who have never used emai= l to maintain a project would be familiar with. > > It=EF=BF=BDs code management for the Instagram generation, and I for one= welcome our new insect overlords. Or at least, that's what Microsoft is betting on! :D Personally, I remain unconvinced about the usability of Github Pull Reques= ts for a project the size of EDK2, but I hope to be proven wrong. -- Rebecca Cran IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.