From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.74]) by mx.groups.io with SMTP id smtpd.web12.16208.1592828622856837602 for ; Mon, 22 Jun 2020 05:23:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Dqf5GYpQ; spf=pass (domain: arm.com, ip: 40.107.15.74, mailfrom: tomas.pilar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=84cf0hwflUU8GqZ+U01a/t+LQSCb6vSx1I8DPIR6afM=; b=Dqf5GYpQNlEI4U1xt3wPjPMQAJ6dy5R7vof1QsH1QDP6AGt7Zqdq64ssimdpJNxf5Yowu+RRKH6aBgQIKvfQrbiJhgE5/FQbkZ8R1w7up2AEi5dAGu+3gIetv59Te7AFxpWH2kLbZXxQGmFAgzOSgfmouErxELqjHe389nkBCD0= Received: from DB8PR04CA0029.eurprd04.prod.outlook.com (2603:10a6:10:110::39) by HE1PR0801MB1866.eurprd08.prod.outlook.com (2603:10a6:3:4e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Mon, 22 Jun 2020 12:23:39 +0000 Received: from DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:110:cafe::44) by DB8PR04CA0029.outlook.office365.com (2603:10a6:10:110::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22 via Frontend Transport; Mon, 22 Jun 2020 12:23:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT024.mail.protection.outlook.com (10.152.20.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22 via Frontend Transport; Mon, 22 Jun 2020 12:23:39 +0000 Received: ("Tessian outbound 839770a6d413:v59"); Mon, 22 Jun 2020 12:23:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fe0ae8fa6f848832 X-CR-MTA-TID: 64aa7808 Received: from 476ae404f26e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 752FC37C-EFAC-458C-867C-CA189DE80ECA.1; Mon, 22 Jun 2020 12:23:33 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 476ae404f26e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 22 Jun 2020 12:23:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9s3v7eq/PJe1sVE53wW4LA5R0WVDs3cx6lLUqM/qv4u9xjpkef+8xdtkeGD4FEFpbghm7zX2haWpIS0AEgrd0iXki8VDG4wz7isV9dpBrdHVLp4KrCMVG6drfCC6klnSOkF/o12EE2abH49oM+bUFm+VdT8oNwt1kXO9m0pSDqoKFT4rlprseydr3/A3cuvQNOPGRF4nzwt3LY0RAlznttY1CWctI15TRztuZvRpoQulVL77MCHPyWrSV9GUsu6rEGJHQqyZovjOfbDek1rt/vo47DBvuxoB+ffjMRv5yoHra9yfpSJdHv+/0LO8QsMowRwMlqkdlw8YlBC3H2Ebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=84cf0hwflUU8GqZ+U01a/t+LQSCb6vSx1I8DPIR6afM=; b=VaINWqGwqs6b5hqaxafghIfgaBh8y98ctXotQ0dJztOTDBj1EHAePZnP4LCrB63ovRYiWUDwRFt6hPAR/7/5a48DPPC6SHsKrbFm0XWQrP7CvIHqgB7TME/WcIqk1+JJDeAIbX1F9yLtizKp6z3qfAfFBBgAxacjmAjrD265Pg/bGpW0lO2AcPXSjcTHVDvnxyqmEGZCQGGWhLiI1MpQUxtARsQomQjoYCxoOxO/0gznwkWMwCC3upFEls0P01f84Lh0JZgQ97MAyP30pjmZ1v8GhsbZEmOXYybjvJbJ0IUf/Caae0lVGTh3yzf8qSCILD7000DtZDaxNRaiO4x+IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=84cf0hwflUU8GqZ+U01a/t+LQSCb6vSx1I8DPIR6afM=; b=Dqf5GYpQNlEI4U1xt3wPjPMQAJ6dy5R7vof1QsH1QDP6AGt7Zqdq64ssimdpJNxf5Yowu+RRKH6aBgQIKvfQrbiJhgE5/FQbkZ8R1w7up2AEi5dAGu+3gIetv59Te7AFxpWH2kLbZXxQGmFAgzOSgfmouErxELqjHe389nkBCD0= Received: from AM5PR0801MB1844.eurprd08.prod.outlook.com (2603:10a6:203:39::22) by AM5PR0801MB1796.eurprd08.prod.outlook.com (2603:10a6:203:30::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Mon, 22 Jun 2020 12:23:32 +0000 Received: from AM5PR0801MB1844.eurprd08.prod.outlook.com ([fe80::95cf:8f23:9053:2f60]) by AM5PR0801MB1844.eurprd08.prod.outlook.com ([fe80::95cf:8f23:9053:2f60%10]) with mapi id 15.20.3109.027; Mon, 22 Jun 2020 12:23:32 +0000 From: "Tomas Pilar (tpilar)" To: "devel@edk2.groups.io" CC: nd , Ray Ni , Zhichao Gao Subject: Re: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application Thread-Topic: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application Thread-Index: AQHWQx4pBoQwo2FVfUSrwdknZKQvcajkmWhA Date: Mon, 22 Jun 2020 12:23:32 +0000 Message-ID: References: <20200615140351.1725-1-Tomas.Pilar@arm.com> In-Reply-To: <20200615140351.1725-1-Tomas.Pilar@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [81.111.29.163] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 37ce40e9-4c16-424b-1be2-08d816a71805 x-ms-traffictypediagnostic: AM5PR0801MB1796:|HE1PR0801MB1866: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430; x-forefront-prvs: 0442E569BC X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0lQc3spr4ao1kaoxFVUcNRb/2Eh15Q651fsh3OYZEJ4Cdy+XAgakwLo+muoIm1EJ77fV53uNK7/HBcrZriHK2yJeOviZtDwYGSyATnYKDtyQZVjkB0bqQM5sOBvm+3LzAwB28RnkCYHIS/bSQBQBZJjG3lTN32MeIOUENnrecFW8p0pZhlO9n/cw6qQAKDNJH808E3gSTbDF4L7Ss3FW7fTyuQNMJ+iasYRmVsoNW+J0X3axzHkLyP0TjXEsgQJyUUkDGRIuGqpXhfPIeyQenIn7teHDljtb2ifD0LAyBgZudYtos8CGpKYFdYWzSAUlbCrJg//Kg0RrRr5bnEZkYfnUZSKUOgTDnifW0nfW3Dn4yzNNFvMLvCIjDbte7tbG5sTv4NLrCGKi4tClhLeevw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM5PR0801MB1844.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(366004)(346002)(39860400002)(396003)(376002)(66476007)(966005)(54906003)(66946007)(71200400001)(66446008)(2906002)(33656002)(76116006)(64756008)(52536014)(5660300002)(9686003)(6916009)(66556008)(83380400001)(4326008)(86362001)(8676002)(55016002)(478600001)(26005)(316002)(186003)(53546011)(6506007)(7696005)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 4/qkWU3uyLcp9272XCSRQj6u/eic7EeaaMGfyNruNuYpHleZzLUHsHjfRtF9X88Hta8PdOEVv90rBPec3IH3tTUD96XGi06TsXgs/DbNIsWxpEz/2KWAKpW1amorHpkVW5gTtZmo7Iz3l8mKfLcc1YJD3LHlEzpB3OuDystT9JEck185ep8mAMsezUipYFlONW+cbyTfVp8qm9RWEBpw+cz4ZMsWTAQZ9osRRWcDxW8CCAUexU0AF8aBKrt79m8V0b84zl7hlGxiGC0saQNgj8ojmSunN/xuNwenZtFXlHtjIeOo7uooBh6wM+nT0GsLyZT0YZoeZSLN58IBL1vMJHQJHd4T0ayEKsAIqYaYDu60uGn1awiNR4YdqINQlZtHyLqzB6+/zE91C1sPXewVEsjJqs3DkwhLkVfnk9sjSAntmVfz9uiFBPyuUG5evy0JfcHH95C2aaQl5BjHNvwdnYg2ZJCXdtNZujtPikM3jmQ= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1796 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Tomas.Pilar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(46966005)(8936002)(966005)(86362001)(8676002)(82740400003)(47076004)(186003)(82310400002)(356005)(54906003)(52536014)(5660300002)(107886003)(4326008)(70586007)(70206006)(7696005)(33656002)(55016002)(316002)(9686003)(478600001)(6506007)(2906002)(53546011)(336012)(26005)(83380400001)(6916009)(81166007);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: e270a182-6695-4366-686d-08d816a71438 X-Forefront-PRVS: 0442E569BC X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: owkFLBAG/g4ZYM7v/5DtKqvRqSDmjTqhY4pi9Ir6I7EXVvZqapQ+Ods0Cp+YHKp7LrDkfjgxMMwB5waGhoD6D9D046M13UhYufU2CLawyXfVa23UTmi9wax+riw4h0w1HfIL97wnrGY5Ev8b+rtdB8Dy3J3DM6jgfpai6+2bsOZaG98aFRsQHpOztIROUqjJZEq2MXnbzaz4TRn51TtTR4Kx9tC1nXTFkLFatYFOOHUIa91hzeX+aWQC8PzqQ0jvPQpqq0TbgrfDd7pLItXwa9PARvDwBWV/qo6TLwcsNHjqm3q5kdMsJ+OxB2PHE8MxUbBgpPCAPc2pemVr58npxYobILr013cghEDC0rOFCA1U1y6eZrY1+eR9c0G4e8dE4gqIx4Ae1s7G7cdegemprsFJTqhZT66A4EBNtOnfXoNaSRgnK92DsybIaUXQyevJJSlNFXmrYJ3rmaRTKLdeDMMWm8gpBaeDVt0Q/5ehTb4= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2020 12:23:39.1192 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37ce40e9-4c16-424b-1be2-08d816a71805 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1866 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Zhichao, Do you have any opinions on the respun patches? Cheers, Tom -----Original Message----- From: devel@edk2.groups.io On Behalf Of Tomas Pilar= (tpilar) via groups.io Sent: 15 June 2020 15:04 To: devel@edk2.groups.io Cc: nd ; Ray Ni ; Zhichao Gao Subject: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application This patchset adds a new application module to the=20 ShellPkg with the functionality of the 'acpiview' command. The existing code is tidied and a clean boundary between the UEFI shell command wrapper and the acpiview functionality is created. Then, a new application wrapper is added. The motivation for a standalone AcpiView application lies in the desire to test implementation of the Acpi tables on=20 a wide selection of platforms, particularly platforms still in development, platforms that might have an older implementation of the UEFI shell or platforms that might not include the 'acpiview' command in the internal build of the UEFI shell. Furthermore, this application can then be integrated in larger firmware testing frameworks. --- v3: Fix pointer dereference in GetSelectedTable. Create library interface for the UefiShellAcpiViewCommandLib and convert to named library. Tidy help text shell hook in standalone app. v2: Patch formatting Cc: Ray Ni Cc: Zhichao Gao Tomas Pilar (7): ShellPkg/AcpiView: Move log reset to main method ShellPkg/AcpiView: Refactor configuration ShellPkg/AcpiView: Move table count reset ShellPkg/AcpiView: Move parameter parsing ShellPkg/AcpiView: Refactor DumpAcpiTableToFile ShellPkg: Add AcpiViewCommandLib ShellPkg/AcpiView: Add application wrapper .../Application/AcpiViewApp/AcpiViewApp.c | 40 ++ .../Application/AcpiViewApp/AcpiViewApp.inf | 34 ++ .../Application/AcpiViewApp/AcpiViewApp.uni | 122 +++++ ShellPkg/Include/Library/AcpiViewCommandLib.h | 46 ++ .../UefiShellAcpiViewCommandLib/AcpiParser.c | 1 + .../AcpiTableParser.c | 1 + .../UefiShellAcpiViewCommandLib/AcpiView.c | 474 ++---------------- .../UefiShellAcpiViewCommandLib/AcpiView.h | 113 +---- .../AcpiViewConfig.c | 246 +++++++++ .../AcpiViewConfig.h | 177 +++++++ .../Parsers/Gtdt/GtdtParser.c | 1 + .../Parsers/Iort/IortParser.c | 1 + .../Parsers/Madt/MadtParser.c | 1 + .../Parsers/Pptt/PpttParser.c | 1 + .../Parsers/Srat/SratParser.c | 1 + .../UefiShellAcpiViewCommandLib.c | 279 ++++++++++- .../UefiShellAcpiViewCommandLib.h | 26 - .../UefiShellAcpiViewCommandLib.inf | 33 +- ShellPkg/ShellPkg.dec | 3 + ShellPkg/ShellPkg.dsc | 4 +- 20 files changed, 1019 insertions(+), 585 deletions(-) create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.c create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.inf create mode 100644 ShellPkg/Application/AcpiViewApp/AcpiViewApp.uni create mode 100644 ShellPkg/Include/Library/AcpiViewCommandLib.h create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewC= onfig.c create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewC= onfig.h delete mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShell= AcpiViewCommandLib.h --=20 2.24.1.windows.2