From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.49; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=udit.kumar@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0049.outbound.protection.outlook.com [104.47.0.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8FD4220348638 for ; Wed, 9 May 2018 13:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/fdmlgZivID7Ei7GrH2fEPdGxYTvUEVwO4JOtcd2ZAM=; b=EPvk5YHzjMSMEFS09LD/Est52HRBplc26xQuvQLjYmJk4UB8Lohr449ytenc3opbcZS5p8aYfosCx90LFYmPDJ6G0dDrDs/XWShTIVvNFrMZ68Nr4QbR2Ug6QPEg00O6WrOwjW+oQjLa54ksZcpU+NQnDzBJaVXMIFCGbfH8gvk= Received: from AM6PR0402MB3334.eurprd04.prod.outlook.com (52.133.18.151) by AM6PR0402MB3781.eurprd04.prod.outlook.com (52.133.29.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 9 May 2018 20:52:29 +0000 Received: from AM6PR0402MB3334.eurprd04.prod.outlook.com ([fe80::adae:b328:3790:b1dd]) by AM6PR0402MB3334.eurprd04.prod.outlook.com ([fe80::adae:b328:3790:b1dd%13]) with mapi id 15.20.0735.021; Wed, 9 May 2018 20:52:29 +0000 From: Udit Kumar To: Supreeth Venkatesh , "edk2-devel@lists.01.org" CC: "ard.biesheuvel@linaro.org" , "leif.lindholm@linaro.org" , "jiewen.yao@intel.com" , "liming.gao@intel.com" , "michael.d.kinney@intel.com" Thread-Topic: [edk2] [PATCH v2 02/17] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. Thread-Index: AQHT4+hMcxC05eNVV0euFz18D3PhGqQn4kNw Date: Wed, 9 May 2018 20:52:28 +0000 Message-ID: References: <20180504204109.3354-1-supreeth.venkatesh@arm.com> <20180504204109.3354-3-supreeth.venkatesh@arm.com> In-Reply-To: <20180504204109.3354-3-supreeth.venkatesh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=udit.kumar@nxp.com; x-originating-ip: [92.121.36.198] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR0402MB3781; 7:jg+84GyA4q04zTsIB6eEVqoZ5Q9B/IvxvgGrYEhKgOCZd1gAEOx+DfRgmLNfxH4FzyZ8hTt6/ywBDXvVt36cjZhP6Ot+lUypYFBynqkQ/v8V3m5vxDhEjfH71R7E/ChAz1ry/7GAUAappKG1ykA5YY58my66Hdr01tYXZVPkl+I375ZlvbADrjXDODWMJSGhoaIdmwj/j5fRNWsa1jkFn/d1+agrissOpFa8jy2x4zZGHElSVYAqqN4q1HhN+SyH x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM6PR0402MB3781; x-ms-traffictypediagnostic: AM6PR0402MB3781: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(189930954265078)(162533806227266)(45079756050767)(228905959029699)(17755550239193); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM6PR0402MB3781; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0402MB3781; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(376002)(39380400002)(366004)(199004)(189003)(13464003)(2906002)(68736007)(6116002)(9686003)(6436002)(55016002)(6306002)(16799955002)(4326008)(3846002)(3280700002)(26005)(229853002)(86362001)(316002)(446003)(11346002)(486006)(5250100002)(3660700001)(110136005)(476003)(54906003)(2501003)(6246003)(53936002)(53946003)(99286004)(44832011)(33656002)(74316002)(186003)(97736004)(478600001)(14454004)(59450400001)(305945005)(5660300001)(966005)(45080400002)(2900100001)(76176011)(8676002)(106356001)(105586002)(8936002)(7736002)(81156014)(81166006)(25786009)(53546011)(7696005)(6506007)(66066001)(102836004)(579004)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0402MB3781; H:AM6PR0402MB3334.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: aZuMU6EOC6YT3EGan5u/umSbR1T+4aKC/rT4e/ZcqvhpmoEQVaSDmB9MENAHo2EDtsHp5Lg8sJnInVGIZZkSfIPFcdxXDILv0kHwU8MRw88O17x7E7PC9cxNADqfMsxlP1rXAChx0Ha40e93JGp705Qjc/8/Y9dDHSRuWhdugvKKIzGsln0BIq2lbbSZcr/z spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1ac1ef47-fb19-4506-353d-08d5b5eec728 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ac1ef47-fb19-4506-353d-08d5b5eec728 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 20:52:28.9688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3781 Subject: Re: [PATCH v2 02/17] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 20:52:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Saturday, May 5, 2018 2:11 AM > To: edk2-devel@lists.01.org > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; jiewen.yao@intel= .com; > liming.gao@intel.com; michael.d.kinney@intel.com > Subject: [edk2] [PATCH v2 02/17] ArmPkg/Drivers: Add > EFI_MM_COMMUNICATION_PROTOCOL DXE driver. >=20 > PI v1.5 Specification Volume 4 defines Management Mode Core Interface > and defines EFI_MM_COMMUNICATION_PROTOCOL. This protocol provides a > means of communicating between drivers outside of MM and MMI > handlers inside of MM. >=20 > This patch implements the EFI_MM_COMMUNICATION_PROTOCOL DXE > runtime > driver for AARCH64 platforms. It uses SMCs allocated from the standard > SMC range defined in DEN0060A_ARM_MM_Interface_Specification.pdf > to communicate with the standalone MM environment in the secure world. >=20 > This patch also adds the MM Communication driver (.inf) file to > define entry point for this driver and other compile > related information the driver needs. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > --- > .../Drivers/MmCommunicationDxe/MmCommunication.c | 408 > +++++++++++++++++++++ > .../Drivers/MmCommunicationDxe/MmCommunication.inf | 50 +++ > 2 files changed, 458 insertions(+) > create mode 100644 > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > create mode 100644 > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf >=20 > diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > new file mode 100644 > index 0000000000..8ba1790af9 > --- /dev/null > +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > @@ -0,0 +1,408 @@ > +/** @file > + > + Copyright (c) 2016-2018, ARM Limited. All rights reserved. > + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the = BSD > License > + which accompanies this distribution. The full text of the license may= be found > at > + > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fopens= o > urce.org%2Flicenses%2Fbsd- > license.php&data=3D02%7C01%7Cudit.kumar%40nxp.com%7Cc6986ed63017483b > 89dd08d5b1ff6c2d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63 > 6610632972644435&sdata=3DCoYRxTy3iCIKcy2xXEF6BJl1qNQEPZTLHBX9pXmrHR > w%3D&reserved=3D0 > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +**/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include > + > +#define MM_MAJOR_VER_MASK 0xFFFF0000 > +#define MM_MINOR_VER_MASK 0x0000FFFF > +#define MM_MAJOR_VER_SHIFT 16 > + > +const UINT32 MM_MAJOR_VER =3D 1; > +const UINT32 MM_MINOR_VER =3D 0; This should be UINT16 , as compare is done against UINT16=20 > + > +// > +// Address, Length of the pre-allocated buffer for communication with th= e > secure > +// world. > +// > +STATIC ARM_MEMORY_REGION_DESCRIPTOR mNsCommBuffMemRegion; > + > +// Notification event when virtual address map is set. > +STATIC EFI_EVENT mSetVirtualAddressMapEvent; > + > +// > +// Handle to install the MM Communication Protocol > +// > +STATIC EFI_HANDLE mMmCommunicateHandle; > + > +/** > + Communicates with a registered handler. > + > + This function provides an interface to send and receive messages to th= e > + Standalone MM environment on behalf of UEFI services. This function i= s part > + of the MM Communication Protocol that may be called in physical mode p= rior > to > + SetVirtualAddressMap() and in virtual mode after SetVirtualAddressMap(= ). > + > + @param[in] This The EFI_MM_COMMUNICATION_PROTOCOL > + instance. > + @param[in, out] CommBuffer A pointer to the buffer to convey > + into MMRAM. > + @param[in, out] CommSize The size of the data buffer being > + passed in. This is optional. > + > + @retval EFI_SUCCESS The message was successfully poste= d. > + @retval EFI_INVALID_PARAMETER The CommBuffer was NULL. > + @retval EFI_BAD_BUFFER_SIZE The buffer size is incorrect for t= he MM > + implementation. If this error is > + returned, the MessageLength field = in > + the CommBuffer header or the integ= er > + pointed by CommSize are updated to= reflect > + the maximum payload size the > + implementation can accommodate. > + @retval EFI_ACCESS_DENIED The CommunicateBuffer parameter > + or CommSize parameter, if not omit= ted, > + are in address range that cannot b= e > + accessed by the MM environment > +**/ > +STATIC > +EFI_STATUS > +EFIAPI > +MmCommunicationCommunicate ( > + IN CONST EFI_MM_COMMUNICATION_PROTOCOL *This, > + IN OUT VOID *CommBuffer, > + IN OUT UINTN *CommSize OPTIONAL > + ) > +{ > + EFI_MM_COMMUNICATE_HEADER *CommunicateHeader; > + ARM_SMC_ARGS CommunicateSmcArgs; > + EFI_STATUS Status; > + UINTN BufferSize; > + > + Status =3D EFI_ACCESS_DENIED; > + BufferSize =3D 0; > + > + ZeroMem (&CommunicateSmcArgs, sizeof (ARM_SMC_ARGS)); > + > + // > + // Check parameters > + // > + if (CommBuffer =3D=3D NULL) { > + return EFI_INVALID_PARAMETER; > + } You can do, parameter check before doing zero-mem In case of bad parameters, it will save few CPU cycles=20 > + > + CommunicateHeader =3D CommBuffer; > + // CommBuffer is a mandatory parameter. Hence, Rely on > + // MessageLength + Header to ascertain the > + // total size of the communication payload rather than > + // rely on optional CommSize parameter > + BufferSize =3D CommunicateHeader->MessageLength + > + sizeof (CommunicateHeader->HeaderGuid) + > + sizeof (CommunicateHeader->MessageLength); > + > + // If the length of the CommBuffer is 0 then return the expected lengt= h. > + if (CommSize) { > + // This case can be used by the consumer of this driver to find out = the > + // max size that can be used for allocating CommBuffer. > + if ((*CommSize =3D=3D 0) || > + (*CommSize > mNsCommBuffMemRegion.Length)) { > + *CommSize =3D mNsCommBuffMemRegion.Length; > + return EFI_BAD_BUFFER_SIZE; > + } > + // > + // CommSize must match MessageLength + sizeof > (EFI_MM_COMMUNICATE_HEADER); > + // > + if (*CommSize !=3D BufferSize) { > + return EFI_INVALID_PARAMETER; > + } > + } > + > + // > + // If the buffer size is 0 or greater than what can be tolerated by th= e MM > + // environment then return the expected size. > + // > + if ((BufferSize =3D=3D 0) || > + (BufferSize > mNsCommBuffMemRegion.Length)) { > + CommunicateHeader->MessageLength =3D mNsCommBuffMemRegion.Length > - > + sizeof (CommunicateHeader->Header= Guid) - > + sizeof (CommunicateHeader->Messag= eLength); > + return EFI_BAD_BUFFER_SIZE; > + } > + > + // SMC Function ID > + CommunicateSmcArgs.Arg0 =3D > ARM_SMC_ID_MM_COMMUNICATE_AARCH64; > + > + // Reserved for Future. Must be Zero. > + CommunicateSmcArgs.Arg1 =3D 0; > + > + // Copy Communication Payload > + CopyMem ((VOID *)mNsCommBuffMemRegion.VirtualBase, CommBuffer, > BufferSize); > + > + // For the SMC64 version, this parameter is a 64-bit Physical Address = (PA) > + // or Intermediate Physical Address (IPA). > + // For the SMC32 version, this parameter is a 32-bit PA or IPA. > + CommunicateSmcArgs.Arg2 =3D > (UINTN)mNsCommBuffMemRegion.PhysicalBase; > + > + // comm_size_address is a PA or an IPA that holds the size of the > + // communication buffer being passed in. This parameter is optional > + // and can be omitted by passing a zero. > + // ARM does not recommend using it since this might require the > + // implementation to create a separate memory mapping for the paramete= r. > + // ARM recommends storing the buffer size in the buffer itself. > + CommunicateSmcArgs.Arg3 =3D 0; > + > + // Call the Standalone MM environment. > + ArmCallSmc (&CommunicateSmcArgs); > + > + switch (CommunicateSmcArgs.Arg0) { > + case ARM_SMC_MM_RET_SUCCESS: > + ZeroMem (CommBuffer, BufferSize); > + // On exit, the size of data being returned is inferred from > + // MessageLength + Header. > + CommunicateHeader =3D (EFI_MM_COMMUNICATE_HEADER > *)mNsCommBuffMemRegion.VirtualBase; > + BufferSize =3D CommunicateHeader->MessageLength + > + sizeof (CommunicateHeader->HeaderGuid) + > + sizeof (CommunicateHeader->MessageLength); > + > + // Note: Very important to ensure that the consumer of this driver > + // has allocated CommBuffer sufficiently so that the return data > + // can be copied. Otherwise, this will lead to buffer overflow. > + // Assumption: CommBuffer =3D malloc (mNsCommBuffMemRegion.Length) > + // This guidance should be in the PI specification. TODO: ECR. > + CopyMem (CommBuffer, > + (const VOID *)mNsCommBuffMemRegion.VirtualBase, > + BufferSize); > + Status =3D EFI_SUCCESS; > + break; > + > + case ARM_SMC_MM_RET_INVALID_PARAMS: > + Status =3D EFI_INVALID_PARAMETER; > + break; > + > + case ARM_SMC_MM_RET_DENIED: > + Status =3D EFI_ACCESS_DENIED; > + break; > + > + case ARM_SMC_MM_RET_NO_MEMORY: > + // Unexpected error since the CommSize was checked for zero length > + // prior to issuing the SMC > + default: > + Status =3D EFI_ACCESS_DENIED; > + ASSERT (0); > + } > + > + return Status; > +} > + > +// > +// MM Communication Protocol instance > +// > +EFI_MM_COMMUNICATION_PROTOCOL mMmCommunication =3D { > + MmCommunicationCommunicate > +}; > + > +/** > + Notification callback on SetVirtualAddressMap event. > + > + This function notifies the MM communication protocol interface on > + SetVirtualAddressMap event and converts pointers used in this driver > + from physical to virtual address. > + > + @param Event SetVirtualAddressMap event. > + @param Context A context when the SetVirtualAddressMap trigger= ed. > + > + @retval EFI_SUCCESS The function executed successfully. > + @retval Other Some error occurred when executing this functio= n. > + > +**/ > +STATIC > +VOID > +EFIAPI > +NotifySetVirtualAddressMap ( > + IN EFI_EVENT Event, > + IN VOID *Context > + ) > +{ > + EFI_STATUS Status; > + > + Status =3D gRT->ConvertPointer (EFI_OPTIONAL_PTR, > + (VOID **)&mNsCommBuffMemRegion.VirtualBa= se > + ); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "NotifySetVirtualAddressMap():" > + " Unable to convert MM runtime pointer. Status:0x%r\n", Stat= us)); > + } > + > +} > + > +STATIC > +EFI_STATUS > +GetMmVersion () > +{ > + EFI_STATUS Status; > + UINT16 MmMajorVersion; > + UINT16 MmMinorVersion; > + UINT32 MmVersion; > + ARM_SMC_ARGS MmVersionArgs; > + > + MmVersionArgs.Arg0 =3D ARM_SMC_ID_MM_VERSION_AARCH32; > + > + ArmCallSmc (&MmVersionArgs); > + > + MmVersion =3D MmVersionArgs.Arg0; > + > + MmMajorVersion =3D ((MmVersion & MM_MAJOR_VER_MASK) >> > MM_MAJOR_VER_SHIFT); MmVersion >> MM_MAJOR_VER_SHIFT is same as of=20 ((MmVersion & MM_MAJOR_VER_MASK) >> MM_MAJOR_VER_SHIFT); > + MmMinorVersion =3D ((MmVersion & MM_MINOR_VER_MASK) >> 0); > + > + // Different major revision values indicate possibly incompatible func= tions. > + // For two revisions, A and B, for which the major revision values are > + // identical, if the minor revision value of revision B is greater tha= n > + // the minor revision value of revision A, then every function in > + // revision A must work in a compatible way with revision B. > + // However, it is possible for revision B to have a higher > + // function count than revision A. > + if ((MmMajorVersion =3D=3D MM_MAJOR_VER) && > + (MmMinorVersion >=3D MM_MINOR_VER)) > + { > + DEBUG ((DEBUG_INFO, "MM Version: Major=3D0x%x, Minor=3D0x%x\n", > + MmMajorVersion, MmMinorVersion)); > + Status =3D EFI_SUCCESS; > + } You can do bit soft here, if ATF has less functions then current version of= MM driver,=20 This is possible that some of additional functions of UEFI side are not use= d for booting.=20 Minor number mismatch should go with warning that some of functions may not= work Instead of denial. Your view please =20 > + else > + { > + DEBUG ((DEBUG_ERROR, "Incompatible MM Versions.\n Current Version: > Major=3D0x%x, Minor=3D0x%x.\n Expected: Major=3D0x%x, Minor>=3D0x%x.\n", > + MmMajorVersion, MmMinorVersion, MM_MAJOR_VER, > MM_MINOR_VER)); > + Status =3D EFI_UNSUPPORTED; > + } > + > + return Status; > +} > + > +/** > + The Entry Point for MM Communication > + > + This function installs the MM communication protocol interface and fin= ds out > + what type of buffer management will be required prior to invoking the > + communication SMC. > + > + @param ImageHandle The firmware allocated handle for the EFI image= . > + @param SystemTable A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The entry point is executed successfully. > + @retval Other Some error occurred when executing this entry p= oint. > + > +**/ > +EFI_STATUS > +EFIAPI > +MmCommunicationInitialize ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + > + // Get Secure Partition Manager Version Information > + Status =3D GetMmVersion (); > + if (EFI_ERROR(Status)) { > + goto ReturnErrorStatus; > + } > + > + mNsCommBuffMemRegion.PhysicalBase =3D PcdGet64 (PcdMmBufferBase); > + // During boot , Virtual and Physical are same > + mNsCommBuffMemRegion.VirtualBase =3D > mNsCommBuffMemRegion.PhysicalBase; > + mNsCommBuffMemRegion.Length =3D PcdGet64 (PcdMmBufferSize); > + > + if (mNsCommBuffMemRegion.PhysicalBase =3D=3D 0) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Invalid MM Buffer Base Address.\n")); > + goto ReturnErrorStatus; > + } > + > + if (mNsCommBuffMemRegion.Length =3D=3D 0) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Maximum Buffer Size is zero.\n")); > + goto ReturnErrorStatus; > + } > + > + Status =3D gDS->AddMemorySpace (EfiGcdMemoryTypeSystemMemory, > + mNsCommBuffMemRegion.PhysicalBase, > + mNsCommBuffMemRegion.Length, > + EFI_MEMORY_WB | > + EFI_MEMORY_XP | > + EFI_MEMORY_RUNTIME); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Failed to add MM-NS Buffer Memory Space\n")); > + goto ReturnErrorStatus; > + } > + > + Status =3D gDS->SetMemorySpaceAttributes > (mNsCommBuffMemRegion.PhysicalBase, > + mNsCommBuffMemRegion.Length, > + EFI_MEMORY_WB | EFI_MEMORY_XP)= ; > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Failed to set MM-NS Buffer Memory attributes\n")); > + goto CleanAddedMemorySpace; > + } > + > + Status =3D gBS->AllocatePages (AllocateAddress, > + EfiRuntimeServicesData, > + EFI_SIZE_TO_PAGES (mNsCommBuffMemRegion.L= ength), > + &mNsCommBuffMemRegion.PhysicalBase); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "MmCommunicateInitialize: " > + "Failed to allocate MM-NS Buffer Memory Space\n")); > + goto CleanAddedMemorySpace; > + } > + > + // Install the communication protocol > + Status =3D gBS->InstallProtocolInterface (&mMmCommunicateHandle, > + &gEfiMmCommunicationProtocolGu= id, > + EFI_NATIVE_INTERFACE, > + &mMmCommunication); > + if (EFI_ERROR(Status)) { > + DEBUG ((DEBUG_ERROR, "MmCommunicationInitialize: " > + "Failed to install MM communication protocol\n")); > + goto CleanAllocatedPages; > + } > + > + // Register notification callback when virtual address is associated > + // with the physical address. > + // Create a Set Virtual Address Map event. > + // > + Status =3D gBS->CreateEvent (EVT_SIGNAL_VIRTUAL_ADDRESS_CHANGE, // > Type > + TPL_NOTIFY, // Noti= fyTpl > + NotifySetVirtualAddressMap, // Noti= fyFunction > + NULL, // Noti= fyContext > + &mSetVirtualAddressMapEvent // Even= t > + ); > + if (Status =3D=3D EFI_SUCCESS) { > + return Status; > + } > + > + gBS->UninstallProtocolInterface(mMmCommunicateHandle, > + &gEfiMmCommunicationProtocolGuid, > + &mMmCommunication); > + > +CleanAllocatedPages: > + gBS->FreePages (mNsCommBuffMemRegion.PhysicalBase, > + EFI_SIZE_TO_PAGES (mNsCommBuffMemRegion.Length)); > + > +CleanAddedMemorySpace: > + gDS->RemoveMemorySpace (mNsCommBuffMemRegion.PhysicalBase, > + mNsCommBuffMemRegion.Length); > + > +ReturnErrorStatus: > + return EFI_INVALID_PARAMETER; > +} > diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > new file mode 100644 > index 0000000000..7797e3de74 > --- /dev/null > +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > @@ -0,0 +1,50 @@ > +#/** @file > +# > +# DXE MM Communicate driver > +# > +# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved. > +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the= BSD > License > +# which accompanies this distribution. The full text of the license ma= y be > found at > +# > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fopens= o > urce.org%2Flicenses%2Fbsd- > license.php&data=3D02%7C01%7Cudit.kumar%40nxp.com%7Cc6986ed63017483b > 89dd08d5b1ff6c2d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63 > 6610632972644435&sdata=3DCoYRxTy3iCIKcy2xXEF6BJl1qNQEPZTLHBX9pXmrHR > w%3D&reserved=3D0 > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION =3D 0x0001001A > + BASE_NAME =3D ArmMmCommunication > + FILE_GUID =3D 09EE81D3-F15E-43F4-85B4-CB9873DA5D6= B > + MODULE_TYPE =3D DXE_RUNTIME_DRIVER > + VERSION_STRING =3D 1.0 > + > + ENTRY_POINT =3D MmCommunicationInitialize > + > +[Sources.AARCH64] > + MmCommunication.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + MdePkg/MdePkg.dec > + > +[LibraryClasses] > + ArmLib > + ArmSmcLib > + BaseMemoryLib > + DebugLib > + DxeServicesTableLib > + HobLib > + UefiDriverEntryPoint > + > +[Protocols] > + gEfiMmCommunicationProtocolGuid ## PRODUCES > + > +[Pcd.common] > + gArmTokenSpaceGuid.PcdMmBufferBase > + gArmTokenSpaceGuid.PcdMmBufferSize > + > +[Depex] > + gEfiCpuArchProtocolGuid > -- > 2.16.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flist= s.01 > .org%2Fmailman%2Flistinfo%2Fedk2- > devel&data=3D02%7C01%7Cudit.kumar%40nxp.com%7Cc6986ed63017483b89dd0 > 8d5b1ff6c2d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6366106 > 32972644435&sdata=3DJsyaz5Z5jiKFEjuUKi9UGi4l%2FftI9TXEGLPVSfzh%2Bo0%3D > &reserved=3D0