From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.67; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=udit.kumar@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0067.outbound.protection.outlook.com [104.47.0.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 90942220D4BE3 for ; Wed, 15 Nov 2017 05:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xH0tYvY2cQJMhU2UIkd+a/P5DtRnJkZDvc+TnAlzU6Y=; b=rYCQX0Q6EZ0KDdVES8H1LVMDFFPxWCvD9ltZshSRaODD3qAmskml2yx+54MTTATrspSiAb4mWsiGwICMpM4P5gh0VBezCKCz1OZPwT9en5YAePyNHEGHw+t7pNHoM1gyUfitxTV2V4pKM0zGp1K7U2rgTTeWDQMbf65vboR7tc0= Received: from AM6PR0402MB3334.eurprd04.prod.outlook.com (52.133.18.151) by AM6PR0402MB3334.eurprd04.prod.outlook.com (52.133.18.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.218.12; Wed, 15 Nov 2017 13:34:09 +0000 Received: from AM6PR0402MB3334.eurprd04.prod.outlook.com ([fe80::7cbb:e077:2ee1:20f0]) by AM6PR0402MB3334.eurprd04.prod.outlook.com ([fe80::7cbb:e077:2ee1:20f0%13]) with mapi id 15.20.0218.015; Wed, 15 Nov 2017 13:34:09 +0000 From: Udit Kumar To: "edk2-devel@lists.01.org" CC: Leif Lindholm , Ard Biesheuvel Thread-Topic: Why we need CapsuleLib even platform does not support this feature Thread-Index: AdNeFkRoaqxD/Xd2SnqfWC3ZFxSTuw== Date: Wed, 15 Nov 2017 13:34:09 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=udit.kumar@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR0402MB3334; 6:CKcbvm8cB4ThJATZzhCjclbhQjKGDv2OV890PpcIrht2lHNWGsquUjzIGrFva7H+SISZjP4suPyqZDu8MRa4XBQzGVoh6NneEIVoRsqaBTdAk/mEDseZV/w1YWSUclv8F7xzQuCmwkqX78u72eqOe0FXe/fAIJwwblplL8YlT/qPJuCNQYNS6YC6toh87NNf1EJJ4kp4lwhG3gyDPrgX0rxgJqRRPgTEEnqAKJ84+MDK/Y7/2s0xS3gcD63tphSdLwDHHiHCL4RTlkh8RdMNR3sUY0m69gkFOON64w/ZnlbJVkpx8uaK0hs5BXEDqNBz5sqWcdM4P8ge3vyWhWqgSMLKeJfg4WxnGYMwuVkuk0w=; 5:qS9xqGUjqyMIquRHYx6rYAuY0N2m2x+3LEks8vuty89IUop4f4bwgnp6ECr9/6NiRT2xPiLoJHiDljuAgNcN/QlW7K8unNU8QQuOMvq49NWySC+cL6NOoFDsO35PdP5lpZQp7bkEQEzVRzzOLF6sq0WAz2LPXOnTzjkn1TkcNzI=; 24:BeixpmZj6pp55yfWUaCE8RWzlvEQ3XnHKmq44RbXeghYuPGjTGMQLi5vkXWVuBEtyb6f8vAYGLolGCw3LegfqCNIPkG+ZHP8Qy8cgY42fDo=; 7:yBt6ozxfFbKG8jY9snB6X3dgGsOBcSEZpqYamsPFar4VlbBK4laUwCQ9MlT/oY2OJaT5RN+wDmMpPGISSwtY8Jz1fO3UuiqfaZ4b5wuHDw0+CcGVjjFoP0V3RPnZUWcEqrKGTKwneVLFQERhXU35wh+XLqGLjRFL7T78g62/PpPKULLPYKKOMggp/9VObhaKuYREwmwUoNE0mUa/l6KzM/HKIcwi7krJnmH6weVrKN5KOfapwwTH34lP6sQ3Hsod x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 1880f491-5102-40e1-676d-08d52c2d8d45 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199); SRVR:AM6PR0402MB3334; x-ms-traffictypediagnostic: AM6PR0402MB3334: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(189930954265078)(162533806227266)(45079756050767); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3231022)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM6PR0402MB3334; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM6PR0402MB3334; x-forefront-prvs: 0492FD61DD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(39860400002)(376002)(199003)(189002)(13464003)(24454002)(86362001)(54356999)(102836003)(6116002)(3846002)(54906003)(5640700003)(2501003)(3660700001)(6506006)(6436002)(575784001)(106356001)(4326008)(5250100002)(50986999)(316002)(2351001)(9686003)(6916009)(68736007)(55016002)(6306002)(5660300001)(66066001)(7696004)(53546010)(25786009)(3280700002)(101416001)(33656002)(105586002)(2906002)(53936002)(97736004)(7736002)(99286004)(81156014)(74316002)(189998001)(14454004)(2900100001)(966005)(478600001)(305945005)(45080400002)(81166006)(4743002)(8676002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0402MB3334; H:AM6PR0402MB3334.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1880f491-5102-40e1-676d-08d52c2d8d45 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2017 13:34:09.7142 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3334 Subject: Why we need CapsuleLib even platform does not support this feature X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2017 13:30:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi,=20 I recently noticed in my build as well, we need to include CapsuleLib even = platform does not support Capsule update feature.=20 Thanks to help me, why this dependency is added in edk2.=20 Regards Udit > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ar= d > Biesheuvel > Sent: Tuesday, November 14, 2017 4:48 PM > To: Kalyan Nagabhirava > Cc: edk2-devel@lists.01.org; Leif Lindholm ; Ma= rk > Gregotski > Subject: Re: [edk2] [PATCH edk2-platforms]: resolving Hikey platform buil= d error >=20 > On 14 November 2017 at 11:16, Kalyan Nagabhirava > wrote: > > > > "Instance of library class [CapsuleLib] is not found" build error is > > coming for Hikey platform, to resolve this issueadded CapsuleLib to > > "LibraryClasses.common" section > > > > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc > > b/Platform/Hisilicon/HiKey/HiKey.dsc > > index 968e8ac..2e3b1c8 100644 > > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > > @@ -61,6 +61,7 @@ > > > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroni > > SynchronizationLib|zationLib.inf > > > > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > > + > > + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull. > > + inf > > > > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootM > an > > UefiBootManagerLib|agerLib.inf > > > > > PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformB > > PlatformBootManagerLib|ootManagerLib.inf > > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > > > > >=20 > Thanks Kalyan >=20 > Could you resend it as a proper patch, please? I.e., with the appropriate >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 >=20 > and Signed-off-by line, > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flist= s.01 > .org%2Fmailman%2Flistinfo%2Fedk2- > devel&data=3D02%7C01%7Cudit.kumar%40nxp.com%7Cc1807332add6499fcd730 > 8d52b516fad%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6364625 > 51151191358&sdata=3DjoABHCm%2F3Iu0jfplBE3Ora9ffp3IfuNuu2GfOgOTsV8%3D > &reserved=3D0