From: Udit Kumar <udit.kumar@nxp.com>
To: "Gao, Liming" <liming.gao@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Varun Sethi <V.Sethi@nxp.com>
Subject: Re: [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver
Date: Tue, 5 Dec 2017 05:07:00 +0000 [thread overview]
Message-ID: <AM6PR0402MB3334E780921DACF1AEC18C3C913D0@AM6PR0402MB3334.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E189CAA@SHSMSX104.ccr.corp.intel.com>
> I suggest return EFI_UNSUPPORTED for this case. The protocol implementation
> could return its status besides spec defined status.
Thanks to help me , how core will treat this error
1/ Wdt not available
2/ ignoring this error
3/ core is not registering handler
I guess 3 is valid,
On side track, looks wdt is not used by core services then do we really need this
as part of arch protocol ?
regards
Udit
> -----Original Message-----
> From: Gao, Liming [mailto:liming.gao@intel.com]
> Sent: Monday, December 04, 2017 8:53 PM
> To: Leif Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>;
> ard.biesheuvel@linaro.org; edk2-devel@lists.01.org; Udit Kumar
> <udit.kumar@nxp.com>; Varun Sethi <V.Sethi@nxp.com>
> Subject: RE: [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support
> for Watchdog driver
>
> Leif:
> I suggest return EFI_UNSUPPORTED for this case. The protocol implementation
> could return its status besides spec defined status.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: Monday, December 4, 2017 10:36 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>;
> > ard.biesheuvel@linaro.org; edk2-devel@lists.01.org;
> > udit.kumar@nxp.com; v.sethi@nxp.com
> > Subject: Re: [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add
> > support for Watchdog driver
> >
> > Mike, Liming, as MdePkg mainteiners - one question below:
> >
> > On Mon, Nov 27, 2017 at 04:21:50PM +0530, Meenakshi Aggarwal wrote:
> > > diff --git a/Platform/NXP/Drivers/WatchDog/WatchDog.c
> > > b/Platform/NXP/Drivers/WatchDog/WatchDog.c
> > > new file mode 100644
> > > index 0000000..a9c70ef
> > > --- /dev/null
> > > +++ b/Platform/NXP/Drivers/WatchDog/WatchDog.c
> > > @@ -0,0 +1,421 @@
> >
> > ...
> >
> > > +/**
> > > + This function registers the handler NotifyFunction so it is
> > > +called every time
> > > + the watchdog timer expires. It also passes the amount of time
> > > +since the last
> > > + handler call to the NotifyFunction.
> > > + If NotifyFunction is not NULL and a handler is not already
> > > +registered,
> > > + then the new handler is registered and EFI_SUCCESS is returned.
> > > + If NotifyFunction is NULL, and a handler is already registered,
> > > + then that handler is unregistered.
> > > + If an attempt is made to register a handler when a handler is
> > > +already registered,
> > > + then EFI_ALREADY_STARTED is returned.
> > > + If an attempt is made to unregister a handler when a handler is
> > > +not registered,
> > > + then EFI_INVALID_PARAMETER is returned.
> > > +
> > > + @param This The EFI_TIMER_ARCH_PROTOCOL instance.
> > > + @param NotifyFunction The function to call when a timer interrupt fires.
> This
> > > + function executes at TPL_HIGH_LEVEL. The DXE Core will
> > > + register a handler for the timer interrupt, so it can know
> > > + how much time has passed. This information is used to
> > > + signal timer based events. NULL will unregister the handler.
> > > +
> > > + @retval EFI_SUCCESS The watchdog timer handler was registered.
> > > + @retval EFI_ALREADY_STARTED NotifyFunction is not NULL, and a
> handler is already
> > > + registered.
> > > + @retval EFI_INVALID_PARAMETER NotifyFunction is NULL, and a handler
> was not
> > > + previously registered.
> > > +
> > > +**/
> > > +STATIC
> > > +EFI_STATUS
> > > +EFIAPI
> > > +WdogRegisterHandler (
> > > + IN EFI_WATCHDOG_TIMER_ARCH_PROTOCOL *This,
> > > + IN EFI_WATCHDOG_TIMER_NOTIFY NotifyFunction
> > > + )
> > > +{
> > > + // ERROR: This function is not supported.
> > > + // The hardware watchdog will reset the board
> > > + return EFI_INVALID_PARAMETER;
> >
> > Michael, Liming - what's your take on this?
> >
> > Is EFI_WATCHDOG_TIMER_ARCH_PROTOCOL suitable for use with a pure-hw
> > watchdog such as this?
> >
> > If so, what would be a suitable return code here?
> > EFI_INVALID_PARAMETER does not look ideal.
> >
> > /
> > Leif
next prev parent reply other threads:[~2017-12-05 5:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 10:51 [PATCH edk2-platforms] [PATCH v3 0/9] Platform/NXP Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 1/9] Platform/NXP: Add support for Big Endian Mmio APIs Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 2/9] Platform/NXP : Add support for Watchdog driver Meenakshi Aggarwal
2017-12-04 14:35 ` Leif Lindholm
2017-12-04 15:23 ` Gao, Liming
2017-12-05 5:07 ` Udit Kumar [this message]
2017-12-05 11:06 ` Leif Lindholm
2017-12-07 3:35 ` Meenakshi Aggarwal
2017-12-07 7:11 ` Gao, Liming
2017-12-07 11:03 ` Leif Lindholm
2017-12-07 14:54 ` Gao, Liming
2017-12-07 15:34 ` Leif Lindholm
2017-12-08 4:41 ` Udit Kumar
2017-12-10 13:30 ` Gao, Liming
2017-12-14 3:37 ` Meenakshi Aggarwal
2017-12-07 11:15 ` Udit Kumar
2017-12-07 14:51 ` Gao, Liming
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 3/9] SocLib : Add support for initialization of peripherals Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 4/9] Platform/NXP : Add support for DUART library Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 5/9] Platform/NXP: Add support for I2c driver Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 6/9] Silicon/Maxim : Add support for DS1307 RTC library Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 7/9] Platform/NXP: Add support for ArmPlatformLib Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 8/9] Compilation : Add the fdf, dsc and dec files Meenakshi Aggarwal
2017-11-27 10:51 ` [PATCH edk2-platforms] [PATCH v3 9/9] Build : Add build script and environment script Meenakshi Aggarwal
2017-11-27 12:05 ` [PATCH edk2-platforms] [PATCH v3 0/9] Platform/NXP Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR0402MB3334E780921DACF1AEC18C3C913D0@AM6PR0402MB3334.eurprd04.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox