From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.61; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=udit.kumar@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0061.outbound.protection.outlook.com [104.47.0.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 08F9320348608 for ; Wed, 9 May 2018 13:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Hosd8t5ONJF69RARPzF2z9BYQsnvDDu+219I8hEbPqQ=; b=INB683YmHOQDeXqxdcNkuKM6IFX1FlGZZruVEVm21ktLyhFTKS3SAYym7m8Y+WzbSuN0NkCkuMnspy1LGdhLmppdcvST8EjfLg61fA52UrHO87AznHmiai7SMQUmGfVWLslUPG7PIFU+Onqa35wQ1jvsYAO4/BgPdIKnqKzmpxo= Received: from AM6PR0402MB3334.eurprd04.prod.outlook.com (52.133.18.151) by AM6PR0402MB3781.eurprd04.prod.outlook.com (52.133.29.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 9 May 2018 20:57:36 +0000 Received: from AM6PR0402MB3334.eurprd04.prod.outlook.com ([fe80::adae:b328:3790:b1dd]) by AM6PR0402MB3334.eurprd04.prod.outlook.com ([fe80::adae:b328:3790:b1dd%13]) with mapi id 15.20.0735.021; Wed, 9 May 2018 20:57:36 +0000 From: Udit Kumar To: Supreeth Venkatesh , "edk2-devel@lists.01.org" CC: "ard.biesheuvel@linaro.org" , "leif.lindholm@linaro.org" , "jiewen.yao@intel.com" , "liming.gao@intel.com" , "michael.d.kinney@intel.com" Thread-Topic: [edk2] [PATCH v2 03/17] ArmPkg/Include: Add MM interface SVC return codes. Thread-Index: AQHT4+hOSdylN4nyukKx23Aw8krpWKQn6I/Q Date: Wed, 9 May 2018 20:57:36 +0000 Message-ID: References: <20180504204109.3354-1-supreeth.venkatesh@arm.com> <20180504204109.3354-4-supreeth.venkatesh@arm.com> In-Reply-To: <20180504204109.3354-4-supreeth.venkatesh@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=udit.kumar@nxp.com; x-originating-ip: [92.121.36.198] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR0402MB3781; 7:VigXD90yNSarNFms8oAaCCoc81mOi5xfws6j+xcaxoSS0WDaQV1e9jFz78Pwca1kGfaMXJLmaDRQtVzGsKdmR3G8WDj1q3xA1LrQTk0MCHp7csbJ4SPrSNkYdrIVnknjH6HntmFVW5ScGSE+klaMtQyr+b6D+AlxGRmQ+6vfYJ2yroGcDe08xSxtIc85g/fF317E/ySiD8R1Aaz/xadhkCs+0DWTPzGcfBiZMJYPahQFTlsYHCGcIXiNgOn8vA9m x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM6PR0402MB3781; x-ms-traffictypediagnostic: AM6PR0402MB3781: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(189930954265078)(162533806227266)(45079756050767)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM6PR0402MB3781; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0402MB3781; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39380400002)(376002)(346002)(39860400002)(13464003)(199004)(189003)(45080400002)(5660300001)(966005)(76176011)(2900100001)(74316002)(33656002)(14454004)(59450400001)(305945005)(186003)(97736004)(478600001)(6506007)(7696005)(53546011)(66066001)(102836004)(8936002)(106356001)(105586002)(8676002)(81156014)(81166006)(25786009)(7736002)(4326008)(3846002)(26005)(86362001)(229853002)(3280700002)(6116002)(2906002)(68736007)(9686003)(55016002)(575784001)(6306002)(6436002)(6246003)(53936002)(44832011)(99286004)(316002)(446003)(476003)(110136005)(54906003)(2501003)(486006)(11346002)(3660700001)(5250100002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0402MB3781; H:AM6PR0402MB3334.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:3; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Q4VI+Y4wC/2Z8C8gwS2JgPM1YkuiqFLE/oh09WoY57OF3BWrFOcQlwHz8NTaEkpjd1Vl9HDjcD6yzaQ69pMqxlSMSNMUF7xIsJP2lbtKM5J1BTo4Nh7yEDpex7PZY3xKd7oU69qV03zh299bwseQvN1nIfPd5LFwYycUQJgSv23f1AtBrSrQkHkghyeWcKfb spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: fc0974c2-b94c-4a2f-3bc1-08d5b5ef7e50 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc0974c2-b94c-4a2f-3bc1-08d5b5ef7e50 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 20:57:36.2854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3781 Subject: Re: [PATCH v2 03/17] ArmPkg/Include: Add MM interface SVC return codes. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 20:57:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Saturday, May 5, 2018 2:11 AM > To: edk2-devel@lists.01.org > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; jiewen.yao@intel= .com; > liming.gao@intel.com; michael.d.kinney@intel.com > Subject: [edk2] [PATCH v2 03/17] ArmPkg/Include: Add MM interface SVC ret= urn > codes. >=20 > This patch adds the Management Mode(MM) - Secure Partition Manager(SPM) > SVC return codes. > Also, It corrects SVC ID for retrieving SPM version information. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > --- > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > index 4c7b6c3386..a64b9ec23c 100644 > --- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > +++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > @@ -20,7 +20,7 @@ > * delegated events and request the Secure partition manager to perform > * privileged operations on its behalf. > */ > -#define ARM_SVC_ID_SPM_VERSION_AARCH64 0xC4000060 > +#define ARM_SVC_ID_SPM_VERSION_AARCH32 0x84000060 > #define ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64 0xC4000061 > #define ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64 0xC4000064 > #define ARM_SVC_ID_SP_SET_MEM_ATTRIBUTES_AARCH64 0xC4000065 > @@ -40,4 +40,11 @@ > ((((c_perm) & SET_MEM_ATTR_CODE_PERM_MASK) << > SET_MEM_ATTR_CODE_PERM_SHIFT) | \ > (( (d_perm) & SET_MEM_ATTR_DATA_PERM_MASK) << > SET_MEM_ATTR_DATA_PERM_SHIFT)) >=20 > +/* MM SVC Return error codes */ > +#define ARM_SVC_SPM_RET_SUCCESS 0 > +#define ARM_SVC_SPM_RET_NOT_SUPPORTED -1 > +#define ARM_SVC_SPM_RET_INVALID_PARAMS -2 > +#define ARM_SVC_SPM_RET_DENIED -3 > +#define ARM_SVC_SPM_RET_NO_MEMORY -5 Please see if you want to define errors as negative. AFAIK, in edk2 negative errors are not used=20 > + > #endif > -- > 2.16.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flist= s.01 > .org%2Fmailman%2Flistinfo%2Fedk2- > devel&data=3D02%7C01%7Cudit.kumar%40nxp.com%7Ca6dc7d4a80e24bad73b80 > 8d5b1ff6f28%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63661063 > 3010245207&sdata=3DIHWYNFk0W2OKDQ%2BYEkJFmpi14mkXJyhblAdZQK7jM%2 > B0%3D&reserved=3D0