public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gaurav Jain" <gaurav.jain@nxp.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Leif Lindholm <leif@nuviainc.com>,
	Pankaj Bansal <pankaj.bansal@nxp.com>
Subject: Re: FW: [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.
Date: Mon, 17 Feb 2020 06:25:23 +0000	[thread overview]
Message-ID: <AM6PR04MB40872D87FB6B56D34B5C2002E7160@AM6PR04MB4087.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAKv+Gu-vG_wQg4P1Ouw=LrsNYo5TsxYhOrFJefWE4WU7kdJb9Q@mail.gmail.com>

Hi Ard

I have also checked UEFI Shell Specification Version 2.2(https://uefi.org/sites/default/files/resources/UEFI_Shell_2_2.pdf)
For date command the range of valid years is from 1998–2099 (on page 121)

So Range of valid years is conflicting in UEFI Spec and UEFI Shell Spec.
I think UEFI spec needs to be corrected. What are your thoughts?


> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Sent: Tuesday, February 11, 2020 7:50 PM
> To: Gaurav Jain <gaurav.jain@nxp.com>
> Cc: devel@edk2.groups.io; Leif Lindholm <leif@nuviainc.com>; Pankaj Bansal
> <pankaj.bansal@nxp.com>
> Subject: Re: FW: [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT
> Runtime Services test.
> 
> Caution: EXT Email
> 
> On Tue, 11 Feb 2020 at 11:37, Gaurav Jain <gaurav.jain@nxp.com> wrote:
> >
> > Hi Ard
> >
> > I am waiting for your response.
> >
> 
> You said
> 
> > Either UEFI spec need to be modified as per the test or SCT Test needs fix as
> per UEFI Specification.
> >
> 
> so you answered your own question, no?
> 
> > -----Original Message-----
> > From: Gaurav Jain
> > Sent: Friday, January 31, 2020 1:58 PM
> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: devel@edk2.groups.io; Leif Lindholm <leif@nuviainc.com>; Pankaj
> > Bansal <pankaj.bansal@nxp.com>
> > Subject: RE: [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT
> Runtime Services test.
> >
> >
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Sent: Thursday, January 30, 2020 2:52 PM
> > > To: Gaurav Jain <gaurav.jain@nxp.com>
> > > Cc: devel@edk2.groups.io; Leif Lindholm <leif@nuviainc.com>; Pankaj
> > > Bansal <pankaj.bansal@nxp.com>
> > > Subject: [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT
> > > Runtime Services test.
> > >
> > > Caution: EXT Email
> > >
> > > On Thu, 30 Jan 2020 at 06:08, Gaurav Jain <gaurav.jain@nxp.com> wrote:
> > > >
> > > > ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test.
> > > > SCT Test expect return as Invalid Parameter.
> > > > So removed ASSERT().
> > > >
> > >
> > > This is not all this patch does.
> > >
> > > > Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> > > > ---
> > > >  EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 12
> > > > ++++++------
> > > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> > > > b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> > > > index 08fb9b0100b6..9bfb7756f0cb 100644
> > > > --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> > > > +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> > > > @@ -85,10 +85,6 @@ IsDayValid (
> > > >    IN  EFI_TIME  *Time
> > > >    )
> > > >  {
> > > > -  ASSERT (Time->Day >= 1);
> > > > -  ASSERT (Time->Day <= mDayOfMonth[Time->Month - 1]);
> > > > -  ASSERT (Time->Month != 2 || IsLeapYear (Time) || Time->Day <=
> > > > 28);
> > > > -
> > > >    if (Time->Day < 1 ||
> > > >        Time->Day > mDayOfMonth[Time->Month - 1] ||
> > > >        (Time->Month == 2 && !IsLeapYear (Time) && Time->Day > 28))
> > > > { @@ -105,14 +101,15 @@ IsTimeValid(
> > > >    )
> > > >  {
> > > >    // Check the input parameters are within the range specified by UEFI
> > > > -  if (Time->Year   < 1900               ||
> > > > -      Time->Year   > 9999               ||
> > > > +  if (Time->Year   < 1998               ||
> > > > +      Time->Year   > 2099               ||
> > >
> > > That original range is based on the UEFI spec. On what basis are you
> > > making this change?
> > >
> > > If your RTC hardware cannot represent the original values, this is
> > > not the place to fix that.
> >
> > As per the UEFI SCT Test, SetWakeupTime_Conf expect
> EFI_INVALID_PARAMETER for Time.Year is 1997 and 2100.
> > Below is the link to check the Test code
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.com%2Ftianocore%2Fedk2-test%2Fblob%2Fmaster%2Fuefi-
> sct%2FSctPkg%2FT
> >
> estCase%2FUEFI%2FEFI%2FRuntimeServices%2FTimeServices%2FBlackBoxTes
> t%2
> >
> FTimeServicesBBTestConformance.c&amp;data=02%7C01%7Cgaurav.jain%40
> nxp.
> >
> com%7C3c6e62107ab149b8709808d7aefd73e8%7C686ea1d3bc2b4c6fa92cd9
> 9c5c301
> >
> 635%7C0%7C0%7C637170275901140244&amp;sdata=83GGnHy%2BZvzz5yZo
> 8et56FQqH
> > meYimYGB9dJxtlluKM%3D&amp;reserved=0 (Line: 847)
> >
> > Either UEFI spec need to be modified as per the test or SCT Test needs fix as
> per UEFI Specification.
> >
> > >
> > >
> > > >        Time->Month  < 1                  ||
> > > >        Time->Month  > 12                 ||
> > > >        !IsDayValid (Time)                ||
> > > >        Time->Hour   > 23                 ||
> > > >        Time->Minute > 59                 ||
> > > >        Time->Second > 59                 ||
> > > > +      Time->Nanosecond > 999999999      ||
> > > >        !IsValidTimeZone (Time->TimeZone) ||
> > > >        !IsValidDaylight (Time->Daylight)) {
> > > >      return FALSE;
> > > > @@ -254,6 +251,9 @@ SetWakeupTime (
> > > >    OUT EFI_TIME    *Time
> > > >    )
> > > >  {
> > > > +  if (Time == NULL || !IsTimeValid (Time)) {
> > > > +    return EFI_INVALID_PARAMETER;  }
> > > >    return LibSetWakeupTime (Enabled, Time);  }
> > > >
> > > > --
> > > > 2.17.1
> > > >

  reply	other threads:[~2020-02-17  6:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30  5:08 [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test Gaurav Jain
2020-01-30  9:21 ` Ard Biesheuvel
2020-01-31  8:27   ` [EXT] " gaurav.jain
2020-02-11 10:37     ` FW: " Gaurav Jain
2020-02-11 14:19       ` Ard Biesheuvel
2020-02-17  6:25         ` Gaurav Jain [this message]
2020-02-17  6:56           ` Ard Biesheuvel
2020-02-17  7:02             ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB40872D87FB6B56D34B5C2002E7160@AM6PR04MB4087.eurprd04.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox